diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-12-09 11:55:30 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-09 11:55:30 +0000 |
| commit | 18660a34d82ccb120efd2fa2480b42ac62dbe2b4 (patch) | |
| tree | 60503faeb260b59e78f4f02fdcda8f6c7bea5ae8 /.github | |
| parent | Remove fallback for missing /federation/v1/state_ids API (#6488) (diff) | |
| download | synapse-18660a34d82ccb120efd2fa2480b42ac62dbe2b4.tar.xz | |
Fix inaccurate per-block metrics (#6491)
`Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during *any* of those calls would be reported against *all* of them, producing wildly inaccurate results. Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions