From 62b3b461ec59b9b3ecd47d92b036d403359d229d Mon Sep 17 00:00:00 2001 From: Nicolas Werner Date: Sun, 12 Jun 2022 19:09:07 +0200 Subject: Fix comparison for glare algorithm --- src/encryption/DeviceVerificationFlow.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/encryption/DeviceVerificationFlow.h') diff --git a/src/encryption/DeviceVerificationFlow.h b/src/encryption/DeviceVerificationFlow.h index e980d2ec..1955fab3 100644 --- a/src/encryption/DeviceVerificationFlow.h +++ b/src/encryption/DeviceVerificationFlow.h @@ -37,7 +37,7 @@ using sas_ptr = std::unique_ptr; * && | n | | | * no canonical_json | a | (m.key.verification.start) | | waitingForKeys * | l |<--------------------------------| Not sending to prevent the glare resolve| && no commitment - * | | | | && no canonical_json + * | | | (1) | && no canonical_json * | | m.key.verification.start | | * waitForOtherAccept | |-------------------------------->| (IF NOT ALREADY ASKED, | * && | | | ASK FOR VERIFICATION REQUEST) | promptStartVerify, if not accepted @@ -57,6 +57,9 @@ using sas_ptr = std::unique_ptr; * | | | | * success/fail | | m.key.verification.done | | success/fail * | |<------------------------------->| | + * + * (1) Sometimes the other side does send this start. In this case we run the glare algorithm and send an accept only if + * We are the bigger mxid and deviceid (since we discard our start message). <- GLARE RESOLUTION */ // clang-format on class DeviceVerificationFlow : public QObject -- cgit 1.5.1