summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorkamathmanu <manuriddle@gmail.com>2021-08-09 09:18:08 -0400
committerkamathmanu <manuriddle@gmail.com>2021-08-09 09:18:08 -0400
commit6a75e5270cd12aebc6130f0bc3ee1d9999620601 (patch)
tree86115bdd5179c1d11f40cdd5aa3e661d58b08e72 /src
parentMerge branch 'master' into nhekoRoomDirectory (diff)
downloadnheko-6a75e5270cd12aebc6130f0bc3ee1d9999620601.tar.xz
Fix nits from code review
Diffstat (limited to 'src')
-rw-r--r--src/RoomDirectoryModel.cpp5
-rw-r--r--src/RoomDirectoryModel.h1
-rw-r--r--src/timeline/TimelineViewManager.cpp2
3 files changed, 2 insertions, 6 deletions
diff --git a/src/RoomDirectoryModel.cpp b/src/RoomDirectoryModel.cpp

index 06bd9d8a..2c633491 100644 --- a/src/RoomDirectoryModel.cpp +++ b/src/RoomDirectoryModel.cpp
@@ -42,9 +42,7 @@ RoomDirectoryModel::resetDisplayedData() nextBatch_ = ""; canFetchMore_ = true; - beginRemoveRows(QModelIndex(), 0, static_cast<int>(publicRoomsData_.size())); publicRoomsData_.clear(); - endRemoveRows(); endResetModel(); } @@ -87,8 +85,7 @@ RoomDirectoryModel::getViasForRoom(const std::vector<std::string> &aliases) std::transform( aliases.begin(), aliases.end(), std::back_inserter(vias), [](const auto &alias) { - const auto roomAliasDelimiter = ":"; - return alias.substr(alias.find(roomAliasDelimiter) + 1); + return alias.substr(alias.find(":") + 1); }); return vias; diff --git a/src/RoomDirectoryModel.h b/src/RoomDirectoryModel.h
index c7089a1e..952ae3ff 100644 --- a/src/RoomDirectoryModel.h +++ b/src/RoomDirectoryModel.h
@@ -51,7 +51,6 @@ public: inline bool canFetchMore(const QModelIndex &) const override { - nhlog::net()->debug("determining if can fetch more"); return canFetchMore_; } void fetchMore(const QModelIndex &) override; diff --git a/src/timeline/TimelineViewManager.cpp b/src/timeline/TimelineViewManager.cpp
index da68d503..ff60856a 100644 --- a/src/timeline/TimelineViewManager.cpp +++ b/src/timeline/TimelineViewManager.cpp
@@ -287,7 +287,7 @@ TimelineViewManager::TimelineViewManager(CallManager *callManager, ChatPage *par "Error: Only enums"); qmlRegisterType<RoomDirectoryModel>( - "im.nheko.RoomDirectoryModel", 1, 0, "RoomDirectoryModel"); + "im.nheko", 1, 0, "RoomDirectoryModel"); #ifdef USE_QUICK_VIEW view = new QQuickView(parent);