diff --git a/src/LoginPage.cpp b/src/LoginPage.cpp
index b34e9806..08b7335a 100644
--- a/src/LoginPage.cpp
+++ b/src/LoginPage.cpp
@@ -6,9 +6,12 @@
#include <QDesktopServices>
+#include <set>
+
#include <mtx/identifiers.hpp>
#include <mtx/requests.hpp>
#include <mtx/responses/login.hpp>
+#include <mtx/responses/version.hpp>
#include "Config.h"
#include "Logging.h"
@@ -149,7 +152,8 @@ LoginPage::checkHomeserverVersion()
return;
}
- http::client()->versions([this](const mtx::responses::Versions &, mtx::http::RequestErr err) {
+ http::client()->versions([this](const mtx::responses::Versions &versions,
+ mtx::http::RequestErr err) {
if (err) {
if (err->status_code == 404) {
emit versionErrorCb(tr("The required endpoints were not found. "
@@ -170,6 +174,21 @@ LoginPage::checkHomeserverVersion()
return;
}
+ if (std::find_if(
+ versions.versions.cbegin(), versions.versions.cend(), [](const std::string &v) {
+ static const std::set<std::string_view, std::less<>> supported{
+ "v1.1",
+ "v1.2",
+ "v1.3",
+ };
+ return supported.count(v) != 0;
+ }) == versions.versions.cend()) {
+ emit versionErrorCb(
+ tr("The selected server does not support a version of the Matrix protocol, that this "
+ "client understands (v1.1, v1.2 or v1.3). You can't sign in."));
+ return;
+ }
+
http::client()->get_login([this](mtx::responses::LoginFlows flows,
mtx::http::RequestErr err) {
if (err || flows.flows.empty())
diff --git a/src/RegisterPage.cpp b/src/RegisterPage.cpp
index 5b2ebc78..b647a73c 100644
--- a/src/RegisterPage.cpp
+++ b/src/RegisterPage.cpp
@@ -4,8 +4,11 @@
//
// SPDX-License-Identifier: GPL-3.0-or-later
+#include <set>
+
#include <mtx/responses/common.hpp>
#include <mtx/responses/register.hpp>
+#include <mtx/responses/version.hpp>
#include <mtx/responses/well-known.hpp>
#include <mtxclient/http/client.hpp>
@@ -101,47 +104,64 @@ RegisterPage::versionsCheck()
{
// Make a request to /_matrix/client/versions to check the address
// given is a Matrix homeserver.
- http::client()->versions([this](const mtx::responses::Versions &, mtx::http::RequestErr err) {
- if (err) {
- if (err->status_code == 404) {
- setHsError(
- tr("The required endpoints were not found. Possibly not a Matrix server."));
- emit hsErrorChanged();
- return;
- }
-
- if (!err->parse_error.empty()) {
- setHsError(
- tr("Received malformed response. Make sure the homeserver domain is valid."));
- emit hsErrorChanged();
- return;
- }
-
- setHsError(tr("An unknown error occured. Make sure the homeserver domain is valid."));
- emit hsErrorChanged();
- return;
- }
-
- http::client()->registration(
- [this](const mtx::responses::Register &, mtx::http::RequestErr e) {
- nhlog::net()->debug("Registration check: {}", e);
-
- if (!e) {
- setHsError(tr("Server does not support querying registration flows!"));
+ http::client()->versions(
+ [this](const mtx::responses::Versions &versions, mtx::http::RequestErr err) {
+ if (err) {
+ if (err->status_code == 404) {
+ setHsError(
+ tr("The required endpoints were not found. Possibly not a Matrix server."));
emit hsErrorChanged();
return;
}
- if (e->status_code != 401) {
- setHsError(tr("Server does not support registration."));
+
+ if (!err->parse_error.empty()) {
+ setHsError(
+ tr("Received malformed response. Make sure the homeserver domain is valid."));
emit hsErrorChanged();
return;
}
- supported_ = true;
- lookingUpHs_ = false;
- emit lookingUpHsChanged();
- });
- });
+ setHsError(tr("An unknown error occured. Make sure the homeserver domain is valid."));
+ emit hsErrorChanged();
+ return;
+ }
+
+ if (std::find_if(
+ versions.versions.cbegin(), versions.versions.cend(), [](const std::string &v) {
+ static const std::set<std::string_view, std::less<>> supported{
+ "v1.1",
+ "v1.2",
+ "v1.3",
+ };
+ return supported.count(v) != 0;
+ }) == versions.versions.cend()) {
+ emit setHsError(
+ tr("The selected server does not support a version of the Matrix protocol, that "
+ "this client understands (v1.1, v1.2 or v1.3). You can't register."));
+ emit hsErrorChanged();
+ return;
+ }
+
+ http::client()->registration(
+ [this](const mtx::responses::Register &, mtx::http::RequestErr e) {
+ nhlog::net()->debug("Registration check: {}", e);
+
+ if (!e) {
+ setHsError(tr("Server does not support querying registration flows!"));
+ emit hsErrorChanged();
+ return;
+ }
+ if (e->status_code != 401) {
+ setHsError(tr("Server does not support registration."));
+ emit hsErrorChanged();
+ return;
+ }
+
+ supported_ = true;
+ lookingUpHs_ = false;
+ emit lookingUpHsChanged();
+ });
+ });
}
void
diff --git a/src/RegisterPage.h b/src/RegisterPage.h
index 67e2a22e..d7a8602c 100644
--- a/src/RegisterPage.h
+++ b/src/RegisterPage.h
@@ -63,12 +63,12 @@ private:
QString registrationError_, hsError_, usernameError_;
- bool registering_;
- bool supported_;
- bool lookingUpHs_;
- bool lookingUpUsername_;
- bool usernameAvailable_;
- bool usernameUnavailable_;
+ bool registering_ = false;
+ bool supported_ = false;
+ bool lookingUpHs_ = false;
+ bool lookingUpUsername_ = false;
+ bool usernameAvailable_ = false;
+ bool usernameUnavailable_ = false;
QString lastServer;
};
|
