cppcheck stuff (#1200)

* cppcheck stuff

* Update src/ui/RoomSettings.cpp

Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de>

* Update src/ui/RoomSettings.cpp

Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de>

* Fix linting

Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de>

1 files changed, 4 insertions, 3 deletions

diff --git a/src/timeline/TimelineViewManager.h b/src/timeline/TimelineViewManager.h

index 0ba732fe..572e3e22 100644
--- a/src/timeline/TimelineViewManager.h
+++ b/src/timeline/TimelineViewManager.h
@@ -54,8 +54,8 @@ public:
     Q_INVOKABLE bool isInitialSync() const { return isInitialSync_; }
     bool isConnected() const { return isConnected_; }
     Q_INVOKABLE void openImageOverlay(TimelineModel *room,
-                                      QString mxcUrl,
-                                      QString eventId,
+                                      const QString &mxcUrl,
+                                      const QString &eventId,
                                       double originalWidth,
                                       double proportionalHeight);
     Q_INVOKABLE void openImagePackSettings(QString roomid);
@@ -112,7 +112,8 @@ public slots:
 
     void setVideoCallItem();
 
-    QObject *completerFor(QString completerName, QString roomId = QLatin1String(QLatin1String("")));
+    QObject *completerFor(const QString &completerName,
+                          const QString &roomId = QLatin1String(QLatin1String("")));
     void forwardMessageToRoom(mtx::events::collections::TimelineEvents *e, QString roomId);
 
     RoomlistModel *rooms() { return rooms_; }