summary refs log tree commit diff
path: root/src/timeline/InputBar.h
diff options
context:
space:
mode:
authorMarcus Hoffmann <bubu@bubu1.eu>2021-12-03 01:10:27 +0100
committerMarcus Hoffmann <bubu@bubu1.eu>2021-12-03 01:37:00 +0100
commit6d8d38490a3a71907cc218d1c9257bbbccb6fdb9 (patch)
tree5215a065a819707c6d770aeb44c038d7d45087c3 /src/timeline/InputBar.h
parentInputBar: use QFileInfo::exists() (diff)
downloadnheko-6d8d38490a3a71907cc218d1c9257bbbccb6fdb9.tar.xz
InputBar: apply clang-tidy const reference suggestions
All suggested by:

Clang-Tidy: The parameter 'X' is copied for each invocation
but only used as a const reference; consider making it a const reference
Diffstat (limited to 'src/timeline/InputBar.h')
-rw-r--r--src/timeline/InputBar.h14
1 files changed, 7 insertions, 7 deletions
diff --git a/src/timeline/InputBar.h b/src/timeline/InputBar.h
index 4a0f4401..3beff0b3 100644
--- a/src/timeline/InputBar.h
+++ b/src/timeline/InputBar.h
@@ -48,17 +48,17 @@ public slots:
     QString text() const;
     QString previousText();
     QString nextText();
-    void setText(QString newText);
+    void setText(const QString& newText);
 
     bool containsAtRoom() const { return containsAtRoom_; }
 
     void send();
     void paste(bool fromMouse);
     void insertMimeData(const QMimeData *data);
-    void updateState(int selectionStart, int selectionEnd, int cursorPosition, QString text);
+    void updateState(int selectionStart, int selectionEnd, int cursorPosition, const QString& text);
     void openFileSelection();
     bool uploading() const { return uploading_; }
-    void message(QString body,
+    void message(const QString& body,
                  MarkdownOverride useMarkdown = MarkdownOverride::NOT_SPECIFIED,
                  bool rainbowify              = false);
     void reaction(const QString &reactedEvent, const QString &reactionKey);
@@ -75,9 +75,9 @@ signals:
     void containsAtRoomChanged();
 
 private:
-    void emote(QString body, bool rainbowify);
-    void notice(QString body, bool rainbowify);
-    void command(QString name, QString args);
+    void emote(const QString& body, bool rainbowify);
+    void notice(const QString& body, bool rainbowify);
+    void command(const QString& name, QString args);
     void image(const QString &filename,
                const std::optional<mtx::crypto::EncryptedFile> &file,
                const QString &url,
@@ -101,7 +101,7 @@ private:
                const QString &mime,
                uint64_t dsize);
 
-    void showPreview(const QMimeData &source, QString path, const QStringList &formats);
+    void showPreview(const QMimeData &source, const QString& path, const QStringList &formats);
     void setUploading(bool value)
     {
         if (value != uploading_) {