Only try to display images if they exist

1 files changed, 6 insertions, 5 deletions

diff --git a/src/notifications/Manager.cpp b/src/notifications/Manager.cpp

index 8a3576c5..b4a3a3da 100644
--- a/src/notifications/Manager.cpp
+++ b/src/notifications/Manager.cpp
@@ -24,7 +24,7 @@ NotificationsManager::cacheImage(const mtx::events::collections::TimelineEvents
 
         http::client()->download(
           url,
-          [path, url, encryptionInfo](const std::string &data,
+          [&path, url, encryptionInfo](const std::string &data,
                                       const std::string &,
                                       const std::string &,
                                       mtx::http::RequestErr err) {
@@ -53,10 +53,11 @@ NotificationsManager::cacheImage(const mtx::events::collections::TimelineEvents
                           // resize the image
                           QImage img{utils::readImage(QByteArray{temp.data()})};
 
-                          // make sure to save as PNG (because Plasma doesn't do JPEG in
-                          // notifications)
-                          //                          if (!file.fileName().endsWith(".png"))
-                          //                                  file.rename(file.fileName() + ".png");
+                          if (img.isNull())
+                          {
+                              path.clear();
+                              return;
+                          }
 
 #ifdef NHEKO_DBUS_SYS // the images in D-Bus notifications are to be 200x100 max
                           img.scaled(200, 100, Qt::KeepAspectRatio, Qt::SmoothTransformation)