summary refs log tree commit diff
path: root/src/Logging.cpp
diff options
context:
space:
mode:
authorForest <forestix@sonic.net>2022-08-19 20:22:32 -0700
committerForest <forestix@sonic.net>2022-08-19 21:14:58 -0700
commitf66ed4bea51d4313dab09438899f5fdc3797983e (patch)
tree7caf9f3e92d96f280133bae8c2f065da2ebcf111 /src/Logging.cpp
parentFix inline image escape order (diff)
downloadnheko-f66ed4bea51d4313dab09438899f5fdc3797983e.tar.xz
Reactions: avoid highlight color misuse, subdue border color
This addresses a few problems with reaction colors:

- The state-checking conditionals for reaction text, background, and border
  were inconsistent, making it difficult to choose colors for each state
  (normal, hovered, and self reactions) that worked well in all themes.
- The QPalette::Highlight color was being misused as a text/foreground color.
  This color role is intended for background areas.  It has little contrast
  against the background in themes like KDE Plasma's Breeze High Contrast,
  so using it for text and icons makes those things difficult to read.
  https://doc.qt.io/qt-5/qpalette.html#ColorRole-enum
- The reaction border was drawn in the same color as normal text, making it
  so bright in some dark themes that it distracted from reading nearby text.

Fixes Nheko-Reborn/nheko#1159
Diffstat (limited to 'src/Logging.cpp')
0 files changed, 0 insertions, 0 deletions