summary refs log tree commit diff
diff options
context:
space:
mode:
authorNicolas Werner <nicolas.werner@hotmail.de>2024-04-05 04:15:29 +0200
committerNicolas Werner <nicolas.werner@hotmail.de>2024-04-05 04:15:29 +0200
commita415b39bf96eb2c45a524a3615fc7a9ce9f9f13d (patch)
tree2cd5a7e821ab31032656f086e5f082cfb299fc09
parentAdd some voip debugging hoops (diff)
downloadnheko-a415b39bf96eb2c45a524a3615fc7a9ce9f9f13d.tar.xz
Color conversion seems to be redundant before the sink (upload too, but removing that breaks stuff)
-rw-r--r--src/voip/WebRTCSession.cpp8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/voip/WebRTCSession.cpp b/src/voip/WebRTCSession.cpp
index 75217e95..7b32f273 100644
--- a/src/voip/WebRTCSession.cpp
+++ b/src/voip/WebRTCSession.cpp
@@ -333,19 +333,16 @@ newVideoSinkChain(GstElement *pipe)
     GstElement *queue          = gst_element_factory_make("queue", nullptr);
     GstElement *compositor     = gst_element_factory_make("compositor", "compositor");
     GstElement *glupload       = gst_element_factory_make("glupload", nullptr);
-    GstElement *glcolorconvert = gst_element_factory_make("glcolorconvert", nullptr);
     GstElement *qmlglsink      = gst_element_factory_make("qml6glsink", nullptr);
     GstElement *glsinkbin      = gst_element_factory_make("glsinkbin", nullptr);
     g_object_set(compositor, "background", 1, nullptr);
     g_object_set(qmlglsink, "widget", WebRTCSession::instance().getVideoItem(), nullptr);
     g_object_set(glsinkbin, "sink", qmlglsink, nullptr);
-    gst_bin_add_many(
-      GST_BIN(pipe), queue, compositor, glupload, glcolorconvert, glsinkbin, nullptr);
-    gst_element_link_many(queue, compositor, glupload, glcolorconvert, glsinkbin, nullptr);
+    gst_bin_add_many(GST_BIN(pipe), queue, compositor, glupload, glsinkbin, nullptr);
+    gst_element_link_many(queue, compositor, glupload, glsinkbin, nullptr);
     gst_element_sync_state_with_parent(queue);
     gst_element_sync_state_with_parent(compositor);
     gst_element_sync_state_with_parent(glupload);
-    gst_element_sync_state_with_parent(glcolorconvert);
     gst_element_sync_state_with_parent(glsinkbin);
 
     // to propagate context (hopefully)
@@ -624,7 +621,6 @@ WebRTCSession::havePlugins(bool isVideo,
 
     static constexpr std::initializer_list<const char *> video_elements = {
       "compositor",
-      "glcolorconvert",
       "glsinkbin",
       "glupload",
       "qml6glsink",