summary refs log tree commit diff
diff options
context:
space:
mode:
authorNicolas Werner <nicolas.werner@hotmail.de>2019-07-28 18:13:16 +0200
committerNicolas Werner <nicolas.werner@hotmail.de>2019-07-28 18:13:16 +0200
commit0398c846f6836b734bf3432696df1e04e86d8867 (patch)
tree65643fadb0b6d3ca16078c03605e219f9750a038
parentFix message_type not being initialized correctly (diff)
downloadnheko-0398c846f6836b734bf3432696df1e04e86d8867.tar.xz
Add 'and' to typing display
-rw-r--r--resources/langs/nheko_de.ts17
-rw-r--r--resources/langs/nheko_el.ts17
-rw-r--r--resources/langs/nheko_en.ts17
-rw-r--r--resources/langs/nheko_fi.ts17
-rw-r--r--resources/langs/nheko_fr.ts17
-rw-r--r--resources/langs/nheko_nl.ts17
-rw-r--r--resources/langs/nheko_pl.ts18
-rw-r--r--resources/langs/nheko_ru.ts18
-rw-r--r--resources/langs/nheko_zh_CN.ts16
-rw-r--r--src/TypingDisplay.cpp17
-rw-r--r--src/timeline/TimelineItem.h2
11 files changed, 85 insertions, 88 deletions
diff --git a/resources/langs/nheko_de.ts b/resources/langs/nheko_de.ts

index 1f856b80..80a50ae2 100644 --- a/resources/langs/nheko_de.ts +++ b/resources/langs/nheko_de.ts
@@ -494,15 +494,14 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> tippt</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> tippen</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation> + <numerusform>%1%2 tippt</numerusform> + <numerusform>%1 und %2 tippen</numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_el.ts b/resources/langs/nheko_el.ts
index e50aadad..ead1ed69 100644 --- a/resources/langs/nheko_el.ts +++ b/resources/langs/nheko_el.ts
@@ -494,15 +494,14 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> πληκτρολογεί</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> πληκτρολογούν</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_en.ts b/resources/langs/nheko_en.ts
index e031c4ec..0ab8d6d8 100644 --- a/resources/langs/nheko_en.ts +++ b/resources/langs/nheko_en.ts
@@ -494,15 +494,14 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation type="unfinished"></translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation type="unfinished"></translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation> + <numerusform>%1%2 is typing</numerusform> + <numerusform>%1 and %2 are typing</numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_fi.ts b/resources/langs/nheko_fi.ts
index 2baba55d..95403f3e 100644 --- a/resources/langs/nheko_fi.ts +++ b/resources/langs/nheko_fi.ts
@@ -494,15 +494,14 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation type="unfinished"></translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation type="unfinished"></translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_fr.ts b/resources/langs/nheko_fr.ts
index 355c4325..9c7f25c6 100644 --- a/resources/langs/nheko_fr.ts +++ b/resources/langs/nheko_fr.ts
@@ -495,15 +495,14 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> est en train d&apos;écrire</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> sont en train d&apos;écrire</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_nl.ts b/resources/langs/nheko_nl.ts
index db56dc0f..dbf81401 100644 --- a/resources/langs/nheko_nl.ts +++ b/resources/langs/nheko_nl.ts
@@ -494,15 +494,14 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> is aan het typen</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> zijn aan het typen</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_pl.ts b/resources/langs/nheko_pl.ts
index 34a4ed26..f4cbfd56 100644 --- a/resources/langs/nheko_pl.ts +++ b/resources/langs/nheko_pl.ts
@@ -494,15 +494,15 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> pisze</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> piszą</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + <numerusform></numerusform> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_ru.ts b/resources/langs/nheko_ru.ts
index afe36ef9..f31b23cf 100644 --- a/resources/langs/nheko_ru.ts +++ b/resources/langs/nheko_ru.ts
@@ -494,15 +494,15 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> печатает</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> печатают</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + <numerusform></numerusform> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/resources/langs/nheko_zh_CN.ts b/resources/langs/nheko_zh_CN.ts
index 607b2ba9..8da7c475 100644 --- a/resources/langs/nheko_zh_CN.ts +++ b/resources/langs/nheko_zh_CN.ts
@@ -494,15 +494,13 @@ </context> <context> <name>TypingDisplay</name> - <message> - <location filename="../../src/TypingDisplay.cpp" line="+46"/> - <source> is typing</source> - <translation> 正在打字</translation> - </message> - <message> - <location line="+2"/> - <source> are typing</source> - <translation> 正在打字</translation> + <message numerus="yes"> + <location filename="../../src/TypingDisplay.cpp" line="+37"/> + <source>%1 and %2 are typing</source> + <comment>Multiple users are typing. First argument is a comma separated list of potentially multiple users. Second argument is the last user of that list. (If only one user is typing, %1 is empty. You should still use it in your string though to silence Qt warnings.)</comment> + <translation type="unfinished"> + <numerusform></numerusform> + </translation> </message> </context> <context> diff --git a/src/TypingDisplay.cpp b/src/TypingDisplay.cpp
index 6059601d..43fabcd8 100644 --- a/src/TypingDisplay.cpp +++ b/src/TypingDisplay.cpp
@@ -33,6 +33,14 @@ TypingDisplay::setUsers(const QStringList &uid) text_.clear(); + QString temp = text_ += + tr("%1 and %2 are typing", + "Multiple users are typing. First argument is a comma separated list of potentially " + "multiple users. Second argument is the last user of that list. (If only one user is " + "typing, %1 is empty. You should still use it in your string though to silence Qt " + "warnings.)", + uid.size()); + if (uid.isEmpty()) { hide(); update(); @@ -40,12 +48,9 @@ TypingDisplay::setUsers(const QStringList &uid) return; } - text_ = uid.join(", "); - - if (uid.size() == 1) - text_ += tr(" is typing"); - else if (uid.size() > 1) - text_ += tr(" are typing"); + QStringList uidWithoutLast = uid; + uidWithoutLast.pop_back(); + text_ = temp.arg(uidWithoutLast.join(", ")).arg(uid.back()); show(); update(); diff --git a/src/timeline/TimelineItem.h b/src/timeline/TimelineItem.h
index a3294d3f..fe354000 100644 --- a/src/timeline/TimelineItem.h +++ b/src/timeline/TimelineItem.h
@@ -277,7 +277,7 @@ private: QFutureWatcher<QString> *colorGenerating_; QString event_id_; - mtx::events::MessageType message_type_ = mtx::events::MessageType::Unknown; + mtx::events::MessageType message_type_ = mtx::events::MessageType::Unknown; QString room_id_; DescInfo descriptionMsg_;