New messagebuilder stuff, table-based help command

5 files changed, 133 insertions, 60 deletions

diff --git a/Utilities/LibMatrix.Utilities.Bot/Commands/AliassesCommand.cs b/Utilities/LibMatrix.Utilities.Bot/Commands/AliassesCommand.cs
new file mode 100644
index 0000000..5c9c480
--- /dev/null
+++ b/Utilities/LibMatrix.Utilities.Bot/Commands/AliassesCommand.cs
@@ -0,0 +1,43 @@
+using System.Collections.Frozen;
+using System.Text;
+using LibMatrix.EventTypes.Spec;
+using LibMatrix.Helpers;
+using LibMatrix.Utilities.Bot.Interfaces;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace LibMatrix.Utilities.Bot.Commands;
+
+public class AliassesCommand(IServiceProvider services) : ICommand {
+    public string Name { get; } = "aliasses";
+    public string[]? Aliases { get; }
+    public string Description { get; } = "Displays aliasses for a command";
+    public bool Unlisted { get; } = true;
+    //TODO: implement command
+
+    public async Task Invoke(CommandContext ctx) {
+        var sb = new StringBuilder();
+        sb.AppendLine("Available commands:");
+        var commands = services.GetServices<ICommand>().Where(x => !x.Unlisted).ToList();
+        foreach (var command in commands) sb.AppendLine($"- {command.Name}: {command.Description}");
+
+        await ctx.Room.SendMessageEventAsync(new RoomMessageEventContent("m.notice", sb.ToString()));
+        
+        var msb = new MessageBuilder("m.notice");
+        msb.WithHtmlTag("table", tb => {
+            tb.WithHtmlTag("thead", th => th.WithBody("Available commands"));
+            tb.WithHtmlTag("tr", tr => {
+                tr.WithHtmlTag("th", th => th.WithBody("Command"));
+                tr.WithHtmlTag("th", th => th.WithBody("Aliasses"));
+                tr.WithHtmlTag("th", th => th.WithBody("Description"));
+            });
+            foreach (var command in commands) {
+                tb.WithHtmlTag("tr", tr => {
+                    tr.WithHtmlTag("td", td => td.WithBody(command.Name));
+                    tr.WithHtmlTag("td", td => td.WithBody(string.Join(", ", command.Aliases)));
+                    tr.WithHtmlTag("td", td => td.WithBody(command.Description));
+                });
+            }
+        });
+        await ctx.Room.SendMessageEventAsync(msb.Build());
+    }
+}
\ No newline at end of file
diff --git a/Utilities/LibMatrix.Utilities.Bot/Commands/HelpCommand.cs b/Utilities/LibMatrix.Utilities.Bot/Commands/HelpCommand.cs
index 979fab6..0abc76b 100644
--- a/Utilities/LibMatrix.Utilities.Bot/Commands/HelpCommand.cs
+++ b/Utilities/LibMatrix.Utilities.Bot/Commands/HelpCommand.cs
@@ -1,6 +1,7 @@
 using System.Collections.Frozen;
 using System.Text;
 using LibMatrix.EventTypes.Spec;
+using LibMatrix.Helpers;
 using LibMatrix.Utilities.Bot.Interfaces;
 using Microsoft.Extensions.DependencyInjection;
 
@@ -13,27 +14,47 @@ public class HelpCommand(IServiceProvider services) : ICommand {
     public bool Unlisted { get; }
 
     public async Task Invoke(CommandContext ctx) {
-        var sb = new StringBuilder();
-        sb.AppendLine("Available commands:");
-        var commands = services.GetServices<ICommand>().Where(x => !x.Unlisted).ToList();
-        foreach (var command in commands) sb.AppendLine($"- {command.Name}: {command.Description}");
-
-        await ctx.Room.SendMessageEventAsync(new RoomMessageEventContent("m.notice", sb.ToString()));
+        var commands = services.GetServices<ICommand>()
+            .Where(x => !x.Unlisted
+                        && !x.GetType().GetInterfaces().Any(i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(ICommand<>))
+            ).ToList();
+
+        var msb = GenerateCommandList(commands);
+        
+        await ctx.Room.SendMessageEventAsync(msb.Build());
     }
-}
-
-public class HelpCommandWithSubCommands<T>(T command) where T : ICommandGroup {
-    public string Name { get; } = "help";
-    public string[]? Aliases { get; } = new[] { "?" };
-    public string Description { get; } = "Displays this help message";
-
-    public async Task Invoke(CommandContext ctx) {
-        var sb = new StringBuilder();
-        sb.AppendLine("Available subcommands:");
-        var commands = command.SubCommands;
-
-        foreach (var command in commands) sb.AppendLine($"- {command.Name}: {command.Description}");
 
-        await ctx.Room.SendMessageEventAsync(new RoomMessageEventContent("m.notice", sb.ToString()));
+    public static MessageBuilder GenerateCommandList(List<ICommand> commands, MessageBuilder? msb = null) {
+        msb ??= new MessageBuilder("m.notice");
+        msb.WithTable(tb => {
+            tb.WithTitle("Available commands", 2);
+            tb.WithRow(rb => {
+                rb.WithCell("Command");
+                rb.WithCell("Description");
+            });
+
+            foreach (var command in commands) {
+                tb.WithRow(rb => {
+                    rb.WithCell(command.Name);
+                    rb.WithCell(command.Description);
+                });
+            }
+        });
+        // msb.WithHtmlTag("table", tb => {
+            // tb.WithHtmlTag("thead",
+                // th => { th.WithHtmlTag("tr", tr => { tr.WithHtmlTag("th", th => th.WithBody("Available commands"), new Dictionary<string, string> { ["colspan"] = "2" }); }); });
+            // tb.WithHtmlTag("tr", tr => {
+                // tr.WithHtmlTag("th", th => th.WithBody("Command"));
+                // tr.WithHtmlTag("th", th => th.WithBody("Description"));
+            // });
+            // foreach (var command in commands) {
+                // tb.WithHtmlTag("tr", tr => {
+                    // tr.WithHtmlTag("td", td => td.WithBody(command.Name));
+                    // tr.WithHtmlTag("td", td => td.WithBody(command.Description));
+                // });
+            // }
+        // });
+        
+        return msb;
     }
 }
\ No newline at end of file
diff --git a/Utilities/LibMatrix.Utilities.Bot/Commands/PingCommand.cs b/Utilities/LibMatrix.Utilities.Bot/Commands/PingCommand.cs
index 5e021a2..76e48f5 100644
--- a/Utilities/LibMatrix.Utilities.Bot/Commands/PingCommand.cs
+++ b/Utilities/LibMatrix.Utilities.Bot/Commands/PingCommand.cs
@@ -5,7 +5,7 @@ namespace LibMatrix.Utilities.Bot.Commands;
 
 public class PingCommand : ICommand {
     public string Name { get; } = "ping";
-    public string[]? Aliases { get; } = [ "?" ];
+    public string[]? Aliases { get; } = [ ];
     public string Description { get; } = "Pong!";
     public bool Unlisted { get; }
 
diff --git a/Utilities/LibMatrix.Utilities.Bot/Interfaces/ICommand.cs b/Utilities/LibMatrix.Utilities.Bot/Interfaces/ICommand.cs
index 4626a23..941d69e 100644
--- a/Utilities/LibMatrix.Utilities.Bot/Interfaces/ICommand.cs
+++ b/Utilities/LibMatrix.Utilities.Bot/Interfaces/ICommand.cs
@@ -1,5 +1,6 @@
 using System.Collections.Frozen;
 using System.Collections.Immutable;
+using Microsoft.Extensions.DependencyInjection;
 
 namespace LibMatrix.Utilities.Bot.Interfaces;
 
@@ -14,7 +15,8 @@ public interface ICommand {
     public Task Invoke(CommandContext ctx);
 }
 
+public interface ICommand<T> : ICommand where T : ICommandGroup { }
 
-public interface ICommandGroup : ICommand {
-    public IImmutableList<ICommand> SubCommands { get; }
-}
\ No newline at end of file
+public interface ICommandGroup : ICommand { }
+
+public interface ICommandGroup<T> : ICommandGroup where T : ICommandGroup { }
\ No newline at end of file
diff --git a/Utilities/LibMatrix.Utilities.Bot/Services/CommandListenerHostedService.cs b/Utilities/LibMatrix.Utilities.Bot/Services/CommandListenerHostedService.cs
index fdf919b..6f22c03 100644
--- a/Utilities/LibMatrix.Utilities.Bot/Services/CommandListenerHostedService.cs
+++ b/Utilities/LibMatrix.Utilities.Bot/Services/CommandListenerHostedService.cs
@@ -112,11 +112,7 @@ public class CommandListenerHostedService : IHostedService {
         var message = evt.TypedContent as RoomMessageEventContent;
         var room = _hs.GetRoom(evt.RoomId!);
         
-        
-        var commandWithoutPrefix = message.BodyWithoutReplyFallback[usedPrefix.Length..];
-        var command = _commands.OrderByDescending(x => x.Name.Length).FirstOrDefault(x => commandWithoutPrefix.StartsWith(x.Name));
-        if (commandWithoutPrefix.Length != command.Name.Length && commandWithoutPrefix[command.Name.Length] != ' ') command = null;
-
+        var commandWithoutPrefix = message.BodyWithoutReplyFallback[usedPrefix.Length..].Trim();
         var ctx = new CommandContext {
             Room = room,
             MessageEvent = @evt,
@@ -124,45 +120,56 @@ public class CommandListenerHostedService : IHostedService {
             Args = commandWithoutPrefix.Split(' ').Length == 1 ? [] : commandWithoutPrefix.Split(' ')[1..],
             CommandName = commandWithoutPrefix.Split(' ')[0]
         };
-        if (command == null) {
-            await room.SendMessageEventAsync(
-                new RoomMessageEventContent("m.notice", $"Command \"{ctx.CommandName}\" not found!"));
-            return new() {
-                Success = false,
-                Result = CommandResult.CommandResultType.Failure_InvalidCommand,
-                Context = ctx
-            };
-        }
+        try {
+            var command = _commands.SingleOrDefault(x => x.Name == commandWithoutPrefix.Split(' ')[0] || x.Aliases?.Contains(commandWithoutPrefix.Split(' ')[0]) == true);
+            if (command == null) {
+                await room.SendMessageEventAsync(
+                    new RoomMessageEventContent("m.notice", $"Command \"{ctx.CommandName}\" not found!"));
+                return new() {
+                    Success = false,
+                    Result = CommandResult.CommandResultType.Failure_InvalidCommand,
+                    Context = ctx
+                };
+            }
 
 
-        if (await command.CanInvoke(ctx))
-            try {
-                await command.Invoke(ctx);
-            }
-            catch (Exception e) {
+            if (await command.CanInvoke(ctx))
+                try {
+                    await command.Invoke(ctx);
+                }
+                catch (Exception e) {
+                    return new CommandResult() {
+                        Context = ctx,
+                        Result = CommandResult.CommandResultType.Failure_Exception,
+                        Success = false,
+                        Exception = e
+                    };
+                    // await room.SendMessageEventAsync(
+                    // MessageFormatter.FormatException("An error occurred during the execution of this command", e));
+                }
+            else
                 return new CommandResult() {
                     Context = ctx,
-                    Result = CommandResult.CommandResultType.Failure_Exception,
-                    Success = false,
-                    Exception = e
+                    Result = CommandResult.CommandResultType.Failure_NoPermission,
+                    Success = false
                 };
-                // await room.SendMessageEventAsync(
-                    // MessageFormatter.FormatException("An error occurred during the execution of this command", e));
-            }
-        else
+            // await room.SendMessageEventAsync(
+            // new RoomMessageEventContent("m.notice", "You do not have permission to run this command!"));
+
             return new CommandResult() {
                 Context = ctx,
-                Result = CommandResult.CommandResultType.Failure_NoPermission,
-                Success = false
+                Success = true,
+                Result = CommandResult.CommandResultType.Success
             };
-            // await room.SendMessageEventAsync(
-                // new RoomMessageEventContent("m.notice", "You do not have permission to run this command!"));
-
-        return new CommandResult() {
-            Context = ctx,
-            Success = true,
-            Result = CommandResult.CommandResultType.Success
-        };
+        }
+        catch (Exception e) {
+            return new CommandResult() {
+                Context = ctx,
+                Result = CommandResult.CommandResultType.Failure_Exception,
+                Success = false,
+                Exception = e
+            };
+        }
     }
 
     private async Task HandleResult(CommandResult res) {