about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2021-04-12 21:18:42 +0000
committerRory& <root@rory.gay>2026-02-06 14:09:56 +0100
commit315e2fedaf8adc6f3783d9af675892580b64248c (patch)
tree3a96d6dfe71056566ff108587c575e38568faa28
parentFix tests for diff spans (diff)
downloadcgit-magenta-315e2fedaf8adc6f3783d9af675892580b64248c.tar.xz
Fix crash trying to print "this commit" on 404s
For example any URL that starts with a real repo name but isn't
valid.
-rw-r--r--ui-shared.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-shared.c b/ui-shared.c

index 8fef1e1..32ac6d2 100644 --- a/ui-shared.c +++ b/ui-shared.c
@@ -939,7 +939,7 @@ void cgit_add_clone_urls(void (*fn)(const char *)) static int print_this_commit_option(void) { struct object_id oid; - if (get_oid(ctx.qry.head, &oid)) + if (!ctx.qry.head || get_oid(ctx.qry.head, &oid)) return 1; html_option(oid_to_hex(&oid), "this commit", ctx.qry.head); return 0;