From 026e0efbf6a1aa38c868c442b6813ecfac51cfd3 Mon Sep 17 00:00:00 2001 From: Edward Ned Harvey Date: Tue, 5 Aug 2014 11:32:29 -0400 Subject: In SecureRandom, the usage of ReversedWindowGenerator only reordered the output of sha256Generator. It added computation overhead and zero cryptographic value. Removed. --- crypto/src/security/SecureRandom.cs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'crypto') diff --git a/crypto/src/security/SecureRandom.cs b/crypto/src/security/SecureRandom.cs index ef932ee8c..c91b5ee91 100644 --- a/crypto/src/security/SecureRandom.cs +++ b/crypto/src/security/SecureRandom.cs @@ -22,9 +22,7 @@ namespace Org.BouncyCastle.Security { if (master[0] == null) { - IRandomGenerator gen = sha256Generator; - gen = new ReversedWindowGenerator(gen, 32); - SecureRandom sr = master[0] = new SecureRandom(gen); + SecureRandom sr = master[0] = new SecureRandom(sha256Generator); // Even though Ticks has at most 8 or 14 bits of entropy, there's no harm in adding it. sr.SetSeed(DateTime.Now.Ticks); -- cgit 1.5.1