From 84b631e9b614e780caace68ad0e815ecd5ef4919 Mon Sep 17 00:00:00 2001 From: Erkin Alp Güney Date: Sun, 26 Jun 2022 14:26:36 +0300 Subject: JOIN_GUILDS is not the right flag there --- api/src/routes/invites/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api/src') diff --git a/api/src/routes/invites/index.ts b/api/src/routes/invites/index.ts index 21da2d18..eeafb22a 100644 --- a/api/src/routes/invites/index.ts +++ b/api/src/routes/invites/index.ts @@ -13,7 +13,7 @@ router.get("/:code", route({}), async (req: Request, res: Response) => { res.status(200).send(invite); }); -router.post("/:code", route({right: "JOIN_GUILDS"}), async (req: Request, res: Response) => { +router.post("/:code", route({right: "USE_MASS_INVITES"}), async (req: Request, res: Response) => { const { code } = req.params; const { guild_id } = await Invite.findOneOrFail({ code }) const { features } = await Guild.findOneOrFail({ id: guild_id}); -- cgit 1.5.1 From a034698970f536733c4872157db830bf070531f1 Mon Sep 17 00:00:00 2001 From: Erkin Alp Güney Date: Sun, 26 Jun 2022 14:41:06 +0300 Subject: self-leave logic --- .../guilds/#guild_id/members/#member_id/index.ts | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) (limited to 'api/src') diff --git a/api/src/routes/guilds/#guild_id/members/#member_id/index.ts b/api/src/routes/guilds/#guild_id/members/#member_id/index.ts index 34836292..756b8955 100644 --- a/api/src/routes/guilds/#guild_id/members/#member_id/index.ts +++ b/api/src/routes/guilds/#guild_id/members/#member_id/index.ts @@ -1,5 +1,5 @@ import { Request, Response, Router } from "express"; -import { Member, getPermission, Role, GuildMemberUpdateEvent, emitEvent, Sticker, Emoji, Guild } from "@fosscord/util"; +import { Member, getPermission, getRights, Role, GuildMemberUpdateEvent, emitEvent, Sticker, Emoji, Rights, Guild } from "@fosscord/util"; import { HTTPError } from "lambert-server"; import { route } from "@fosscord/api"; @@ -51,9 +51,16 @@ router.patch("/", route({ body: "MemberChangeSchema" }), async (req: Request, re router.put("/", route({}), async (req: Request, res: Response) => { // TODO: Lurker mode + + const rights = await getRights(req.user_id); let { guild_id, member_id } = req.params; - if (member_id === "@me") member_id = req.user_id; + if (member_id === "@me") { + member_id = req.user_id; + rights.hasThrow("JOIN_GUILDS"); + } else { + // TODO: join others by controller + } var guild = await Guild.findOneOrFail({ where: { id: guild_id } }); @@ -71,7 +78,16 @@ router.put("/", route({}), async (req: Request, res: Response) => { res.send({...guild, emojis: emoji, roles: roles, stickers: stickers}); }); -router.delete("/", route({ permission: "KICK_MEMBERS" }), async (req: Request, res: Response) => { +router.delete("/", route(), async (req: Request, res: Response) => { + const permission = await getPermission(req.user_id); + const rights = await getRights(req.user_id); + if (member_id !== "@me" || member_id === req.user_id) { + // TODO: unless force-joined + rights.hasThrow("SELF_LEAVE_GUILDS"); + } else { + rights.hasThrow("KICK_BAN_MEMBERS"); + permission.hasThrow("KICK_MEMBERS"); + } const { guild_id, member_id } = req.params; await Member.removeFromGuild(member_id, guild_id); -- cgit 1.5.1 From cecd9f6e827f71054201a4a7784aaf15b1aa800a Mon Sep 17 00:00:00 2001 From: Erkin Alp Güney Date: Sun, 26 Jun 2022 14:42:06 +0300 Subject: fix the wrong name --- api/src/routes/guilds/#guild_id/members/#member_id/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api/src') diff --git a/api/src/routes/guilds/#guild_id/members/#member_id/index.ts b/api/src/routes/guilds/#guild_id/members/#member_id/index.ts index 756b8955..38f2a529 100644 --- a/api/src/routes/guilds/#guild_id/members/#member_id/index.ts +++ b/api/src/routes/guilds/#guild_id/members/#member_id/index.ts @@ -83,7 +83,7 @@ router.delete("/", route(), async (req: Request, res: Response) => { const rights = await getRights(req.user_id); if (member_id !== "@me" || member_id === req.user_id) { // TODO: unless force-joined - rights.hasThrow("SELF_LEAVE_GUILDS"); + rights.hasThrow("SELF_LEAVE_GROUPS"); } else { rights.hasThrow("KICK_BAN_MEMBERS"); permission.hasThrow("KICK_MEMBERS"); -- cgit 1.5.1 From d834b52fc4f9179acaafa7bce788f15b4e2c896e Mon Sep 17 00:00:00 2001 From: Madeline <46743919+MaddyUnderStars@users.noreply.github.com> Date: Sun, 26 Jun 2022 23:33:30 +1000 Subject: Fix compile errors in latest --- .../guilds/#guild_id/members/#member_id/index.ts | 24 +++++++++++++--------- 1 file changed, 14 insertions(+), 10 deletions(-) (limited to 'api/src') diff --git a/api/src/routes/guilds/#guild_id/members/#member_id/index.ts b/api/src/routes/guilds/#guild_id/members/#member_id/index.ts index 38f2a529..c285abb3 100644 --- a/api/src/routes/guilds/#guild_id/members/#member_id/index.ts +++ b/api/src/routes/guilds/#guild_id/members/#member_id/index.ts @@ -51,7 +51,7 @@ router.patch("/", route({ body: "MemberChangeSchema" }), async (req: Request, re router.put("/", route({}), async (req: Request, res: Response) => { // TODO: Lurker mode - + const rights = await getRights(req.user_id); let { guild_id, member_id } = req.params; @@ -59,28 +59,33 @@ router.put("/", route({}), async (req: Request, res: Response) => { member_id = req.user_id; rights.hasThrow("JOIN_GUILDS"); } else { - // TODO: join others by controller + // TODO: join others by controller } var guild = await Guild.findOneOrFail({ - where: { id: guild_id } }); + where: { id: guild_id } + }); var emoji = await Emoji.find({ - where: { guild_id: guild_id } }); + where: { guild_id: guild_id } + }); var roles = await Role.find({ - where: { guild_id: guild_id } }); + where: { guild_id: guild_id } + }); var stickers = await Sticker.find({ - where: { guild_id: guild_id } }); - + where: { guild_id: guild_id } + }); + await Member.addToGuild(member_id, guild_id); - res.send({...guild, emojis: emoji, roles: roles, stickers: stickers}); + res.send({ ...guild, emojis: emoji, roles: roles, stickers: stickers }); }); -router.delete("/", route(), async (req: Request, res: Response) => { +router.delete("/", route({}), async (req: Request, res: Response) => { const permission = await getPermission(req.user_id); const rights = await getRights(req.user_id); + const { guild_id, member_id } = req.params; if (member_id !== "@me" || member_id === req.user_id) { // TODO: unless force-joined rights.hasThrow("SELF_LEAVE_GROUPS"); @@ -88,7 +93,6 @@ router.delete("/", route(), async (req: Request, res: Response) => { rights.hasThrow("KICK_BAN_MEMBERS"); permission.hasThrow("KICK_MEMBERS"); } - const { guild_id, member_id } = req.params; await Member.removeFromGuild(member_id, guild_id); res.sendStatus(204); -- cgit 1.5.1