From 6d67e2f8c53f5391ea20a39135ee5e2aa2b0ed62 Mon Sep 17 00:00:00 2001 From: babolivier Date: Tue, 19 Jul 2022 14:14:03 +0000 Subject: deploy: 6fccd72f42ac76b185cc20ed258792ff94ee81fb --- latest/development/cas.html | 2 +- latest/development/contributing_guide.html | 15 +- latest/development/database_schema.html | 2 +- latest/development/demo.html | 2 +- latest/development/dependencies.html | 2 +- latest/development/experimental_features.html | 2 +- latest/development/git.html | 2 +- .../development/internal_documentation/index.html | 2 +- latest/development/releases.html | 6 +- latest/development/reviews.html | 222 +++++++++++++++++++++ latest/development/room-dag-concepts.html | 2 +- latest/development/saml.html | 2 +- .../synapse_architecture/cancellation.html | 2 +- latest/development/url_previews.html | 2 +- 14 files changed, 248 insertions(+), 17 deletions(-) create mode 100644 latest/development/reviews.html (limited to 'latest/development') diff --git a/latest/development/cas.html b/latest/development/cas.html index 9489e46039..f8228d64a2 100644 --- a/latest/development/cas.html +++ b/latest/development/cas.html @@ -76,7 +76,7 @@ diff --git a/latest/development/contributing_guide.html b/latest/development/contributing_guide.html index 3e875cce15..bdebf87817 100644 --- a/latest/development/contributing_guide.html +++ b/latest/development/contributing_guide.html @@ -76,7 +76,7 @@ @@ -347,6 +347,9 @@ Here is how to run your local Synapse checkout against your local Complement che
  • Passing POSTGRES=1 as an environment variable to use the Postgres database instead.
  • Passing WORKERS=1 as an environment variable to use a workerised setup instead. This option implies the use of Postgres.
    • +

    To increase the log level for the tests, set SYNAPSE_TEST_LOG_LEVEL, e.g:

    +
    SYNAPSE_TEST_LOG_LEVEL=DEBUG COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh -run TestImportHistoricalMessages
+

    Prettier formatting with gotestfmt

    If you want to format the output of the tests the same way as it looks in CI, install gotestfmt.

    @@ -373,7 +376,7 @@ install gotestfmt.<
  • git push your commit to your fork of Synapse;
  • on GitHub, create the Pull Request;
  • add a changelog entry and push it to your Pull Request;
    • -
  • for most contributors, that's all - however, if you are a member of the organization matrix-org, on GitHub, please request a review from matrix.org / Synapse Core.
    • +
  • that's it for now, a non-draft pull request will automatically request review from the team;
  • if you need to update your PR, please avoid rebasing and just add new commits to your branch.

    • Changelog

    @@ -522,7 +525,11 @@ be required.

  • If there is any error, fix the error.
    • -
  • If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again.
    • +
  • If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again. + +
  • Create a new commit with the changes.
  • Back to 1.
    • +
  • Once the pull request is ready for review again please re-request review from whichever developer did your initial +review (or leave a comment in the pull request that you believe all required changes have been done).

    • Once both the CI and the developers are happy, the patch will be merged into Synapse and released shortly!

    11. Find a new issue.

    diff --git a/latest/development/database_schema.html b/latest/development/database_schema.html index 4647bfed38..2b2c5ceaec 100644 --- a/latest/development/database_schema.html +++ b/latest/development/database_schema.html @@ -76,7 +76,7 @@ diff --git a/latest/development/demo.html b/latest/development/demo.html index 3622336657..88089929c4 100644 --- a/latest/development/demo.html +++ b/latest/development/demo.html @@ -76,7 +76,7 @@ diff --git a/latest/development/dependencies.html b/latest/development/dependencies.html index 46b2ac0bae..168648a8a0 100644 --- a/latest/development/dependencies.html +++ b/latest/development/dependencies.html @@ -76,7 +76,7 @@ diff --git a/latest/development/experimental_features.html b/latest/development/experimental_features.html index b82202c3b3..e58d22dba1 100644 --- a/latest/development/experimental_features.html +++ b/latest/development/experimental_features.html @@ -76,7 +76,7 @@ diff --git a/latest/development/git.html b/latest/development/git.html index a3e299777c..1f6ac5c907 100644 --- a/latest/development/git.html +++ b/latest/development/git.html @@ -76,7 +76,7 @@ diff --git a/latest/development/internal_documentation/index.html b/latest/development/internal_documentation/index.html index f85324af4a..1de6b5daee 100644 --- a/latest/development/internal_documentation/index.html +++ b/latest/development/internal_documentation/index.html @@ -76,7 +76,7 @@ diff --git a/latest/development/releases.html b/latest/development/releases.html index 5a4afdfb69..502adcad8e 100644 --- a/latest/development/releases.html +++ b/latest/development/releases.html @@ -76,7 +76,7 @@ @@ -181,7 +181,7 @@ found in the security catego