From 7cf0b9069f40acfbf84e64233a62231cd8e40e87 Mon Sep 17 00:00:00 2001 From: clokep Date: Wed, 6 Jul 2022 11:31:35 +0000 Subject: deploy: dcc7873700da4a818e84c44c6190525d39a854cb --- develop/print.html | 45 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 42 insertions(+), 3 deletions(-) (limited to 'develop/print.html') diff --git a/develop/print.html b/develop/print.html index 4d1f1aeb98..a6397eb006 100644 --- a/develop/print.html +++ b/develop/print.html @@ -77,7 +77,7 @@ @@ -14135,7 +14135,7 @@ install gotestfmt.<
  • git push your commit to your fork of Synapse;
  • on GitHub, create the Pull Request;
  • add a changelog entry and push it to your Pull Request;
    • -
  • for most contributors, that's all - however, if you are a member of the organization matrix-org, on GitHub, please request a review from matrix.org / Synapse Core.
    • +
  • that's it for now, a non-draft pull request will automatically request review from the team;
  • if you need to update your PR, please avoid rebasing and just add new commits to your branch.

    • Changelog

    @@ -14284,7 +14284,11 @@ be required.

  • If there is any error, fix the error.
    • -
  • If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again.
    • +
  • If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again. + +
  • Create a new commit with the changes.
  • Back to 1.
    • +
  • Once the pull request is ready for review again please re-request review from whichever developer did your initial +review (or leave a comment in the pull request that you believe all required changes have been done).

    • Once both the CI and the developers are happy, the patch will be merged into Synapse and released shortly!

    11. Find a new issue.

    @@ -14429,6 +14435,39 @@ for the module.

    and is maintained by a script, scripts-dev/generate_sample_config.sh. Making sure that the output from this script matches the desired format is left as an exercise for the reader!

    +

    Some notes on how we do reviews

    +

    The Synapse team works off a shared review queue -- any new pull requests for +Synapse (or related projects) has a review requested from the entire team. Team +members should process this queue using the following rules:

    + +

    For the latter two categories above, older pull requests should be prioritised.

    +

    It is explicit that there is no priority given to pull requests from the team +(vs from the community). If a pull request requires a quick turn around, please +explicitly communicate this via #synapse-dev:matrix.org +or as a comment on the pull request.

    +

    Once an initial review has been completed and the author has made additional changes, +follow-up reviews should go back to the same reviewer. This helps build a shared +context and conversation between author and reviewer.

    +

    As a team we aim to keep the number of inflight pull requests to a minimum to ensure +that ongoing work is finished before starting new work.

    +

    Performing a review

    +

    To communicate to the rest of the team the status of each pull request, team +members should do the following:

    + +

    If you are unsure about a particular part of the pull request (or are not confident +in your understanding of part of the code) then ask questions or request review +from the team again. When requesting review from the team be sure to leave a comment +with the rationale on why you're putting it back in the queue.

    Synapse Release Cycle

    Releases of Synapse follow a two week release cycle with new releases usually occurring on Tuesdays:

    -- cgit 1.5.1