From d77783ca009d9b70372881a71e53089eef0b1ee9 Mon Sep 17 00:00:00 2001
From: DMRobertson
Date: Tue, 30 May 2023 12:55:46 +0000
Subject: deploy: 42786d8a477b6d44075b0e56949820331d9962d8
---
develop/development/dependencies.html | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
(limited to 'develop/development')
diff --git a/develop/development/dependencies.html b/develop/development/dependencies.html
index 8435095574..d64f15fc41 100644
--- a/develop/development/dependencies.html
+++ b/develop/development/dependencies.html
@@ -334,15 +334,16 @@ poetry lock --no-update
doesn't require poetry. (It's what we use in CI too). However, you could try
poetry build
too.
-Synapse uses Dependabot to keep the poetry.lock
file up-to-date. When it
-creates a pull request a GitHub Action will run to automatically create a changelog
-file. Ensure that:
+Synapse uses Dependabot to keep the poetry.lock
and Cargo.lock
file
+up-to-date with the latest releases of our dependencies. The changelog check is
+omitted for Dependabot PRs; the release script will include them in the
+changelog.
+When reviewing a dependabot PR, ensure that:
- the lockfile changes look reasonable;
- the upstream changelog file (linked in the description) doesn't include any
breaking changes;
-- continuous integration passes (due to permissions, the GitHub Actions run on
-the changelog commit will fail, look at the initial commit of the pull request);
+- continuous integration passes.
In particular, any updates to the type hints (usually packages which start with types-
)
should be safe to merge if linting passes.
--
cgit 1.5.1