From 7cf0b9069f40acfbf84e64233a62231cd8e40e87 Mon Sep 17 00:00:00 2001
From: clokep
Date: Wed, 6 Jul 2022 11:31:35 +0000
Subject: deploy: dcc7873700da4a818e84c44c6190525d39a854cb
---
develop/development/contributing_guide.html | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
(limited to 'develop/development/contributing_guide.html')
diff --git a/develop/development/contributing_guide.html b/develop/development/contributing_guide.html
index e770b68a95..2778bd52c4 100644
--- a/develop/development/contributing_guide.html
+++ b/develop/development/contributing_guide.html
@@ -76,7 +76,7 @@
@@ -376,7 +376,7 @@ install gotestfmt.<
git push
your commit to your fork of Synapse;
on GitHub, create the Pull Request;
add a changelog entry and push it to your Pull Request;
-for most contributors, that's all - however, if you are a member of the organization matrix-org
, on GitHub, please request a review from matrix.org / Synapse Core
.
+that's it for now, a non-draft pull request will automatically request review from the team;
if you need to update your PR, please avoid rebasing and just add new commits to your branch.
@@ -525,7 +525,11 @@ be required.
If there is any error, fix the error.
-If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again.
+If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again.
+
+- A pull request is a conversation, if you disagree with the suggestions, please respond and discuss it.
+
+
Create a new commit with the changes.
- Please do NOT overwrite the history. New commits make the reviewer's life easier.
@@ -533,6 +537,8 @@ be required.
Back to 1.
+Once the pull request is ready for review again please re-request review from whichever developer did your initial
+review (or leave a comment in the pull request that you believe all required changes have been done).
Once both the CI and the developers are happy, the patch will be merged into Synapse and released shortly!
--
cgit 1.5.1