From d9277e94f3740b15f8bcede9695d83090a86a749 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Tue, 16 Jun 2020 12:00:57 +0100 Subject: Don't lowercase medium in this PR --- synapse/rest/client/v1/login.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/synapse/rest/client/v1/login.py b/synapse/rest/client/v1/login.py index 14189828ff..602785fe22 100644 --- a/synapse/rest/client/v1/login.py +++ b/synapse/rest/client/v1/login.py @@ -150,7 +150,7 @@ class LoginRestServlet(RestServlet): ) if medium and address: self._failed_attempts_ratelimiter.ratelimit( - (medium.lower(), address.lower()), update=False + (medium, address.lower()), update=False ) # Extract a localpart or user ID from the values in the identifier @@ -163,7 +163,7 @@ class LoginRestServlet(RestServlet): # The user attempted to login via threepid and failed # Record this failed attempt self._failed_attempts_ratelimiter.can_do_action( - (medium.lower(), address.lower()) + (medium, address.lower()) ) raise LoginError(403, "Unauthorized threepid", errcode=Codes.FORBIDDEN) -- cgit 1.5.1