From d0bdd41a75ac71281311aa7e03d488e8367772e7 Mon Sep 17 00:00:00 2001 From: reivilibre Date: Wed, 24 Jan 2024 11:59:15 +0000 Subject: Downgrade the `download-artifact` and `upload-artifact` actions to v3 due to breaking changes. (#16847) Partially reverts #16796 This is causing errors of the form: ``` Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` for the debs and wheels stages. There were breaking changes that weren't included in the dependabot changelog (:/): https://github.com/actions/upload-artifact#breaking-changes Base: `release-v1.100` Original commit schedule, with full messages:
  1. Downgrade the `upload-artifact` and `download-artifact` actions to v3
--------- Signed-off-by: Olivier Wilkinson (reivilibre) --- .github/workflows/release-artifacts.yml | 8 ++++---- changelog.d/16847.misc | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 changelog.d/16847.misc diff --git a/.github/workflows/release-artifacts.yml b/.github/workflows/release-artifacts.yml index 3773b97c73..5d4a4fe1d6 100644 --- a/.github/workflows/release-artifacts.yml +++ b/.github/workflows/release-artifacts.yml @@ -92,7 +92,7 @@ jobs: mv /tmp/.buildx-cache-new /tmp/.buildx-cache - name: Upload debs as artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 # Don't upgrade to v4; broken: https://github.com/actions/upload-artifact#breaking-changes with: name: debs path: debs/* @@ -156,7 +156,7 @@ jobs: CARGO_NET_GIT_FETCH_WITH_CLI: true CIBW_ENVIRONMENT_PASS_LINUX: CARGO_NET_GIT_FETCH_WITH_CLI - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 # Don't upgrade to v4; broken: https://github.com/actions/upload-artifact#breaking-changes with: name: Wheel path: ./wheelhouse/*.whl @@ -177,7 +177,7 @@ jobs: - name: Build sdist run: python -m build --sdist - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v3 # Don't upgrade to v4; broken: https://github.com/actions/upload-artifact#breaking-changes with: name: Sdist path: dist/*.tar.gz @@ -194,7 +194,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Download all workflow run artifacts - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v3 # Don't upgrade to v4, it should match upload-artifact - name: Build a tarball for the debs run: tar -cvJf debs.tar.xz debs - name: Attach to release diff --git a/changelog.d/16847.misc b/changelog.d/16847.misc new file mode 100644 index 0000000000..95650f01fb --- /dev/null +++ b/changelog.d/16847.misc @@ -0,0 +1 @@ +Downgrade the `download-artifact` and `upload-artifact` actions to v3 due to breaking changes. \ No newline at end of file -- cgit 1.5.1 From cf7109fc352ce7224214f719e0c3e67f7c4a7942 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Wed, 24 Jan 2024 12:01:20 +0000 Subject: 1.100.0rc2 --- CHANGES.md | 9 +++++++++ changelog.d/16847.misc | 1 - debian/changelog | 6 ++++++ pyproject.toml | 2 +- 4 files changed, 16 insertions(+), 2 deletions(-) delete mode 100644 changelog.d/16847.misc diff --git a/CHANGES.md b/CHANGES.md index 4bef78409e..b91ef3d73f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,14 @@ +# Synapse 1.100.0rc2 (2024-01-24) + +### Internal Changes + +- Downgrade the `download-artifact` and `upload-artifact` actions to v3 due to breaking changes. ([\#16847](https://github.com/element-hq/synapse/issues/16847)) + + # Synapse 1.100.0rc1 (2024-01-23) +*This version was never released to PyPI or the Debian repository due to failures in the automatic part of the release process.* + ### Features - Advertise experimental support for [MSC4028](https://github.com/matrix-org/matrix-spec-proposals/pull/4028) through `/_matrix/clients/versions` if enabled. Contributed by @hanadi92. ([\#16787](https://github.com/element-hq/synapse/issues/16787)) diff --git a/changelog.d/16847.misc b/changelog.d/16847.misc deleted file mode 100644 index 95650f01fb..0000000000 --- a/changelog.d/16847.misc +++ /dev/null @@ -1 +0,0 @@ -Downgrade the `download-artifact` and `upload-artifact` actions to v3 due to breaking changes. \ No newline at end of file diff --git a/debian/changelog b/debian/changelog index ca0e2aec49..5a86b6302b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +matrix-synapse-py3 (1.100.0~rc2) stable; urgency=medium + + * New Synapse release 1.100.0rc2. + + -- Synapse Packaging team Wed, 24 Jan 2024 11:59:51 +0000 + matrix-synapse-py3 (1.100.0~rc1) stable; urgency=medium * New Synapse release 1.100.0rc1. diff --git a/pyproject.toml b/pyproject.toml index 3bfbb1cc41..d4cb01f7c5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -96,7 +96,7 @@ module-name = "synapse.synapse_rust" [tool.poetry] name = "matrix-synapse" -version = "1.100.0rc1" +version = "1.100.0rc2" description = "Homeserver for the Matrix decentralised comms protocol" authors = ["Matrix.org Team and Contributors "] license = "AGPL-3.0-or-later" -- cgit 1.5.1 From 594842cf7fe4cb3afde4c613345d96019e7006cb Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Wed, 24 Jan 2024 12:05:03 +0000 Subject: Tweak changelog --- CHANGES.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index b91ef3d73f..e9478ea1ac 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,7 @@ # Synapse 1.100.0rc2 (2024-01-24) +This version is the same as 1.100.0rc1 but with fixes to the release process. + ### Internal Changes - Downgrade the `download-artifact` and `upload-artifact` actions to v3 due to breaking changes. ([\#16847](https://github.com/element-hq/synapse/issues/16847)) -- cgit 1.5.1 From adf15c4f6b856c3dfc98904a039f678cac036c1f Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Wed, 24 Jan 2024 13:57:12 +0000 Subject: Run `ANALYZE` after fiddling with stats (#16849) Introduced in #16833 Fixes #16844 --- changelog.d/16849.bugfix | 1 + .../main/delta/84/01_auth_links_stats.sql.postgres | 2 ++ .../main/delta/84/03_auth_links_analyze.sql.postgres | 16 ++++++++++++++++ 3 files changed, 19 insertions(+) create mode 100644 changelog.d/16849.bugfix create mode 100644 synapse/storage/schema/main/delta/84/03_auth_links_analyze.sql.postgres diff --git a/changelog.d/16849.bugfix b/changelog.d/16849.bugfix new file mode 100644 index 0000000000..1bbe2b9ad8 --- /dev/null +++ b/changelog.d/16849.bugfix @@ -0,0 +1 @@ +Fix database performance regression due to changing Postgres table statistics. Introduced in v1.100.0rc1. diff --git a/synapse/storage/schema/main/delta/84/01_auth_links_stats.sql.postgres b/synapse/storage/schema/main/delta/84/01_auth_links_stats.sql.postgres index b0b41bd106..0c3ae979eb 100644 --- a/synapse/storage/schema/main/delta/84/01_auth_links_stats.sql.postgres +++ b/synapse/storage/schema/main/delta/84/01_auth_links_stats.sql.postgres @@ -16,3 +16,5 @@ -- figuring that out by itself. ALTER TABLE event_auth_chain_links ALTER origin_chain_id SET (n_distinct = -0.5); ALTER TABLE event_auth_chain_links ALTER target_chain_id SET (n_distinct = -0.5); + +-- We should have done an `ANALYZE event_auth_chain_links` here, but we forgot. diff --git a/synapse/storage/schema/main/delta/84/03_auth_links_analyze.sql.postgres b/synapse/storage/schema/main/delta/84/03_auth_links_analyze.sql.postgres new file mode 100644 index 0000000000..aecb72a477 --- /dev/null +++ b/synapse/storage/schema/main/delta/84/03_auth_links_analyze.sql.postgres @@ -0,0 +1,16 @@ +-- +-- This file is licensed under the Affero General Public License (AGPL) version 3. +-- +-- Copyright (C) 2023 New Vector, Ltd +-- +-- This program is free software: you can redistribute it and/or modify +-- it under the terms of the GNU Affero General Public License as +-- published by the Free Software Foundation, either version 3 of the +-- License, or (at your option) any later version. +-- +-- See the GNU Affero General Public License for more details: +-- . + +-- We need to do an ANALYZE after `01_auth_links_stats.sql.postgres`, where we +-- fiddled with the stats. +ANALYZE event_auth_chain_links; -- cgit 1.5.1 From 458c9f6a1591865e3b451c51045216445a3400ff Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Wed, 24 Jan 2024 14:18:35 +0000 Subject: 1.100.0rc3 --- CHANGES.md | 9 +++++++++ changelog.d/16849.bugfix | 1 - debian/changelog | 6 ++++++ pyproject.toml | 2 +- 4 files changed, 16 insertions(+), 2 deletions(-) delete mode 100644 changelog.d/16849.bugfix diff --git a/CHANGES.md b/CHANGES.md index e9478ea1ac..d14e91e221 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,3 +1,12 @@ +# Synapse 1.100.0rc3 (2024-01-24) + +### Bugfixes + +- Fix database performance regression due to changing Postgres table statistics. Introduced in v1.100.0rc1. ([\#16849](https://github.com/element-hq/synapse/issues/16849)) + + + + # Synapse 1.100.0rc2 (2024-01-24) This version is the same as 1.100.0rc1 but with fixes to the release process. diff --git a/changelog.d/16849.bugfix b/changelog.d/16849.bugfix deleted file mode 100644 index 1bbe2b9ad8..0000000000 --- a/changelog.d/16849.bugfix +++ /dev/null @@ -1 +0,0 @@ -Fix database performance regression due to changing Postgres table statistics. Introduced in v1.100.0rc1. diff --git a/debian/changelog b/debian/changelog index 5a86b6302b..67212704bb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +matrix-synapse-py3 (1.100.0~rc3) stable; urgency=medium + + * New Synapse release 1.100.0rc3. + + -- Synapse Packaging team Wed, 24 Jan 2024 14:18:15 +0000 + matrix-synapse-py3 (1.100.0~rc2) stable; urgency=medium * New Synapse release 1.100.0rc2. diff --git a/pyproject.toml b/pyproject.toml index d4cb01f7c5..99c29cea2d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -96,7 +96,7 @@ module-name = "synapse.synapse_rust" [tool.poetry] name = "matrix-synapse" -version = "1.100.0rc2" +version = "1.100.0rc3" description = "Homeserver for the Matrix decentralised comms protocol" authors = ["Matrix.org Team and Contributors "] license = "AGPL-3.0-or-later" -- cgit 1.5.1