From b8da5d07908d49e5402e016e2ad7433e69912c43 Mon Sep 17 00:00:00 2001
From: Luke Barnard <luke@matrix.org>
Date: Mon, 6 Nov 2017 16:16:24 +0000
Subject: Use static column name insertion

Otherwise we end up trying to ORDER BY "is_admin", the literal string.
---
 synapse/storage/_base.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/synapse/storage/_base.py b/synapse/storage/_base.py
index 35ded73f25..73a66e28b0 100644
--- a/synapse/storage/_base.py
+++ b/synapse/storage/_base.py
@@ -670,8 +670,9 @@ class SQLBaseStore(object):
             )
 
         if order:
-            sql = sql + " ORDER BY ? %s" % ("ASC" if order_asc else "DESC")
-            query_values.append(order)
+            sql = sql + " ORDER BY %s %s" % (
+                order, "ASC" if order_asc else "DESC"
+            )
 
         txn.execute(sql, query_values)
 
-- 
cgit 1.5.1