From b0603dabc9e188596c244ef85c0d6dc98ce495e2 Mon Sep 17 00:00:00 2001 From: Mathieu Velten Date: Tue, 22 Nov 2022 17:15:02 +0100 Subject: Add type ignore unused-awaitable to run_in_background calls --- synapse/appservice/scheduler.py | 4 ++-- synapse/federation/transport/server/_base.py | 2 +- synapse/handlers/devicemessage.py | 2 +- synapse/handlers/message.py | 4 ++-- synapse/handlers/presence.py | 2 +- synapse/http/server.py | 2 +- synapse/rest/media/v1/storage_provider.py | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/synapse/appservice/scheduler.py b/synapse/appservice/scheduler.py index 9c7e01a520..8f9f280ec1 100644 --- a/synapse/appservice/scheduler.py +++ b/synapse/appservice/scheduler.py @@ -406,10 +406,10 @@ class _TransactionController: if sent: await txn.complete(self.store) else: - run_in_background(self._on_txn_fail, service) + run_in_background(self._on_txn_fail, service) # type: ignore[unused-awaitable] except Exception: logger.exception("Error creating appservice transaction") - run_in_background(self._on_txn_fail, service) + run_in_background(self._on_txn_fail, service) # type: ignore[unused-awaitable] async def on_recovered(self, recoverer: "_Recoverer") -> None: logger.info( diff --git a/synapse/federation/transport/server/_base.py b/synapse/federation/transport/server/_base.py index cdaf0d5de7..90376dd4f2 100644 --- a/synapse/federation/transport/server/_base.py +++ b/synapse/federation/transport/server/_base.py @@ -132,7 +132,7 @@ class Authenticator: # alive retry_timings = await self.store.get_destination_retry_timings(origin) if retry_timings and retry_timings.retry_last_ts: - run_in_background(self.reset_retry_timings, origin) + run_in_background(self.reset_retry_timings, origin) # type: ignore[unused-awaitable] return origin diff --git a/synapse/handlers/devicemessage.py b/synapse/handlers/devicemessage.py index 444c08bc2e..165ac9249b 100644 --- a/synapse/handlers/devicemessage.py +++ b/synapse/handlers/devicemessage.py @@ -198,7 +198,7 @@ class DeviceMessageHandler: await self.store.mark_remote_user_device_cache_as_stale(sender_user_id) # Immediately attempt a resync in the background - run_in_background(self._user_device_resync, user_id=sender_user_id) + run_in_background(self._user_device_resync, user_id=sender_user_id) # type: ignore[unused-awaitable] async def send_device_message( self, diff --git a/synapse/handlers/message.py b/synapse/handlers/message.py index 875db2eed2..7299aa7e8d 100644 --- a/synapse/handlers/message.py +++ b/synapse/handlers/message.py @@ -1918,7 +1918,7 @@ class EventCreationHandler: if event.type == EventTypes.Message: # We don't want to block sending messages on any presence code. This # matters as sometimes presence code can take a while. - run_in_background(self._bump_active_time, requester.user) + run_in_background(self._bump_active_time, requester.user) # type: ignore[unused-awaitable] async def _notify() -> None: try: @@ -1928,7 +1928,7 @@ class EventCreationHandler: except Exception: logger.exception("Error notifying about new room events") - run_in_background(_notify) + run_in_background(_notify) # type: ignore[unused-awaitable] return persisted_events[-1] diff --git a/synapse/handlers/presence.py b/synapse/handlers/presence.py index 2d1d3f3705..5957f5be3b 100644 --- a/synapse/handlers/presence.py +++ b/synapse/handlers/presence.py @@ -1060,7 +1060,7 @@ class PresenceHandler(BasePresenceHandler): yield finally: if affect_presence: - run_in_background(_end) + run_in_background(_end) # type: ignore[unused-awaitable] return _user_syncing() diff --git a/synapse/http/server.py b/synapse/http/server.py index 051a1899a0..4605404891 100644 --- a/synapse/http/server.py +++ b/synapse/http/server.py @@ -757,7 +757,7 @@ def respond_with_json( if send_cors: set_cors_headers(request) - run_in_background( + run_in_background( # type: ignore[unused-awaitable] _async_write_json_to_request_in_thread, request, encoder, json_object ) return NOT_DONE_YET diff --git a/synapse/rest/media/v1/storage_provider.py b/synapse/rest/media/v1/storage_provider.py index 1c9b71d69c..4cbec73884 100644 --- a/synapse/rest/media/v1/storage_provider.py +++ b/synapse/rest/media/v1/storage_provider.py @@ -112,7 +112,7 @@ class StorageProviderWrapper(StorageProvider): except Exception: logger.exception("Error storing file") - run_in_background(store) + run_in_background(store) # type: ignore[unused-awaitable] async def fetch(self, path: str, file_info: FileInfo) -> Optional[Responder]: if file_info.url_cache: -- cgit 1.5.1