From 0aa020145267829d1ccf9dff6200ebaef4c07c7a Mon Sep 17 00:00:00 2001 From: David Robertson Date: Wed, 8 Mar 2023 18:14:17 +0000 Subject: Unconditionally omit remote events in partial state rooms I can't see why erased senders makes a difference here? --- synapse/visibility.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/synapse/visibility.py b/synapse/visibility.py index cb9a2d1e0a..92955fc2ce 100644 --- a/synapse/visibility.py +++ b/synapse/visibility.py @@ -643,14 +643,13 @@ async def filter_events_for_server( # this check but would base the filtering on an outdated view of the membership events. partial_state_invisible_events = set() - if filter_out_erased_senders: - for e in events: - sender_domain = get_domain_from_id(e.sender) - if ( - sender_domain != local_server_name - and await storage.main.is_partial_state_room(e.room_id) - ): - partial_state_invisible_events.add(e) + for e in events: + sender_domain = get_domain_from_id(e.sender) + if ( + sender_domain != local_server_name + and await storage.main.is_partial_state_room(e.room_id) + ): + partial_state_invisible_events.add(e) # Let's check to see if all the events have a history visibility # of "shared" or "world_readable". If that's the case then we don't -- cgit 1.4.1