summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesPatrick Cloke2023-11-089-93/+227
|\
| * Avoid updating the same rows multiple times with simple_update_many_txn. ↵Patrick Cloke2023-11-071-4/+1
| | | | | | | | | | | | (#16609) simple_update_many_txn had a bug in it which would cause each update to be applied twice.
| * Avoid executing no-op queries. (#16583)Patrick Cloke2023-11-075-19/+33
| | | | | | | | | | | | If simple_{insert,upsert,update}_many_txn is called without any data to modify then return instead of executing the query. This matches the behavior of simple_{select,delete}_many_txn.
| * More tests for the simple_* methods. (#16596)Patrick Cloke2023-11-071-9/+4
| | | | | | | | Expand tests for the simple_* database methods, additionally test against both PostgreSQL and SQLite variants.
| * Collect information for PushRuleEvaluator in parallel. (#16590)Patrick Cloke2023-11-063-34/+86
| | | | | | | | | | | | | | | | Fetch information needed for push rule evaluation in parallel. Ideally this would use query pipelining, but this is not available in psycopg2. Due to the database thread pool this may result in little to no parallelization.
| * Support reactor timing metric on more reactors. (#16532)Patrick Cloke2023-11-061-27/+103
| | | | | | | | | | | | | | | | | | | | Previously only Twisted's EPollReactor was compatible with the reactor timing metric, notably not working when asyncio was used. After this change, the following configurations support the reactor timing metric: * poll, epoll, or select reactors * asyncio reactor with a poll, epoll, select, /dev/poll, or kqueue event loop.
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesPatrick Cloke2023-11-0321-457/+640
|\|
| * Simplify event persistence code (#16584)Patrick Cloke2023-11-032-312/+324
| | | | | | | | | | | | | | | | | | | | | | The event persistence code used to handle multiple rooms at a time, but was simplified to only ever be called with a single room at a time (different rooms are now handled in parallel). The code is still generic to multiple rooms causing a lot of work that is unnecessary (e.g. unnecessary loops, and partitioning data by room). This strips out the ability to handle multiple rooms at once, greatly simplifying the code.
| * Use simple_select_many_txn in event persistance code. (#16585)Patrick Cloke2023-11-021-5/+11
| | | | | | | | | | Just to standardize on the normal helpers, it might also have a slight perf improvement on PostgreSQL which will now use `ANY (?)` instead of `IN (?, ?, ...)`.
| * Bump twisted from 23.8.0 to 23.10.0 (#16588)dependabot[bot]2023-11-011-1/+1
| |
| * Do not call getfullargspec on every call. (#16589)Patrick Cloke2023-10-311-2/+5
| | | | | | | | | | getfullargspec is relatively expensive and the results will not change between calls, so precalculate it outside the wrapper.
| * Remove remaining usage of cursor_to_dict. (#16564)Patrick Cloke2023-10-3114-136/+283
| |
| * Fix import ordering issue introduced in ↵Patrick Cloke2023-10-311-1/+1
| | | | | | | | 7a3a55ac98847d7adb0e200378abe07ef8d0c645.
| * Merge pull request from GHSA-mp92-3jfm-3575Patrick Cloke2023-10-313-1/+16
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-10-312-114/+149
|\|
| * Claim local one-time-keys in bulk (#16565)David Robertson2023-10-302-114/+149
| | | | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-10-304-0/+90
|\|
| * Add fast path for replication events stream fetch (#16580)Erik Johnston2023-10-301-0/+6
| | | | | | | | We can bail early if the from token is greater than or equal to the current token.
| * Claim fallback keys in bulk (#16570)David Robertson2023-10-303-0/+84
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-10-304-5/+22
|\|
| * Fix HTTP repl response to use minimum token (#16578)Erik Johnston2023-10-301-1/+1
| |
| * Portdb: don't copy a table that gets rebuilt (#16563)David Robertson2023-10-271-1/+1
| |
| * Ensure local invited & knocking users leave before purge. (#16559)Patrick Cloke2023-10-272-3/+20
| | | | | | | | | | This is mostly useful for federated rooms where some users would get stuck in the invite or knock state when the room was purged from their homeserver.
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-10-271-0/+10
|\|
| * Reduce amount of caches POSITIONS we send (#16561)Erik Johnston2023-10-271-0/+10
| | | | | | Follow on from / actually correctly does #16557
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesPatrick Cloke2023-10-2783-714/+1570
|\|
| * Reduce spurious replication catchup (#16555)Erik Johnston2023-10-271-5/+9
| |
| * Fix cross-worker ratelimiting (#16558)Erik Johnston2023-10-271-16/+57
| | | | | | c.f. #16481
| * Reduce replication traffic due to reflected cache stream POSITION (#16557)Erik Johnston2023-10-271-1/+18
| |
| * Add new module API for adding custom fields to events `unsigned` section ↵Erik Johnston2023-10-2714-42/+99
| | | | | | | | (#16549)
| * Remove more usages of cursor_to_dict. (#16551)Patrick Cloke2023-10-2621-123/+182
| | | | | | Mostly to improve type safety.
| * Add a new module API to update user presence state. (#16544)Patrick Cloke2023-10-268-42/+94
| | | | | | | | | | | | | | | | | | | | This adds a module API which allows a module to update a user's presence state/status message. This is useful for controlling presence from an external system. To fully control presence from the module the presence.enabled config parameter gains a new state of "untracked" which disables internal tracking of presence changes via user actions, etc. Only updates from the module will be persisted and sent down sync properly).
| * Convert simple_select_list and simple_select_list_txn to return lists of ↵Patrick Cloke2023-10-2621-269/+346
| | | | | | | | | | tuples (#16505) This should use fewer allocations and improves type hints.
| * Allow multiple workers to write to receipts stream. (#16432)Erik Johnston2023-10-2512-85/+347
| | | | | | Fixes #16417
| * Fix http/s proxy authentication with long username/passwords (#16504)Richard Brežák2023-10-241-1/+1
| |
| * Remove duplicate call to wake a remote destination when using federation ↵Jason Little2023-10-242-13/+0
| | | | | | | | sending worker (#16515)
| * Fix type hint errors from Twisted trunk (#16526)Patrick Cloke2023-10-231-5/+11
| |
| * Fix bug where a new writer advances their token too quickly (#16473)Erik Johnston2023-10-236-62/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix bug where a new writer advances their token too quickly When starting a new writer (for e.g. persisting events), the `MultiWriterIdGenerator` doesn't have a minimum token for it as there are no rows matching that new writer in the DB. This results in the the first stream ID it acquired being announced as persisted *before* it actually finishes persisting, if another writer gets and persists a subsequent stream ID. This is due to the logic of setting the minimum persisted position to the minimum known position of across all writers, and the new writer starts off not being considered. * Fix sending out POSITIONs when our token advances without update Broke in #14820 * For replication HTTP requests, only wait for minimal position
| * Fix bug that could cause a `/sync` to tightloop with sqlite after restart ↵Erik Johnston2023-10-231-1/+4
| | | | | | | | | | (#16540) This could happen if the last rows in the account data stream were inserted into `account_data`. After a restart the max account ID would be calculated without looking at the `account_data` table, and so have an old ID.
| * Force TLS certificate verification in registration script. (#16530)Denis Kasak2023-10-231-2/+2
| | | | | | | | | | | | | | | | | | | | If using the script remotely, there's no particularly convincing reason to disable certificate verification, as this makes the connection interceptible. If on the other hand, the script is used locally (the most common use case), you can simply target the HTTP listener and avoid TLS altogether. This is what the script already attempts to do if passed a homeserver configuration YAML file.
| * Remove the last reference to event_txn_id. (#16521)Patrick Cloke2023-10-232-7/+4
| | | | | | | | This table was no longer used, except for a background process which purged old entries in it.
| * Mark sync as limited if there is a gap in the timeline (#16485)Erik Johnston2023-10-194-33/+165
| | | | | | | | | | | | | | | | This splits thinsg into two queries, but most of the time we won't have new event backwards extremities so this shouldn't actually add an extra RTT for the majority of cases. Note this removes the check for events with no prev events, but that was part of MSC2716 work that has since been removed.
| * Avoid sending massive replication updates when purging a room. (#16510)Patrick Cloke2023-10-182-1/+52
| |
| * Improve performance of delete device messages query (#16492)Mathieu Velten2023-10-182-7/+10
| |
* | Merge branch 'release-v1.95' into matrix-org-hotfixesPatrick Cloke2023-10-1786-1338/+1704
|\|
| * Convert DeviceLastConnectionInfo to attrs. (#16507)Patrick Cloke2023-10-172-36/+33
| | | | | | To improve type safety & memory usage.
| * Fix a bug where servers could be marked as up when they were failing (#16506)Patrick Cloke2023-10-171-13/+17
| | | | | | | | After this change a server will only be reported as back online if they were previously having requests fail.
| * Convert state delta processing from a dict to attrs. (#16469)Patrick Cloke2023-10-166-108/+109
| | | | | | For improved type checking & memory usage.
| * Remove useless async job to delete device messages on sync (#16491)Mathieu Velten2023-10-162-24/+3
| |
| * Clean up logging on event persister endpoints (#16488)Richard van der Hoff2023-10-142-6/+13
| |
| * Revert "Drop unused tables & unneeded access token ID for events. (#16268)" ↵Patrick Cloke2023-10-123-28/+8
| | | | | | | | | | | | | | | | (#16465) This reverts commit cabd57746004fe2dacc11aa8d373854a3d25e306. There are additional usages of these tables which need to be removed first.
| * Convert user_get_threepids response to attrs. (#16468)Patrick Cloke2023-10-117-14/+26
| | | | | | This improves type annotations by not having a dictionary of Any values.
| * Convert simple_select_many_batch, simple_select_many_txn to tuples. (#16444)Patrick Cloke2023-10-1121-416/+601
| |
| * Handle content types with parameters. (#16440)Patrick Cloke2023-10-111-1/+3
| |
| * Inline simple_search_list/simple_search_list_txn. (#16434)Patrick Cloke2023-10-103-73/+48
| | | | | | | | This only has a single use and is over abstracted. Inline it so that we can improve type hints.
| * Add DB indices to speed up purging rooms (#16457)David Robertson2023-10-103-0/+34
| |
| * Disable statement timeout whilst purging rooms (#16455)reivilibre2023-10-091-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | * Disable statement timeout whilst purging rooms * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Note the introduction version --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Bump ruff from 0.0.290 to 0.0.292 (#16449)dependabot[bot]2023-10-095-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump ruff from 0.0.290 to 0.0.292 Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.290 to 0.0.292. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](https://github.com/astral-sh/ruff/compare/v0.0.290...v0.0.292) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix up lint --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
| * Fix possible AttributeError when account-api is called over unix socket (#16404)Christoph2023-10-091-1/+1
| | | | | | Fixes #16396
| * Apply join rate limiter outside the lineariser (#16441)David Robertson2023-10-061-20/+23
| |
| * Convert simple_select_list_paginate_txn to return tuples. (#16433)Patrick Cloke2023-10-066-39/+66
| |
| * Return ThumbnailInfo in more places (#16438)Patrick Cloke2023-10-064-62/+71
| | | | | | | | Improves type hints by using concrete types instead of dictionaries.
| * Drop unused tables & unneeded access token ID for events. (#16268)Patrick Cloke2023-10-063-8/+28
| | | | | | | | Drop the event_txn_id table and the tables related to MSC2716, which is no longer supported in Synapse.
| * Stop sending incorrect knock_state_events. (#16403)Patrick Cloke2023-10-064-22/+6
| | | | | | | | | | | | | | | | | | Synapse was incorrectly implemented with a knock_state_events property on some APIs (instead of knock_room_state). This was correct in Synapse 1.70.0, but *both* fields were sent to also be compatible with Synapse versions expecting the wrong field. Enough time has passed that only the correct field needs to be included/handled.
| * Fix comments related to replication. (#16428)Patrick Cloke2023-10-062-3/+1
| |
| * Register media servlets via regex. (#16419)Patrick Cloke2023-10-069-118/+103
| | | | | | | | | | This converts the media servlet URLs in the same way as (most) of the rest of Synapse. This will give more flexibility in the versions each endpoint exists under.
| * Remove unused method. (#16435)Patrick Cloke2023-10-051-20/+0
| |
| * Remove manys calls to cursor_to_dict (#16431)Patrick Cloke2023-10-0514-227/+318
| | | | | | | | | | | | | | | | | | | | This avoids calling cursor_to_dict and then immediately unpacking the values in the dict for other users. By not creating the intermediate dictionary we can avoid allocating the dictionary and strings for the keys, which should generally be more performant. Additionally this improves type hints by avoid Dict[str, Any] dictionaries coming out of the database layer.
| * Add __slots__ to replication commands. (#16429)Patrick Cloke2023-10-051-1/+26
| | | | | | To slightly reduce the amount of memory each command takes.
| * Factor out `MultiWriter` token from `RoomStreamToken` (#16427)Erik Johnston2023-10-057-57/+110
| |
| * Some refactors around receipts stream (#16426)Erik Johnston2023-10-0413-69/+87
| |
* | Revert "TEMPORARY Measure and log test cases"Olivier Wilkinson (reivilibre)2023-10-171-17/+6
| | | | | | | | This reverts commit adfdd6afe120d13ec6cd9d8a1d72b6fba5d8c9f8.
* | TEMPORARY Measure and log test casesOlivier Wilkinson (reivilibre)2023-10-171-6/+17
| |
* | Revert "TEMPORARY Subdivide _resolve_events Measure blocks"Olivier Wilkinson (reivilibre)2023-10-161-92/+79
| | | | | | | | This reverts commit f3db863420ff2093359d828839952950c0d15584.
* | Revert "TEMPORARY Add more Measure blocks"Olivier Wilkinson (reivilibre)2023-10-161-70/+64
| | | | | | | | This reverts commit adfa0fded3f3f8330788417107decc53cac3c49c.
* | TEMPORARY Add more Measure blocksOlivier Wilkinson (reivilibre)2023-10-161-64/+70
| |
* | TEMPORARY Subdivide _resolve_events Measure blocksOlivier Wilkinson (reivilibre)2023-10-161-79/+92
| |
* | TEMPORARY Disable prune_old_outbound_device_pokesOlivier Wilkinson (reivilibre)2023-10-161-1/+3
| | | | | | | | See #16480
* | Merge remote-tracking branch 'origin/release-v1.94' into matrix-org-hotfixesDavid Robertson2023-10-036-21/+72
|\|
| * mypy plugin to check `@cached` return types (#14911)David Robertson2023-10-026-21/+72
| | | | | | | | | | | | | | | | Co-authored-by: David Robertson <davidr@element.io> Co-authored-by: Patrick Cloke <patrickc@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org> Assert that the return type of callables wrapped in @cached and @cachedList are cachable (aka immutable).
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesPatrick Cloke2023-10-0253-264/+458
|\|
| * Remove Python version from `/_synapse/admin/v1/server_version` (#16380)MomentQYC2023-10-021-5/+1
| | | | | | | | There's no reason to expose the full Python version over what is frequently a public API.
| * Downgrade repl stream time out error to warning (#16401)Erik Johnston2023-09-291-1/+1
| | | | | | | | | | | | This is because if a worker reaches ~100% CPU then everything starts lagging and we hit the log line a lot. When at error we invoke sentry and that has a lot of overhead, which then puts even more pressure on the worker.
| * Support rendering some media downloads as inline (#15988)Will Hunt2023-09-291-2/+40
| | | | | | | | | | Use an `inline` Content-Disposition header when the media is "safe" to display inline (some known text, image, video, audio formats).
| * Improve state types. (#16395)Patrick Cloke2023-09-281-3/+2
| |
| * Add a cache around server ACL checking (#16360)Patrick Cloke2023-09-266-72/+87
| | | | | | | | | | * Pre-compiles the server ACLs onto an object per room and invalidates them when new events come in. * Converts the server ACL checking into Rust.
| * Implement MSC4028: push all encrypted events. (#16361)Patrick Cloke2023-09-262-0/+5
| | | | | | | | This unstable push rule is implemented behind an experimental configuration flag.
| * Reduce calls to `send_presence_to_destinations` (#16385)Erik Johnston2023-09-261-15/+18
| |
| * Improve comments in StateGroupBackgroundUpdateStore. (#16383)Patrick Cloke2023-09-251-2/+16
| |
| * Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 (#16381)dependabot[bot]2023-09-252-29/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 Bumps [types-psycopg2](https://github.com/python/typeshed) from 2.9.21.11 to 2.9.21.14. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-psycopg2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Relax the annotation of Cursor.description See https://github.com/matrix-org/synapse/pull/16343#issuecomment-1726083384 for rationale. * Changelog * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
| * Add support for pydantic v2 via pydantic.v1 compat module (#16332)Maxwell G2023-09-2512-15/+105
| | | | | | While maintaining support with pydantic v1.
| * Add missing license header. (#16359)Patrick Cloke2023-09-211-0/+13
| |
| * Convert more cached return values to immutable types (#16356)Patrick Cloke2023-09-209-20/+32
| |
| * Return immutable objects for cachedList decorators (#16350)Patrick Cloke2023-09-1923-100/+133
| |
* | Revert "Temporarily disable webp thumbnailing"Patrick Cloke2023-09-251-1/+1
| | | | | | | | This reverts commit 93248076c2a0eecc631a7ce7503f3d5e773e224c.
* | Merge remote-tracking branch 'origin/release-v1.93' into matrix-org-hotfixesPatrick Cloke2023-09-1933-541/+500
|\|
| * Bump ruff from 0.0.286 to 0.0.290 (#16342)dependabot[bot]2023-09-182-13/+2
| | | | | | | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick Cloke <patrickc@matrix.org>
| * Filter locked users in the admin API (#16328)Hanadi2023-09-183-2/+12
| | | | | | | | Co-authored-by: Hanadi Tamimi <hanadi.tamimi@sdui.de>
| * Make cached account data/tags/admin types immutable (#16325)Patrick Cloke2023-09-188-50/+54
| |
| * Return an immutable value from get_latest_event_ids_in_room. (#16326)Patrick Cloke2023-09-185-15/+14
| |
| * Additional validation of receipts (#16327)Patrick Cloke2023-09-183-4/+26
| | | | | | | | Reject invalid receipts with a reasonable error message & expands tests for receipts.
| * Set email charset as utf-8 rather than utf8 (#16329)José Joaquín Atria2023-09-181-2/+2
| |
| * Add automatic purge after all users forget a room (#15488)Mathieu Velten2023-09-158-427/+368
| | | | | | | | | | | | Also add restore of purge/shutdown rooms after a synapse restart. Co-authored-by: Eric Eastwood <erice@matrix.org> Co-authored-by: Erik Johnston <erikj@matrix.org>
| * Convert `_insert_graph_receipts_txn` to `simple_upsert` (#16299)Jason Little2023-09-152-14/+12
| |
| * Only use literal strings for process names (#16315)Erik Johnston2023-09-153-14/+10
| |
* | Temporarily disable webp thumbnailingErik Johnston2023-09-151-1/+1
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-09-1432-214/+284
|\|
| * Some minor performance fixes for task schedular (#16313)Erik Johnston2023-09-144-34/+94
| |
| * Speed up deleting to-device messages task (#16318)Erik Johnston2023-09-141-13/+14
| |
| * Refactor `get_user_by_id` (#16316)Erik Johnston2023-09-1411-96/+74
| |
| * Remove a reference cycle in background process (#16314)Erik Johnston2023-09-131-1/+20
| |
| * Fix using dehydrated devices (MSC2697) & refresh tokens (#16288)Hanadi2023-09-132-3/+24
| | | | | | | | | | Refresh tokens were not correctly moved to the rehydrated device (similar to how the access token is currently handled). This resulted in invalid refresh tokens after rehydration.
| * Use StrCollection in additional places. (#16301)Patrick Cloke2023-09-1315-67/+58
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-09-131-11/+26
|\|
| * Don't schedule an async task on every sync (#16312)Erik Johnston2023-09-131-11/+26
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-09-131-31/+31
|\|
| * Fix deleting device inbox when using background worker (#16311)Erik Johnston2023-09-131-31/+31
| | | | | | | | | | Introduced in #16240 The action for the task was only defined on the "master" handler, rather than the base worker one.
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-09-1350-507/+860
|\|
| * Improve logging of replication (#16309)Erik Johnston2023-09-132-2/+7
| |
| * Bump mypy from 1.4.1 to 1.5.1. (#16300)Patrick Cloke2023-09-121-8/+2
| |
| * Stop purging tables which are slated for removal. (#16273)Patrick Cloke2023-09-122-5/+5
| |
| * Refactor storing of server keys (#16261)Erik Johnston2023-09-122-175/+79
| |
| * Add the List-Unsubscribe header for notification emails. (#16274)Patrick Cloke2023-09-113-6/+54
| | | | | | | | | | | | | | | | Adds both the List-Unsubscribe (RFC2369) and List-Unsubscribe-Post (RFC8058) headers to push notification emails, which together should: * Show an "Unsubscribe" link in the MUA UI when viewing Synapse notification emails. * Enable "one-click" unsubscribe (the user never leaves their MUA, which automatically makes a POST request to the specified endpoint).
| * Filter out down hosts when retrying fetching device lists (#16298)Erik Johnston2023-09-111-1/+14
| |
| * Improve type hints for attrs classes (#16276)David Robertson2023-09-086-39/+36
| |
| * Update ruff config (#16283)Patrick Cloke2023-09-084-8/+1
| | | | | | Enable additional checks & clean-up unneeded configuration.
| * Log values at DEBUG level with execute_values (#16281)David Robertson2023-09-081-2/+3
| |
| * Fix bug with new task scheduler using lots of CPU. (#16278)Erik Johnston2023-09-081-21/+22
| | | | | | | | | | Using the new `TaskScheduler` meant that we'ed create lots of new metrics (due to adding task ID to the desc of background process), resulting in requests for metrics taking an increasing amount of CPU.
| * Avoid temporary storage of sensitive information. (#16272)Patrick Cloke2023-09-081-2/+2
| | | | | | | | During the UI auth process, avoid storing sensitive information into the database.
| * Reduce CPU overhead of change password endpoint (#16264)Erik Johnston2023-09-081-58/+54
| |
| * Recheck if remote device is cached before requesting it (#16252)Erik Johnston2023-09-073-17/+34
| | | | | | | | This fixes a bug where we could get stuck re-requesting the device over replication again and again.
| * Add `/notifications` endpoint to workers (#16265)Erik Johnston2023-09-073-37/+39
| |
| * Send the opentracing span information to appservices (#16227)Marcel2023-09-061-8/+24
| |
| * Handle "registration_enabled" parameter for CAS (#16262)Aurélien Grimpard2023-09-062-0/+5
| | | | | | | | Similar to OIDC, CAS providers can now disable registration such that only existing users are able to login via SSO.
| * Merge remote-tracking branch 'origin/release-v1.92' into developPatrick Cloke2023-09-068-202/+10
| |\
| * | Add the ability to use `G` (GiB) and `T` (TiB) suffixes in configuration ↵reivilibre2023-09-061-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | options that refer to numbers of bytes. (#16219) * Add more suffixes to `parse_size` * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * | Allow modules to delete rooms. (#15997)reivilibre2023-09-064-6/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow user_id to be optional for room deletion * Add module API method to delete a room * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Don't worry about the case block=True && requester_user_id is None --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * | Delete device messages asynchronously and in staged batches (#16240)Mathieu Velten2023-09-0611-37/+106
| | |
| * | Fix appservices being unable to handle to_device messages for multiple users ↵Will Hunt2023-09-051-1/+1
| | | | | | | | | | | | (#16251)
| * | Add MSC4040 `matrix-fed` service lookups (#16137)Travis Ralston2023-09-051-5/+24
| | |
| * | Fix bug where we kept re-requesting a remote server's key repeatedly. (#16257)Erik Johnston2023-09-051-6/+11
| | | | | | | | | | | | | | | * Correctly handle multiple rows per server/key * Newsfile
| * | Time out busy presence status & test multi-device busy (#16174)Patrick Cloke2023-09-051-1/+18
| | | | | | | | | | | | | | | | | | | | | Add a (long) timeout to when a "busy" device is considered not online. This does *not* match MSC3026, but is a reasonable thing for an implementation to do. Expands tests for the (unstable) busy presence with multiple devices.
| * | Track presence state per-device and combine to a user state. (#16066)Patrick Cloke2023-09-052-51/+271
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tracks presence on an individual per-device basis and combine the per-device state into a per-user state. This should help in situations where a user has multiple devices with conflicting status (e.g. one is syncing with unavailable and one is syncing with online). The tie-breaking is done by priority: BUSY > ONLINE > UNAVAILABLE > OFFLINE
| * | Bump twisted from 22.10.0 to 23.8.0 (#16235)dependabot[bot]2023-09-053-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump twisted from 22.10.0 to 23.8.0 Bumps [twisted](https://github.com/twisted/twisted) from 22.10.0 to 23.8.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](https://github.com/twisted/twisted/compare/twisted-22.10.0...twisted-23.8.0) --- updated-dependencies: - dependency-name: twisted dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fix types * Fix lint * Newsfile --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
* | | Merge branch 'release-v1.92' into matrix-org-hotfixesPatrick Cloke2023-09-068-202/+10
|\ \ \ | | |/ | |/|
| * | Merge remote-tracking branch 'origin/release-v1.91' into release-v1.92Patrick Cloke2023-09-067-199/+6
| |\ \
| | * | Revert MSC3861 introspection cache, admin impersonation and account lock ↵Quentin Gliech2023-09-067-199/+6
| | | | | | | | | | | | | | | | (#16258)
| * | | Fix incorrect docstring for Ratelimiter. (#16255)Patrick Cloke2023-09-051-3/+4
| | |/ | |/|
* | | Merge remote-tracking branch 'origin/release-v1.92' into matrix-org-hotfixesDavid Robertson2023-09-0577-607/+929
|\| |
| * | Don't wake up destination transaction queue if they're not due for retry. ↵Erik Johnston2023-09-0411-67/+161
| | | | | | | | | | | | (#16223)
| * | Add last_seen_ts to the admin users API (#16218)Mathieu Velten2023-09-046-2/+16
| | |
| * | Don't reset retry timers on "valid" error codes (#16221)Erik Johnston2023-09-043-3/+27
| | |
| * | Cache device resync requests over replication (#16241)David Robertson2023-09-041-1/+1
| | |
| * | Fix typo where we ended up with multiple `WorkerLocksHandler` (#16220)Erik Johnston2023-09-011-0/+1
| | | | | | | | | | | | | | | I don't think has caused any actual issues. Introduced in #15891
| * | Log the details of background update failures (#16212)David Robertson2023-09-011-2/+2
| | |
| * | Gracefully handle failing to thumbnail images (#16211)Erik Johnston2023-08-302-1/+9
| | |
| * | Fix rare bug that broke looping calls (#16210)Erik Johnston2023-08-301-14/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix rare bug that broke looping calls We can't interact with the reactor from the main thread via looping call. Introduced in v1.90.0 / #15791. * Newsfile
| * | Stop writing to the event_txn_id table (#16175)Patrick Cloke2023-08-304-84/+21
| | |
| * | Describe which rate limiter was hit in logs (#16135)David Robertson2023-08-3014-92/+150
| | |
| * | Track currently syncing users by device for presence (#16172)Patrick Cloke2023-08-293-63/+128
| | | | | | | | | | | | | | | | | | | | | Refactoring to use both the user ID & the device ID when tracking the currently syncing users in the presence handler. This is done both locally and over replication. Note that the device ID is discarded but will be used in a future change.
| * | Bump mypy-zope & mypy. (#16188)Patrick Cloke2023-08-294-14/+32
| | |
| * | Bump ruff from 0.0.277 to 0.0.286 (#16198)dependabot[bot]2023-08-2917-33/+47
| | | | | | | | | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
| * | Support IPv6-only SMTP servers (#16155)Evilham2023-08-291-17/+11
| | | | | | | | | | | | Use Twisted HostnameEndpoint to connect to SMTP servers (instead of connectTCP/connectSSL) which properly supports IPv6-only servers.
| * | Fix inaccurate error message while trying to ban or unban a user with the ↵Chen Zhang2023-08-291-1/+7
| | | | | | | | | | | | same or higher PL (#16205)
| * | Pass the device ID around in the presence handler (#16171)Patrick Cloke2023-08-289-19/+63
| | | | | | | | | | | | | | | | | | Refactoring to pass the device ID (in addition to the user ID) through the presence handler (specifically the `user_syncing`, `set_state`, and `bump_presence_active_time` methods and their replication versions).
| * | Combine logic about not overriding BUSY presence. (#16170)Patrick Cloke2023-08-282-97/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify some of the presence code by reducing duplicated code between worker & non-worker modes. The main change is to push some of the logic from `user_syncing` into `set_state`. This is done by passing whether the user is setting the presence via a `/sync` with a new `is_sync` flag to `set_state`. If this is `true` some additional logic is performed: * Don't override `busy` presence. * Update the `last_user_sync_ts`. * Never update the status message.
| * | Task scheduler: add replication notify for new task to launch ASAP (#16184)Mathieu Velten2023-08-283-49/+73
| | |
| * | Prepare unit tests for Python 3.12 (#16099)V024602023-08-251-0/+1
| | |
| * | Validate input to POST /key/v2/query endpoint. (#16183)Patrick Cloke2023-08-251-10/+29
| | | | | | | | | To avoid 500 internal server errors with garbage input.
| * | Send proper JSON POST data to /publicRooms (#16185)Patrick Cloke2023-08-251-10/+6
| | | | | | | | | | | | The include_all_networks was previously sent in the JSON body as string "true" and "false" instead of boolean true and false.
| * | Add configuration setting for CAS protocol version (#15816)Aurélien Grimpard2023-08-242-2/+17
| | |
| * | Fix typechecking with twisted trunk (#16121)David Robertson2023-08-243-26/+27
| | |
| * | Add `Retry-After` to M_LIMIT_EXCEEDED error responses (#16136)Will Hunt2023-08-242-1/+18
| | | | | | | | | Implements MSC4041 behind an experimental configuration flag.
| * | Stabilize support for MSC3958 (suppress notifications from edits). (#16113)Patrick Cloke2023-08-232-6/+0
| | |
* | | Merge remote-tracking branch 'origin/release-v1.91' into matrix-org-hotfixesDavid Robertson2023-09-041-0/+1
|\ \ \ | | |/ | |/|
| * | Fix typo where we ended up with multiple `WorkerLocksHandler` (#16220)Erik Johnston2023-09-011-0/+1
| |/ | | | | | | | | I don't think has caused any actual issues. Introduced in #15891
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-08-232-37/+71
|\|
| * Fix rare deadlock when using read/write locks (#16169) github/release-v1.91.0 release-v1.91.0Erik Johnston2023-08-232-37/+71
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-08-231-0/+5
|\|
| * Filter out unwanted user_agents from udv. (#16124)Neil Johnson2023-08-231-0/+5
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-08-235-5/+81
|\|
| * Fix rare deadlock when using read/write locks (#16133)Erik Johnston2023-08-231-0/+37
| |
| * Reduce DB contention on worker locks (#16160)Erik Johnston2023-08-231-0/+37
| |
| * Always update `retry_last_ts` (#16164)Erik Johnston2023-08-231-3/+3
| |
| * Task scheduler: mark task as active if we are scheduling ASAP (#16165)Mathieu Velten2023-08-232-2/+4
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-08-2324-190/+1233
|\|
| * Properly update retry_last_ts when hitting the maximum retry interval (#16156)DeepBlueV7.X2023-08-231-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Properly update retry_last_ts when hitting the maximum retry interval This was broken in 1.87 when the maximum retry interval got changed from almost infinite to a week (and made configurable). fixes #16101 Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> * Add changelog * Change fix + add test * Add comment --------- Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
| * Only lock when we're backfilling (#16159)Erik Johnston2023-08-232-146/+156
| |
| * Increase perf of read/write locks (#16149)Erik Johnston2023-08-231-0/+30
| | | | | | We do this by marking the tables as `UNLOGGED` in PostgreSQL.
| * Fix perf of `wait_for_stream_positions` (#16148)Erik Johnston2023-08-221-7/+12
| |
| * Disable `m.3pid_changes` capability when MSC3861 is enabled. (#16134)Mathieu Velten2023-08-222-1/+16
| |
| * Add an admin endpoint to allow authorizing server to signal token ↵Shay2023-08-227-0/+127
| | | | | | | | revocations (#16125)
| * Disallow user_consent where experimental MSC3861 is enabled (#16127)Hugh Nimmo-Smith2023-08-221-0/+7
| |
| * Add `client_secret_path` as alternative for `client_secret` for OIDC config ↵Maximilian Bosch2023-08-211-1/+15
| | | | | | | | (#16030)
| * Implements a task scheduler for resumable potentially long running tasks ↵Mathieu Velten2023-08-218-1/+644
| | | | | | | | (#15891)
| * Speed up state res in rare case we don't have all events (#16116)Erik Johnston2023-08-181-23/+161
| | | | | | | | | | | | | | If we don't have all the auth events in a room then not all state events will have a chain cover index. Even so, we can still use the chain cover index on the events that do have it, rather than bailing and using the slower functions. This situation should not arise for newly persisted rooms, as we check we have the full auth chain for each event, but can happen for existing rooms. c.f. #15245
| * MSC3861: allow impersonation by an admin using a query param (#16132)Mathieu Velten2023-08-181-3/+22
| |
| * Allow filtering for admins in the list accounts admin API (#16114)Alexander Fechler2023-08-182-0/+13
| |
| * Add response time metrics for introspection requests (#16131)Erik Johnston2023-08-181-7/+27
| | | | | | See #16119
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-08-1856-429/+746
|\|
| * Add cache to `get_server_keys_json_for_remote` (#16123)Erik Johnston2023-08-183-63/+120
| |
| * Cache token introspection response from OIDC provider (#16117)Shay2023-08-171-2/+38
| |
| * Fix database performance of read/write worker locks (#16061)Erik Johnston2023-08-171-52/+35
| | | | | | | | | | | | | | We were seeing serialization errors when taking out multiple read locks. The transactions were retried, so isn't causing any failures. Introduced in #15782.
| * Override global statement timeout when creating indexes in Postgres (#16085)Shay2023-08-171-0/+12
| |
| * Disable caching in /sync corner case (#16080)Matthew Ma2023-08-171-10/+10
| | | | | | Fixes #15502
| * Rename pagination&purge locks and add comments explaining them (#16112)Mathieu Velten2023-08-167-19/+28
| |
| * Attempt to fix twisted trunk (#16115)David Robertson2023-08-151-1/+3
| |
| * Run pyupgrade for python 3.7 & 3.8. (#16110)Patrick Cloke2023-08-1521-71/+62
| |
| * Allow customizing IdP name and icon for SAML and CAS (#16094)Gabriel Rodríguez2023-08-114-10/+22
| |
| * Add linearizer on user ID to push rule PUT/DELETE requests (#16052)Nick Mills-Barrett2023-08-111-6/+22
| | | | | | | | | | See: #16053 Signed off by Nick @ Beeper (@Fizzadar)
| * Fix the type annotation on `run_db_interaction` in the Module API. (#16089)reivilibre2023-08-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | * Fix the method signature of `run_db_interaction` on the module API * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Clean-up presence code (#16092)Patrick Cloke2023-08-101-94/+75
| | | | | | | | | | | | | | | | Misc. clean-ups to: * Use keyword arguments. * Return early (reducing indentation) of some functions. * Removing duplicated / unused code. * Use wrap_as_background_process.
| * Implements admin API to lock an user (MSC3939) (#15870)Mathieu Velten2023-08-1013-10/+144
| |
| * Support MSC3814: Dehydrated Devices Part 2 (#16010)Shay2023-08-085-90/+174
| |
* | Merge remote-tracking branch 'origin/release-v1.90' into matrix-org-hotfixesErik Johnston2023-08-0937-361/+1096
|\|
| * Allow modules to schedule delayed background calls. (#15993)reivilibre2023-08-081-0/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add a module API function to provide `call_later` * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Add comments * Update version number --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Remove old rows from the `cache_invalidation_stream_by_instance` table ↵reivilibre2023-08-081-0/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | automatically. (This table is not used when Synapse is configured to use SQLite.) (#15868) * Add a cache invalidation clean-up task * Run the cache invalidation stream clean-up on the background worker * Tune down * call_later is in millis! * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * fixup! Add a cache invalidation clean-up task * Update synapse/storage/databases/main/cache.py Co-authored-by: Eric Eastwood <erice@element.io> * Update synapse/storage/databases/main/cache.py Co-authored-by: Eric Eastwood <erice@element.io> * MILLISEC -> MS * Expand on comment * Move and tweak comment about Postgres * Use `wrap_as_background_process` --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Co-authored-by: Eric Eastwood <erice@element.io>
| * Fix endpoint improperly declaring support for MSC3814 (#16068)Shay2023-08-071-10/+8
| |
| * Drop backwards compat hack for event serialization (#16069)Shay2023-08-071-11/+1
| |
| * Fix deletion for Dehydrated Devices (#16046)Shay2023-08-042-4/+26
| |
| * Stabilize support for MSC3970: updated transaction semantics (scope to ↵Patrick Cloke2023-08-048-59/+47
| | | | | | | | | | | | | | `device_id`) (#15629) For now this maintains compatible with old Synapses by falling back to using transaction semantics on a per-access token. A future version of Synapse will drop support for this.
| * Move support for application service query parameter authorization behind a ↵Shay2023-08-032-9/+33
| | | | | | | | configuration option (#16017)
| * Allow config of the backoff algorithm for the federation client. (#15754)Mathieu Velten2023-08-032-13/+34
| | | | | | | | | | | | | | | | | | | | | | Adds three new configuration variables: * destination_min_retry_interval is identical to before (10mn). * destination_retry_multiplier is now 2 instead of 5, the maximum value will be reached slower. * destination_max_retry_interval is one day instead of (essentially) infinity. Capping this will cause destinations to continue to be retried sometimes instead of being lost forever. The previous value was 2 ^ 62 milliseconds.
| * Allow modules to check whether the current worker is configured to run ↵reivilibre2023-08-031-0/+12
| | | | | | | | background tasks. (#15991)
| * Add forward-compatibility for the redacts property (MSC2174). (#16013)Patrick Cloke2023-08-021-8/+10
| | | | | | | | | | | | | | | | The location of the redacts field changes in room version 11. Ensure it is copied to the *new* location for *old* room versions for forwards-compatibility with clients. Note that copying it to the *old* location for the *new* room version was previously handled.
| * Properly setup the additional sequences in the portdb script. (#16043)Patrick Cloke2023-08-011-3/+15
| | | | | | | | | | The un_partial_stated_event_stream_sequence and application_services_txn_id_seq were never properly configured in the portdb script, resulting in an error on start-up.
| * Trim whitespace when setting display names (#16031)Mohit Rathee2023-08-011-1/+1
| |
| * Add metrics tracking for eviction to ResponseCache (#16028)Jason Little2023-08-011-2/+8
| | | | | | | | Track whether the ResponseCache is evicting due to invalidation or due to time.
| * Combine duplicated code for calculating an event ID from a txn ID (#16023)Patrick Cloke2023-07-312-32/+35
| | | | | | | | Refactoring related to stabilization of MSC3970, refactor to combine code which has the same logic.
| * Add ability to wait for locks and add locks to purge history / room deletion ↵Erik Johnston2023-07-3112-106/+654
| | | | | | | | | | (#15791) c.f. #13476
| * Clarify comment on key uploads over replication (#16016)Shay2023-07-271-2/+2
| |
| * Fix 404 on /profile when the display name is empty but not the avatar (#16012)Mathieu Velten2023-07-271-1/+1
| |
| * Remove support for legacy application service paths (#15964)Shay2023-07-261-71/+11
| |
| * Inline SQL queries using boolean parameters (#15525)Anshul Madnawat2023-07-267-25/+23
| | | | | | | | SQLite now supports TRUE and FALSE constants, simplify some queries by inlining those instead of passing them as arguments.
* | Merge branch 'release-v1.89' into matrix-org-hotfixesMathieu Velten2023-07-266-16/+21
|\|
| * Bump DB version to 79 since synapse v1.88 was already there (#15998)Mathieu Velten2023-07-266-16/+21
| |
* | Merge branch 'release-v1.89' into matrix-org-hotfixesMathieu Velten2023-07-258-24/+379
|\|
| * Support MSC3814: Dehydrated Devices (#15929)Shay2023-07-244-9/+356
| | | | | | | | | | | | Signed-off-by: Nicolas Werner <n.werner@famedly.com> Co-authored-by: Nicolas Werner <n.werner@famedly.com> Co-authored-by: Nicolas Werner <89468146+nico-famedly@users.noreply.github.com> Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
| * Resync stale devices in background (#15975)Erik Johnston2023-07-241-1/+8
| | | | | | | | This is so we don't block responding to federation transaction while we try and fetch the device lists.
| * Properly handle redactions of creation events (#15973)Shay2023-07-231-3/+5
| |
| * Actually stop reading from column `user_id` of tables `profiles` (#15955)Shay2023-07-233-11/+10
| |
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-07-204-131/+140
|\|
| * Speed up updating state in large rooms (#15971)Erik Johnston2023-07-204-131/+140
| | | | | | This should speed up updating state in rooms with lots of state.
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-07-201-4/+0
|\|
| * Don't log exceptions for every non-200 response (#15969)Erik Johnston2023-07-201-4/+0
| | | | | | Introduced in #15913
* | Merge remote-tracking branch 'origin/develop' into matrix-org-hotfixesErik Johnston2023-07-2049-525/+1199
|\|
| * Reduce the amount of state we pull out (#15968)Erik Johnston2023-07-203-12/+13
| |
| * Ensure a long state res does not starve CPU (#15960)Erik Johnston2023-07-191-1/+8
| | | | | | We do this by yielding the reactor in hot loops.
| * Fix bad merge of #15933 (#15958)Erik Johnston2023-07-192-0/+0
| | | | | | This was because we reverted the bump of the schema version, so we were not applying the new deltas.
| * Fix race in triggers for read/write locks. (#15933)Erik Johnston2023-07-194-98/+134
| |
generated by cgit-magenta 1.5.1 (git 2.48.1) at 2025-08-10 02:26:09 +0000