summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge commit 'dc22090a6' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-1916-346/+122
|\ | | | | | | | | | | | | | | * commit 'dc22090a6': Add type hints to synapse.handlers.room (#8090) Remove some unused database functions. (#8085) Convert misc database code to async (#8087) Remove a space at the start of a changelog entry.
| * Add type hints to synapse.handlers.room (#8090)Erik Johnston2020-08-141-38/+66
| |
| * Remove some unused database functions. (#8085)Patrick Cloke2020-08-146-244/+18
| |
| * Convert misc database code to async (#8087)Patrick Cloke2020-08-1410-64/+38
| |
| * Merge tag 'v1.19.0rc1' into developOlivier Wilkinson (reivilibre)2020-08-131-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067))
* | \ Merge commit '091ca3910' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-1/+1
|\ \ \ | | |/ | |/| | | | | | | * commit '091ca3910': 1.19.0rc1
| * | 1.19.0rc1Olivier Wilkinson (reivilibre)2020-08-131-1/+1
| | |
* | | Merge commit '53834bb9c' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-3/+1
|\ \ \ | | |/ | |/| | | | | | | * commit '53834bb9c': Run `remove_push_actions_from_staging` in foreground (#8081)
| * | Run `remove_push_actions_from_staging` in foreground (#8081)Richard van der Hoff2020-08-131-3/+1
| | | | | | | | | | | | | | | | | | | | | If we got an error persisting an event, we would try to remove the push actions asynchronously, which would lead to a 'Re-starting finished log context' warning. I don't think there's any need for this to be asynchronous.
* | | Merge commit 'ff0e89465' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-0/+22
|\| | | | | | | | | | | | | | * commit 'ff0e89465': Drop federation transmission queues during a significant remote outage. (#7864)
| * | Drop federation transmission queues during a significant remote outage. (#7864)reivilibre2020-08-131-0/+22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | * Empty federation transmission queues when we are backing off. Fixes #7828. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Address feedback Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Reword newsfile
* | Merge commit 'fbe930dad' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-193-241/+98
|\| | | | | | | | | * commit 'fbe930dad': Convert the roommember database to async/await. (#8070)
| * Convert the roommember database to async/await. (#8070)Patrick Cloke2020-08-123-241/+98
| |
* | Merge commit '5ecc8b582' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-153/+180
|\| | | | | | | | | * commit '5ecc8b582': Convert devices database to async/await. (#8069)
| * Convert devices database to async/await. (#8069)Patrick Cloke2020-08-121-153/+180
| |
* | Merge commit '5dd73d029' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-193-40/+52
|\| | | | | | | | | * commit '5dd73d029': Add type hints to handlers.message and events.builder (#8067)
| * Add type hints to handlers.message and events.builder (#8067)Erik Johnston2020-08-123-40/+52
| |
* | Merge commit 'd68e10f30' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-193-86/+96
|\| | | | | | | | | * commit 'd68e10f30': Convert account data, device inbox, and censor events databases to async/await (#8063)
| * Convert account data, device inbox, and censor events databases to ↵Patrick Cloke2020-08-123-86/+96
| | | | | | | | async/await (#8063)
* | Merge commit 'a3a59bab7' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-197-104/+78
|\| | | | | | | | | * commit 'a3a59bab7': Convert appservice, group server, profile and more databases to async (#8066)
| * Convert appservice, group server, profile and more databases to async (#8066)Patrick Cloke2020-08-127-104/+78
| |
* | Merge commit '9d1e4942a' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-1910-423/+304
|\| | | | | | | | | | | | | | | | | * commit '9d1e4942a': Fix typing for notifier (#8064) Add comment explaining cast Handle optional dependencies for Oidc and Saml Newsfile Change HomeServer definition to work with typing.
| * Fix typing for notifier (#8064)Erik Johnston2020-08-124-16/+35
| |
| * Merge pull request #8060 from matrix-org/erikj/type_serverErik Johnston2020-08-116-403/+267
| |\ | | | | | | Change HomeServer definition to work with typing.
| | * Merge remote-tracking branch 'origin/develop' into erikj/type_serverErik Johnston2020-08-1110-100/+354
| | |\
| | * | Add comment explaining castErik Johnston2020-08-111-0/+2
| | | |
| | * | Handle optional dependencies for Oidc and SamlErik Johnston2020-08-111-5/+9
| | | |
| | * | Change HomeServer definition to work with typing.Erik Johnston2020-08-116-399/+263
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Duplicating function signatures between server.py and server.pyi is silly. This commit changes that by changing all `build_*` methods to `get_*` methods and changing the `_make_dependency_method` to work work as a descriptor that caches the produced value. There are some changes in other files that were made to fix the typing in server.py.
* | | | Merge commit '04faa0bfa' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-192-64/+59
|\| | | | | | | | | | | | | | | | | | | * commit '04faa0bfa': Convert tags and metrics databases to async/await (#8062)
| * | | Convert tags and metrics databases to async/await (#8062)Patrick Cloke2020-08-112-64/+59
| | | |
* | | | Merge commit 'a0acdfa9e' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-195-214/+143
|\| | | | | | | | | | | | | | | | | | | * commit 'a0acdfa9e': Converts event_federation and registration databases to async/await (#8061)
| * | | Converts event_federation and registration databases to async/await (#8061)Patrick Cloke2020-08-113-164/+125
| | |/ | |/|
* | | Merge commit '61d8ff0d4' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-8/+16
|\| | | | | | | | | | | | | | | | | | | | * commit '61d8ff0d4': Update changelog.d/8051.misc Newsfile Move setting of Filter into code.
| * | Auto set logging filter (#8051)Erik Johnston2020-08-111-8/+16
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we *log* rather than *handle*. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on *every* logger used in the code base)
| | * | Move setting of Filter into code.Erik Johnston2020-08-111-8/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we *log* rather than *handle*. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on *every* logger used in the code base)
* | | | Merge commit 'a1e9bb9ea' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-193-52/+89
|\| | | | | | | | | | | | | | | | | | | * commit 'a1e9bb9ea': Add typing info to Notifier (#8058)
| * | | Add typing info to Notifier (#8058)Erik Johnston2020-08-113-52/+89
| |/ /
* | | Merge commit 'a0f574f3c' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-193-25/+73
|\| | | | | | | | | | | | | | * commit 'a0f574f3c': Reduce INFO logging (#8050)
| * | Reduce INFO logging (#8050)Erik Johnston2020-08-113-25/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | c.f. #8021 A lot of the code here is to change the `Completed 200 OK` logging to include the request URI so that we can drop the `Sending request...` log line. Some notes: 1. We won't log retries, which may be confusing considering the time taken log line includes retries and sleeps. 2. The `_send_request_with_optional_trailing_slash` will always be logged *without* the forward slash, even if it succeeded only with the forward slash.
* | | Merge commit 'db131b6b2' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-199-30/+421
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'db131b6b2': Change the default log config to reduce disk I/O and storage (#8040) Implement login blocking based on SAML attributes (#8052) Add an assertion on prev_events in create_new_client_event (#8041) Typo Lint why mypy why Lint Incorporate review Incorporate review Fix PUT /pushrules to use the right rule IDs Back out the database hack and replace it with a temporary config setting Fix cache name Fix cache invalidation calls Lint Changelog Implement new experimental push rules with a database hack to enable them
| * | Change the default log config to reduce disk I/O and storage (#8040)Erik Johnston2020-08-111-5/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Change default log config to buffer by default. This batches up writes to the filesystem, which is more efficient for disk I/O. This means that it can take some time for logs to get written to disk. Note that ERROR logs (and above) immediately flush the buffer. This only effects new installs, as we only write the log config if started with `--generate-config` (in the same way we do for generating signing keys). * Default to keeping last 4 days of logs. This hopefully reduces the amount of logs kept for new servers. Keeping the last 1GB of logs is likely overkill for new servers, but equally may not be enough for busy ones. Instead, we keep the last four days worth of logs, enough so that admins can investigate any problems that happened over e.g. a long weekend.
| * | Implement login blocking based on SAML attributes (#8052)Richard van der Hoff2020-08-114-11/+147
| |/ | | | | | | | | | | | | Hopefully this mostly speaks for itself. I also did a bit of cleaning up of the error handling. Fixes #8047
| * Add an assertion on prev_events in create_new_client_event (#8041)Richard van der Hoff2020-08-101-0/+9
| | | | | | | | | | | | I think this would have caught all the cases in https://github.com/matrix-org/synapse/issues/7642 - and I think a 500 makes more sense here than a 403
| * Implement new experimental push rules (#7997)Brendan Abolivier2020-08-104-14/+244
| |\ | | | | | | With an undocumented configuration setting to enable them for specific users.
| | * TypoBrendan Abolivier2020-08-101-1/+1
| | |
| | * LintBrendan Abolivier2020-08-101-2/+2
| | |
| | * why mypy whyBrendan Abolivier2020-08-101-1/+3
| | |
| | * LintBrendan Abolivier2020-08-061-1/+1
| | |
| | * Incorporate reviewBrendan Abolivier2020-08-061-2/+2
| | |
| | * Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-08-06350-1509/+1754
| | |\ | | | | | | | | | | | | babolivier/new_push_rules
| | * | Incorporate reviewBrendan Abolivier2020-08-064-21/+12
| | | |
| | * | Fix PUT /pushrules to use the right rule IDsBrendan Abolivier2020-08-031-2/+9
| | | |
| | * | Back out the database hack and replace it with a temporary config settingBrendan Abolivier2020-08-034-48/+20
| | | |
| | * | Fix cache nameBrendan Abolivier2020-07-311-1/+1
| | | |
| | * | Fix cache invalidation callsBrendan Abolivier2020-07-312-2/+2
| | | |
| | * | LintBrendan Abolivier2020-07-301-19/+32
| | | |
| | * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-07-3096-1714/+2102
| | |\ \ | | | | | | | | | | | | | | | babolivier/new_push_rules
| | * | | Implement new experimental push rules with a database hack to enable themBrendan Abolivier2020-07-283-14/+259
| | | | |
* | | | | Merge commit '7f837959e' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-199-252/+199
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '7f837959e': Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users database to async (#8042) Convert additional database stores to async/await (#8045)
| * | | | Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users ↵Patrick Cloke2020-08-075-102/+95
| | | | | | | | | | | | | | | | | | | | database to async (#8042)
| * | | | Convert additional database stores to async/await (#8045)Patrick Cloke2020-08-074-150/+104
| | | | |
* | | | | Merge commit 'de6f89206' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-0/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit 'de6f89206': Add a comment about SSLv23_METHOD (#8043)
| * | | | Add a comment about SSLv23_METHOD (#8043)Richard van der Hoff2020-08-071-0/+8
| | | | |
* | | | | Merge commit '2f9fd5ab0' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-191-1/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '2f9fd5ab0': Don't log OPTIONS request at INFO (#8049)
| * | | | Don't log OPTIONS request at INFO (#8049)Erik Johnston2020-08-071-1/+7
| | | | |
* | | | | Merge commit '4e874ed59' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-194-7/+4
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '4e874ed59': Remove unnecessary maybeDeferred calls (#8044)
| * | | | Remove unnecessary maybeDeferred calls (#8044)Patrick Cloke2020-08-074-7/+4
| | | | |
* | | | | Merge commit '7620912d8' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-194-3/+48
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '7620912d8': Add health check endpoint (#8048)
| * | | | Add health check endpoint (#8048)Erik Johnston2020-08-074-3/+48
| | | | |
* | | | | Merge commit '4dd27e6d1' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-1914-53/+55
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '4dd27e6d1': Reduce unnecessary whitespace in JSON. (#7372)
| * | | | Reduce unnecessary whitespace in JSON. (#7372)David Vo2020-08-0714-53/+55
| | | | |
* | | | | Merge commit '2ffd6783c' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-197-162/+15
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '2ffd6783c': Revert #7736 (#8039)
| * | | | Revert #7736 (#8039)Brendan Abolivier2020-08-067-162/+15
| | | | |
* | | | | Merge commit 'fe6cfc80e' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-192-28/+27
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit 'fe6cfc80e': Convert some util functions to async (#8035)
| * | | | Convert some util functions to async (#8035)Patrick Cloke2020-08-062-28/+27
| | | | |
* | | | | Merge commit 'd4a7829b1' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-1912-93/+80
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit 'd4a7829b1': Convert synapse.api to async/await (#8031)
| * | | | Convert synapse.api to async/await (#8031)Patrick Cloke2020-08-0612-92/+78
| | | | |
* | | | | Merge commit 'c36228c40' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-193-26/+15
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit 'c36228c40': Convert run_as_background_process inner function to async. (#8032)
| * | | | Convert run_as_background_process inner function to async. (#8032)Patrick Cloke2020-08-063-26/+15
| | | | |
* | | | | Merge commit '66f24449d' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-196-71/+186
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '66f24449d': Improve performance of the register endpoint (#8009)
| * | | | Improve performance of the register endpoint (#8009)Patrick Cloke2020-08-064-73/+144
| | |_|/ | |/| |
* | | | Merge commit 'a7bdf98d0' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-16319-1204/+1246
|\| | | | | | | | | | | | | | | | | | | * commit 'a7bdf98d0': Rename database classes to make some sense (#8033)
| * | | Rename database classes to make some sense (#8033)Erik Johnston2020-08-05314-1152/+1232
| | | |
* | | | Merge commit '0a86850ba' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-161-2/+8
|\| | | | | | | | | | | | | | | | | | | * commit '0a86850ba': Stop the parent process flushing the logs on exit (#8012)
| * | | Stop the parent process flushing the logs on exit (#8012)Richard van der Hoff2020-08-051-2/+8
| | | | | | | | | | | | This solves the problem that the first few lines are logged twice on matrix.org. Hopefully the comments explain it.
* | | | Merge commit '8ff2deda7' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-162-22/+20
|\| | | | | | | | | | | | | | | | | | | * commit '8ff2deda7': Fix async/await calls for broken media providers. (#8027)
| * | | Fix async/await calls for broken media providers. (#8027)Patrick Cloke2020-08-042-22/+20
| | | |
* | | | Merge commit '88a3ff12f' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-162-32/+25
|\| | | | | | | | | | | | | | | | | | | * commit '88a3ff12f': Convert the SimpleHttpClient to async. (#8016)
| * | | Convert the SimpleHttpClient to async. (#8016)Patrick Cloke2020-08-042-32/+25
| | | |
* | | | Merge commit 'e19de43eb' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-168-29/+25
|\| | | | | | | | | | | | | | | | | | | * commit 'e19de43eb': Convert streams to async. (#8014)
| * | | Convert streams to async. (#8014)Patrick Cloke2020-08-048-29/+25
| | | |
* | | | Merge commit '916cf2d43' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-163-14/+134
|\| | | | | | | | | | | | | | | | | | | * commit '916cf2d43': re-implement daemonize (#8011)
| * | | re-implement daemonize (#8011)Richard van der Hoff2020-08-043-14/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has long been something I've wanted to do. Basically the `Daemonize` code is both too flexible and not flexible enough, in that it offers a bunch of features that we don't use (changing UID, closing FDs in the child, logging to syslog) and doesn't offer a bunch that we could do with (redirecting stdout/err to a file instead of /dev/null; having the parent not exit until the child is running). As a first step, I've lifted the Daemonize code and removed the bits we don't use. This should be a non-functional change. Fixing everything else will come later.
* | | | Merge commit '481f76c7a' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-161-31/+3
|\| | | | | | | | | | | | | | | | | | | * commit '481f76c7a': Remove signature check on v1 identity server lookups (#8001)
| * | | Remove signature check on v1 identity server lookups (#8001)Andrew Morgan2020-08-031-31/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We've [decided](https://github.com/matrix-org/synapse/issues/5253#issuecomment-665976308) to remove the signature check for v1 lookups. The signature check has been removed in v2 lookups. v1 lookups are currently deprecated. As mentioned in the above linked issue, this verification was causing deployments for the vector.im and matrix.org IS deployments, and this change is the simplest solution, without being unjustified. Implementations are encouraged to use the v2 lookup API as it has [increased privacy benefits](https://github.com/matrix-org/matrix-doc/pull/2134).
* | | | Merge commit '5d92a1428' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-163-6/+62
|\| | | | | | | | | | | | | | | | | | | * commit '5d92a1428': Prevent join->join membership transitions changing member count (#7977)
| * | | Prevent join->join membership transitions changing member count (#7977)Andrew Morgan2020-08-033-6/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc. However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information. This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point. Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update). Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.
* | | | Merge commit '681250980' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-161-5/+11
|\| | | | | | | | | | | | | | | | | | | * commit '681250980': Implement handling of HTTP HEAD requests. (#7999)
| * | | Implement handling of HTTP HEAD requests. (#7999)Patrick Cloke2020-08-031-5/+11
| | | |
* | | | Merge commit '2a89ce8cd' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-161-109/+92
|\| | | | | | | | | | | | | | | | | | | * commit '2a89ce8cd': Convert the crypto module to async/await. (#8003)
| * | | Convert the crypto module to async/await. (#8003)Patrick Cloke2020-08-031-109/+92
| | | |
* | | | Merge commit 'b6c6fb795' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-161-1/+1
|\| | | | | | | | | | | | | | | | | | | * commit 'b6c6fb795': Allow guests to operate in encrypted rooms (#7314)
| * | | Allow guests to operate in encrypted rooms (#7314)Michael Albert2020-08-031-1/+1
| | | | | | | | | | | | Signed-off-by: Michael Albert <michael.albert@awesome-technologies.de>
* | | | Merge commit '3b415e23a' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-1610-38/+28
|\| | | | | | | | | | | | | | | | | | | * commit '3b415e23a': Convert replication code to async/await. (#7987)
| * | | Convert replication code to async/await. (#7987)Patrick Cloke2020-08-0310-38/+28
| | | |
* | | | Merge commit 'db5970ac6' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-162-14/+10
|\| | | | | | | | | | | | | | | | | | | * commit 'db5970ac6': Convert ACME code to async/await. (#7989)
| * | | Convert ACME code to async/await. (#7989)Patrick Cloke2020-08-032-14/+10
| | | |
* | | | Merge commit 'd1008fe94' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-165-59/+54
|\| | | | | | | | | | | | | | | | | | | * commit 'd1008fe94': Fix some comments and types in service notices (#7996)
| * | | Fix some comments and types in service notices (#7996)Patrick Cloke2020-07-315-59/+54
| | | |
* | | | Merge commit '394be6a0e' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-163-2/+58
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '394be6a0e': Newsfile Add ratelimiting on joins Add docs for undoing room shutdowns (#7998)
| * | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2020-07-3156-964/+1051
| |\ \ \ | | | |/ | | |/| | | | | erikj/add_rate_limiting_to_joins
| * | | Add ratelimiting on joinsErik Johnston2020-07-312-2/+56
| | | |
* | | | Merge commit '0a7fb2471' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-161-8/+21
|\ \ \ \ | | |/ / | |/| | | | | | | | | | * commit '0a7fb2471': Fix invite rejection when we have no forward-extremeties (#7980)
| * | | Fix invite rejection when we have no forward-extremeties (#7980)Richard van der Hoff2020-07-301-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thanks to some slightly overzealous cleanup in the `delete_old_current_state_events`, it's possible to end up with no `event_forward_extremities` in a room where we have outstanding local invites. The user would then get a "no create event in auth events" when trying to reject the invite. We can hack around it by using the dangling invite as the prev event.
| * | | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2020-07-3011-23/+81
| |\| |
* | | | Merge commit 'c978f6c45' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-166-162/+128
|\| | | | | | | | | | | | | | | | | | | * commit 'c978f6c45': Convert federation client to async/await. (#7975)
| * | | Convert federation client to async/await. (#7975)Patrick Cloke2020-07-306-162/+128
| | | |
* | | | Merge commit '4cce8ef74' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-164-65/+46
|\| | | | | | | | | | | | | | | | | | | * commit '4cce8ef74': Convert appservice to async. (#7973)
| * | | Convert appservice to async. (#7973)Patrick Cloke2020-07-304-65/+46
| | | |
* | | | Merge commit 'b3a97d6da' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-166-188/+160
|\| | | | | | | | | | | | | | | | | | | * commit 'b3a97d6da': Convert some of the data store to async. (#7976)
| * | | Convert some of the data store to async. (#7976)Patrick Cloke2020-07-306-188/+160
| | | |
* | | | Merge commit '3950ae51e' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-1643-533/+690
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '3950ae51e': Ensure that remove_pusher is always async (#7981) Ensure the msg property of HttpResponseException is a string. (#7979) Remove from the event_relations table when purging historical events. (#7978) Add additional logging for SAML sessions. (#7971) Add MSC reference to changelog for #7736 Re-implement unread counts (#7736) Various improvements to the docs (#7899) Convert storage layer to async/await. (#7963) Add an option to disable purge in delete room admin API (#7964) Move some log lines from default logger to sql/transaction loggers (#7952) Use the JSON module from the std library instead of simplejson. (#7936) Fix exit code for `check_line_terminators.sh` (#7970) Option to allow server admins to join complex rooms (#7902) Fix typo in metrics docs (#7966) Add script for finding files with unix line terminators (#7965) Convert the remaining media repo code to async / await. (#7947) Convert a synapse.events to async/await. (#7949) Convert groups and visibility code to async / await. (#7951) Convert push to async/await. (#7948)
| * | | Ensure that remove_pusher is always async (#7981)Patrick Cloke2020-07-301-1/+1
| | | |
| * | | Ensure the msg property of HttpResponseException is a string. (#7979)Patrick Cloke2020-07-292-7/+16
| | | |
| * | | Remove from the event_relations table when purging historical events. (#7978)Patrick Cloke2020-07-291-0/+2
| | | |
| * | | Add additional logging for SAML sessions. (#7971)Patrick Cloke2020-07-291-0/+3
| | | |
| * | | Re-implement unread counts (#7736)Brendan Abolivier2020-07-297-15/+162
| | | |
| * | | Various improvements to the docs (#7899)Aaron Raimist2020-07-291-18/+0
| | | |
| * | | Convert storage layer to async/await. (#7963)Patrick Cloke2020-07-283-140/+145
| | | |
| * | | Add an option to disable purge in delete room admin API (#7964)Dirk Klimpel2020-07-281-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | Add option ```purge``` to ```POST /_synapse/admin/v1/rooms/<room_id>/delete``` Fixes: #3761 Signed-off-by: Dirk Klimpel dirk@klimpel.org
| * | | Move some log lines from default logger to sql/transaction loggers (#7952)Andrew Morgan2020-07-281-8/+10
| | | | | | | | | | | | Idea from matrix-org/synapse-dinsic#49
| * | | Use the JSON module from the std library instead of simplejson. (#7936)Patrick Cloke2020-07-282-1/+13
| | | |
| * | | Option to allow server admins to join complex rooms (#7902)lugino-emeritus2020-07-282-2/+13
| | | | | | | | | | | | | | | | | | | | Fixes #7901. Signed-off-by: Niklas Tittjung <nik_t.01@web.de>
| * | | Merge tag 'v1.18.0rc2' into developRichard van der Hoff2020-07-285-88/+113
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.18.0rc2 (2020-07-28) ============================== Bugfixes -------- - Fix an `AssertionError` exception introduced in v1.18.0rc1. ([\#7876](https://github.com/matrix-org/synapse/issues/7876)) - Fix experimental support for moving typing off master when worker is restarted, which is broken in v1.18.0rc1. ([\#7967](https://github.com/matrix-org/synapse/issues/7967)) Internal Changes ---------------- - Further optimise queueing of inbound replication commands. ([\#7876](https://github.com/matrix-org/synapse/issues/7876))
| * | | | Convert the remaining media repo code to async / await. (#7947)Patrick Cloke2020-07-275-107/+130
| | | | |
| * | | | Convert a synapse.events to async/await. (#7949)Patrick Cloke2020-07-278-72/+73
| | | | |
| * | | | Convert groups and visibility code to async / await. (#7951)Patrick Cloke2020-07-272-31/+24
| | | | |
| * | | | Convert push to async/await. (#7948)Patrick Cloke2020-07-277-141/+97
| | | | |
* | | | | Remember mappings when we bind a 3pid using the internal sydent bind API (#66)Andrew Morgan2020-10-141-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/matrix-org/synapse-dinsic/pull/51 added an option that would automatically bind a user's threepid to a configured identity server after they had registered. Unfortunately, when you bind threepids, ideally you would store that mapping in the database so that later on you can remove those mappings when you deactivate an account. We found that due the fact that we did not store these mappings, threepids were not unbound upon user account deactivation. This PR fixes the issue by creating the mappings again, meaning they will again be removed upon account deactivation.
* | | | | "Freeze" a room when the last admin of that room leaves (#59)Andrew Morgan2020-10-131-3/+171
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the last admin of a room departs, and thus the room no longer has any admins within it, we "freeze" the room. Freezing a room means that the power level required to do anything in the room (sending messages, inviting others etc) will require power level 100. At the moment, an admin can come back and unfreeze the room manually. The plan is to eventually make unfreezing of the room automatic on admin rejoin, though that will be in a separate PR. This *could* work in mainline, however if the admin who leaves is on a homeserver without this functionality, then the room isn't frozen. I imagine this would probably be pretty confusing to people. Part of this feature was allowing Synapse modules to send events, which has been implemented in mainline at https://github.com/matrix-org/synapse/pull/8479, and cherry-picked to the `dinsic` fork in 62c7b10. The actual freezing logic has been implemented here in the RoomAccessRules module.
* | | | | Allow modules to create and send events into rooms (#8479)Andrew Morgan2020-10-123-3/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR allows Synapse modules making use of the `ModuleApi` to create and send non-membership events into a room. This can useful to have modules send messages, or change power levels in a room etc. Note that they must send event through a user that's already in the room. The non-membership event limitation is currently arbitrary, as it's another chunk of work and not necessary at the moment. This commit has been cherry-picked from mainline.
* | | | | Only assert valid next_link params when provided (#65)Andrew Morgan2020-09-291-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug introduced in https://github.com/matrix-org/synapse-dinsic/commit/ff91a451b We were checking whether the `nextLink` param was valid, even if it wasn't provided. In that case, `nextLink` was `None`, which would clearly not be a valid URL. This would prevent password reset and other operations if `nextLink` was not provided and the `next_link_domain_whitelist` config option was in use.
* | | | | Don't push if an user account has expired (#58)Mathieu Velten2020-09-183-5/+39
| | | | |
* | | | | Make all rooms noisy by default (#60)Mathieu Velten2020-09-181-2/+10
| | | | |
* | | | | Make AccessRules use the public rooms directory instead of checking a room's ↵Andrew Morgan2020-09-185-61/+229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | join rules on rule change (#63) This PR switches several conditions regarding room access rules to check against the status of the room's inclusion in the public room list instead of its join rules. The code includes a snapshot of https://github.com/matrix-org/synapse/pull/8292, which will likely change in time and need merging in again.
* | | | | Override the power levels defaults, enforce mod requirement for invites, ↵Andrew Morgan2020-09-111-2/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | admin requirements for unknown state events (#61) This PR modifies the `RoomAccessRules` module, an implementation of `ThirdPartyEventRules`, to both: * Modify the default power levels when creating a room to set: - `invite` to be minimum PL50 - `state_default` to be minimum PL100 * Enforce this when creating the room.
* | | | | RoomAccessRules cleanup (#62)Andrew Morgan2020-09-101-115/+182
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Various cleanups of the DINUM-specific `RoomAccessRules` module, including: * Type hints * Docstring cleanups * Some code cleanups
* | | | | Add a config option for validating 'next_link' parameters against a domain ↵Andrew Morgan2020-09-092-11/+103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | whitelist (#8275) This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285 They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality. This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004, but across all `*/submit_token` endpoint. This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.
* | | | | Remove duplicated error definitions, likely due to mergeAndrew Morgan2020-09-021-7/+0
| | | | |
* | | | | TO REVERT: add user_id to presence response in client worker (#57)Mathieu Velten2020-08-181-1/+1
| | | | | | | | | | | | | | | It's currently expected by the Tchap clients, a fix will be deployed to them later on.
* | | | | Revert "Remove "user_id" from GET /presence. (#7606)"Brendan Abolivier2020-08-181-3/+1
| | | | | | | | | | | | | | | | | | | | This reverts commit a3fbc23c39c0366392fd51faf0b1696f1f1d21c7.
* | | | | dinsic lintAndrew Morgan2020-08-034-5/+3
| | | | | | | | | | | | | | | | | | | | linting after the v1.18.0 mainline merge
* | | | | Merge commit 'a9631b7b4' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-0311-23/+81
|\ \ \ \ \ | | |_|/ / | |/| | | | | | | | | | | | | | | | | | * commit 'a9631b7b4': 1.18.0 Update worker docs with recent enhancements (#7969)
| * | | | 1.18.0Olivier Wilkinson (reivilibre)2020-07-301-1/+1
| | | | |
| * | | | Update worker docs with recent enhancements (#7969)Erik Johnston2020-07-2910-22/+80
| | |/ / | |/| |
* | | | Merge commit '7000a215e' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-035-88/+113
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '7000a215e': 1.18.0rc2 Typing worker needs to handle stream update requests (#7967) Handle replication commands synchronously where possible (#7876) update changelog
| * | | 1.18.0rc2 v1.18.0rc2Richard van der Hoff2020-07-281-1/+1
| | | |
| * | | Typing worker needs to handle stream update requests (#7967)Erik Johnston2020-07-281-1/+1
| | | | | | | | | | | | | | | | | | | | IIRC this doesn't break tests because its only hit on reconnection, or something. Basically, when a process needs to fetch missing updates for the `typing` stream it needs to query the writer instance via HTTP (as we don't write typing notifications to the DB), the problem was that the endpoint (`streams`) was only registered on master and specifically not on the typing writer worker.
| * | | Handle replication commands synchronously where possible (#7876)Richard van der Hoff2020-07-273-86/+111
| |/ / | | | | | | Most of the stuff we do for replication commands can be done synchronously. There's no point spinning up background processes if we're not going to need them.
* | | Merge commit 'f88c48f3b' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-0335-504/+670
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'f88c48f3b': 1.18.0rc1 Fix error reporting when using `opentracing.trace` (#7961) Fix typing replication not being handled on master (#7959) Remove hacky error handling for inlineDeferreds. (#7950) Convert tests/rest/admin/test_room.py to unix file endings (#7953) Support oEmbed for media previews. (#7920) Convert state resolution to async/await (#7942) Fix up types and comments that refer to Deferreds. (#7945) Do not convert async functions to Deferreds in the interactive_auth_handler (#7944) Convert more of the media code to async/await (#7873) Return an empty body for OPTIONS requests. (#7886) Downgrade warning on client disconnect to INFO (#7928) Convert presence handler helpers to async/await. (#7939) Update the auth providers to be async. (#7935) Put a cache on `/state_ids` (#7931)
| * | 1.18.0rc1Richard van der Hoff2020-07-271-1/+1
| | |
| * | Fix error reporting when using `opentracing.trace` (#7961)Erik Johnston2020-07-272-12/+3
| | |
| * | Fix typing replication not being handled on master (#7959)Erik Johnston2020-07-273-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Handling of incoming typing stream updates from replication was not hooked up on master, effecting set ups where typing was handled on a different worker. This is really only a problem if the master process is also handling sync requests, which is unlikely for those that are at the stage of moving typing off. The other observable effect is that if a worker restarts or a replication connect drops then the typing worker will issue a `POSITION typing`, triggering master process to try and stream *all* typing updates from position 0. Fixes #7907
| * | Remove hacky error handling for inlineDeferreds. (#7950)Patrick Cloke2020-07-272-21/+12
| | |
| * | Support oEmbed for media previews. (#7920)Patrick Cloke2020-07-271-45/+220
| | | | | | | | | Fixes previews of Twitter URLs by using their oEmbed endpoint to grab content.
| * | Convert state resolution to async/await (#7942)Patrick Cloke2020-07-2412-134/+124
| | |
| * | Fix up types and comments that refer to Deferreds. (#7945)Patrick Cloke2020-07-247-157/+172
| | |
| * | Do not convert async functions to Deferreds in the interactive_auth_handler ↵Patrick Cloke2020-07-241-26/+21
| | | | | | | | | | | | (#7944)
| * | Convert more of the media code to async/await (#7873)Patrick Cloke2020-07-242-33/+42
| | |
| * | Return an empty body for OPTIONS requests. (#7886)Patrick Cloke2020-07-241-19/+5
| | |
| * | Downgrade warning on client disconnect to INFO (#7928)Richard van der Hoff2020-07-241-3/+1
| | | | | | | | | | | | Clients disconnecting before we finish processing the request happens from time to time. We don't need to yell about it
| * | Convert presence handler helpers to async/await. (#7939)Patrick Cloke2020-07-232-24/+23
| | |
| * | Update the auth providers to be async. (#7935)Patrick Cloke2020-07-232-19/+23
| | |
| * | Put a cache on `/state_ids` (#7931)Richard van der Hoff2020-07-231-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we send out an event which refers to `prev_events` which other servers in the federation are missing, then (after a round or two of backfill attempts), they will end up asking us for `/state_ids` at a particular point in the DAG. As per https://github.com/matrix-org/synapse/issues/7893, this is quite expensive, and we tend to see lots of very similar requests around the same time. We can therefore handle this much more efficiently by using a cache, which (a) ensures that if we see the same request from multiple servers (or even the same server, multiple times), then they share the result, and (b) any other servers that miss the initial excitement can also benefit from the work. [It's interesting to note that `/state` has a cache for exactly this reason. `/state` is now essentially unused and replaced with `/state_ids`, but evidently when we replaced it we forgot to add a cache to the new endpoint.]
* | | Merge commit '4876af06d' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-0/+6
|\| | | | | | | | | | | | | | * commit '4876af06d': Abort federation requests if the client disconnects early (#7930)
| * | Abort federation requests if the client disconnects early (#7930)Richard van der Hoff2020-07-231-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For inbound federation requests, if a given remote server makes too many requests at once, we start stacking them up rather than processing them immediatedly. However, that means that there is a fair chance that the requesting server will disconnect before we start processing the request. In that case, if it was a read-only request (ie, a GET request), there is absolutely no point in building a response (and some requests are quite expensive to handle). Even in the case of a POST request, one of two things will happen: * Most likely, the requesting server will retry the request and we'll get the information anyway. * Even if it doesn't, the requesting server has to assume that we didn't get the memo, and act accordingly. In short, we're better off aborting the request at this point rather than ploughing on with what might be a quite expensive request.
* | | Merge commit '68cd93582' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-16/+10
|\| | | | | | | | | | | | | | * commit '68cd93582': Convert the federation agent and related code to async/await. (#7874)
| * | Convert the federation agent and related code to async/await. (#7874)Patrick Cloke2020-07-232-16/+10
| | |
* | | Merge commit '13d77464c' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-6/+42
|\| | | | | | | | | | | | | | * commit '13d77464c': Follow-up to admin API to re-activate accounts (#7908)
| * | Follow-up to admin API to re-activate accounts (#7908)Patrick Cloke2020-07-222-6/+42
| | |
* | | Merge commit 'cc9bb3dc3' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-136/+152
|\| | | | | | | | | | | | | | * commit 'cc9bb3dc3': Convert the message handler to async/await. (#7884)
| * | Convert the message handler to async/await. (#7884)Patrick Cloke2020-07-221-136/+152
| |/
* | Merge commit '923c99502' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-0/+6
|\| | | | | | | | | * commit '923c99502': Skip serializing /sync response if client has disconnected (#7927)
| * Skip serializing /sync response if client has disconnected (#7927)Richard van der Hoff2020-07-221-0/+6
| | | | | | ... it's a load of work which may be entirely redundant.
* | Merge commit 'b74919c72' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-2/+18
|\| | | | | | | | | * commit 'b74919c72': Add debugging to sync response generation (#7929)
| * Add debugging to sync response generation (#7929)Richard van der Hoff2020-07-222-2/+18
| |
* | Merge commit '931b02684' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-3/+1
|\| | | | | | | | | * commit '931b02684': Remove an unused prometheus metric (#7878)
| * Remove an unused prometheus metric (#7878)Richard van der Hoff2020-07-221-3/+1
| |
* | Merge commit '05060e022' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-3/+38
|\| | | | | | | | | * commit '05060e022': Track command processing as a background process (#7879)
| * Track command processing as a background process (#7879)Richard van der Hoff2020-07-222-3/+38
| | | | | | | | I'm going to be doing more stuff synchronously, and I don't want to lose the CPU metrics down the sofa.
* | Merge commit '15997618e' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-18/+15
|\| | | | | | | | | | | * commit '15997618e': Clean up PreserveLoggingContext (#7877) fix an incorrect comment
| * Clean up PreserveLoggingContext (#7877)Richard van der Hoff2020-07-221-16/+13
| | | | | | This had some dead code and some just plain wrong docstrings.
| * fix an incorrect commentRichard van der Hoff2020-07-221-2/+2
| |
* | Merge commit 'de119063f' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-0372-968/+1224
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'de119063f': (31 commits) Convert room list handler to async/await. (#7912) Element CSS and logo in email templates (#7919) Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914) Remove unused code from synapse.logging.utils. (#7897) Fix a typo in the sample config. (#7890) Fix deprecation warning: import ABC from collections.abc (#7892) Change sample config's postgres user to synapse_user (#7889) Fix deprecation warning due to invalid escape sequences (#7895) Remove Ubuntu Eoan that is now EOL (#7888) Fix the trace function for async functions. (#7872) Add help for creating a user via docker (#7885) Switch to Debian:Slim from Alpine for the docker image (#7839) Stop using 'device_max_stream_id' (#7882) Fix TypeError in synapse.notifier (#7880) Add a default limit (of 100) to get/sync operations. (#7858) Change "unknown room ver" logging to warning. (#7881) Convert device handler to async/await (#7871) Convert synapse.app to async/await. (#7868) Convert _base, profile, and _receipts handlers to async/await (#7860) Add admin endpoint to get members in a room. (#7842) ...
| * Convert room list handler to async/await. (#7912)Patrick Cloke2020-07-212-41/+31
| |
| * Element CSS and logo in email templates (#7919)Jason Robinson2020-07-213-0/+11
| | | | | | | | | | Use Element CSS and logo in notification emails when app name is Element. Signed-off-by: Jason Robinson <jasonr@matrix.org>
| * Remove unused code from synapse.logging.utils. (#7897)Karthikeyan Singaravelan2020-07-201-126/+0
| |
| * Fix a typo in the sample config. (#7890)Adrian2020-07-201-1/+1
| |
| * Fix deprecation warning: import ABC from collections.abc (#7892)Karthikeyan Singaravelan2020-07-204-6/+6
| |
| * Change sample config's postgres user to synapse_user (#7889)Andrew Morgan2020-07-201-1/+1
| | | | | | | | | | | | | | The [postgres setup docs](https://github.com/matrix-org/synapse/blob/develop/docs/postgres.md#set-up-database) recommend setting up your database with user `synapse_user`. However, uncommenting the postgres defaults in the sample config leave you with user `synapse`. This PR switches the sample config to recommend `synapse_user`. Took a me a second to figure this out, so assume this will beneficial to others.
| * Fix the trace function for async functions. (#7872)Patrick Cloke2020-07-171-23/+40
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * Stop using 'device_max_stream_id' (#7882)Erik Johnston2020-07-173-5/+2
| | | | | | | | | | It serves no purpose and updating everytime we write to the device inbox stream means all such transactions will conflict, causing lots of transaction failures and retries.
| * Fix TypeError in synapse.notifier (#7880)Erik Johnston2020-07-171-0/+8
| | | | | | Fixes #7774
| * Add a default limit (of 100) to get/sync operations. (#7858)Patrick Cloke2020-07-172-3/+14
| |
| * Change "unknown room ver" logging to warning. (#7881)Erik Johnston2020-07-171-1/+1
| | | | | | | | It's somewhat expected for us to have unknown room versions in the database due to room version experiments.
| * Convert device handler to async/await (#7871)Patrick Cloke2020-07-172-138/+131
| |
| * Convert synapse.app to async/await. (#7868)Patrick Cloke2020-07-173-41/+36
| |
| * Convert _base, profile, and _receipts handlers to async/await (#7860)Patrick Cloke2020-07-174-53/+41
| |
| * Add admin endpoint to get members in a room. (#7842)Michael Albert2020-07-162-0/+27
| |
| * Consistently use `db_to_json` to convert from database values to JSON ↵Patrick Cloke2020-07-1621-82/+79
| | | | | | | | objects. (#7849)
| * Optimise queueing of inbound replication commands (#7861)Richard van der Hoff2020-07-161-116/+215
| | | | | | | | | | | | | | | | | | | | | | When we get behind on replication, we tend to stack up background processes behind a linearizer. Bg processes are heavy (particularly with respect to prometheus metrics) and linearizers aren't terribly efficient once the queue gets long either. A better approach is to maintain a queue of requests to be processed, and nominate a single process to work its way through the queue. Fixes: #7444
| * Reject attempts to join empty rooms over federation (#7859)Richard van der Hoff2020-07-161-2/+13
| | | | | | | | | | | | We shouldn't allow others to make_join through us if we've left the room; reject such attempts with a 404. Fixes #7835. Fixes #6958.
| * Allow moving typing off master (#7869)Erik Johnston2020-07-169-178/+283
| |
| * Add ability to run multiple pusher instances (#7855)Erik Johnston2020-07-167-82/+99
| | | | | | This reuses the same scheme as federation sender sharding
| * Merge pull request #7866 from matrix-org/rav/fix_guest_user_idRichard van der Hoff2020-07-169-80/+184
| |\ | | | | | | Fix guest user registration with lots of client readers
| | * Use a postgres sequence to generate guest user IDsRichard van der Hoff2020-07-163-50/+71
| | |
| | * Use SequenceGenerator for state group ID allocationRichard van der Hoff2020-07-164-26/+11
| | |
| | * Use `PostgresSequenceGenerator` from `MultiWriterIdGenerator`Richard van der Hoff2020-07-161-4/+4
| | | | | | | | | | | | partly just to show it works, but alwo to remove a bit of code duplication.
| | * Add some helper classes for generating ID sequencesRichard van der Hoff2020-07-161-0/+98
| | |
* | | Merge commit 'a973bcb8a' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-0319-253/+250
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a973bcb8a': Add some tiny type annotations (#7870) Remove obsolete comment. Ensure that calls to `json.dumps` are compatible with the standard library json. (#7836) Avoid brand new rooms in `delete_old_current_state_events` (#7854) Allow accounts to be re-activated from the admin APIs. (#7847) Fix tests Fix typo Newsfile Use get_users_in_room rather than state handler in typing for speed Fix client reader sharding tests (#7853) Convert E2E key and room key handlers to async/await. (#7851) Return the proper 403 Forbidden error during errors with JWT logins. (#7844) remove `retry_on_integrity_error` wrapper for persist_events (#7848)
| * | Add some tiny type annotations (#7870)Richard van der Hoff2020-07-162-8/+6
| | | | | | | | | I found these made pycharm have more of a clue as to what was going on in other places.
| * | Remove obsolete comment.Olivier Wilkinson (reivilibre)2020-07-161-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | It was correct at the time of our friend Jorik writing it (checking git blame), but the world has moved now and it is no longer a generator. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
| * | Ensure that calls to `json.dumps` are compatible with the standard library ↵Patrick Cloke2020-07-157-13/+21
| | | | | | | | | | | | json. (#7836)
| * | Avoid brand new rooms in `delete_old_current_state_events` (#7854)Richard van der Hoff2020-07-151-10/+55
| | | | | | | | | | | | | | | | | | | | | | | | When considering rooms to clean up in `delete_old_current_state_events`, skip rooms which we are creating, which otherwise look a bit like rooms we have left. Fixes #7834.
| * | Merge branch 'erikj/faster_typing' of github.com:matrix-org/synapse into developErik Johnston2020-07-151-2/+2
| |\ \ | | |/ | |/|
| | * Fix typoErik Johnston2020-07-151-1/+1
| | |
| | * Use get_users_in_room rather than state handler in typing for speedErik Johnston2020-07-151-2/+2
| | |
| * | Allow accounts to be re-activated from the admin APIs. (#7847)Patrick Cloke2020-07-152-21/+37
| | |
| * | Fix client reader sharding tests (#7853)Erik Johnston2020-07-152-1/+28
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix client reader sharding tests * Newsfile * Fix typing * Update changelog.d/7853.misc Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Move mocking of http_client to tests Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * Convert E2E key and room key handlers to async/await. (#7851)Patrick Cloke2020-07-152-124/+98
| |
| * Return the proper 403 Forbidden error during errors with JWT logins. (#7844)Patrick Cloke2020-07-151-5/+3
| |
| * remove `retry_on_integrity_error` wrapper for persist_events (#7848)Richard van der Hoff2020-07-151-67/+0
| | | | | | | | | | | | | | | | | | As far as I can tell from the sentry logs, the only time this has actually done anything in the last two years is when we had two master workers running at once, and even then, it made a bit of a mess of it (see https://github.com/matrix-org/synapse/issues/7845#issuecomment-658238739). Generally I feel like this code is doing more harm than good.
* | Merge commit '8d0097bef' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-1/+1
|\| | | | | | | | | * commit '8d0097bef': Fix bug in per-room message retention policies. (#7850)
| * Fix bug in per-room message retention policies. (#7850)Patrick Cloke2020-07-141-1/+1
| |
* | Merge commit '85223106f' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-37/+132
|\| | | | | | | | | * commit '85223106f': Allow email subjects to be customised through Synapse's configuration (#7846)
| * Allow email subjects to be customised through Synapse's configuration (#7846)Brendan Abolivier2020-07-142-37/+132
| |
* | Merge commit '491f0dab1' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-036-113/+273
|\| | | | | | | | | * commit '491f0dab1': Add delete room admin endpoint (#7613)
| * Add delete room admin endpoint (#7613)Dirk Klimpel2020-07-146-113/+273
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Delete Room admin API allows server admins to remove rooms from server and block these rooms. `DELETE /_synapse/admin/v1/rooms/<room_id>` It is a combination and improvement of "[Shutdown room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/shutdown_room.md)" and "[Purge room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/purge_room.md)" API. Fixes: #6425 It also fixes a bug in [synapse/storage/data_stores/main/room.py](synapse/storage/data_stores/main/room.py) in ` get_room_with_stats`. It should return `None` if the room is unknown. But it returns an `IndexError`. https://github.com/matrix-org/synapse/blob/901b1fa561e3cc661d78aa96d59802cf2078cb0d/synapse/storage/data_stores/main/room.py#L99-L105 Related to: - #5575 - https://github.com/Awesome-Technologies/synapse-admin/issues/17 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Merge commit '77d2c0541' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-032-6/+47
|\| | | | | | | | | * commit '77d2c0541': Add the option to validate the `iss` and `aud` claims for JWT logins. (#7827)
| * Add the option to validate the `iss` and `aud` claims for JWT logins. (#7827)Patrick Cloke2020-07-142-6/+47
| |
* | Merge commit '4db150951' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-55/+73
|\| | | | | | | | | * commit '4db150951': Improve the type hints of synapse.api.errors. (#7820)
| * Improve the type hints of synapse.api.errors. (#7820)Patrick Cloke2020-07-141-55/+73
| |
* | Merge commit 'f886a6991' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-2/+8
|\| | | | | | | | | * commit 'f886a6991': Correctly pass app_name to all email templates. (#7829)
| * Correctly pass app_name to all email templates. (#7829)Erik Johnston2020-07-141-2/+8
| | | | | | We didn't do this for e.g. registration emails.
* | Merge commit '457096e6d' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-1/+2
|\| | | | | | | | | * commit '457096e6d': Support handling registration requests across multiple client readers. (#7830)
| * Support handling registration requests across multiple client readers. (#7830)Patrick Cloke2020-07-131-1/+2
| |
* | Merge commit '504c8f348' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-1/+6
|\| | | | | | | | | | | * commit '504c8f348': Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822) Update grafana dashboard
| * Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822)Brendan Abolivier2020-07-131-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7821, introduced in https://github.com/matrix-org/synapse/pull/7639 Turns out PyYAML translates `off` into a `False` boolean if it's unquoted (see https://stackoverflow.com/questions/36463531/pyyaml-automatically-converting-certain-keys-to-boolean-values), which seems to be a liberal interpretation of this bit of the YAML spec: https://yaml.org/spec/1.1/current.html#id864510 An alternative fix would be to implement the solution mentioned in the SO post linked above, but I'm aware it might break existing setups (which might use these values in the configuration file) so it's probably better just to add an extra check for this one. We should be aware that this is a thing for the next times we do that though. I didn't find any other occurrence of this bug elsewhere in the codebase.
| * Merge branch 'master' into developRichard van der Hoff2020-07-131-1/+1
| |\
* | \ Merge commit '29df3d0e9' into anoa/dinsic_release_1_18_xAndrew Morgan2020-08-031-1/+1
|\ \ \ | | |/ | |/| | | | | | | * commit '29df3d0e9': 1.17.0
generated by cgit-magenta 1.5.1 (git 2.48.1) at 2025-08-09 03:16:19 +0000