summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'madlittlemods/11850-migrate-to-opentelemetry' into ↵Eric Eastwood2022-08-0921-200/+554
|\ | | | | | | | | | | | | | | madlittlemods/13356-messages-investigation-scratch-v1 Conflicts: pyproject.toml synapse/logging/tracing.py
| * Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetryEric Eastwood2022-08-0921-240/+638
| |\ | | | | | | | | | | | | | | | Conflicts: synapse/logging/opentracing.py tests/logging/test_opentracing.py
| | * Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453)Eric Eastwood2022-08-091-56/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```
| | * Correct a misnamed argument in state res v2 (#13467)David Robertson2022-08-081-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In state res v2, we apply two passes of iterative auth checks. The first pass replays power events and events in their auth chains, but only those belonging to the full conflicted set. The source code as written suggests that we want only those belonging to the auth difference (which is a smaller set of events). At runtime we were doing the correct thing anyway, because the only callsite of `_reverse_topological_power_sort` passes in the `full_conflicted_set`. So this really is just a rename.
| | * Support stable identifiers for MSC2285: private read receipts. (#13273)Šimon Brandner2022-08-0510-42/+126
| | | | | | | | | | | | | | | This adds support for the stable identifiers of MSC2285 while continuing to support the unstable identifiers behind the configuration flag. These will be removed in a future version.
| | * Update module API "update room membership" method to allow for remote joins ↵Matt C2022-08-051-4/+4
| | | | | | | | | | | | | | | | | | (#13441) Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| | * Add comments about how event push actions are stored. (#13445)Erik Johnston2022-08-041-0/+61
| | |
| | * Fix `@tag_args` being off-by-one (ahead) (#13452)Eric Eastwood2022-08-041-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix @tag_args being off-by-one (ahead) Example: ``` argspec.args=[ 'self', 'room_id' ] args=( <synapse.storage.databases.main.DataStore object at 0x10d0b8d00>, '!HBehERstyQBxyJDLfR:my.synapse.server' ) ``` --- The previous logic was also flawed and we can end up in a situation like this: ``` argspec.args=['self', 'dest', 'room_id', 'limit', 'extremities'] args=(<synapse.federation.federation_client.FederationClient object at 0x7f1651c18160>, 'hs1', '!jAEHKIubyIfuLOdfpY:hs1') ``` From this source: ```py async def backfill( self, dest: str, room_id: str, limit: int, extremities: Collection[str] ) -> Optional[List[EventBase]]: ``` And this usage: ```py events = await self._federation_client.backfill( dest, room_id, limit=limit, extremities=extremities ) ``` which would previously cause this error: ``` synapse_main | 2022-08-04 06:13:12,051 - synapse.handlers.federation - 424 - ERROR - GET-5 - Failed to backfill from hs1 because tuple index out of range synapse_main | Traceback (most recent call last): synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation.py", line 392, in try_backfill synapse_main | await self._federation_event_handler.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation_event.py", line 593, in backfill synapse_main | events = await self._federation_client.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 827, in _wrapper synapse_main | with wrapping_logic(func, *args, **kwargs): synapse_main | File "/usr/local/lib/python3.9/contextlib.py", line 119, in __enter__ synapse_main | return next(self.gen) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 922, in _wrapping_logic synapse_main | set_attribute("ARG_" + arg, str(args[i + 1])) # type: ignore[index] synapse_main | IndexError: tuple index out of range ```
| | * Improve comments (& avoid a duplicate query) in push actions processing. ↵Patrick Cloke2022-08-041-124/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | (#13455) * Adds docstrings and inline comments. * Formats SQL queries using triple quoted strings. * Minor formatting changes. * Avoid fetching `event_push_summary_stream_ordering` multiple times in the same transactions.
| | * Update type of `EventContext.rejected` (#13460)Richard van der Hoff2022-08-042-5/+4
| | |
| | * Faster Room Joins: prevent Synapse from answering federated join requests ↵reivilibre2022-08-042-0/+34
| | | | | | | | | | | | for a room which it has not fully joined yet. (#13416)
| | * Optimise async get event lookups (#13435)Nick Mills-Barrett2022-08-043-8/+86
| | | | | | | | | | | | | | | | | | Still maintains local in memory lookup optimisation, but does any external lookup as part of the deferred that prevents duplicate lookups for the same event at once. This makes the assumption that fetching from an external cache is a non-zero load operation.
| | * Add module API method to create a room (#13429)Matt C2022-08-041-0/+51
| | | | | | | | | | | | Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| | * Fix rooms not being properly excluded from incremental sync (#13408)Brendan Abolivier2022-08-041-10/+15
| | |
* | | Only set attribute if going forwardEric Eastwood2022-08-081-1/+2
| | |
* | | Fix some lints (mistakes) and better trace when fetching eventsEric Eastwood2022-08-063-11/+27
| | |
* | | Add length to the list of eventsEric Eastwood2022-08-062-4/+10
| | |
* | | More tracing for federationEric Eastwood2022-08-065-10/+25
| | |
* | | More tracing for federated sideEric Eastwood2022-08-056-41/+97
| | |
* | | Trace moreEric Eastwood2022-08-045-5/+11
| | |
* | | Allow @trace and @tag_args to be used togetherEric Eastwood2022-08-032-51/+96
| | |
* | | Fix @tag_args being one-off (ahead)Eric Eastwood2022-08-031-1/+1
| | |
* | | Merge branch 'madlittlemods/11850-migrate-to-opentelemetry' into ↵Eric Eastwood2022-08-039-64/+100
|\| | | | | | | | | | | madlittlemods/13356-messages-investigation-scratch-v1
| * | Fix tracing imports after merging in developEric Eastwood2022-08-0311-15/+15
| | |
| * | Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetryEric Eastwood2022-08-0317-65/+127
| |\| | | | | | | | | | | | | | | | Conflicts: docs/usage/configuration/config_documentation.md synapse/api/auth.py
| | * Add some tracing spans to give insight into local joins (#13439)Shay2022-08-032-33/+39
| | |
| | * Instrument `/messages` for understandable traces in Jaeger (#13368)Eric Eastwood2022-08-0310-1/+31
| | | | | | | | | | | | | | | | | | In Jaeger: - Before: huge list of uncategorized database calls - After: nice and collapsible into units of work
| | * Return 404 or member list when getting joined_members after leaving (#13374)andrew do2022-08-031-2/+4
| | | | | | | | | | | | | | | | | | Signed-off-by: Andrew Doh <andrewddo@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <andrewm@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| | * Rename `RateLimitConfig` to `RatelimitSettings` (#13442)Dirk Klimpel2022-08-034-29/+29
| | |
| | * Add module API method to resolve a room alias to a room ID (#13428)Matt C2022-08-031-0/+24
| | | | | | | | | | | | Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| * | Use latested Twisted from source to fix contextvar issues causing OTEL ↵Eric Eastwood2022-08-031-0/+2
| | | | | | | | | | | | | | | | | | `Failed to detach context` errors See https://github.com/matrix-org/synapse/pull/13400#discussion_r936195492
* | | Fix imports after OTEL changesEric Eastwood2022-08-028-8/+8
| | |
* | | Merge branch 'madlittlemods/instrument-messages-tracing' into ↵Eric Eastwood2022-08-0210-2/+30
|\ \ \ | |/ / |/| | | | | | | | | | | | | | madlittlemods/13356-messages-investigation-scratch-v1 Conflicts: synapse/api/auth.py
| * | Instrument /messages for understandable tracesEric Eastwood2022-07-2210-2/+30
| | |
* | | Fix table missing columnEric Eastwood2022-08-022-2/+3
| | |
* | | Fix remnantEric Eastwood2022-08-021-1/+1
| | |
* | | Fix lintsEric Eastwood2022-08-021-3/+1
| | |
* | | Move to 72 schema versionEric Eastwood2022-08-021-3/+1
| | | | | | | | | | | | | | | Do as they tell us: https://github.com/matrix-org/synapse/runs/7639487550?check_suite_focus=true
* | | Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetryEric Eastwood2022-08-0238-318/+742
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Conflicts: docs/usage/configuration/config_documentation.md synapse/logging/opentracing.py Got changes from: - https://github.com/matrix-org/synapse/pull/13362/files
| * | Fix error when out of servers to sync partial state with (#13432)Sean Quah2022-08-021-2/+3
| | | | | | | | | | | | | | | so that we raise the intended error instead. Signed-off-by: Sean Quah <seanq@matrix.org>
| * | Faster Room Joins: don't leave a stuck room partial state flag if the join ↵reivilibre2022-08-011-14/+18
| | | | | | | | | | | | fails. (#13403)
| * | Fix missing import in `federation_event` handler. (#13431)Patrick Cloke2022-08-011-0/+1
| | | | | | | | | | | | #13404 removed an import of `Optional` which was still needed due to #13413 added more usages.
| * | Refactor `_resolve_state_at_missing_prevs` to return an `EventContext` (#13404)Sean Quah2022-08-013-82/+56
| | | | | | | | | | | | | | | | | | | | | | | | Previously, `_resolve_state_at_missing_prevs` returned the resolved state before an event and a partial state flag. These were unwieldy to carry around would only ever be used to build an event context. Build the event context directly instead. Signed-off-by: Sean Quah <seanq@matrix.org>
| * | Faster joins: fix rejected events becoming un-rejected during resync (#13413)Richard van der Hoff2022-08-012-6/+31
| | | | | | | | | | | | | | | Make sure that we re-check the auth rules during state resync, otherwise rejected events get un-rejected.
| * | Merge tag 'v1.64.0rc2' into developRichard van der Hoff2022-07-298-71/+242
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.64.0rc2 (2022-07-29) ============================== This RC reintroduces support for `account_threepid_delegates.email`, which was removed in 1.64.0rc1. It remains deprecated and will be removed altogether in a future release. ([\#13406](https://github.com/matrix-org/synapse/issues/13406))
| | * | Revert "Drop support for delegating email validation (#13192)" (#13406)3nprob2022-07-298-71/+242
| | | | | | | | | | | | | | | | | | | | Reverts commit fa71bb18b527d1a3e2629b48640ea67fff2f8c59, and tweaks documentation. Signed-off-by: 3nprob <git@3n.anonaddy.com>
| * | | Use stable prefixes for MSC3827: filtering of `/publicRooms` by room type ↵Šimon Brandner2022-07-275-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | (#13370) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
| * | | Implement MSC3848: Introduce errcodes for specific event sending failures ↵Will Hunt2022-07-279-34/+140
| | | | | | | | | | | | | | | | | | | | (#13343) Implements MSC3848
| * | | Make minor clarifications to the error messages given when we fail to join a ↵reivilibre2022-07-272-2/+12
| | | | | | | | | | | | | | | | room via any server. (#13160)
| * | | Fix `get_pdu` asking every remote destination even after it finds an event ↵Eric Eastwood2022-07-271-3/+3
| | | | | | | | | | | | | | | | (#13346)
| * | | Copy room serials before handling in `get_new_events_as` (#13392)Nick Mills-Barrett2022-07-261-3/+10
| | | |
| * | | Remove the unspecced `room_id` field in the `/hierarchy` response. (#13365)Patrick Cloke2022-07-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.
| * | | Fix infinite loop in partial-state resync (#13353)Richard van der Hoff2022-07-262-8/+26
| | | | | | | | | | | | | | | | | | | | Make sure that we only pull out events from the db once they have no prev-events with partial state.
| * | | Faster room joins: avoid blocking when pulling events with missing prevs ↵Sean Quah2022-07-264-32/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#13355) Avoid blocking on full state in `_resolve_state_at_missing_prevs` and return a new flag indicating whether the resolved state is partial. Thread that flag around so that it makes it into the event context. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | Remove unused argument for get_relations_for_event. (#13383)Patrick Cloke2022-07-262-9/+0
| |/ /
| * | Disable autocorrect and autocaptialisation when entering username for SSO ↵Doug2022-07-261-1/+1
| | | | | | | | | | | | | | | registration. (#13350) When registering a new account via SSO on iOS, the text field becomes pretty annoying as it autocapitalises and autocorrects your input. This PR fixes that (although I have only tested the raw HTML file on the simulator, I'm not sure how to get the complete setup available for testing in the flow).
| * | Support Implicit TLS for sending emails (#13317)Jan Schär2022-07-252-11/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, TLS could only be used with STARTTLS. Add a new option `force_tls`, where TLS is used from the start. Implicit TLS is recommended over STARTLS, see https://datatracker.ietf.org/doc/html/rfc8314 Fixes #8046. Signed-off-by: Jan Schär <jan@jschaer.ch>
| * | Additional fixes for opentracing type hints. (#13362)Patrick Cloke2022-07-251-2/+2
| | |
| * | Refactor presence so we can prune user in room caches (#13313)Erik Johnston2022-07-253-91/+108
| |/ | | | | | | | | | | | | | | See #10826 and #10786 for context as to why we had to disable pruning on those caches. Now that `get_users_who_share_room_with_user` is called frequently only for presence, we just need to make calls to it less frequent and then we can remove the various levels of caching that is going on.
* | Seems to (see test_side_by_side_spans)Eric Eastwood2022-08-021-1/+0
| |
* | Update docsEric Eastwood2022-08-022-67/+62
| |
* | Clean up some opentracing text referencesEric Eastwood2022-08-028-20/+21
| |
* | Restore logging current_context (not sure why removedEric Eastwood2022-08-021-0/+16
| |
* | End on exit is already the default expected behaviorEric Eastwood2022-08-022-2/+0
| |
* | Always return config path for config errorEric Eastwood2022-08-021-6/+10
| |
* | More clear method namesEric Eastwood2022-08-023-9/+9
| |
* | Fix lintsEric Eastwood2022-08-026-35/+29
| |
* | Revert crazy custom sampler and span process to try force tracing for usersEric Eastwood2022-08-022-149/+16
| |
* | Revert "Non-working try baggage to inherit force tracing/sampling"Eric Eastwood2022-08-021-53/+7
| | | | | | | | This reverts commit d15fa457c987f51908cdba440655a0d6d88573a9.
* | Non-working try baggage to inherit force tracing/samplingEric Eastwood2022-08-021-7/+53
| |
* | PoC force tracingEric Eastwood2022-08-024-51/+198
| | | | | | | | Doesn't force tracing for the child spans yet
* | Fix tests and some lintsEric Eastwood2022-08-013-7/+30
| |
* | Try to align read from edu contentEric Eastwood2022-08-011-2/+4
| |
* | Remove what's left of scopemanagerEric Eastwood2022-08-011-8/+1
| |
* | Implement start_active_span_from_edu for OTELEric Eastwood2022-08-016-17/+32
| | | | | | | | | | | | | | | | AFAICT, this never worked before because everything was serialized into `content["org.matrix.opentracing_context"]` but `start_active_span_from_edu` read from `content["opentracing"]`. See https://github.com/matrix-org/synapse/pull/5852#discussion_r934960586 Do we even still want this?
* | todosEric Eastwood2022-08-012-0/+6
| |
* | Fix some lintsEric Eastwood2022-08-018-63/+138
| |
* | Use HTTP_HOST attributeEric Eastwood2022-07-302-3/+2
| |
* | Use correct type for what start_as_current_span returnsEric Eastwood2022-07-291-1/+2
| | | | | | | | | | | | | | See: - https://github.com/open-telemetry/opentelemetry-python/pull/198#discussion_r333399436 - https://github.com/open-telemetry/opentelemetry-python/issues/219
* | Passing tests and context manager doesn't seem to be neededEric Eastwood2022-07-292-178/+9
| |
* | Move to start_active_spanEric Eastwood2022-07-296-103/+42
| |
* | Easier to follow local vs remote span tracingEric Eastwood2022-07-292-45/+99
| | | | | | | | | | | | | | | | | | | | | | | | The `incoming-federation-request` vs `process-federation_request` was first introduced in https://github.com/matrix-org/synapse/pull/11870 - Span for remote trace: `incoming-federation-request` - `child_of` reference: `origin_span_context` - `follows_from` reference: `servlet_span` - Span for local trace: `process-federation-request` - `child_of` reference: `servlet_span` (by the nature of it being active) - `follows_from` reference: `incoming-federation-request`
* | Explain weird functionEric Eastwood2022-07-291-0/+4
| |
* | Record exceptionEric Eastwood2022-07-293-6/+10
| |
* | Fix using wrong type of context (`Context` vs `SpanContext`)Eric Eastwood2022-07-291-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix error: ``` AttributeError: 'SpanContext' object has no attribute 'get' ``` `Context`: ``` {'current-span-1a226c96-a5db-4412-bcaa-1fdd34213c5c': _Span(name="sendToDevice", context=SpanContext(trace_id=0x5d2dcc3fdc8205046d60a5cd18672ac6, span_id=0x715c736ff5f4d208, trace_flags=0x01, trace_state=[], is_remote=False))} ``` `SpanContext`: ``` SpanContext(trace_id=0xf7cd9d058b7b76f364bdd649c4ba7b8a, span_id=0x287ce71bac31bfc4, trace_flags=0x01, trace_state=[], is_remote=False) ```
* | Fix invalid attribute typeEric Eastwood2022-07-292-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` Invalid type StreamToken for attribute value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types ``` Had to add a few more logs to find this instance since the warning doens't give much info where I am setting this invalid attribute. This was good enough to find it in the code. ``` BoundedAttributes __setitem__ key=since_token value=StreamToken(room_key=RoomStreamToken(topological=None, stream=1787, instance_map=frozendict.frozendict({})), presence_key=481272, typing_key=0, receipt_key=340, account_data_key=1233, push_rules_key=8, to_device_key=57, device_list_key=199, groups_key=0) BoundedAttributes __setitem__ key=now_token value=StreamToken(room_key=RoomStreamToken(topological=None, stream=1787, instance_map=frozendict.frozendict({})), presence_key=481287, typing_key=0, receipt_key=340, account_data_key=1233, push_rules_key=8, to_device_key=57, device_list_key=199, groups_key=0) BoundedAttributes __setitem__ key=token value=StreamToken(room_key=RoomStreamToken(topological=None, stream=1787, instance_map=frozendict.frozendict({})), presence_key=481291, typing_key=0, receipt_key=340, account_data_key=1237, push_rules_key=8, to_device_key=57, device_list_key=199, groups_key=0) ```
* | Fix some lintsEric Eastwood2022-07-282-2/+2
| |
* | Fixup some todosEric Eastwood2022-07-289-42/+75
| |
* | Fix some lintsEric Eastwood2022-07-274-9/+9
| |
* | We use the config for the Jaeger exporter nowEric Eastwood2022-07-271-1/+0
| |
* | Revert changes to Sentry scopes (not OTEL)Eric Eastwood2022-07-271-3/+3
| | | | | | | | See https://github.com/matrix-org/synapse/pull/13400#discussion_r931325627
* | Export to Jaeger (things are showing up)Eric Eastwood2022-07-274-46/+73
| |
* | Server runningEric Eastwood2022-07-271-3/+6
| |
* | Progress towards OTELEric Eastwood2022-07-2715-348/+199
| |
* | Some shim and some newEric Eastwood2022-07-2630-176/+211
| |
* | Migrate to OpenTelemetry tracingEric Eastwood2022-07-2633-147/+97
|/ | | | See https://github.com/matrix-org/synapse/issues/11850
* Backfill remote event fetched by MSC3030 so we can paginate from it later ↵Eric Eastwood2022-07-222-15/+93
| | | | | | | | | (#13205) Depends on https://github.com/matrix-org/synapse/pull/13320 Complement tests: https://github.com/matrix-org/complement/pull/406 We could use the same method to backfill for `/context` as well in the future, see https://github.com/matrix-org/synapse/issues/3848
* Skip soft fail checks for rooms with partial state (#13354)Sean Quah2022-07-221-0/+10
| | | | | | | | | | | | When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <seanq@matrix.org>
* Remove old empty/redundant slaved stores. (#13349)Nick Mills-Barrett2022-07-219-166/+36
|
* Make DictionaryCache have better expiry properties (#13292)Erik Johnston2022-07-214-34/+321
|
* Don't hold onto full state in state cache (#13324)Erik Johnston2022-07-211-15/+53
|
* Track DB txn times w/ two counters, not histogram (#13342)David Robertson2022-07-211-3/+5
|
* Add missing types to opentracing. (#13345)Patrick Cloke2022-07-2110-32/+60
| | | After this change `synapse.logging` is fully typed.
* Use cache store remove base slaved (#13329)Nick Mills-Barrett2022-07-2115-114/+38
| | | This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.
* Update `get_pdu` to return the original, pristine `EventBase` (#13320)Eric Eastwood2022-07-203-49/+119
| | | | | | | | | | | | Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](https://github.com/matrix-org/synapse/blob/7864f33e286dec22368dc0b11c06eebb1462a51e/synapse/federation/federation_client.py#L581-L594).
* Validate federation destinations and log an error if server name is invalid. ↵Shay2022-07-201-0/+9
| | | | (#13318)
* Merge remote-tracking branch 'origin/master' into developErik Johnston2022-07-201-0/+7
|\
| * Don't include appservice users when calculating push rules (#13332)Erik Johnston2022-07-201-0/+7
| | | | | | This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
* | Fix spurious warning when fetching state after a missing prev event (#13258)Sean Quah2022-07-191-0/+3
| |
* | Add type annotations to `trace` decorator. (#13328)Patrick Cloke2022-07-1911-55/+101
| | | | | | | | Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.
* | Merge branch 'master' into developBrendan Abolivier2022-07-192-8/+8
|\|
| * Remove 'anonymised' from the phone home stats documentation (#13321)Andrew Morgan2022-07-192-8/+8
| |
* | Reduce memory usage of state group cache (#13323)Erik Johnston2022-07-191-1/+2
| |
* | Rate limit joins per-room (#13276)David Robertson2022-07-198-9/+106
| |
* | Safe async event cache (#13308)Nick Mills-Barrett2022-07-197-21/+101
| | | | | | | | | | | | | | | | Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).
* | Increase batch size of `bulk_get_push_rules` and ↵Shay2022-07-182-1/+2
| | | | | | | | `_get_joined_profiles_from_event_ids`. (#13300)
* | Improve performance of query ` _get_subset_users_in_room_with_profiles` (#13299)Shay2022-07-181-1/+1
| |
* | Fix overcounting of pushers when they are replaced (#13296)Sean Quah2022-07-181-11/+16
| | | | | | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* | Revert "Make all `process_replication_rows` methods async (#13304)" (#13312)Erik Johnston2022-07-1813-39/+25
| | | | | | This reverts commit 5d4028f217f178fcd384d5bfddd92225b4e78c51.
* | Don't pull out full state when sending dummy events (#13310)Erik Johnston2022-07-181-7/+1
| |
* | Use READ COMMITTED isolation level when purging rooms (#12942)Nick Mills-Barrett2022-07-181-2/+31
| | | | | | | | | | To close: #10294. Signed off by Nick @ Beeper.
* | Don't pull out the full state when creating an event (#13281)Erik Johnston2022-07-182-2/+9
| |
* | Make all `process_replication_rows` methods async (#13304)Nick Mills-Barrett2022-07-1713-25/+39
| | | | | | | | | | More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
* | Provide more info why we don't have any thumbnails to serve (#13038)Eric Eastwood2022-07-152-9/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
* | Don't pull out the full state when storing state (#13274)Erik Johnston2022-07-153-69/+125
| |
* | Use state before join to determine if we `_should_perform_remote_join` (#13270)David Robertson2022-07-153-24/+34
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Bg update to populate new `events` table columns (#13215)Richard van der Hoff2022-07-152-0/+134
| | | | | | | | | | These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.
* | Fix a bug which could lead to incorrect state (#13278)Erik Johnston2022-07-152-6/+16
| | | | | | | | | | There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.
* | Async get event cache prep (#13242)Nick Mills-Barrett2022-07-157-20/+79
| | | | | | | | | | Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)
* | Federation Sender & Appservice Pusher Stream Optimisations (#13251)Nick Mills-Barrett2022-07-155-79/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | * Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.
* | Rip out auth-event reconciliation code (#12943)Richard van der Hoff2022-07-142-221/+82
| | | | | | | | | | | | | | There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.
* | Don't pull out state in `compute_event_context` for unconflicted state (#13267)Erik Johnston2022-07-145-81/+94
| |
* | Allow rate limiters to passively record actions they cannot limit (#13253)David Robertson2022-07-131-12/+82
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Notifier: accept callbacks to fire on room joins (#13254)David Robertson2022-07-131-0/+18
| |
* | Call the v2 identity service `/3pid/unbind` endpoint, rather than v1. (#13240)Jacek Kuśnierz2022-07-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | * Drop support for v1 unbind Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc
* | Add support for room version 10 (#13220)Shay2022-07-132-0/+59
| |
* | Optimise room creation event lookups part 2 (#13224)Nick Mills-Barrett2022-07-132-15/+73
| |
* | Reduce duplicate code in receipts servlets. (#13198)Patrick Cloke2022-07-132-44/+32
| |
* | Add prometheus counters for content types other than events (#13175)Brad Murray2022-07-131-0/+14
| |
* | Drop unused tables from groups/communities. (#12967)Patrick Cloke2022-07-133-19/+35
| | | | | | | | These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
* | Fix "add user" admin api error when request contains a "msisdn" threepid ↵Thomas Weston2022-07-131-0/+1
| | | | | | | | | | | | (#13263) Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Inline URL preview documentation. (#13261)Patrick Cloke2022-07-121-4/+58
| | | | | | Inline URL preview documentation near the implementation.
* | Drop unused table `event_reference_hashes` (#13218)Richard van der Hoff2022-07-121-0/+17
| | | | | | This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
* | Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an ↵Jacek Kuśnierz2022-07-122-26/+10
| | | | | | | | | | | | | | `id_access_token` (#13239) Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
* | Drop support for delegating email validation (#13192)Richard van der Hoff2022-07-128-234/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
* | Log the stack when waiting for an entire room to be un-partial stated (#13257)Sean Quah2022-07-121-0/+1
| | | | | | | | The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
* | Make the AS login method call `Auth.get_user_by_req` for checking the AS ↵Quentin Gliech2022-07-121-2/+8
| | | | | | | | | | | | | | | | token. (#13094) This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>
* | expose whether a room is a space in the Admin API (#13208)andrew do2022-07-121-2/+4
|/
* Don't pull out the full state when calculating push actions (#13078)Erik Johnston2022-07-114-341/+160
|
* Reduce event lookups during room creation by passing known event IDs (#13210)Nick Mills-Barrett2022-07-111-2/+16
| | | | | | | | Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)
* Uniformize spam-checker API, part 5: expand other spam-checker callbacks to ↵David Teller2022-07-118-50/+176
| | | | | | return `Tuple[Codes, dict]` (#13044) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix to-device messages not being sent to MSC3202-enabled appservices (#13235)Travis Ralston2022-07-111-2/+3
| | | | The field name was simply incorrect, leading to errors.
* Remove delay when rotating event push actions (#13211)Erik Johnston2022-07-111-3/+1
| | | | We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
* Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston2022-07-112-138/+399
|
* Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236)Travis Ralston2022-07-111-1/+3
| | | | | | | | | | | * Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again
* Ensure portdb selects _all_ rows with negative rowids (#13226)David Robertson2022-07-111-1/+4
|
* Fix notification count after a highlighted message (#13223)Erik Johnston2022-07-081-3/+8
| | | | | Fixes #13196 Broke by #13005
* Fix exception when using MSC3030 to look for remote federated events before ↵Eric Eastwood2022-07-071-1/+5
| | | | | | | | | | | | | | | | room creation (#13197) Complement tests: https://github.com/matrix-org/complement/pull/405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```
* Faster room joins: fix race in recalculation of current room state (#13151)Sean Quah2022-07-076-55/+211
| | | | | | | | | | | Bounce recalculation of current state to the correct event persister and move recalculation of current state into the event persistence queue, to avoid concurrent updates to a room's current state. Also give recalculation of a room's current state a real stream ordering. Signed-off-by: Sean Quah <seanq@matrix.org>
* Use a single query in `ProfileHandler.get_profile` (#13209)Nick Mills-Barrett2022-07-071-12/+7
|
* Check that `auto_vacuum` is disabled when porting a SQLite database to ↵reivilibre2022-07-071-0/+34
| | | | Postgres, as `VACUUM`s must not be performed between runs of the script. (#13195)
* Make `_get_state_map_for_room` not break when room state events don't ↵David Teller2022-07-071-8/+1
| | | | | contain an event id. (#13174) Method `_get_state_map_for_room` seems to break in presence of some ill-formed events in the database. Reimplementing this method to use `get_current_state`, which is more robust to such events.
* Fix bug where we failed to delete old push actions (#13194)Erik Johnston2022-07-061-2/+4
| | | This happened if we encountered a stream ordering in `event_push_actions` that had more rows than the batch size of the delete, as If we don't delete any rows in an iteration then the next time round we get the exact same stream ordering and get stuck.
* Handle race between persisting an event and un-partial stating a room (#13100)Sean Quah2022-07-059-74/+233
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever we want to persist an event, we first compute an event context, which includes the state at the event and a flag indicating whether the state is partial. After a lot of processing, we finally try to store the event in the database, which can fail for partial state events when the containing room has been un-partial stated in the meantime. We detect the race as a foreign key constraint failure in the data store layer and turn it into a special `PartialStateConflictError` exception, which makes its way up to the method in which we computed the event context. To make things difficult, the exception needs to cross a replication request: `/fed_send_events` for events coming over federation and `/send_event` for events from clients. We transport the `PartialStateConflictError` as a `409 Conflict` over replication and turn `409`s back into `PartialStateConflictError`s on the worker making the request. All client events go through `EventCreationHandler.handle_new_client_event`, which is called in *a lot* of places. Instead of trying to update all the code which creates client events, we turn the `PartialStateConflictError` into a `429 Too Many Requests` in `EventCreationHandler.handle_new_client_event` and hope that clients take it as a hint to retry their request. On the federation event side, there are 7 places which compute event contexts. 4 of them use outlier event contexts: `FederationEventHandler._auth_and_persist_outliers_inner`, `FederationHandler.do_knock`, `FederationHandler.on_invite_request` and `FederationHandler.do_remotely_reject_invite`. These events won't have the partial state flag, so we do not need to do anything for then. The remaining 3 paths which create events are `FederationEventHandler.process_remote_join`, `FederationEventHandler.on_send_membership_event` and `FederationEventHandler._process_received_pdu`. We can't experience the race in `process_remote_join`, unless we're handling an additional join into a partial state room, which currently blocks, so we make no attempt to handle it correctly. `on_send_membership_event` is only called by `FederationServer._on_send_membership_event`, so we catch the `PartialStateConflictError` there and retry just once. `_process_received_pdu` is called by `on_receive_pdu` for incoming events and `_process_pulled_event` for backfill. The latter should never try to persist partial state events, so we ignore it. We catch the `PartialStateConflictError` in `on_receive_pdu` and retry just once. Refering to the graph of code paths in https://github.com/matrix-org/synapse/issues/12988#issuecomment-1156857648 may make the above make more sense. Signed-off-by: Sean Quah <seanq@matrix.org>
* Type `tests.utils` (#13028)David Robertson2022-07-052-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Cast to postgres types when handling postgres db * Remove unused method * Easy annotations * Annotate create_room * Use `ParamSpec` to annotate looping_call * Annotate `default_config` * Track `now` as a float `time_ms` returns an int like the proper Synapse `Clock` * Introduce a `Timer` dataclass * Introduce a Looper type * Suppress checking of a mock * tests.utils is typed * Changelog * Whoops, import ParamSpec from typing_extensions * ditch the psycopg2 casts
* Use upserts for updating `event_push_summary` (#13153)Erik Johnston2022-07-051-40/+7
|
* Fix application service not being able to join remote federated room without ↵Eric Eastwood2022-07-051-9/+23
| | | | | | | a profile set (#13131) Fix https://github.com/matrix-org/synapse/issues/4778 Complement tests: https://github.com/matrix-org/complement/pull/399
* Merge tag 'v1.62.0rc3' into developAndrew Morgan2022-07-041-2/+7
|\ | | | | | | | | | | | | | | | | | | | | Synapse 1.62.0rc3 (2022-07-04) ============================== Bugfixes -------- - Update the version of the [ldap3 plugin](https://github.com/matrix-org/matrix-synapse-ldap3/) included in the `matrixdotorg/synapse` DockerHub images and the Debian packages hosted on `packages.matrix.org` to 0.2.1. This fixes [a bug](https://github.com/matrix-org/matrix-synapse-ldap3/pull/163) with usernames containing uppercase characters. ([\#13156](https://github.com/matrix-org/synapse/issues/13156)) - Fix a bug introduced in Synapse 1.62.0rc1 affecting unread counts for users on small servers. ([\#13168](https://github.com/matrix-org/synapse/issues/13168))
| * Fix stuck notification counts on small servers (#13168)Erik Johnston2022-07-041-2/+7
| |
* | Extra validation for rest/client/account_data (#13148)David Robertson2022-07-011-2/+17
| | | | | | | | | | | | | | * Extra validation for rest/client/account_data This is a fairly simple endpoint and we did pretty well here. * Changelog
* | `_process_received_pdu`: Improve exception handling (#13145)Richard van der Hoff2022-07-011-7/+6
| | | | | | | | `_check_event_auth` is expected to raise `AuthError`s, so no need to log it again.
* | Skip waiting for full state for incoming events (#13144)Richard van der Hoff2022-07-011-3/+9
| | | | | | | | | | When we receive an event over federation during a faster join, there is no need to wait for full state, since we have a whole reconciliation process designed to take the partial state into account.
* | Allow dependency errors to pass through (#13113)Jacek Kuśnierz2022-06-307-58/+15
| | | | | | | | Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge remote-tracking branch 'origin/release-v1.62' into developPatrick Cloke2022-06-303-26/+57
|\|
| * Fix unread counts on large servers (#13140)Erik Johnston2022-06-301-22/+26
| |
| * Add index to help delete old push actions (#13141)Erik Johnston2022-06-303-4/+31
| |
* | Don't process /send requests for users who have hit their ratelimit (#13134)Shay2022-06-301-0/+3
| |
* | Cleanup references to sample config in the docs and redirect users to ↵Shay2022-06-301-1/+1
| | | | | | | | configuration manual (#13077)
* | More type hints for `synapse.logging` (#13103)Patrick Cloke2022-06-302-42/+54
| | | | | | | | Completes type hints for synapse.logging.scopecontextmanager and (partially) for synapse.logging.opentracing.
* | Improve startup times in Complement test runs against workers, particularly ↵reivilibre2022-06-302-2/+196
| | | | | | | | | | in CPU-constrained environments. (#13127) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Rate limiting invites per issuer (#13125)David Teller2022-06-302-2/+23
| | | | | | Co-authored-by: reivilibre <oliverw@matrix.org>
* | Don't actually one-line the SQL statements we send to the DB (#13129)Brendan Abolivier2022-06-301-3/+4
| |
* | Implement MSC3827: Filtering of `/publicRooms` by room type (#13031)Šimon Brandner2022-06-298-10/+186
| | | | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Improve performance of getting unread counts in rooms (#13119)Erik Johnston2022-06-294-4/+37
|/
* fix linting error from the 1.61.1 main -> develop mergeAndrew Morgan2022-06-281-1/+2
|
* Merge branch 'master' into developAndrew Morgan2022-06-281-24/+39
|\
| * Merge pull request from GHSA-22p3-qrh9-cx32reivilibre2022-06-281-24/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Make _iterate_over_text easier to read by using simple data structures * Prefer a set of tags to ignore In my tests, it's 4x faster to check for containment in a set of this size * Add a stack size limit to _iterate_over_text * Continue accepting the case where there is no body element * Use an early return instead for None Co-authored-by: Richard van der Hoff <richard@matrix.org>
* | Fix serialization errors when rotating notifications (#13118)Erik Johnston2022-06-283-78/+171
| |
* | Remove unspecced DELETE endpoint that modifies room visibility (#13123)santhoshivan232022-06-281-11/+0
| |
* | Update MSC3786 implementation: Check the `state_key` (#12939)Šimon Brandner2022-06-271-1/+7
| | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Add Cross-Origin-Resource-Policy header to thumbnail and download media ↵Robert Long2022-06-273-2/+23
| | | | | | | | endpoints (#12944)
* | validate room alias before interacting with the room directory (#13106)santhoshivan232022-06-221-0/+6
| |
* | Fix inconsistencies in event validation (#13088)Richard van der Hoff2022-06-171-2/+21
| |
* | Fix inconsistencies in event validation for `m.room.create` events (#13087)Richard van der Hoff2022-06-171-23/+44
| | | | | | | | | | | | | | | | | | | | * Extend the auth rule checks for `m.room.create` events ... and move them up to the top of the function. Since the no auth_events are allowed for m.room.create events, we may as well get the m.room.create event checks out of the way first. * Add a test for create events with prev_events
* | Fix type error that made its way onto develop (#13098)reivilibre2022-06-171-2/+2
| | | | | | | | | | | | | | * Fix type error introduced accidentally by #13045 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Simplify the alias deletion logic as an application service. (#13093)Quentin Gliech2022-06-171-22/+13
| |
* | Rotate notifications more frequently (#13096)Erik Johnston2022-06-171-1/+1
| |
* | Use new `device_list_changes_in_room` table when getting device list changes ↵Erik Johnston2022-06-173-31/+116
| | | | | | | | (#13045)
* | Allow MSC3030 'timestamp_to_event' calls from anyone on world-readable ↵Quentin Gliech2022-06-171-1/+3
| | | | | | | | | | rooms. (#13062) Signed-off-by: Quentin Gliech <quenting@element.io>
* | Fix logging context misuse when we fail to persist a federation event (#13089)Sean Quah2022-06-171-4/+2
| | | | | | | | | | | | | | | | | | When we fail to persist a federation event, we kick off a task to remove its push actions in the background, using the current logging context. Since we don't `await` that task, we may finish our logging context before the task finishes. There's no reason to not `await` the task, so let's do that. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Add desc to `get_earliest_token_for_stats` (#13085)Erik Johnston2022-06-161-0/+1
| |
* | Improve URL previews for sites with only Twitter card information. (#13056)Patrick Cloke2022-06-161-17/+95
| | | | | | | | | | | | Pull out `twitter:` meta tags when generating a preview and use it to augment any `og:` meta tags. Prefers Open Graph information over Twitter card information.
* | Reduce the duplication of code that invokes the rate limiter. (#13070)reivilibre2022-06-161-27/+3
| |
* | Add custom well-known (#13035)Jacek Kuśnierz2022-06-162-1/+28
| | | | | | Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Move some event auth checks out to a different method (#13065)Richard van der Hoff2022-06-155-44/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add auth events to events used in tests * Move some event auth checks out to a different method Some of the event auth checks apply to an event's auth_events, rather than the state at the event - which means they can play no part in state resolution. Move them out to a separate method. * Rename check_auth_rules_for_event Now it only checks the state-dependent auth rules, it needs a better name.
* | Change default `sync_response_cache_duration` (#13042)Erik Johnston2022-06-151-1/+1
| |
* | Replace pyjwt with authlib in `org.matrix.login.jwt` (#13011)Hannes Lerchl2022-06-152-13/+43
| |
* | Type annotations in `synapse.databases.main.devices` (#13025)David Robertson2022-06-153-20/+35
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Speed up `get_unread_event_push_actions_by_room` (#13005)Erik Johnston2022-06-1510-135/+276
| | | | | | | | | | | | | | | | | | | | | | Fixes #11887 hopefully. The core change here is that `event_push_summary` now holds a summary of counts up until a much more recent point, meaning that the range of rows we need to count in `event_push_actions` is much smaller. This needs two major changes: 1. When we get a receipt we need to recalculate `event_push_summary` rather than just delete it 2. The logic for deleting `event_push_actions` is now divorced from calculating `event_push_summary`. In future it would be good to calculate `event_push_summary` while we persist a new event (it should just be a case of adding one to the relevant rows in `event_push_summary`), as that will further simplify the get counts logic and remove the need for us to periodically update `event_push_summary` in a background job.
* | Track a histogram of state res durations (#13036)David Robertson2022-06-151-0/+12
| |
* | Fix a long-standing bug which meant that rate limiting was not restrictive ↵reivilibre2022-06-151-1/+4
| | | | | | | | enough in some cases. (#13018)
* | Don't use keyword arguments when initialising modules (#13060)Brendan Abolivier2022-06-151-1/+1
| |
* | Clean up schema for `event_edges` (#12893)Richard van der Hoff2022-06-156-11/+215
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove redundant references to `event_edges.room_id` We don't need to care about the room_id here, because we are already checking the event id. * Clean up the event_edges table We make a number of changes to `event_edges`: * We give the `room_id` and `is_state` columns defaults (null and false respectively) so that we can stop populating them. * We drop any rows that have `is_state` set true - they should no longer exist. * We drop any rows that do not exist in `events` - these should not exist either. * We drop the old unique constraint on all the colums, which wasn't much use. * We create a new unique index on `(event_id, prev_event_id)`. * We add a foreign key constraint to `events`. These happen rather differently depending on whether we are on Postgres or SQLite. For SQLite, we just rebuild the whole table, copying only the rows we want to keep. For Postgres, we try to do things in the background as much as possible. * Stop populating `event_edges.room_id` and `is_state` We can just rely on the defaults.
* | Refactor entry points so that they all have a `main` function. (#13052)reivilibre2022-06-1410-10/+60
| |
* | Fix `destination_is` errors seen in sentry. (#13041)David Robertson2022-06-143-7/+23
| | | | | | | | | | | | * Rename test_fedclient to match its source file * Require at least one destination to be truthy * Explicitly validate user ID in profile endpoint GETs Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Remove code generating comments in configuration file (#12941)Shay2022-06-1438-2873/+53
| |
* | Rename delta to apply in the proper schema version. (#13050)Patrick Cloke2022-06-141-0/+0
| |
* | Move the "email unsubscribe" resource, refactor the macaroon generator & ↵Quentin Gliech2022-06-1410-424/+454
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | simplify the access token verification logic. (#12986) This simplifies the access token verification logic by removing the `rights` parameter which was only ever used for the unsubscribe link in email notifications. The latter has been moved under the `/_synapse` namespace, since it is not a standard API. This also makes the email verification link more secure, by embedding the app_id and pushkey in the macaroon and verifying it. This prevents the user from tampering the query parameters of that unsubscribe link. Macaroon generation is refactored: - Centralised all macaroon generation and verification logic to the `MacaroonGenerator` - Moved to `synapse.utils` - Changed the constructor to require only a `Clock`, hostname, and a secret key (instead of a full `Homeserver`). - Added tests for all methods.
* | Decouple `synapse.api.auth_blocking.AuthBlocking` from ↵Quentin Gliech2022-06-148-24/+18
| | | | | | | | `synapse.api.auth.Auth`. (#13021)
* | Uniformize spam-checker API, part 4: port other spam-checker callbacks to ↵David Teller2022-06-138-121/+258
| | | | | | | | | | return `Union[Allow, Codes]`. (#12857) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Replace noop background updates with DELETE. (#12954)Patrick Cloke2022-06-1312-118/+61
| | | | | | | | Removes the `register_noop_background_update` and deletes the background updates directly in a delta file.
* | Merge branch 'rav/simplify_event_auth_interface' into developRichard van der Hoff2022-06-139-73/+36
|\ \
| * | Remove redundant `room_version` param from `check_auth_rules_from_context`Richard van der Hoff2022-06-124-35/+8
| | | | | | | | | | | | It's now implied by the room_version property on the event.
| * | Remove `room_version` param from `check_auth_rules_for_event`Richard van der Hoff2022-06-125-24/+14
| | | | | | | | | | | | | | | | | | | | | Instead, use the `room_version` property of the event we're checking. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
| * | Remove `room_version` param from `validate_event_for_room_version`Richard van der Hoff2022-06-126-14/+14
| |/ | | | | | | | | | | | | Instead, use the `room_version` property of the event we're validating. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
* | Stop depending on `room_id` to be returned for children state in the ↵Patrick Cloke2022-06-101-4/+0
| | | | | | | | | | | | | | | | | | | | | | hierarchy response. (#12991) The `room_id` field was removed from MSC2946 before it was accepted. It was initially kept for backwards compatibility and should be removed now that the stable form of the API is used. This change only stops Synapse from validating that it is returned, a future PR will remove returning it as part of the response.
* | Faster joins: add issue links to the TODOs (#13004)Richard van der Hoff2022-06-098-2/+26
| | | | | | | | ... to help us keep track of these things
* | Type annotations for `test_v2` (#12985)David Robertson2022-06-091-15/+42
| |
* | Use READ COMMITTED isolation level when inserting read receipts (#12957)Nick Mills-Barrett2022-06-091-0/+5
| |
* | Move the (unstable) `dir` parameter for /relations behind an experimental ↵Patrick Cloke2022-06-082-3/+13
| | | | | | | | | | | | flag. (#12984) MSC3715 defines this parameter, but the unstable version of it should be behind an experimental flag.
* | Use dummy fallback engines if imports fail (#12979)David Robertson2022-06-074-21/+46
| |
* | Return the same error message from `/login` when password is incorrect and ↵Daniel Aloni2022-06-071-2/+6
| | | | | | | | when account doesn't exist. (#12738)
* | Fix Synapse git info missing in version strings (#12973)David Robertson2022-06-0712-32/+29
| |
* | Reduce amount of state we pull out when attempting to send catchup PDUs. ↵Erik Johnston2022-06-071-11/+20
| | | | | | | | | | | | | | | | | | (#12963) * Don't pull out state for catchup * Newsfile * Merge newsfile
* | Fix a stale comment in get_room_version_id_txn. (#12969)Patrick Cloke2022-06-071-6/+1
| |
* | Consolidate the logic of delete_device/delete_devices. (#12970)Patrick Cloke2022-06-076-46/+9
|/ | | | | | | | By always using delete_devices and sometimes passing a list with a single device ID. Previously these methods had gotten out of sync with each other and it seems there's little benefit to the single-device variant.
* Prevent breaking old sqlite's when media retention is enabled (#12977)Andrew Morgan2022-06-071-1/+1
|
* Prevent local quarantined media from being claimed by media retention (#12972)Andrew Morgan2022-06-073-16/+82
|
* Remove remaining pieces of groups code. (#12966)Patrick Cloke2022-06-066-207/+5
| | | | | * Remove an unused stream ID generator. * Remove the now unused remote profile cache.
* Reduce state pulled from DB due to sending typing and receipts over ↵Erik Johnston2022-06-066-7/+56
| | | | | federation (#12964) Reducing the amount of state we pull from the DB is useful as fetching state is expensive in terms of DB, CPU and memory.
* Do not break URL previews if an image is unreachable. (#12950)Patrick Cloke2022-06-061-6/+17
| | | | Avoid breaking a URL preview completely if the chosen image 404s or is unreachable for some other reason (e.g. DNS).
* Implement MSC3816, consider the root event for thread participation. (#12766)Patrick Cloke2022-06-061-21/+37
| | | | As opposed to only considering a user to have "participated" if they replied to the thread.
* Allow updating passwords using the admin api without logging out devices ↵Jan Christian Grünhage2022-06-061-1/+7
| | | | (#12952)
* Reduce the amount of state we pull from the DB (#12811)Erik Johnston2022-06-0617-130/+133
|
* Remove groups code from synapse_port_db. (#12899)Patrick Cloke2022-06-032-15/+17
|
* Improve URL previews for some pages (#12951)Patrick Cloke2022-06-031-17/+35
| | | | | * Skip `og` and `meta` tags where the value is empty. * Fallback to the favicon if there are no other images. * Ignore tags meant for navigation.
* Wait for lazy join to complete when getting current state (#12872)Erik Johnston2022-06-0127-75/+288
|
* Remove remaining bits of groups code. (#12936)Patrick Cloke2022-06-015-9/+0
| | | | | | * Update worker docs to remove group endpoints. * Removes an unused parameter to `ApplicationService`. * Break dependency between media repo and groups. * Avoid copying `m.room.related_groups` state events during room upgrades.
* Fix 404 on `/sync` when the last event is a redaction of an unknown/purged ↵Richard van der Hoff2022-06-015-65/+128
| | | | | | | | | | | event (#12905) Currently, we try to pull the event corresponding to a sync token from the database. However, when we fetch redaction events, we check the target of that redaction (because we aren't allowed to send redactions to clients without validating them). So, if the sync token points to a redaction of an event that we don't have, we have a problem. It turns out we don't really need that event, and can just work with its ID and metadata, which sidesteps the whole problem.
* Fix potential thumbnail memory leaks. (#12932)Erik Johnston2022-06-012-135/+201
|
generated by cgit-magenta 1.5.1 (git 2.48.1) at 2025-08-10 08:27:47 +0000