summary refs log tree commit diff
path: root/synapse (unfollow)
Commit message (Collapse)AuthorFilesLines
2019-12-16Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff1-1/+1
(#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
2019-12-16Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff3-165/+83
The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
2019-12-16sanity-checking for events used in state res (#6531)Richard van der Hoff6-43/+128
When we perform state resolution, check that all of the events involved are in the right room.
2019-12-16Sanity-check room ids in event auth (#6530)Richard van der Hoff2-0/+14
When we do an event auth operation, check that all of the events involved are in the right room.
2019-12-16Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2-24/+56
When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
2019-12-16Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2-18/+22
Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
2019-12-16Move get_state methods into FederationHandler (#6503)Richard van der Hoff3-86/+107
This is a non-functional refactor as a precursor to some other work.
2019-12-16Refactor get_events_from_store_or_dest to return a dict (#6501)Richard van der Hoff2-29/+16
There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.