summary refs log tree commit diff
path: root/synapse (unfollow)
Commit message (Collapse)AuthorFilesLines
2022-10-13Properly return the thread ID down sync. (#14159)Patrick Cloke1-2/+2
Fix a broken conflict in e6e876b9b158f47811b6dfedd8783f658ce960a4, by not stomping over a field right after creating it.
2022-10-13Add an API for listing threads in a room. (#13394)Patrick Cloke10-6/+522
Implement the /threads endpoint from MSC3856. This is currently unstable and behind an experimental configuration flag. It includes a background update to backfill data, results from the /threads endpoint will be partial until that finishes.
2022-10-12Fix a bug where the joined hosts for a given event were not being properly ↵Shay3-45/+51
cached (#14125)
2022-10-12Return the thread ID properly down sync. (#14159)Patrick Cloke2-0/+3
A receipt's thread ID, if one exists, should be added to the body of a receipt.
2022-10-12Return the main timeline for events which are not part of a thread. (#14140)Patrick Cloke3-6/+9
Fixes a bug where threaded receipts could not be sent for the main timeline.
2022-10-12Bump typing-extensions from 4.1.1 to 4.4.0 (#14134)dependabot[bot]2-5/+6
2022-10-12Correct field name for stripped state events when knocking. ↵Andrew Morgan4-6/+26
`knock_state_events` -> `knock_room_state` (#14102)
2022-10-12Bump bleach from 4.1.0 to 5.0.1 (#14116)dependabot[bot]2-5/+9
2022-10-12Bump idna from 3.3 to 3.4 (#14115)dependabot[bot]2-3/+4
2022-10-12Mark /relations endpoint as usable on workers. (#14028)Patrick Cloke6-2/+37
Co-authored-by: Eric Eastwood <erice@element.io>
2022-10-12Batch up calls to `get_rooms_for_users` (#14109)Nick Mills-Barrett2-1/+17
2022-10-12Remove the experimental implementation of MSC3772. (#14094)Patrick Cloke12-365/+22
MSC3772 has been abandoned.
2022-10-12Use minimal Rust installation in docker images and CI (#14141)David Robertson5-3/+5
2022-10-11Fix a bug where redactions were not being sent over federation if we did not ↵Shay6-38/+62
have the original event. (#13813)
2022-10-11Handle `gottestfmt` repository move (#14144)David Robertson3-2/+3
2022-10-11Remove the groups config code. (#14142)Patrick Cloke2-27/+1
This has been unused for a long time, but missed removal in #11584.
2022-10-11Making parse_server_name more consistent (#14007)Abdullah Osama3-2/+6
Fixes #12122
2022-10-11Enable dependabot for Rust dependencies (#14132)Erik Johnston3-28/+34
2022-10-10Fix name of "alias_creation_rules" option in config manual (#14124)Andrew Morgan2-2/+3
2022-10-10Bump types-psycopg2 from 2.9.9 to 2.9.21.1 (#14114)dependabot[bot]2-3/+4
* Bump types-psycopg2 from 2.9.9 to 2.9.21.1 Bumps [types-psycopg2](https://github.com/python/typeshed) from 2.9.9 to 2.9.21.1. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-psycopg2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-10Bump types-pillow from 9.0.15 to 9.2.2 (#14113)dependabot[bot]2-5/+6
* Bump types-pillow from 9.0.15 to 9.2.2 Bumps [types-pillow](https://github.com/python/typeshed) from 9.0.15 to 9.2.2. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pillow dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-07Indicate what endpoint came back with a JSON response we were unable to ↵Eric Eastwood3-2/+12
parse (#14097) **Before:** ``` WARNING - POST-11 - Unable to parse JSON: Expecting value: line 1 column 1 (char 0) (b'') ``` **After:** ``` WARNING - POST-11 - Unable to parse JSON from POST /_matrix/client/v3/join/%21ZlmJtelqFroDRJYZaq:hs1?server_name=hs1 response: Expecting value: line 1 column 1 (char 0) (b'') ``` --- It's possible to figure out which endpoint these warnings were coming from before but you had to follow the request ID `POST-11` to the log line that says `Completed request [...]`. Including this key information next to the JSON parsing error makes it much easier to reason whether it matters or not. ``` 2022-09-29T08:23:25.7875506Z synapse_main | 2022-09-29 08:21:10,336 - synapse.http.matrixfederationclient - 299 - INFO - POST-11 - {GET-O-13} [hs1] Completed request: 200 OK in 0.53 secs, got 450 bytes - GET matrix://hs1/_matrix/federation/v1/make_join/%21ohtKoQiXlPePSycXwp%3Ahs1/%40charlie%3Ahs2?ver=1&ver=2&ver=3&ver=4&ver=5&ver=6&ver=org.matrix.msc2176&ver=7&ver=8&ver=9&ver=org.matrix.msc3787&ver=10&ver=org.matrix.msc2716v4 ``` --- As a note, having no `body` is normal for the `/join` endpoint and it can handle it. https://github.com/matrix-org/synapse/blob/0c853e09709d52783efd37060ed9e8f55a4fc704/synapse/rest/client/room.py#L398-L403 Alternatively we could remove these extra logs but they are probably more usually helpful to figure out what went wrong.
2022-10-07Remove support for the unstable dir flag on relations. (#14106)Patrick Cloke5-57/+31
From MSC3715, this was unused by clients (and there was no way for clients to know it was supported). Matrix 1.4 defines the stable field.
2022-10-07Apply & bundle edits for non-message events. (#14034)Patrick Cloke2-7/+5
Fixes two related bugs: * No edit information was bundled for events which aren't `m.room.message`. * `m.new_content` was not applied for those events.
2022-10-07Document Google OpenID Connect email attribute (#14081)Paul Tötterman2-1/+3
2022-10-07Parse SYNAPSE_ASYNC_IO_REACTOR env variable & log the reactor on startup ↵Quentin Gliech3-14/+16
(#14092)
2022-10-07Bump phonenumbers from 8.12.44 to 8.12.56 (#14043)dependabot[bot]2-3/+4
* Bump phonenumbers from 8.12.44 to 8.12.56 Bumps [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers) from 8.12.44 to 8.12.56. - [Release notes](https://github.com/daviddrysdale/python-phonenumbers/releases) - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.12.44...v8.12.56) --- updated-dependencies: - dependency-name: phonenumbers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
2022-10-07Bump pydantic from 1.9.1 to 1.10.2 (#14044)dependabot[bot]2-38/+40
* Bump pydantic from 1.9.1 to 1.10.2 Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.9.1 to 1.10.2. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](https://github.com/pydantic/pydantic/compare/v1.9.1...v1.10.2) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
2022-10-07Bump msgpack from 1.0.3 to 1.0.4 (#14040)dependabot[bot]2-36/+55
* Bump msgpack from 1.0.3 to 1.0.4 Bumps [msgpack](https://github.com/msgpack/msgpack-python) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/msgpack/msgpack-python/releases) - [Changelog](https://github.com/msgpack/msgpack-python/blob/main/ChangeLog.rst) - [Commits](https://github.com/msgpack/msgpack-python/compare/v1.0.3...v1.0.4) --- updated-dependencies: - dependency-name: msgpack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
2022-10-07Improve the listener example on the metrics documentation (#14078)Dirk Klimpel2-12/+30
Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
2022-10-07Be more lenient in the oEmbed response parsing. (#14089)Patrick Cloke3-51/+160
Attempt to parse any valid information from an oEmbed response (instead of bailing at the first unexpected data). This should allow for more partial oEmbed data to be returned, resulting in better / more URL previews, even if those URL previews are only partial.
2022-10-07Use stable identifiers for MSC3771 & MSC3773. (#14050)Patrick Cloke12-52/+49
These are both part of Matrix 1.4 which has now been released. For now, support both the unstable and stable identifiers.
2022-10-07Add sample worker files for `pusher` and `federation_sender` (#14077)Dirk Klimpel4-0/+29
Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
2022-10-07Use Pydantic to validate /devices endpoints (#14054)David Robertson2-46/+53
2022-10-07Catch BrokenPipeError from metrics server, and log as a warning (#14072)David Robertson2-6/+13
2022-10-07Update frozendict 2.3.3 -> 2.3.4 (#13955)David Robertson2-18/+19
* Update frozendict 2.3.3 -> 2.3.4 This claims to fix more memory leaks. Could have automated this upgrade with #11828 if we wanted. * Changelog
2022-10-06Fix broken links to README (#14093)David Robertson3-2/+3
2022-10-06Always close _all_ `ijson` coroutines, even if doing so raises Exceptions ↵David Robertson4-5/+76
(#14065)
2022-10-06The changelog entry ending in a `.` or `!` is not optional (#14087)Andre Klärner2-1/+2
2022-10-06Update 1.69.0rc2 changelog v1.69.0rc2Sean Quah1-2/+2
2022-10-06Replace incorrect 1.69.0rc3 version with 1.69.0rc2Sean Quah1-1/+1
2022-10-061.69.0rc3Sean Quah5-5/+10
2022-10-06Fix sending events into rooms with non-integer power levels (#14073)David Robertson4-1/+86
2022-10-06Pin build-system requirements (#14080)David Robertson2-1/+2
* Pin build-system requirements * Changelog
2022-10-06Deprecate the `generate_short_term_login_token` method in favor of an async ↵Quentin Gliech3-0/+76
`create_login_token` method in the Module API. (#13842) Signed-off-by: Quentin Gliech <quenting@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-10-061.69.0rc2Sean Quah4-4/+17
2022-10-06openid.md: fix a typo in the facebook exampleRichard van der Hoff1-1/+1
2022-10-05Batch up notifications after event persistence (#14033)Shay5-58/+66
2022-10-05Complement test image: capture logs from nginx (#14063)Richard van der Hoff2-1/+6
Have nginx send its logs to stderr/out, so that we can debug https://github.com/matrix-org/synapse/issues/13334.
2022-10-05Fix handling of public rooms filter with a network tuple. (#14053)Patrick Cloke3-27/+58
Fixes two related bugs: * The handling of `[null]` for a `room_types` filter was incorrect. * The ordering of arguments when providing both a network tuple and room type field was incorrect.
2022-10-05Fix backwards compatibility with upcoming threads schema changes. (#14045)Patrick Cloke2-11/+24
Ensure that the upsert will work properly by first updating any existing rows (in the same way that the background update to backfill data works).
2022-10-04Use threaded receipts when fetching events for push. (#13878)Patrick Cloke3-41/+97
Update the HTTP and email pushers to consider threaded read receipts when fetching unread events.
2022-10-04Bump types-pyyaml from 6.0.4 to 6.0.12 (#14041)dependabot[bot]2-5/+6
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-04Remove get rooms for user with stream ordering (#13991)Nick Mills-Barrett2-80/+70
By getting the joined rooms before the current token we avoid any reading history to confirm a user *was* in a room. We can then use any membership change events, which we already fetch during sync, to determine the final list of joined room IDs.
2022-10-04Recursively fetch the thread for receipts & notifications. (#13824)Patrick Cloke5-2/+162
Consider an event to be part of a thread if you can follow a chain of relations up to a thread root. Part of MSC3773 & MSC3771.
2022-10-04update authlib from 0.15.5 to 1.1.0 (#14006)ffaex2-10/+8
Signed-off-by: Fyodor Fomichev <fyodor.fomichev@gmail.com>
2022-10-04Mark events as read using threaded read receipts from MSC3771. (#13877)Patrick Cloke5-62/+504
Applies the proper logic for unthreaded and threaded receipts to either apply to all events in the room or only events in the same thread, respectively.
2022-10-04Advertise supporting version 1.3 of the Matrix spec. (#14032)Patrick Cloke2-0/+2
Now that all features / changes in 1.3 are supported in Synapse.
2022-10-04Fix building wheels on OSX (#14046)David Robertson2-0/+5
* Fix building wheels on OSX Follow-up to #13983. I missed a breaking change in setup-python v4. Serves me right for rushing to cut through the dependabot spam. * Changelog * Merge changelog
2022-10-04Track notification counts per thread (implement MSC3773). (#13776)Patrick Cloke17-93/+514
When retrieving counts of notifications segment the results based on the thread ID, but choose whether to return them as individual threads or as a single summed field by letting the client opt-in via a sync flag. The summarization code is also updated to be per thread, instead of per room.
2022-10-04Bump isort from 5.7.0 to 5.10.1 (#13988)dependabot[bot]3-6/+8
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-04Update changelog v1.69.0rc1Sean Quah1-20/+18
2022-10-04Bump jsonschema from 4.4.0 to 4.16.0 (#13985)dependabot[bot]2-4/+18
* Bump jsonschema from 4.4.0 to 4.16.0 Bumps [jsonschema](https://github.com/python-jsonschema/jsonschema) from 4.4.0 to 4.16.0. - [Release notes](https://github.com/python-jsonschema/jsonschema/releases) - [Changelog](https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst) - [Commits](https://github.com/python-jsonschema/jsonschema/compare/v4.4.0...v4.16.0) --- updated-dependencies: - dependency-name: jsonschema dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-04Bump types-pyopenssl from 22.0.0 to 22.0.10 (#13984)dependabot[bot]2-5/+6
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-04Bump actions/setup-python from 2 to 4 (#13983)dependabot[bot]4-8/+9
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-04Bump types-requests from 2.27.11 to 2.28.11 (#13987)dependabot[bot]2-3/+4
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-04Bump types-setuptools from 57.4.9 to 65.4.0.0 (#13986)dependabot[bot]2-28/+11
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-10-04Disable pushing for server ACL events (MSC3786). (#13997)Patrick Cloke6-25/+5
Switches to the stable identifier for MSC3786 and enables it by default. This disables pushes of m.room.server_acl events.
2022-10-04Send the appservice access token as a header. (#13996)Patrick Cloke3-6/+26
Implements MSC2832 by sending application service access tokens in the Authorization header. The access token is also still sent as a query parameter until the application service ecosystem has fully migrated to using headers. In the future this could be made opt-in, or removed completely.
2022-10-041.69.0rc1Sean Quah102-102/+111
2022-10-04Linkify config documentation. (#14003)Akshit Tyagi2-5/+8
2022-10-03Track when the pulled event signature fails (#13815)Eric Eastwood5-15/+140
Because we're doing the recording in `_check_sigs_and_hash_for_pulled_events_and_fetch` (previously named `_check_sigs_and_hash_and_fetch`), this means we will track signature failures for `backfill`, `get_room_state`, `get_event_auth`, and `get_missing_events` (all pulled event scenarios). And we also record signature failures from `get_pdu`. Part of https://github.com/matrix-org/synapse/issues/13700 Part of https://github.com/matrix-org/synapse/issues/13676 and https://github.com/matrix-org/synapse/issues/13356 This PR will be especially important for https://github.com/matrix-org/synapse/pull/13816 so we can avoid the costly `_get_state_ids_after_missing_prev_event` down the line when `/messages` calls backfill.
2022-10-03Dependabot changelog: don't require a changelog in lintsDavid Robertson2-16/+7
2022-10-03Bump actions/upload-artifact from 2 to 3 (#14023)dependabot[bot]5-5/+6
* Bump actions/upload-artifact from 2 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-03Dependabot changelog: try using branch nameDavid Robertson1-2/+2
Gonna hope this doesn't use the merge ref and is good enough
2022-10-03Clear out old rows from `event_push_actions_staging` (#14020)Erik Johnston5-1/+105
On matrix.org we have ~5 million stale rows in `event_push_actions_staging`, let's add a background job to make sure we clear them out.
2022-10-03Announce that legacy metric names are deprecated, will be turned off by ↵reivilibre5-27/+64
default in Synapse v1.71.0 and removed altogether in Synapse v1.73.0. (#14024)
2022-10-03Bump actions/cache from 2 to 3 (#13980)dependabot[bot]2-1/+2
* Bump actions/cache from 2 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-03Dependabot changelog: allow dependabot to trigger actionsDavid Robertson1-0/+3
2022-10-03Bump actions/download-artifact from 2 to 3 (#13979)dependabot[bot]2-1/+2
* Bump actions/download-artifact from 2 to 3 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-03Do not return unspecced original_event field when using the stable ↵Patrick Cloke4-17/+28
/relations endpoint. (#14025) Keep the old behavior (of including the original_event field) for any requests to the /unstable version of the endpoint, but do not include the field when the /v1 version is used. This should avoid new clients from depending on this field, but will not help with current dependencies.
2022-10-03Bump docker/login-action from 1 to 2 (#13978)dependabot[bot]2-1/+2
* Bump docker/login-action from 1 to 2 Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](https://github.com/docker/login-action/compare/v1...v2) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2022-10-03Dependabot changelog: pass GITHUB_TOKEN to ghDavid Robertson1-0/+2
2022-10-03Dependabot changelogs: trigger CI explicitly (#14027)David Robertson4-4/+22
* Dependabot changelogs: trigger CI explicitly * Changelog * Use merge ref, not head ref ref ref ref ref ref * explanatory note
2022-10-03Bump docker/build-push-action from 2 to 3 (#14022)dependabot[bot]2-1/+2
* Bump docker/build-push-action from 2 to 3 Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2 to 3. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/v2...v3) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
2022-10-03More WIP dependabot changelog CIDavid Robertson1-1/+2
Fixes a typo in #14021, and allows the workflow to trigger on `reopen` for easier debugging.
2022-10-03Bump docker/setup-qemu-action from 1 to 2 (#14019)dependabot[bot]2-1/+2
* Bump docker/setup-qemu-action from 1 to 2 Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](https://github.com/docker/setup-qemu-action/compare/v1...v2) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
2022-10-03yet another attempt to make dependabot changelogs work (#14021)David Robertson2-0/+6
* yet another attempt to make dependabot changelogs work * Changelog
2022-10-03Bump docker/setup-buildx-action from 1 to 2 (#14015)dependabot[bot]3-2/+3
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
2022-10-03Fix bug where we didn't delete staging push actions (#14014)Erik Johnston2-1/+2
Introduced in #13719
2022-10-03Try again to automate dependabot changelogs (#14017)David Robertson2-0/+7
* Try again to automate dependabot changelogs * Changelog
2022-10-03Add query parameter `ts` to allow appservices set the `origin_server_ts` for ↵lukasdenk4-15/+152
state events. (#11866) MSC3316 declares that both /rooms/{roomId}/send and /rooms/{roomId}/state should accept a ts parameter for appservices. This change expands support to /state and adds tests.
2022-10-03Fix twisted trunk mypy errors (#14012)David Robertson3-0/+7
2022-10-03Bump actions/checkout from 2 to 3 (#13982)dependabot[bot]6-32/+33
* Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
2022-10-03Add cache to `get_partial_state_servers_at_join` (#14013)Erik Johnston2-0/+8
2022-10-03Refactor `_get_e2e_device_keys_txn` to split large queries (#13956)Sean Quah3-29/+115
Instead of running a single large query, run a single query for user-only lookups and additional queries for batches of user device lookups. Resolves #13580. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-10-03Change dependabot CL suffix (#14011)David Robertson2-1/+2
* Change dependabot CL suffix * Changelog
2022-10-03Protoype automatic changelogs for dependabot PRs (#13998)David Robertson2-0/+24
2022-10-03Always build Rust extension in release mode (#14009)Erik Johnston2-0/+4
Fixes #13990
2022-10-03Revert the general exception recording introduced in #13814 (#13969)Eric Eastwood2-10/+1
* Maybe not catch all errors to avoid things in the nature-of CancelledError See https://github.com/matrix-org/synapse/pull/13815#discussion_r983384698 * Remove general exception tracking * Add changelog
2022-09-30Fix `get_users_in_room` mis-use in `transfer_room_state_on_room_upgrade` ↵Eric Eastwood2-2/+3
(#13960) Spawning from looking into `get_users_in_room` while investigating https://github.com/matrix-org/synapse/issues/13942#issuecomment-1262787050. See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 for the original exploration around finding `get_users_in_room` mis-uses. Related to the following PRs where we also cleaned up some `get_users_in_room` mis-uses: - https://github.com/matrix-org/synapse/pull/13605 - https://github.com/matrix-org/synapse/pull/13608 - https://github.com/matrix-org/synapse/pull/13606 - https://github.com/matrix-org/synapse/pull/13958
2022-09-30Clarifications in user directory for users who share rooms tracking (#13966)Eric Eastwood2-12/+25
Spawned while working on [`get_users_in_room` mis-uses](https://github.com/matrix-org/synapse/pull/13958#discussion_r984074897) and thinking we could use `get_local_users_in_room` here but we can't. From first glance, it seemed like this was only using local users from all of the `is_mine_id(user_id)` checks but I see that it does actually use remote users. Just making things a little more clear here what it does and mentions remote users so maybe that will be more obvious in the future.
2022-09-30Skip filtering during push if there are no push actions (#13992)Erik Johnston4-2/+12
2022-09-30Update mypy and mypy-zope, attempt 3 (#13993)David Robertson11-68/+61
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-09-30Revert "Update mypy and mypy-zope (#13925)"David Robertson10-60/+67
This reverts commit 6d543d6d9f56e39199b7e460d0081b02d61f12be.
2022-09-30Update mypy and mypy-zope (#13925)David Robertson10-67/+60
* Update mypy and mypy-zope * Unignore assigning to LogRecord attributes Presumably https://github.com/python/typeshed/pull/8064 makes this ok Cherry-picked from #13521 * Remove unused ignores due to mypy ParamSpec fixes https://github.com/python/mypy/pull/12668 Cherry-picked from #13521 * Remove additional unused ignores * Fix new mypy complaints related to `assertGreater` Presumably due to https://github.com/python/typeshed/pull/8077 * Changelog * Reword changelog Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-09-30Enable dependabot updates (#13976)Richard van der Hoff2-0/+18
Fixes https://github.com/matrix-org/synapse/issues/11828
2022-09-30Speed up calculating push actions in large rooms (#13973)Erik Johnston3-12/+96
We move the expensive check of visibility to after calculating push actions, avoiding the expensive check for users who won't get pushed anyway. I think this should have a big impact on rooms with large numbers of local users that have pushed disabled.
2022-09-30Discourage automatic replies to Synapse's emails (#13957)David Robertson2-0/+14
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-09-30Add some cross references to worker documentation (#13974)Dirk Klimpel3-15/+28
Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
2022-09-30Fix performance regression in `get_users_in_room` (#13972)Erik Johnston5-70/+98
Fixes #13942. Introduced in #13575. Basically, let's only get the ordered set of hosts out of the DB if we need an ordered set of hosts. Since we split the function up the caching won't be as good, but I think it will still be fine as e.g. multiple backfill requests for the same room will hit the cache.
2022-09-30Fix overflows in /messages backfill calculation (#13936)David Robertson3-41/+103
* Reproduce bug * Compute `least_function` first * Substitute `least_function` with an f-string * Bugfix: avoid overflow Co-authored-by: Eric Eastwood <erice@element.io>
2022-09-30Add missing version information in the ModuleApi (#13947)Brendan Abolivier2-0/+5
2022-09-29Don't require `setuptools_rust` at runtime (#13952)David Robertson3-3/+35
2022-09-29Update UPSERT comment now that native upserts are the default (#13924)David Robertson2-10/+51
2022-09-29Implement push rule evaluation in Rust. (#13838)Erik Johnston14-403/+894
2022-09-29Optimise get_rooms_for_user (drop with_stream_ordering) (#13787)Nick Mills-Barrett7-75/+66
2022-09-29Allow admins to require a manual approval process before new accounts can be ↵Brendan Abolivier21-34/+731
used (using MSC3866) (#13556)
2022-09-29Explicit cast to enforce type hints. (#13939)Patrick Cloke2-4/+5
2022-09-29Expose MSC3882 only be under an unstable endpoint. (#13868)Hugh Nimmo-Smith3-8/+13
2022-09-29Clarify that a method returns only unthreaded receipts. (#13937)Patrick Cloke4-76/+47
By renaming it and updating the docstring. Additionally, refactors a method which is used only by tests.
2022-09-29Always send default and rule_id to clients (#13904)Nicolas Werner2-4/+3
2022-09-29Improve backfill robustness by trying more servers. (#13890)reivilibre2-2/+32
Co-authored-by: Eric Eastwood <erice@element.io>
2022-09-28Handle local device list updates during partial join (#13934)Erik Johnston4-15/+141
2022-09-28Limit and filter the number of backfill points to get from the database (#13879)Eric Eastwood4-82/+198
There is no need to grab thousands of backfill points when we only need 5 to make the `/backfill` request with. We need to grab a few extra in case the first few aren't visible in the history. Previously, we grabbed thousands of backfill points from the database, then sorted and filtered them in the app. Fetching the 4.6k backfill points for `#matrix:matrix.org` from the database takes ~50ms - ~570ms so it's not like this saves a lot of time 🤷. But it might save us more time now that `get_backfill_points_in_room`/`get_insertion_event_backward_extremities_in_room` are more complicated after https://github.com/matrix-org/synapse/pull/13635 This PR moves the filtering and limiting to the SQL query so we just have less data to work with in the first place. Part of https://github.com/matrix-org/synapse/issues/13356
2022-09-28Add upgrade notes for changes to receipts replication. (#13932)Patrick Cloke2-0/+13
2022-09-28Revert "Stop returning an unused column when handling new receipts. ↵Patrick Cloke2-3/+2
(#13933)" (#13935) This reverts commit 7766bd5b354cd4ea1a33351ba320e54a14d3aeac (#13933). The unused column is actually used, but much further down in the function.
2022-09-28Stop returning an unused column when handling new receipts. (#13933)Patrick Cloke2-2/+3
2022-09-28Document that the 'auto_join_rooms' option works with Spaces (#13931)Andrew Morgan2-2/+6
2022-09-28Correct default number of bcrypt hash rounds in .1 man page (#13930)Andrew Morgan2-1/+2
2022-09-28Handle remote device list updates during partial join (#13913)Erik Johnston6-0/+170
c.f. #12993 (comment), point 3 This stores all device list updates that we receive while partial joins are ongoing, and processes them once we have the full state. Note: We don't actually process the device lists in the same ways as if we weren't partially joined. Instead of updating the device list remote cache, we simply notify local users that a change in the remote user's devices has happened. I think this is safe as if the local user requests the keys for the remote user and we don't have them we'll simply fetch them as normal.
2022-09-28fix: Push notifications for invite over federation (#13719)Kateřina Churanová8-23/+42
2022-09-28Add instruction for running unit tests in parallel (#13928)Ashish Kumar2-0/+7
2022-09-28Persist CreateRoom events to DB in a batch (#13800)Shay12-339/+563
2022-09-28Prepatory work for batching events to send (#13487)Shay5-108/+290
This PR begins work on batching up events during the creation of a room. The PR splits out the creation and sending/persisting of the events. The first three events in the creation of the room-creating the room, joining the creator to the room, and the power levels event are sent sequentially, while the subsequent events are created and collected to be sent at the end of the function. This is currently done by appending them to a list and then iterating over the list to send, the next step (after this PR) would be to send and persist the collected events as a batch.
2022-09-27Fix `have_seen_event` cache not being invalidated (#13863)Eric Eastwood5-67/+165
Fix https://github.com/matrix-org/synapse/issues/13856 Fix https://github.com/matrix-org/synapse/issues/13865 > Discovered while trying to make Synapse fast enough for [this MSC2716 test for importing many batches](https://github.com/matrix-org/complement/pull/214#discussion_r741678240). As an example, disabling the `have_seen_event` cache saves 10 seconds for each `/messages` request in that MSC2716 Complement test because we're not making as many federation requests for `/state` (speeding up `have_seen_event` itself is related to https://github.com/matrix-org/synapse/issues/13625) > > But this will also make `/messages` faster in general so we can include it in the [faster `/messages` milestone](https://github.com/matrix-org/synapse/milestone/11). > > *-- https://github.com/matrix-org/synapse/issues/13856* ### The problem `_invalidate_caches_for_event` doesn't run in monolith mode which means we never even tried to clear the `have_seen_event` and other caches. And even in worker mode, it only runs on the workers, not the master (AFAICT). Additionally there was bug with the key being wrong so `_invalidate_caches_for_event` never invalidates the `have_seen_event` cache even when it does run. Because we were using the `@cachedList` wrong, it was putting items in the cache under keys like `((room_id, event_id),)` with a `set` in a `set` (ex. `(('!TnCIJPKzdQdUlIyXdQ:test', '$Iu0eqEBN7qcyF1S9B3oNB3I91v2o5YOgRNPwi_78s-k'),)`) and we we're trying to invalidate with just `(room_id, event_id)` which did nothing.
2022-09-27Emphasize the right reasons to use `(room_id, event_id)` in a schema (#13915)Eric Eastwood2-15/+17
* Emphasize the right reasons to use (room_id, event_id) Follow-up to: - https://github.com/matrix-org/synapse/pull/13701 - https://github.com/matrix-org/synapse/pull/13771
2022-09-27Add new columns tracking when we partial-joined (#13892)David Robertson4-3/+87
2022-09-27Support the stable dir parameter for /relations. (#13920)Patrick Cloke3-13/+18
Since MSC3715 has passed FCP, the stable parameter can be used. This currently falls back to the unstable parameter if the stable parameter is not provided (and MSC3715 support is enabled in the configuration).
2022-09-27Prioritize outbound to-device over device list updates (#13922)Erik Johnston2-13/+17
Otherwise device list changes for large accounts can temporarily delay to-device messages.
2022-09-27Update upgrade notes (#13923)David Robertson1-6/+23
* Update upgrade notes * Synapse Synapse Synapse Synapse Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2022-09-27Dockerfile for tests: align comments with current behavior (#13867)Mathieu Velten2-13/+10
Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-09-27Carry IdP Session IDs through user-mapping sessions. (#13839)Quentin Gliech2-0/+10
Since #11482, we're saving sessions IDs from upstream IdPs, but we've been losing them when the user goes through a user mapping session on account registration.
2022-09-27Handle the case of remote users leaving a partial join room for device lists ↵Erik Johnston7-107/+85
(#13885)
2022-09-27Clarify who isn't affected by rust v1.68.0David Robertson1-2/+6
2022-09-27s/Synapse v1/Synapse 1/gDavid Robertson1-18/+18
2022-09-27tweak upgrade notesDavid Robertson1-3/+5
2022-09-27typo fixesDavid Robertson1-3/+3
2022-09-27`SQLite earlier than` -> `SQLite older than`David Robertson1-1/+1
2022-09-271.68.0David Robertson4-7/+20
2022-09-27Faster room joins: Fix spurious error when joining a room (#13872)Sean Quah2-3/+20
During a `lazy_load_members` `/sync`, we look through auth events in rooms with partial state to find prior membership events. When such a membership is not found, an error is logged. Since the first join event for a user never has a prior membership event to cite, the error would always be logged when one appeared in the room timeline. Avoid logging errors for such events. Introduced in #13477. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-26Complement image: propagate SIGTERM to all workers (#13914)Richard van der Hoff2-2/+31
This should mean that logs from worker processes are flushed before shutdown. When a test completes, Complement stops the docker container, which means that synapse will receive a SIGTERM. Currently, the `complement_fork_starter` exits immediately (without notifying the worker processes), which means that the workers never get a chance to flush their logs before the whole container is vaped. We can fix this by propagating the SIGTERM to the children.
2022-09-26Improve tests for get_unread_push_actions_for_user_in_range_*. (#13893)Patrick Cloke3-30/+97
* Adds a docstring. * Reduces a small amount of duplicated code. * Improves tests.
2022-09-26Update the manpage documentation for the hash_password script (#13911)Andrew Morgan3-1/+9
2022-09-26Snapshot schema 72 (#13873)David Robertson13-22/+2165
Including another batch of fixes to the schema dump script
2022-09-26typing: check origin server of typing event against room's servers (#13830)Mathieu Velten3-2/+10
This is also using the partial state approximation if needed so we do not block here during a fast join. Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
2022-09-26Simplify cache invalidation after event persist txn (#13796)Nick Mills-Barrett4-119/+52
This moves all the invalidations into a single place and de-duplicates the code involved in invalidating caches for a given event by using the base class method.
2022-09-26Update NixOS module URL (#13818)enterprisey2-1/+2
* Update NixOS module URL * Create 13818.doc
2022-09-26Correctly add Cargo.lock to sdsit (#13909)Erik Johnston2-1/+2
2022-09-26Correctly add Cargo.lock to sdsit (#13909)Erik Johnston2-1/+2
2022-09-26Fix mypy errors with latest canonicaljson (#13905)David Robertson3-6/+8
* Lockfile: update canonicaljson 1.6.0 -> 1.6.3 * Fix mypy errors with latest canonicaljson The change to `_encode_json_bytes` definition wasn't sufficient: ``` synapse/http/server.py:751: error: Incompatible types in assignment (expression has type "Callable[[Arg(object, 'json_object')], bytes]", variable has type "Callable[[Arg(object, 'data')], bytes]") [assignment] ``` Which I think is mypy warning us that the two functions accept different sets of kwargs. Fair enough! * Changelog
2022-09-23Only try to backfill event if we haven't tried before recently (#13635)Eric Eastwood4-48/+626
Only try to backfill event if we haven't tried before recently (exponential backoff). No need to keep trying the same backfill point that fails over and over. Fix https://github.com/matrix-org/synapse/issues/13622 Fix https://github.com/matrix-org/synapse/issues/8451 Follow-up to https://github.com/matrix-org/synapse/pull/13589 Part of https://github.com/matrix-org/synapse/issues/13356
2022-09-23Faster room joins: Avoid blocking `/keys/changes` (#13888)Sean Quah3-3/+12
Part of the work for #12993. Once #12993 is fully resolved, we expect `/keys/changes` to behave sensibly when joined to a room with partial state. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-23Fix access token leak to logs from proxyagent (#13855)Eric Eastwood2-1/+7
This can happen specifically with an application service `/transactions/10722?access_token=leaked` request Fix https://github.com/matrix-org/synapse/issues/13010 --- Saw an example leak in https://github.com/matrix-org/synapse/issues/13423#issuecomment-1205348482 ``` 2022-08-04 14:47:57,925 - synapse.http.client - 401 - DEBUG - as-sender-signal-1 - Sending request PUT http://localhost:29328/transactions/10722?access_token=<redacted> 2022-08-04 14:47:57,926 - synapse.http.proxyagent - 223 - DEBUG - as-sender-signal-1 - Requesting b'http://localhost:29328/transactions/10722?access_token=leaked' via <HostnameEndpoint localhost:29328> ```
2022-09-23Update Cargo.lock file. (#13889)Patrick Cloke2-10/+153
2022-09-23Accept & store thread IDs for receipts (implement MSC3771). (#13782)Patrick Cloke17-41/+173
Updates the `/receipts` endpoint and receipt EDU handler to parse a `thread_id` from the body and insert it in the database.
2022-09-23Send device list updates out to servers in partially joined rooms (#13874)Sean Quah4-2/+66
Use the provided list of servers in the room from the `/send_join` response, since we will not know which users are in the room. This isn't sufficient to ensure that all remote servers receive the right device list updates, since the `/send_join` response may be inaccurate or we may calculate the membership state of new users in the room incorrectly. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-23Faster Remote Room Joins: tell remote homeservers that we are unable to ↵reivilibre11-42/+58
authorise them if they query a room which has partial state on our server. (#13823)
2022-09-23Add comments to the Prometheus recording rules to make it clear which set of ↵reivilibre2-7/+19
rules you need for Grafana or Prometheus Console. (#13876)
2022-09-23Move warnings up v1.68.0rc2Erik Johnston1-7/+7
2022-09-231.68.0rc2Erik Johnston7-5/+24
2022-09-22Raise issue if complement fails with latest deps (#13859)David Robertson2-1/+3
2022-09-22Fix the cross-link from register admin API to config docs. (#13870)Patrick Cloke2-1/+2
2022-09-22Properly paginate forward in the /relations API. (#13840)Patrick Cloke4-14/+60
This fixes a bug where the `/relations` API with `dir=f` would skip the first item of each page (except the first page), causing incomplete data to be returned to the client.
2022-09-22Fix sdist to include rust build script (#13866)Erik Johnston2-0/+2
* Fix sdist to include rust build script Fixes #13851 * Newsfile
2022-09-21Last batch of Pydantic for synapse/rest/client/account.py (#13832)David Robertson2-6/+14
* Validation for `/add_threepid/msisdn/submit_token` * Don't validate deprecated endpoint * Changelog
2022-09-21Add version flag for MSC3881 (#13860)Brendan Abolivier2-0/+3
2022-09-21Track device IDs for pushers (#13831)Brendan Abolivier7-10/+154
Second half of the MSC3881 implementation
2022-09-21Implementation of MSC3882 login token request (#13722)Hugh Nimmo-Smith6-0/+238
2022-09-21Add `worker_main_http_uri` to the contrib bash script (#13772)villepeh2-1/+4
* Add worker_main_http_uri, replace >> with > Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
2022-09-21Support enabling/disabling pushers (from MSC3881) (#13799)Brendan Abolivier15-71/+294
Partial implementation of MSC3881
2022-09-21Add cache invalidation across workers to module API (#13667)Mathieu Velten7-21/+153
Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
2022-09-21Correct documentation for map_user_attributes of OpenID Mapping Providers ↵Peter Scheu3-3/+13
(#13836) Co-authored-by: David Robertson <davidr@element.io>
2022-09-21Fix the release script not publishing binary wheels. (#13850)reivilibre2-11/+35
2022-09-21Improve the `synapse.api.auth.Auth` mock used in unit tests. (#13809)Quentin Gliech2-26/+11
To return the proper type (`Requester`) instead of a `dict`.
2022-09-21Lock rust dependencies (#13858)Erik Johnston4-1/+328
2022-09-21Fix the release script not publishing binary wheels. (#13850)reivilibre2-11/+35
2022-09-21Lower minimum rustc version to 1.58.1 (#13857)Erik Johnston3-7/+8
2022-09-20Remove the `complete_sso_login` method from the Module API which was ↵Quentin Gliech3-58/+2
deprecated in Synapse 1.13.0. (#13843) Signed-off-by: Quentin Gliech <quenting@element.io>
2022-09-20Generate separate snapshots for logical databases (#13792)David Robertson4-46/+140
* Generate separate snapshots for sqlite, postgres and common * Cleanup postgres dbs in the TRAP * Say which logical DB we're applying updates to * Run background updates on the state DB * Add new option for accepting a SCHEMA_NUMBER
2022-09-20Tweak changelog v1.68.0rc1Olivier Wilkinson (reivilibre)1-1/+1
2022-09-20Edit description of cache invalidation bugOlivier Wilkinson (reivilibre)1-1/+1
2022-09-20Port the push rule classes to Rust. (#13768)Erik Johnston14-615/+930
2022-09-20Edit changelog in response to feedbackOlivier Wilkinson (reivilibre)2-7/+21
2022-09-201.68.0rc1Olivier Wilkinson (reivilibre)69-67/+90
2022-09-20Don't include redundant prev_state in new events (#13791)Denis3-4/+1
2022-09-16Add support to purge rows from MSC2716 and other tables when purging a room ↵Eric Eastwood4-0/+30
(#13825) `event_failed_pull_attempts` added in https://github.com/matrix-org/synapse/pull/13589 MSC2716 related tables added in: - https://github.com/matrix-org/synapse/pull/10245/files#diff-3d42dfb44d02f7de3aada105e0bdc1cc9dd7f953cbf0f36c5d0f50827bf0320aR1 - Renamed in https://github.com/matrix-org/synapse/pull/10838/files#diff-2730bfbe9e688b55e46f9371aefe67dac2bd2b2b7d9d6b92774eea1fcfae156dR1 - https://github.com/matrix-org/synapse/pull/10498/files#diff-c52bbfbb5921a3f6f023b24343668479d966fac164f13b7c39d2197ce3afa7a5R1
2022-09-16Fix Docker build when Rust .so has been build locally first (#13811)Mathieu Velten3-3/+7
Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
2022-09-16Compare ported to unported PG schemas in portdb test job (#13808)David Robertson5-47/+50
2022-09-16Minor speedups to CI linting (#13827)David Robertson2-4/+6
2022-09-16Remove error spam when users query the keys of departed remote users (#13826)Sean Quah2-9/+13
The error message introduced in #13749 has turned out to be very spammy. Remove it for now.
2022-09-16complement: init postgres DB directly inside the target image (#13819)Mathieu Velten2-11/+10
Doing so in the base postgres image doesn't work with buildah because changes in a declared VOLUME in the Dockerfile is supposed to be discarded, cf https://docs.docker.com/engine/reference/builder/#volume Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
2022-09-16Add an admin API endpoint to find a user based on its external ID in an auth ↵Quentin Gliech5-0/+155
provider. (#13810)
2022-09-16Update request log format documentation to mention the format used when the ↵reivilibre2-2/+3
authenticated user is controlling another user. (#13794)
2022-09-16Avoid putting rejected events in room state (#13723)Sean Quah3-0/+415
Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-15Document common fix of Poetry problems by removing egg-info (#13785)Eric Eastwood2-0/+28
`matrix_synapse.egg-info/` Mentioned at https://matrix.to/#/!vcyiEtMVHIhWXcJAfl:sw1v.org/$aKy_IjrKwb70aTVZWeW_6zt0k7OIZ1YkyZpkP9uiRaM?via=matrix.org&via=element.io&via=beeper.com and many other places.
2022-09-15Be able to correlate timeouts in reverse-proxy layer in front of Synapse ↵Eric Eastwood5-5/+38
(pull request ID from header) (#13801) Fix https://github.com/matrix-org/synapse/issues/13685 New config: ```diff listeners: - port: 8008 tls: false type: http x_forwarded: true + request_id_header: "cf-ray" bind_addresses: ['::1', '127.0.0.1', '0.0.0.0'] ```
2022-09-15Record any exception when processing a pulled event (#13814)Eric Eastwood3-1/+12
Part of https://github.com/matrix-org/synapse/issues/13700 and https://github.com/matrix-org/synapse/issues/13356 Follow-up to https://github.com/matrix-org/synapse/pull/13589
2022-09-15Support providing an index predicate for upserts. (#13822)Patrick Cloke3-7/+25
This is useful to upsert against a table which has a unique partial index while avoiding conflicts.
2022-09-15A third batch of Pydantic validation for rest/client/account.py (#13736)David Robertson4-45/+78
2022-09-15Add a `MXCUri` class to make working with mxc uri's easier. (#13162)Andrew Morgan6-74/+53
2022-09-14Keep track when we try and fail to process a pulled event (#13589)Eric Eastwood7-9/+329
We can follow-up this PR with: 1. Only try to backfill from an event if we haven't tried recently -> https://github.com/matrix-org/synapse/issues/13622 1. When we decide to backfill that event again, process it in the background so it doesn't block and make `/messages` slow when we know it will probably fail again -> https://github.com/matrix-org/synapse/issues/13623 1. Generally track failures everywhere we try and fail to pull an event over federation -> https://github.com/matrix-org/synapse/issues/13700 Fix https://github.com/matrix-org/synapse/issues/13621 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.qv7cj51sv9i5)
2022-09-14Update event push action and receipt tables to support threads. (#13753)Patrick Cloke11-20/+312
Adds a `thread_id` column to the `event_push_actions`, `event_push_actions_staging`, and `event_push_summary` tables. This will notifications to be segmented by the thread in a future pull request. The `thread_id` column stores the root event ID or the special value `"main"`. The `thread_id` column for `event_push_actions` and `event_push_summary` is backfilled with `"main"` for all existing rows. New entries into `event_push_actions` and `event_push_actions_staging` will get the proper thread ID. `receipts_linearized` and `receipts_graph` also gain a `thread_id` column, which is similar, except `NULL` is a special value meaning the receipt is "unthreaded". See MSC3771 and MSC3773 for where this data will be useful.
2022-09-14Use partial indices on SQLIte. (#13802)Patrick Cloke4-5/+59
Partial indices have been supported since SQLite 3.8, but Synapse now requires >= 3.27, so we can enable support for them. This requires rebuilding previous indices which were partial on PostgreSQL, but not on SQLite.
2022-09-14Deduplicate `is_server_notices_room`. (#13780)reivilibre4-18/+20
2022-09-14Fix a memory leak when running the unit tests. (#13798)reivilibre3-6/+8
2022-09-14Remove unused method in `synapse.api.auth.Auth`. (#13795)Quentin Gliech2-9/+1
Clean-up from b19060a29b4f73897847db2aba5d03ec819086e0 (#13094) and 73af10f419346a5f2d70131ac1ed8e69942edca0 (#13093) which removed all callers.
2022-09-14Remove incorrect migration file from `state` logical DB (#13788)David Robertson2-37/+1
* Remove incorrect migration file from `state` logical DB The table `ex_outlier_stream` is part of the `main` logical DB; it should not have been created in the `state` logical DB. We remove this migration now as a tidy-up. Note: we cannot `DROP TABLE IF EXISTS ex_outlier_stream` in a new migration, because some (most) instances of Synapse host both of these logical DBs on the same DB cluster. * Changelog
2022-09-14Fix bug in device list caching when remote users leave rooms (#13749)Sean Quah5-15/+51
When a remote user leaves the last room shared with the homeserver, we have to mark their device list as unsubscribed, otherwise we would hold on to a stale device list in our cache. Crucially, the device list would remain cached even after the remote user rejoined the room, which could lead to E2EE failures until the next change to the remote user's device list. Fixes #13651. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-14Fix a long-standing spec compliance bug where Synapse would accept a ↵reivilibre2-2/+2
trailing slash on the end of `/get_missing_events` federation requests. (#13789) * Don't accept a trailing slash on the end of /get_missing_events * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2022-09-13Make sequence `cache_invalidation_stream_seq` begin at `2` (#13766)Mathieu Velten3-0/+25
Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
2022-09-13Updates to the schema dump script (#13770)David Robertson3-32/+21
2022-09-13Simplify CI tests DAG (#13784)David Robertson2-4/+1
* Simplify CI tests DAG * Changelog
2022-09-13installation.md: require libpq on M1 macs (#13480)Richard van der Hoff2-2/+4
2022-09-13Fixup changelog v1.67.0Erik Johnston1-3/+3
2022-09-131.67.0Erik Johnston3-3/+15
2022-09-13Add receipts event stream ordering (#13703)Nick Mills-Barrett4-1/+95
2022-09-12Fix GHA skippable syntax (#13778)Mathieu Velten2-1/+3
Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
2022-09-12Fix typo in ratelimiting documentation (#13727)Brendan Abolivier2-1/+2
2022-09-12Fix CI on non-PR builds (#13769)Erik Johnston2-0/+2
Mark cargo-test as skippable since it only runs on Rust code change.
2022-09-12Remove check current state membership up to date (#13745)Nick Mills-Barrett3-155/+100
* Remove checks for membership column in current_state_events * Add schema script to force through the `current_state_events_membership` background job Contributed by Nick @ Beeper (@fizzadar).
2022-09-12Check if Rust lib needs rebuilding. (#13759)Erik Johnston7-1/+149
This protects against the common mistake of failing to remember to rebuild Rust code after making changes.
2022-09-09Concurrently collect room unread counts for push badges (#13765)Nick Mills-Barrett2-3/+11
Most of the time this function is heavily cached, but when that isn't the case fetching the counts room by room slows down push delivery on users with many (thousands) of rooms. Signed off by Nick @ Beeper.
2022-09-09Tag trace with instance name (#13761)Eric Eastwood3-2/+12
We tag the Synapse instance name so that it's an easy jumping off point into the logs. Can also be used to filter for an instance that is under load. As suggested by @clokep and @reivilibre in, - https://github.com/matrix-org/synapse/pull/13729#discussion_r964719258 - https://github.com/matrix-org/synapse/pull/13729#discussion_r964733578
2022-09-09Strip number suffix from instance name to consolidate services that traces ↵Eric Eastwood2-1/+13
are spread over (#13729) The problem with many services is that it makes it hard to find which service has the trace you want, see https://github.com/jaegertracing/jaeger-ui/issues/985 Previously, we split traces out into services based on their instance name like `matrix.org client_reader-1`, etc but there are many worker instances of the same `client_reader` so there is a lot to click through. With this PR, all of the traces are just collected under the worker type like `client_reader`, `event_persister` 😇 Note: A Synapse worker instance name is an opaque string with the number convention only being our own thing for the `matrix.org` deployment. But seems pretty sensible to group things this way.
2022-09-09Use an upsert for `receipts_graph`. (#13752)Patrick Cloke2-8/+5
Instead of a delete, then insert. This was previously done for `receipts_linearized` in 2dc430d36ef793b38d6d79ec8db4ea60588df2ee (#7607).
2022-09-09Add rust to CI (#13763)Erik Johnston3-1/+84
2022-09-09Require SQLite >= 3.27.0 (#13760)David Robertson9-208/+106
2022-09-08Re-type hint some collections in `/sync` code as read-only (#13754)Sean Quah2-10/+11
Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-08Remove unused Prometheus recording rules from `synapse-v2.rules` and add ↵reivilibre2-23/+9
comments describing where the rest are used. (#13756)
2022-09-08Add timestamp to user's consent (#13741)Dirk Klimpel7-8/+52
Co-authored-by: reivilibre <olivier@librepush.net>
2022-09-08Update docstrings to explain the impact of partial state (#13750)Sean Quah2-1/+17
Update the docstrings for `get_users_in_room` and `get_current_hosts_in_room` to explain the impact of partial state. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-08Avoid raising errors due to malformed IDs in `get_current_hosts_in_room` ↵Sean Quah2-1/+5
(#13748) Handle malformed user IDs with no colons in `get_current_hosts_in_room`. It's not currently possible for a malformed user ID to join a room, so this error would never be hit. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-08Fix error in `is_mine_id` when encountering a malformed ID (#13746)Sean Quah3-2/+37
Previously, `is_mine_id` would raise an exception when passed an ID with no colons. Return `False` instead. Fixes #13040. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-09-08Fix cache metrics not being updated when not using the legacy exposition ↵reivilibre4-21/+81
module. (#13717)
2022-09-08Fix Prometheus recording rules to not use legacy metric names. (#13718)reivilibre6-37/+22
2022-09-08Fix latest deps (#13743)Erik Johnston2-0/+15
2022-09-08Also cite upgrade notesDavid Robertson1-1/+1
2022-09-08Add minimum version bump for sqlite to the release notes (#13742)David Robertson2-1/+21
* Notify that SQLite min version will be bumped * Mention in upgrade notes Co-authored-by: reivilibre <oliverw@matrix.org>
2022-09-08Fix a bug where Synapse fails to start if a signing key file contains an ↵reivilibre2-1/+13
empty line. (#13738)
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-10-17 16:33:36 +0000