| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | |
| | |
| | | |
These are surprisingly expensive, and we only really need to do them at startup.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room).
Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on.
People probably want to look at this commit by commit.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it.
https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync.
This commit uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now.
It also adds a looping call to retry all failed resync every 30s. This shouldn't cause too much spam in the logs as this commit also removes the "Failed to handle device list update for..." warning logs when catching `NotRetryingDestination`.
Fixes #7418
|
| | | |
| | |
| | |
| | |
| | | |
`_is_server_still_joined` will throw if it is given state updates with non-user ID state keys with local user leaves. This is actually rarely a problem since local leaves almost always get persisted by themselves.
(I discovered this on a branch that was otherwise broken, so I haven't seen this in the wild)
|
| | |\ \
| | | |
| | | | |
Kill off some old python 2 code
|
| | | | |
| | | |
| | | |
| | | | |
this is no longer needed on python 3
|
| | | | |
| | | |
| | | |
| | | | |
this is a no-op on python 3.
|
| | | | |
| | | |
| | | |
| | | | |
this is a no-op on python 3.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Make sure that the AccountDataStream presents complete updates, in the right
order.
This is much the same fix as #7337 and #7358, but applied to a different stream.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.
|
| | | | |
| | | |
| | | |
| | | | |
queries (#7465)
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This allows us to have the logic on both master and workers, which is necessary to move event persistence off master.
We also combine the instantiation of ID generators from DataStore and slave stores to the base worker stores. This allows us to select which process writes events independently of the master/worker splits.
|
| | |/ /
| | |
| | |
| | | |
update_remote_profile_cache (#7511)
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Synapse 1.13.0rc2 (2020-05-14)
==============================
Bugfixes
--------
- Fix a long-standing bug which could cause messages not to be sent over federation, when state events with state keys matching user IDs (such as custom user statuses) were received. ([\#7376](https://github.com/matrix-org/synapse/issues/7376))
- Restore compatibility with non-compliant clients during the user interactive authentication process, fixing a problem introduced in v1.13.0rc1. ([\#7483](https://github.com/matrix-org/synapse/issues/7483))
Internal Changes
----------------
- Fix linting errors in new version of Flake8. ([\#7470](https://github.com/matrix-org/synapse/issues/7470))
|
| | | | |
| | | |
| | | | |
This is safe as we can now write to cache invalidation stream on workers, and is required for when we move event persistence off master.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The aim here is to get to a stage where we have a `PersistEventStore` that holds all the write methods used during event persistence, so that we can take that class out of the `DataStore` mixin and instansiate it separately. This will allow us to instansiate it on processes other than master, while also ensuring it is only available on processes that are configured to write to events stream.
This is a bit of an architectural change, where we end up with multiple classes per data store (rather than one per data store we have now). We end up having:
1. Storage classes that provide high level APIs that can talk to multiple data stores.
2. Data store modules that consist of classes that must point at the same database instance.
3. Classes in a data store that can be instantiated on processes depending on config.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
variables (#6391)
|
| | | | | |
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* release-v1.13.0:
Don't UPGRADE database rows
RST indenting
Put rollback instructions in upgrade notes
Fix changelog typo
Oh yeah, RST
Absolute URL it is then
Fix upgrade notes link
Provide summary of upgrade issues in changelog. Fix )
Move next version notes from changelog to upgrade notes
Changelog fixes
1.13.0rc1
Documentation on setting up redis (#7446)
Rework UI Auth session validation for registration (#7455)
Fix errors from malformed log line (#7454)
Drop support for redis.dbid (#7450)
|
| | | | | | |
|
| | | | | | |
|
| | |\ \ \ \ |
|
| | |\ \ \ \ \
| | | | | | |
| | | | | | | |
Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulk
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
... mostly because the latter has a cache.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
There's no point carefully dividing a list into batches, and then completely
ignoring the batches.
|
| | |\ \ \ \ \ \ |
|
| | | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This will be used to coordinate stream IDs across multiple writers.
Functions as the equivalent of both `StreamIdGenerator` and
`SlavedIdTracker`.
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
most of these params don't really need to be lists.
|
| |\ \ \ \ \ \ \
| | |_|_|_|/ /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
dinsic-release-v1.14.x
* 'release-v1.13.0' of github.com:matrix-org/synapse: (257 commits)
Update changelog based on feedback.
Move warnings in the changelog and re-iterate changes to branches.
1.13.0
update dh-virtualenv (#7526)
1.13.0rc3
Hash passwords earlier in the registration process (#7523)
1.13.0rc2
1.13.0rc2
Stop `get_joined_users` corruption from custom statuses (#7376)
Do not validate that the client dict is stable during UI Auth. (#7483)
Fix new flake8 errors (#7489)
Don't UPGRADE database rows
RST indenting
Put rollback instructions in upgrade notes
Fix changelog typo
Oh yeah, RST
Absolute URL it is then
Fix upgrade notes link
Provide summary of upgrade issues in changelog. Fix )
Move next version notes from changelog to upgrade notes
...
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fix a bug where the `get_joined_users` cache could be corrupted by custom
status events (or other state events with a state_key matching the user ID).
The bug was introduced by #2229, but has largely gone unnoticed since then.
Fixes #7099, #7373.
|
| | | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
This is a cherry-pick of 1a1da60ad2c9172fe487cd38a164b39df60f4cb5 (#7470)
to the release-v1.13.0 branch.
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | | |
Be less strict about validation of UI authentication sessions during
registration to match client expecations.
|
| | |\ \ \ \
| | | |/ /
| | |/| | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
(#7387)
populate_stats_process_rooms was added in #5971 / v1.4.0; current_state_events_membership was added in #5706 / v1.3.0.
Fixes #7380.
|
| | | |/ / |
|
| | |/ /
| | |
| | |
| | |
| | | |
Currently we copy `users_who_share_room` needlessly about three times,
which is expensive when the set is large (which it can easily be).
|
| | | |
| | |
| | |
| | |
| | | |
By persisting the user interactive authentication sessions to the database, this fixes
situations where a user hits different works throughout their auth session and also
allows sessions to persist through restarts of Synapse.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Factor out functions for injecting events into database
I want to add some more flexibility to the tools for injecting events into the
database, and I don't want to clutter up HomeserverTestCase with them, so let's
factor them out to a new file.
* Rework TestReplicationDataHandler
This wasn't very easy to work with: the mock wrapping was largely superfluous,
and it's useful to be able to inspect the received rows, and clear out the
received list.
* Fix AssertionErrors being thrown by EventsStream
Part of the problem was that there was an off-by-one error in the assertion,
but also the limit logic was too simple. Fix it all up and add some tests.
|
| | | |
| | |
| | |
| | |
| | | |
(#6881)
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Figuring out how to correctly limit updates from this stream without dropping
entries is far more complicated than just counting the number of rows being
returned. We need to consider each query separately and, if any one query hits
the limit, truncate the results from the others.
I think this also fixes some potentially long-standing bugs where events or
state changes could get missed if we hit the limit on either query.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
We could end up looking up tens of thousands of events, which could cause large
amounts of data to be logged to the postgres log.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
We seem to have some duplicates, which could do with being cleared out.
|
| | | | |
|
| | | |
| | |
| | | |
They just get in the way.
|
| | | |
| | |
| | |
| | | |
Fixes a race between handling `POSITION` and `RDATA` commands. We do this by simply linearizing handling of them.
|
| | | | |
|
| | |\ \
| | | |
| | | | |
Only run one background update at a time
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
returning a None or an int that we don't use is confusing.
|
| | | | |
| | | |
| | | |
| | | | |
(Almost) everywhere that uses it is happy with an awaitable.
|
| | | | |
| | | |
| | | |
| | | | |
This was only used in a unit test, so let's just inline it in the test.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Occasionally we could get a federation device list update transaction which
looked like:
```
[
{'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}},
{'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}},
{'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}}
]
```
Having `stream_ids` which are lower than `prev_ids` looks odd. It might work
(I'm not actually sure), but in any case it doesn't seem like a reasonable
thing to expect other implementations to support.
|
| | | |
| | |
| | | |
Signed-off-by: Karl Linderhed <git@karlinde.se>
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
make sure we clear out all but one update for the user
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Fixes: #7127
Signed-off-by: David Vo <david@vovo.id.au>
|
| | | |
| | |
| | | |
This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Pull Sentinel out of LoggingContext
... and drop a few unnecessary references to it
* Factor out LoggingContext.current_context
move `current_context` and `set_context` out to top-level functions.
Mostly this means that I can more easily trace what's actually referring to
LoggingContext, but I think it's generally neater.
* move copy-to-parent into `stop`
this really just makes `start` and `stop` more symetric. It also means that it
behaves correctly if you manually `set_log_context` rather than using the
context manager.
* Replace `LoggingContext.alive` with `finished`
Turn `alive` into `finished` and make it a bit better defined.
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Add 'device_lists_outbound_pokes' as extra table.
This makes sure we check all the relevant tables to get the current max
stream ID.
Currently not doing so isn't problematic as the max stream ID in
`device_lists_outbound_pokes` is the same as in `device_lists_stream`,
however that will change.
* Change device lists stream to have one row per id.
This will make it possible to process the streams more incrementally,
avoiding having to process large chunks at once.
* Change device list replication to match new semantics.
Instead of sending down batches of user ID/host tuples, send down a row
per entity (user ID or host).
* Newsfile
* Remove handling of multiple rows per ID
* Fix worker handling
* Comments from review
|
| | | | | |
|
| | | |\ \
| | | | |
| | | | |
| | | | | |
erikj/fixup_devices_stream
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Instead of sending down batches of user ID/host tuples, send down a row
per entity (user ID or host).
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This will make it possible to process the streams more incrementally,
avoiding having to process large chunks at once.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This makes sure we check all the relevant tables to get the current max
stream ID.
Currently not doing so isn't problematic as the max stream ID in
`device_lists_outbound_pokes` is the same as in `device_lists_stream`,
however that will change.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Switch sytest-synapse to sytest-dinsic
* Be sure to invalidate our caches properly!
* Remove duplicate encryption state key definition
* Remove old config option name in comment
* Make dinsic the default in merge_base_branch
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes: #7127
Signed-off-by: David Vo <david@vovo.id.au>
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* commit '4a17a647a':
Improve get auth chain difference algorithm. (#7095)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It was originally implemented by pulling the full auth chain of all
state sets out of the database and doing set comparison. However, that
can take a lot work if the state and auth chains are large.
Instead, lets try and fetch the auth chains at the same time and
calculate the difference on the fly, allowing us to bail early if all
the auth chains converge. Assuming that the auth chains do converge more
often than not, this should improve performance. Hopefully.
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* commit '6a3504636': (29 commits)
Revert "Add options to disable setting profile info for prevent changes. (#7053)"
Populate the room version from state events (#7070)
Fix buggy condition in account validity handler (#7074)
Use innerText instead of innerHTML
Add type annotations and comments to auth handler (#7063)
Lint
Put the file in the templates directory
Update wording and config
Changelog
Move the default SAML2 error HTML to a dedicated file
Refactor a bit
Also don't fail on aliases events in this case
Lint
Changelog
Also don't filter out events sent by ignored users when checking state visibility
Fix condition
Don't filter out dummy events when we're checking the visibility of state
Update sample_config.yaml
Update synapse/config/registration.py
lint, fix tests
...
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #7065
This is basically the same as https://github.com/matrix-org/synapse/pull/6847 except it tries to populate events from `state_events` rather than `current_state_events`, since the latter might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* commit '6640460d0':
Rephrase default message
Hopefully mypy is happy now
Attempt at appeasing the gods of mypy
Lint
Changelog
Update sample config
SAML2: render a comprehensible error page if something goes wrong
|
| | | | | | |
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
matrix-org/babolivier/get_time_of_last_push_action_before
* commit '14b2ebe76':
Changelog
Fix undefined `room_id` in `make_summary_text`
Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore`
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
matrix-org/babolivier/get_time_of_last_push_action_before
Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #7054
I also had a look at the rest of the functions in
`EventPushActionsStore` and in the push notifications send code and it
looks to me like there shouldn't be any other method with this issue in
this part of the codebase.
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
room ver. (#7037)
* commit '06eb5cae0':
Remove special auth and redaction rules for aliases events in experimental room ver. (#7037)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
room ver. (#7037)
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '1d66dce83':
Break down monthly active users by appservice_id (#7030)
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
* Break down monthly active users by appservice_id and emit via prometheus.
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* commit '8ef8fb2c1':
Read the room version from database when fetching events (#6874)
Update debian changelog
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | | |
This is a precursor to giving EventBase objects the knowledge of which room version they belong to.
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'b29474e0a':
Always return a deferred from `get_current_state_deltas`. (#7019)
|
| | |/ /
| | |
| | |
| | |
| | | |
This currently causes presence notify code to log exceptions when there
is no state changes to process. This doesn't actually cause any problems
as we'd simply do nothing anyway.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '9b06d8f8a':
Fixed set a user as an admin with the new API (#6928)
|
| | | |
| | |
| | | |
Fix #6910
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '132b673db':
Add some type annotations in `synapse.storage` (#6987)
|
| | | |
| | |
| | |
| | |
| | | |
I cracked, and added some type definitions in synapse.storage.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '3e99528f2':
Store room version on invite (#6983)
|
| | | |
| | |
| | |
| | |
| | | |
When we get an invite over federation, store the room version in the rooms table.
The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere...
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '7728d87fd':
Updated warning for incorrect database collation/ctype (#6985)
|
| | | |
| | |
| | | |
Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com>
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'e66f099ca':
Sanity-check database before running upgrades (#6982)
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Some of the database deltas rely on `config.server_name` being set correctly,
so we should check that it is before running the deltas.
Fixes #6870.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'bbf8886a0':
Merge worker apps into one. (#6964)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'a301934f4':
Upsert room version when we join over federation (#6968)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is intended as a precursor to storing room versions when we receive an
invite over federation, but has the happy side-effect of fixing #3374 at last.
In short: change the store_room with try/except to a proper upsert which
updates the right columns.
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit '509e381af':
Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)
changelog
Increase MAX_EVENTS_BEHIND for replication clients
|
| | | |
| | |
| | |
| | | |
Ensure good comprehension hygiene using flake8-comprehensions.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'a90d0dc5c':
don't insert into the device table for remote cross-signing keys (#6956)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | |
| | | |
* commit '4fb5f4d0c':
Add some clarifications to README.md in the database schema directory. (#6615)
Minor perf fixes to `get_auth_chain_ids`.
|
| | | |
| | |
| | | |
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | |
| | | |
* commit '2b37eabca':
Reduce auth chains fetched during v2 state res. (#6952)
update changes.md
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The state res v2 algorithm only cares about the difference between auth
chains, so we can pass in the known common state to the `get_auth_chain`
storage function so that it can ignore those events.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '099c96b89':
Revert `get_auth_chain_ids` changes (#6951)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '0d0bc3579':
Increase DB/CPU perf of `_is_server_still_joined` check. (#6936)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Increase DB/CPU perf of `_is_server_still_joined` check.
For rooms with large amount of state a single user leaving could cause
us to go and load a lot of membership events and then pull out
membership state in a large number of batches.
* Newsfile
* Update synapse/storage/persist_events.py
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Fix adding if too soon
* Update docstring
* Review comments
* Woops typo
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '5a5abd55e':
Limit size of get_auth_chain_ids query (#6947)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '8a380d0fe':
Increase perf of `get_auth_chain_ids` used in state res v2. (#6937)
|
| | | |
| | |
| | | |
We do this by moving the recursive query to be fully in the DB.
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | | |
delete_old_current_state_events (#6924)
* commit '46fa66bbf':
wait for current_state_events_membership before delete_old_current_state_events (#6924)
|
| | | |
| | |
| | |
| | | |
delete_old_current_state_events (#6924)
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'e1d858984':
Remove unused `get_room_stats_state` method. (#6869)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'de2d26737':
Allow moving group read APIs to workers (#6866)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'ed630ea17':
Reduce amount of logging at INFO level. (#6862)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A lot of the things we log at INFO are now a bit superfluous, so lets
make them DEBUG logs to reduce the amount we log by default.
Co-Authored-By: Brendan Abolivier <babolivier@matrix.org>
Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Synapse 1.10.0rc2 (2020-02-06)
==============================
Bugfixes
--------
- Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844))
- Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848))
Internal Changes
----------------
- Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850))
|
| | | | |
| | | |
| | | | |
add device signatures to device key query results
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'a831d2e4e':
Reduce performance logging to DEBUG (#6833)
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Reduce tnx performance logging to DEBUG
* Changelog.d
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'd88e0ec08':
Database updates to populate rooms.room_version (#6847)
|
| | | | |
| | | |
| | | | |
We're going to need this so that we can figure out how to handle redactions when fetching events from the database.
|
| |\ \ \ \
| | |/ /
| |/| |
| | | |
| | | | |
* commit '6475382d8':
Fix detecting unknown devices from remote encrypted events. (#6848)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We were looking at the wrong event type (`m.room.encryption` vs
`m.room.encrypted`).
Also fixup the duplicate `EvenTypes` entries.
Introduced in #6776.
|
| |\ \ \ \
| | |/ /
| |/| |
| | | |
| | | |
| | | | |
* commit '74bf3fdbb':
add changelog
add device signatures to device key query results
|
| | |/ / |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '83b0ea047':
Fix deleting of stale marker for device lists (#6819)
|
| | | |
| | |
| | |
| | | |
We were in fact only deleting stale marker when we got an incremental
update, rather than when we did a full resync.
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit '160522e32':
newsfile
Add `get_room_version` method
s/get_room_version/get_room_version_id/
|
| | | |
| | |
| | |
| | | |
So that we can start factoring out some of this boilerplatey boilerplate.
|
| | | |
| | |
| | |
| | |
| | | |
... to make way for a forthcoming get_room_version which returns a RoomVersion
object.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'e0992fcc5':
Log when we delete room in bg update (#6816)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '57ad702af':
Backgroud update to clean out rooms from current state (#6802)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'a5bab2d05':
When server leaves room check for stale device lists. (#6801)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a server leaves a room it may stop sharing a room with remote
users, and thus not get any updates to their device lists. So we need to
check for this case and delete those device lists from the cache.
We don't need to do this if we stop sharing a room because the remote
user leaves the room, because we track that case via looking at
membership changes.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'c80a9fe13':
When a client asks for remote keys check if should resync. (#6797)
|
| | | |
| | |
| | |
| | |
| | |
| | | |
If we detect that the remote users' keys may have changed then we should
attempt to resync against the remote server rather than using the
(potentially) stale local cache.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '611215a49':
Delete current state when server leaves a room (#6792)
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Otherwise its just stale data, which may get deleted later anyway so
can't be relied on. It's also a bit of a shotgun if we're trying to get
the current state of a room we're not in.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'e17a11066':
Detect unknown remote devices and mark cache as stale (#6776)
|
| | | |
| | |
| | |
| | | |
We just mark the fact that the cache may be stale in the database for
now.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '02b44db92':
Warn if postgres database has non-C locale. (#6734)
|
| | | |
| | |
| | | |
As using non-C locale can cause issues on upgrading OS.
|
| | |\ \ |
|
| |\ \ \ \
| | |/ /
| |/| |
| | | |
| | | | |
* commit 'bdbeeb94e':
Fix setting `mau_limit_reserved_threepids` config (#6793)
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Calling the invalidation function during initialisation of the data
stores introduces a circular dependency, causing Synapse to fail to
start.
|
| |\ \ \ \
| | |/ /
| |/| |
| | | |
| | | | |
* commit '8df862e45':
Add `rooms.room_version` column (#6729)
|
| | | | |
| | | |
| | | | |
This is so that we don't have to rely on pulling it out from `current_state_events` table.
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'd5275fc55':
Propagate cache invalidates from workers to other workers. (#6748)
|
| | | | |
| | | |
| | | | |
Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers.
|
| |\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* commit 'fa4d609e2':
Make 'event.redacts' never raise. (#6771)
Fixup changelog
Fixup changelog
Fixup changelog
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There are quite a few places that we assume that a redaction event has a
corresponding `redacts` key, which is not always the case. So lets
cheekily make it so that event.redacts just returns None instead.
|
| |\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* commit 'ce84dd9e2':
Remove unnecessary abstractions in admin handler (#6751)
Fixup warning about workers changes
Add deprecation headers
Fixup changelog
|
| | |/ / |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '90a28fb47':
Admin API to list, filter and sort rooms (#6720)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '5e52d8563':
Allow monthly active user limiting support for worker mode, fixes #4639. (#6742)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '5d7a6ad22':
Allow streaming cache invalidate all to workers. (#6749)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '0e6876007':
Add a DeltaState to track changes to be made to current state (#6716)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '722b4f302':
Fix syntax error in run_upgrade for schema 57 (#6728)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix #6727
Related #6655
Co-authored-by: Erik Johnston <erikj@jki.re>
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit '3b72bb780':
bump version to v1.9.0.dev1
Precise changelog
Fixup diff
Remove get_room_event_after_stream_ordering entirely
Lint
Rename changelog
Changelog
Correctly order when selecting before stream ordering
Fix typo
Fix instantiation of message retention purge jobs
|
| | |\ \
| | | |
| | | | |
Fix instantiation of message retention purge jobs
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When figuring out which topological token to start a purge job at, we
need to do the following:
1. Figure out a timestamp before which events will be purged
2. Select the first stream ordering after that timestamp
3. Select info about the first event after that stream ordering
4. Build a topological token from that info
In some situations (e.g. quiet rooms with a short max_lifetime), there
might not be an event after the stream ordering at step 3, therefore we
abort the purge with the error `No event found`. To mitigate that, this
patch fetches the first event _before_ the stream ordering, instead of
after.
|
| |\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* commit '59dc87c61':
changelog
Log saml assertions rather than the whole response
move batch_iter to a separate module
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'd386f2f33':
Add StateMap type alias (#6715)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '19a1aac48':
Fix purge_room admin API (#6711)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '28c98e51f':
Add `local_current_membership` table (#6655)
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
Currently we rely on `current_state_events` to figure out what rooms a
user was in and their last membership event in there. However, if the
server leaves the room then the table may be cleaned up and that
information is lost. So lets add a table that separately holds that
information.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '1177d3f3a':
Quarantine media by ID or user ID (#6681)
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit '1d16f5ea0':
update install notes for CentOS
changelog
Refuse to start if sqlite is older than 3.11.0
Check postgres version in check_database
Modify check_database to take a connection rather than a cursor
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
this saves doing it on each connection, and will allow us to pass extra options
in.
|
| | | |
| | |
| | |
| | | |
We might not need the cursor at all.
|
| |\| |
| | |
| | |
| | |
| | |
| | | |
* commit 'd2906fe66':
Allow admin users to create or modify users without a shared secret (#6495)
Fixup changelog
|
| | | |
| | |
| | | |
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit '7c232bd98':
Shuffle the code
Comments
Do not rely on streaming events, as media repo doesn't
Newsfile
Import RoomStore in media worker to fix admin APIs
Move media admin store functions to worker store
|
| | |\ \
| | | |
| | | | |
Fix media repo admin APIs when using a media worker.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '7caaa29da':
Fix GET request on /_synapse/admin/v2/users endpoint (#6563)
|
| | |/ /
| | |
| | |
| | | |
Fixes #6552
|
| |\| |
| | |
| | |
| | |
| | |
| | | |
* commit '0ab5853ec':
Changelog
Fix conditions failing if min_depth = 0
|
| | |\ \
| | | |
| | | | |
Fix conditions failing if min_depth = 0
|
| | | | |
| | | |
| | | |
| | | | |
This could result in Synapse not fetching prev_events for new events in the room if it has missed some events.
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '85db7f73b':
Add a background update to clear tombstoned rooms from the directory (#6648)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Add a background update to clear tombstoned rooms from the directory
* use the ABC metaclass
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '9824a39d8':
Async/await for background updates (#6647)
|
| | | | |
| | | |
| | | |
| | | | |
so that bg update routines can be async
|
| |\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* commit 'd20c34654':
port BackgroundUpdateTestCase to HomeserverTestCase (#6653)
changelog
Fix exceptions in log when rejected event is replicated
async/await for SyncReplicationHandler.process_and_notify
Clarify documentation on get_event* methods
|
| | |\ \ \
| | | | |
| | | | | |
Fix exceptions in the synchrotron worker log when events are rejected.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Make it clearer how they behave in the face of rejected and/or missing events.
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* commit '1807db5e7':
changelog
Remove unused get_latest_event_ids_and_hashes_in_room
Remove unused get_prev_events_and_hashes_for_room
Remove unused hashes and depths from _update_membership params
Remove unused hashes and depths from create_event params
Remove unused hashes and depths from create_new_client_event params
replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in create_new_client_event
rename get_prev_events_for_room to get_prev_events_and_hashes_for_room
|
| | |\ \ \ \
| | |/ / /
| |/| | | |
Remove a bunch of unused code from event creation
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
create_new_client_event
|
| | | |/ /
| | | |
| | | |
| | | | |
... to make way for a new method which just returns the event ids
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'ba897a759':
Fix some test failures when frozen_dicts are enabled (#6642)
|
| | | | |
| | | |
| | | |
| | | | |
Fixes #4026
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '9f6c1befb':
Add experimental 'databases' config (#6580)
|
| | |/ / |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '7c6b85355':
Update reverse proxy file name (#6590)
|
| |\| |
| | |
| | |
| | |
| | | |
* commit '75d8f26ac':
Split state groups into a separate data store (#6296)
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
* commit '4caab0e95':
Backport fixes to sqlite upgrade from develop (#6578)
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Only run prepare_database on connection for in-memory databases.
Fixes #6569.
|
| |\ \ \ \
| | |/ /
| |/| |
| | | |
| | | | |
* commit 'fa780e972':
Change EventContext to use the Storage class (#6564)
|
| | | | | |
|
