summary refs log tree commit diff
path: root/synapse/storage (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge commit '939ef657c' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-2213-32/+44
|\
| * Merge remote-tracking branch 'origin/release-v1.26.0' into developErik Johnston2021-01-212-1/+19
| |\
| | * Add schema update to fix existing DBs affected by #9193 (#9195)Erik Johnston2021-01-212-1/+19
| | |
| * | Merge remote-tracking branch 'origin/release-v1.26.0' into developErik Johnston2021-01-214-7/+61
| |\|
| * | Use execute_batch in more places (#9188)Erik Johnston2021-01-2111-31/+25
| | | | | | | | | | | | | | | * Use execute_batch in more places * Newsfile
* | | Merge commit '2506074ef' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-224-7/+61
|\ \ \ | | |/ | |/|
| * | Fix receipts or account data not being sent down sync (#9193)Erik Johnston2021-01-214-7/+61
| | | | | | | | | | | | | | | Introduced in #9104 This wasn't picked up by the tests as this is all fine the first time you run Synapse (after upgrading), but then when you restart the wrong value is pulled from `stream_positions`.
* | | Merge commit '42a8e8137' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-222-12/+11
|\ \ \ | | |/ | |/|
| * | Use execute_batch instead of executemany in places (#9181)Erik Johnston2021-01-212-12/+11
| |/ | | | | `execute_batch` does fewer round trips in postgres than `executemany`, but does not give a correct `txn.rowcount` result after.
* | Merge commit '0cd2938bc' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-221-4/+2
|\|
| * Support icons for Identity Providers (#9154)Richard van der Hoff2021-01-201-4/+2
| |
* | Merge commit '73b03722f' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-2210-160/+315
|\|
| * Allow moving account data and receipts streams off master (#9104)Erik Johnston2021-01-1810-160/+315
| |
* | Merge commit '2b467d0b6' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-222-153/+181
|\|
| * Make chain cover index bg update go faster (#9124)Erik Johnston2021-01-151-150/+179
| | | | | | | | | | | | We do this by allowing a single iteration to process multiple rooms at a time, as there are often a lot of really tiny rooms, which can massively slow things down.
| * Ensure we store pusher data as text (#9117)Richard van der Hoff2021-01-151-3/+2
| | | | | | | | | | I don't think there's any need to use canonicaljson here. Fixes: #4475.
* | Merge commit 'd34c6e127' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-221-1/+2
|\|
| * Add type hints to media rest resources. (#9093)Patrick Cloke2021-01-151-1/+2
| |
* | Merge commit '20af31088' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-225-42/+65
|\|
| * Fix perf of get_cross_signing_keys (#9116)Erik Johnston2021-01-141-13/+28
| |
| * Fix chain cover background update to work with split out event persisters ↵Erik Johnston2021-01-144-29/+37
| | | | | | | | (#9115)
* | Merge commit '631dd06f2' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-224-29/+254
|\|
| * Fix get destinations to catch up query. (#9114)Erik Johnston2021-01-141-13/+11
| | | | | | | | t was doing a sequential scan on `destination_rooms`, which took minutes.
| * Add background update for add chain cover index (#9029)Erik Johnston2021-01-143-16/+243
| |
* | Merge commit '233c8b9fc' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-221-11/+30
|\|
| * Register the /devices endpoint on workers. (#9092)Patrick Cloke2021-01-131-11/+30
| |
* | Merge commit '98a64b7f7' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-2215-150/+1086
|\|
| * Remove user's avatar URL and displayname when deactivated. (#8932)Dirk Klimpel2021-01-121-1/+1
| | | | | | This only applies if the user's data is to be erased.
| * Move more encryption endpoints off master (#9068)Erik Johnston2021-01-111-44/+44
| |
| * Use a chain cover index to efficiently calculate auth chain difference (#8868)Erik Johnston2021-01-116-22/+839
| |
| * Remove old tables after schema version bump (#9055)Erik Johnston2021-01-115-59/+36
| | | | | | | | | | These tables are unused, and can be dropped now the schema version has been bumped.
| * Ensure rejected events get added to some metadata tables (#9016)Erik Johnston2021-01-113-24/+166
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Merge commit '2fb1c2b6e' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-212-0/+78
|\|
| * Drop last_used column from access_tokens (#9025)Jerin J Titus2021-01-112-0/+78
| | | | | | | | | | * Dropped last_used column from access_tokens Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
* | Merge commit 'a03d71dc9' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-215-96/+181
|\|
| * Fix error handling during insertion of client IPs (#9051)Erik Johnston2021-01-081-31/+23
| | | | | | | | | | You can't continue using a transaction once an exception has been raised, so catching and dropping the error here is pointless and just causes more errors.
| * Allow running sendToDevice on workers (#9044)Erik Johnston2021-01-074-65/+158
| |
* | Merge commit '63593134a' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-211-49/+58
|\|
| * Some cleanups to device inbox store. (#9041)Erik Johnston2021-01-071-49/+58
| |
* | Merge commit '23d701864' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-213-37/+185
|\|
| * Improve the performance of calculating ignored users in large rooms (#9024)Patrick Cloke2021-01-073-30/+175
| | | | | | | | | | | | This allows for efficiently finding which users ignore a particular user. Co-authored-by: Erik Johnston <erik@matrix.org>
| * Handle updating schema version without any deltas. (#9033)Erik Johnston2021-01-071-7/+10
| | | | | | | | This can happen when using a split out state database and we've upgraded the schema version without there being any changes in the state schema.
* | Merge commit '0312266ee' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-211-3/+5
|\|
| * Add type hints to the logging context code. (#8939)Patrick Cloke2021-01-051-3/+5
| |
* | Merge commit '1c9a85056' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-219-149/+216
|\|
| * Add type hints to the crypto module. (#8999)Patrick Cloke2021-01-041-5/+5
| |
| * Add additional type hints to the storage module. (#8980)Patrick Cloke2020-12-308-144/+211
| |
* | Merge commit '9999eb2d0' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-212-2/+23
|\|
| * Add type hints to admin and room list handlers. (#8973)Patrick Cloke2020-12-291-2/+5
| |
| * Drop the unused local_invites table. (#8979)Patrick Cloke2020-12-291-0/+18
| | | | | | This table has been unused since Synapse v1.17.0.
* | Merge commit '28877fade' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-212-0/+56
|\|
| * Allow re-using a UI auth validation for a period of time (#8970)Patrick Cloke2020-12-182-0/+56
| |
* | Merge commit 'a7a913918' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-201-16/+184
|\|
| * Try and drop stale extremities. (#8929)Erik Johnston2020-12-181-16/+184
| | | | | | | | If we see stale extremities while persisting events, and notice that they don't change the result of state resolution, we drop them.
* | Merge commit 'c9c1c9d82' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-203-17/+18
|\|
| * Use the simple dictionary in full text search for the user directory (#8959)Brendan Abolivier2020-12-171-12/+12
| | | | | | | | | | * Use the simple dictionary in fts for the user directory * Clarify naming
| * Make search statement in List Room and User Admin API case-insensitive (#8931)Dirk Klimpel2020-12-172-5/+6
| |
* | Merge commit 'bd30cfe86' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-164-43/+64
|\|
| * Convert internal pusher dicts to attrs classes. (#8940)Patrick Cloke2020-12-163-41/+59
| | | | | | This improves type hinting and should use less memory.
| * Do not assume that the contents dictionary includes history_visibility. (#8945)Patrick Cloke2020-12-161-2/+5
| |
* | Merge commit '01333681b' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-161-10/+0
|\|
| * Fix handling of stream tokens for push. (#8943)Patrick Cloke2020-12-151-10/+0
| | | | | | | | Removes faulty assertions and fixes the logic to ensure the max stream token is always set.
* | Merge commit 'f14428b25' into anoa/dinsic_release_1_31_0Andrew Morgan2021-04-161-0/+32
|\|
| * Add number of local devices to Room Details Admin API (#8886)Dirk Klimpel2020-12-111-0/+32
| |
* | Merge commit 'cf7d3c90d' into dinsicAndrew Morgan2021-04-163-1/+45
|\|
| * Pass room_id to get_auth_chain_difference (#8879)Erik Johnston2020-12-041-1/+3
| | | | | | | | | | This is so that we can choose which algorithm to use based on the room ID.
| * UIA: offer only available auth flowsRichard van der Hoff2020-12-022-0/+42
| | | | | | | | | | | | | | During user-interactive auth, do not offer password auth to users with no password, nor SSO auth to users with no SSO. Fixes #7559.
* | Add a config option to prioritise local users in user directory search ↵Andrew Morgan2021-02-191-9/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | results (#84) * Add a config option to prioritise local users in user directory search results (#9383) This PR adds a homeserver config option, `user_directory.prefer_local_users`, that when enabled will show local users higher in user directory search results than remote users. This option is off by default. Note that turning this on doesn't necessarily mean that remote users will always be put below local users, but they should be assuming all other ranking factors (search query match, profile information present etc) are identical. This is useful for, say, University networks that are openly federating, but want to prioritise local students and staff in the user directory over other random users. * Don't mix simple and english psql query types
* | Show knock rooms in the public room directory and inform clients they can be ↵Andrew Morgan2021-02-101-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | knocked on (#82) This PR implements the ["Changes regarding the Public Rooms Directory"](https://github.com/Sorunome/matrix-doc/blob/soru/knock/proposals/2403-knock.md#changes-regarding-the-public-rooms-directory) section of knocking MSC2403. Specifically, it: * Allows rooms with `join_rule` "knock" to be returned by the query behind the public rooms directory * Adds the field `join_rule` to each room entry returned by a public rooms directory query, so clients can know whether to attempt a join or knock on a room This PR is a clone of [the mainline PR](https://github.com/matrix-org/synapse/pull/9359). Complement tests for this change: https://github.com/matrix-org/complement/pull/72.
* | Add knocking support (#81)Andrew Morgan2021-02-093-1/+19
| | | | | | | | | | | | | | | | | | Implement knocking as defined by https://github.com/matrix-org/matrix-doc/pull/2403 This is the base knocking stuff, taken from https://github.com/matrix-org/synapse/pull/6739 and does not include any public room directory changes. While knocking hasn't merged yet on mainline due to waiting on getting Complement into Synapse's CI, the code has been well-tested.
* | Merge commit 'd3ed93504' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-314-12/+12
|\|
| * Add missing `ordering` to background updates (#8850)Richard van der Hoff2020-12-014-12/+12
| | | | | | | | | | | | | | It's important that we make sure our background updates happen in a defined order, to avoid disasters like #6923. Add an ordering to all of the background updates that have landed since #7190.
* | Merge commit '09ac0569f' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-312-1/+20
|\|
| * Drop (almost) unused index on event_json (#8845)Richard van der Hoff2020-11-302-1/+20
| |
* | Merge commit '7c4344747' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-311-1/+33
|\|
| * Speed up remote invite rejection database call (#8815)Andrew Morgan2020-11-251-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | This is another PR that grew out of #6739. The existing code for checking whether a user is currently invited to a room when they want to leave the room looks like the following: https://github.com/matrix-org/synapse/blob/f737368a26bb9eea401fcc3a5bdd7e0b59e91f09/synapse/handlers/room_member.py#L518-L540 It calls `get_invite_for_local_user_in_room`, which will actually query *all* rooms the user has been invited to, before iterating over them and matching via the room ID. It will then return a tuple of a lot of information which we pull the event ID out of. I need to do a similar check for knocking, but this code wasn't very efficient. I then tried to write a different implementation using `StateHandler.get_current_state` but this actually didn't work as we haven't *joined* the room yet - we've only been invited to it. That means that only certain tables in Synapse have our desired `invite` membership state. One of those tables is `local_current_membership`. So I wrote a store method that just queries that table instead
* | Merge commit '8ca120df7' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-311-1/+6
|\|
| * Improve appservice handler to send only the most recent read receipts when ↵Will Hunt2020-11-181-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no stream_id is stored. (#8744) * Make this line debug (it's noisy) * Don't include from_key for presence if we are at 0 * Limit read receipts for all rooms to 100 * changelog.d/8744.bugfix * Allow from_key to be None * Update 8744.bugfix * The from_key is superflous * Update comment
| * Add admin API for logging in as a user (#8617)Erik Johnston2020-11-171-0/+2
| |
* | Merged commit 'deff8f628' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-311-0/+2
| |
* | Merge commit 'f12589547' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-311-4/+6
|\|
| * Generalise _maybe_store_room_on_invite (#8754)Andrew Morgan2020-11-131-4/+6
| | | | | | | | | | | | | | | | | | There's a handy function called maybe_store_room_on_invite which allows us to create an entry in the rooms table for a room and its version for which we aren't joined to yet, but we can reference when ingesting events about. This is currently used for invites where we receive some stripped state about the room and pass it down via /sync to the client, without us being in the room yet. There is a similar requirement for knocking, where we will eventually do the same thing, and need an entry in the rooms table as well. Thus, reusing this function works, however its name needs to be generalised a bit. Separated out from #6739.
* | Merge commit '4a54b821b' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-312-13/+76
|\|
| * Cache event ID to auth event IDs lookups (#8752)Erik Johnston2020-11-131-12/+70
| | | | | | | | | | This should hopefully speed up `get_auth_chain_difference` a bit in the case of repeated state res on the same rooms. `get_auth_chain_difference` does a breadth first walk of the auth graphs by repeatedly looking up events' auth events. Different state resolutions on the same room will end up doing a lot of the same event to auth events lookups, so by caching them we should speed things up in cases of repeated state resolutions on the same room.
| * Enable reconnection in DB pool (#8726)Erik Johnston2020-11-121-1/+6
| | | | | | | | | | | | `adbapi.ConnectionPool` let's you turn on auto reconnect of DB connections. This is off by default. As far as I can tell if its not enabled dead connections never get removed from the pool. Maybe helps #8574
* | Merge commit 'c3119d153' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-314-3/+161
|\|
| * Add an admin API for users' media statistics (#8700)Dirk Klimpel2020-11-051-0/+127
| | | | | | | | | | | | | | | | Add `GET /_synapse/admin/v1/statistics/users/media` to get statisics about local media usage by users. Related to #6094 It is the first API for statistics. Goal is to avoid/reduce usage of sql queries like [Wiki analyzing Synapse](https://github.com/matrix-org/synapse/wiki/SQL-for-analyzing-Synapse-PostgreSQL-database-stats) Signed-off-by: Dirk Klimpel dirk@klimpel.org
| * Improve start time by adding index to e2e_cross_signing_keys (#8694)Erik Johnston2020-11-022-2/+33
| | | | | | We do a `SELECT MAX(stream_id) FROM e2e_cross_signing_keys` on startup.
| * Fix error handling around when completing an AS transaction (#8693)Brendan Abolivier2020-10-301-1/+1
| |
* | Merge commit 'f27a78969' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-312-1/+28
|\|
| * Fix race for concurrent downloads of remote media. (#8682)Erik Johnston2020-10-301-0/+27
| | | | | | Fixes #6755
| * Fix optional parameter in stripped state storage method (#8688)Andrew Morgan2020-10-301-1/+1
| | | | | | Missed in #8671.
* | Merge commit 'ef2d62701' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-312-11/+58
|\|
| * Add ability for access tokens to belong to one user but grant access to ↵Erik Johnston2020-10-292-9/+56
| | | | | | | | | | | | | | | | | | | | another user. (#8616) We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't). A future PR will add an API for creating such a token. When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.
* | Merge commit 'c97da1e45' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-315-51/+75
|\|
| * Merge pull request #8678 from matrix-org/rav/fix_frozen_eventsRichard van der Hoff2020-10-282-9/+7
| |\ | | | | | | Fix serialisation errors when using third-party event rules.
| | * Remove frozendict_json_encoder and support frozendicts everywhereRichard van der Hoff2020-10-282-9/+7
| | | | | | | | | | | | | | | | | | Not being able to serialise `frozendicts` is fragile, and it's annoying to have to think about which serialiser you want. There's no real downside to supporting frozendicts, so let's just have one json encoder.
| * | Add type hints to application services. (#8655)Patrick Cloke2020-10-281-38/+60
| | |
| * | Don't pull event from DB when handling replication traffic. (#8669)Erik Johnston2020-10-281-2/+6
| | | | | | | | | | | | | | | I was trying to make it so that we didn't have to start a background task when handling RDATA, but that is a bigger job (due to all the code in `generic_worker`). However I still think not pulling the event from the DB may help reduce some DB usage due to replication, even if most workers will simply go and pull that event from the DB later anyway. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * | Tell Black to format code for Python 3.5 (#8664)Dan Callahan2020-10-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | This allows trailing commas in multi-line arg lists. Minor, but we might as well keep our formatting current with regard to our minimum supported Python version. Signed-off-by: Dan Callahan <danc@element.io>
* | | Merge commit '88e1d0c52' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-314-1/+113
|\| |
| * | Abstract code for stripping room state into a separate method (#8671)Andrew Morgan2020-10-271-1/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a requirement for [knocking](https://github.com/matrix-org/synapse/pull/6739), and is abstracting some code that was originally used by the invite flow. I'm separating it out into this PR as it's a fairly contained change. For a bit of context: when you invite a user to a room, you send them [stripped state events](https://matrix.org/docs/spec/server_server/unstable#put-matrix-federation-v2-invite-roomid-eventid) as part of `invite_room_state`. This is so that their client can display useful information such as the room name and avatar. The same requirement applies to knocking, as it would be nice for clients to be able to display a list of rooms you've knocked on - room name and avatar included. The reason we're sending membership events down as well is in the case that you are invited to a room that does not have an avatar or name set. In that case, the client should use the displayname/avatar of the inviter. That information is located in the inviter's membership event. This is optional as knocks don't really have any user in the room to link up to. When you knock on a room, your knock is sent by you and inserted into the room. It wouldn't *really* make sense to show the avatar of a random user - plus it'd be a data leak. So I've opted not to send membership events to the client here. The UX on the client for when you knock on a room without a name/avatar is a separate problem. In essence this is just moving some inline code to a reusable store method.
| * | Add admin API to list users' local media (#8647)Dirk Klimpel2020-10-273-0/+60
| | | | | | | | | Add admin API `GET /_synapse/admin/v1/users/<user_id>/media` to get information of users' uploaded files.
* | | Merge commit '24229fac0' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-314-21/+144
|\| |
| * | Add type hints for account validity handler (#8620)Patrick Cloke2020-10-262-4/+4
| | | | | | | | | This also fixes a bug by fixing handling of an account which doesn't expire.
| * | Split admin API for reported events into a detail and a list view (#8539)Dirk Klimpel2020-10-261-17/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Split admin API for reported events in detail und list view. API was introduced with #8217 in synapse v.1.21.0. It makes the list (`GET /_synapse/admin/v1/event_reports`) less complex and provides a better overview. The details can be queried with: `GET /_synapse/admin/v1/event_reports/<report_id>`. It is similar to room and users API. It is a kind of regression in `GET /_synapse/admin/v1/event_reports`. `event_json` was removed. But the api was introduced one version before and it is an admin API (not under spec). Signed-off-by: Dirk Klimpel dirk@klimpel.org
| * | Add an admin api to delete local media. (#8519)Dirk Klimpel2020-10-261-0/+53
| | | | | | | | | | | | | | | | | | Related to: #6459, #3479 Add `DELETE /_synapse/admin/v1/media/<server_name>/<media_id>` to delete a single file from server.
| * | Merge branch 'release-v1.22.0' into developErik Johnston2020-10-261-4/+5
| |\|
| * | Fix get|set_type_stream_id_for_appservice store functions (#8648)Will Hunt2020-10-261-7/+22
| | |
* | | Merge commit '7a3adbd7a' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-312-11/+27
|\ \ \ | | |/ | |/|
| * | Fix get|set_type_stream_id_for_appservice store functions (#8648)Will Hunt2020-10-261-7/+22
| | |
| * | Fix user_daily_visits to not have duplicate rows for UA. (#8654)Erik Johnston2020-10-261-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix user_daily_visits to not have duplicate rows for UA. Fixes #8641. * Newsfile * Fix typo. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Merge commit 'b19b63e6b' into anoa/dinsic_release_1_23_1Andrew Morgan2020-12-312-74/+83
|\ \ \ | | |/ | |/|
| * | Type hints for RegistrationStore (#8615)Erik Johnston2020-10-222-74/+83
| |/
* | Merge commit 'de5cafe98' into dinsicAndrew Morgan2020-12-317-31/+21
|\|
| * Add type hints to profile and base handlers. (#8609)Patrick Cloke2020-10-211-3/+3
| |
| * Consistently use wrap_as_background_task in more places (#8599)Patrick Cloke2020-10-202-14/+13
| |
| * Move schema file for as_device_stream (#8590)Will Hunt2020-10-201-3/+2
| | | | | | | | | | | | | | | | | | * Move schema file * Add a . * Add matching changelog entry * Fix sqlite
| * Drop unused `device_max_stream_id` table (#8589)Vasilis Gerakaris2020-10-191-0/+1
| | | | | | Signed-off-by: Vasilis Gerakaris <vasilis.gerakaris@navarino.gr>
| * Add `DeferredCache.get_immediate` method (#8568)Richard van der Hoff2020-10-193-12/+3
| | | | | | | | | | | | | | | | | | | | | | * Add `DeferredCache.get_immediate` method A bunch of things that are currently calling `DeferredCache.get` are only really interested in the result if it's completed. We can optimise and simplify this case. * Remove unused 'default' parameter to DeferredCache.get() * another get_immediate instance
* | Merge commit '97647b33c' into dinsicAndrew Morgan2020-12-317-26/+25
|\|
| * Replace DeferredCache with LruCache where possible (#8563)Richard van der Hoff2020-10-195-22/+21
| | | | | | Most of these uses don't need a full-blown DeferredCache; LruCache is lighter and more appropriate.
| * Pre-emptively fix synapse.storage.types.Connection for future mypy release ↵Jonathan de Jong2020-10-172-3/+3
| | | | | | | | | | (#8577) Fix the Connection protocol according to typeshed's assertions about sqlite3.Connection
| * Clean-up old transaction IDs on the background worker. (#8544)Patrick Cloke2020-10-161-1/+1
| |
* | Merge commit '3ee17585c' into dinsicAndrew Morgan2020-12-313-9/+130
|\|
| * Send some ephemeral events to appservices (#8437)Will Hunt2020-10-153-9/+130
| | | | | | Optionally sends typing, presence, and read receipt information to appservices.
* | Merge commit '74976a8e4' into dinsicAndrew Morgan2020-12-3144-1151/+2073
|\|
| * Merge pull request #8548 from matrix-org/rav/deferred_cacheRichard van der Hoff2020-10-153-6/+8
| |\ | | | | | | Rename Cache to DeferredCache, and related changes
| | * move DeferredCache into its own moduleRichard van der Hoff2020-10-143-3/+5
| | |
| | * Rename Cache->DeferredCacheRichard van der Hoff2020-10-143-6/+6
| | |
| * | Include user agent in user daily visits table (#8503)Neil Johnson2020-10-152-3/+26
| | | | | | | | | Include user agent in user daily visits table.
| * | Use autocommit mode for single statement DB functions. (#8542)Erik Johnston2020-10-144-70/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Autocommit means that we don't wrap the functions in transactions, and instead get executed directly. Introduced in #8456. This will help: 1. reduce the number of `could not serialize access due to concurrent delete` errors that we see (though there are a few functions that often cause serialization errors that we don't fix here); 2. improve the DB performance, as it no longer needs to deal with the overhead of `REPEATABLE READ` isolation levels; and 3. improve wall clock speed of these functions, as we no longer need to send `BEGIN` and `COMMIT` to the DB. Some notes about the differences between autocommit mode and our default `REPEATABLE READ` transactions: 1. Currently `autocommit` only applies when using PostgreSQL, and is ignored when using SQLite (due to silliness with [Twisted DB classes](https://twistedmatrix.com/trac/ticket/9998)). 2. Autocommit functions may get retried on error, which means they can get applied *twice* (or more) to the DB (since they are not in a transaction the previous call would not get rolled back). This means that the functions need to be idempotent (or otherwise not care about being called multiple times). Read queries, simple deletes, and updates/upserts that replace rows (rather than generating new values from existing rows) are all idempotent. 3. Autocommit functions no longer get executed in [`REPEATABLE READ`](https://www.postgresql.org/docs/current/transaction-iso.html) isolation level, and so data can change queries, which is fine for single statement queries.
| * | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-141-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
| * | Make sure a retention policy is a state event (#8527)Brendan Abolivier2020-10-141-0/+4
| |/ | | | | | | | | * Make sure a retention policy is a state event * Changelog
| * Move additional tasks to the background worker, part 4 (#8513)Patrick Cloke2020-10-133-152/+150
| |
| * Fix message duplication if something goes wrong after persisting the event ↵Erik Johnston2020-10-135-15/+241
| | | | | | | | | | (#8476) Should fix #3365.
| * Make event persisters periodically announce position over replication. (#8499)Erik Johnston2020-10-122-0/+12
| | | | | | | | | | Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress. This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.
| * Only send RDATA for instance local events. (#8496)Erik Johnston2020-10-093-19/+42
| | | | | | | | | | When pulling events out of the DB to send over replication we were not filtering by instance name, and so we were sending events for other instances.
| * Move additional tasks to the background worker, part 3 (#8489)Patrick Cloke2020-10-096-271/+272
| |
| * Add type hints to some handlers (#8505)Patrick Cloke2020-10-091-1/+3
| |
| * Invalidate the cache when an olm fallback key is uploaded (#8501)Hubert Chathi2020-10-081-0/+4
| |
| * Move additional tasks to the background worker (#8458)Patrick Cloke2020-10-075-175/+179
| |
| * Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-075-8/+110
| | | | | | | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
| * Use vector clocks for room stream tokens. (#8439)Erik Johnston2020-10-072-37/+268
| | | | | | | | | | | | | | | | | | | | Currently when using multiple event persisters we (in the worst case) don't tell clients about events until all event persisters have persisted new events after the original event. This is a suboptimal, especially if one of the event persisters goes down. To handle this, we encode the position of each event persister in the room tokens so that we can send events to clients immediately. To reduce the size of the token we do two things: 1. We create a unique immutable persistent mapping between instance names and a generated small integer ID, which we can encode in the tokens instead of the instance name; and 2. We encode the "persisted upto position" of the room token and then only explicitly include instances that have positions strictly greater than that. The new tokens look something like: `m3478~1.3488~2.3489`, where the first number is the min position, and the subsequent `-` separated pairs are the instance ID to positions map. (We use `.` and `~` as separators as they're URL safe and not already used by `StreamToken`).
| * Add typing information to the device handler. (#8407)Patrick Cloke2020-10-071-3/+3
| |
| * Add support for MSC2697: Dehydrated devices (#8380)Hubert Chathi2020-10-074-4/+133
| | | | | | | | This allows a user to store an offline device on the server and then restore it at a subsequent login.
| * Add support for MSC2732: olm fallback keys (#8312)Hubert Chathi2020-10-062-1/+123
| |
| * Remove stream ordering from Metadata dict (#8452)Richard van der Hoff2020-10-054-23/+22
| | | | | | | | | | | | | | | | There's no need for it to be in the dict as well as the events table. Instead, we store it in a separate attribute in the EventInternalMetadata object, and populate that on load. This means that we can rely on it being correctly populated for any event which has been persited to the database.
| * Do not assume that account data is of the correct form. (#8454)Patrick Cloke2020-10-051-2/+7
| | | | | | | | This fixes a bug where `m.ignored_user_list` was assumed to be a dict, leading to odd behavior for users who set it to something else.
| * Add logging on startup/shutdown (#8448)Erik Johnston2020-10-0220-107/+134
| | | | | | | | | | This is so we can tell what is going on when things are taking a while to start up. The main change here is to ensure that transactions that are created during startup get correctly logged like normal transactions.
| * Speed up unit tests when using PostgreSQL (#8450)Erik Johnston2020-10-021-1/+12
| |
| * Allow background tasks to be run on a separate worker. (#8369)Patrick Cloke2020-10-025-259/+266
| |
| * Merge tag 'v1.21.0rc2' into developRichard van der Hoff2020-10-021-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc2 (2020-10-02) ============================== Features -------- - Convert additional templates from inline HTML to Jinja2 templates. ([\#8444](https://github.com/matrix-org/synapse/issues/8444)) Bugfixes -------- - Fix a regression in v1.21.0rc1 which broke thumbnails of remote media. ([\#8438](https://github.com/matrix-org/synapse/issues/8438)) - Do not expose the experimental `uk.half-shot.msc2778.login.application_service` flow in the login API, which caused a compatibility problem with Element iOS. ([\#8440](https://github.com/matrix-org/synapse/issues/8440)) - Fix malformed log line in new federation "catch up" logic. ([\#8442](https://github.com/matrix-org/synapse/issues/8442)) - Fix DB query on startup for negative streams which caused long start up times. Introduced in [\#8374](https://github.com/matrix-org/synapse/issues/8374). ([\#8447](https://github.com/matrix-org/synapse/issues/8447))
| * | Enable mypy checking for unreachable code and fix instances. (#8432)Patrick Cloke2020-10-014-18/+10
| | |
* | | Allow users to click account renewal links multiple times without hitting an ↵Andrew Morgan2020-12-302-13/+55
| | | | | | | | | | | | 'Invalid Token' page (#74)
* | | Make sure a retention policy is a state event (#8527)Brendan Abolivier2020-10-211-0/+4
| | | | | | | | | | | | | | | * Make sure a retention policy is a state event * Changelog
* | | Merge commit '9991aaa49' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-211-7/+0
|\ \ \ | | | | | | | | | | | | | | | | | | | | * commit '9991aaa49': 1.21.2 Remove racey assertion in MultiWriterIDGenerator (#8530)
| * | | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-151-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
* | | | Merge commit 'f76194a02' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-215-5/+107
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'f76194a02': 1.21.0 Update change log 1.21.0rc3 Reduce serialization errors in MultiWriterIdGen (#8456) Add Ubuntu 20.10 (Groovy Gorilla) to build scripts. (#8475) move #8444 to 'feature' linkify changelog
| * | | Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-075-5/+107
| | |/ | |/| | | | | | | | | | | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
* | | Merge commit '6a8fd03ac' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-211-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '6a8fd03ac': 1.21.0rc2 1.21.0rc2 Fix bug in remote thumbnail search (#8438) Fix DB query on startup for negative streams. (#8447) Convert additional templates to Jinja (#8444) Fix malformed log line in new federation "catch up" logic (#8442) Do not expose the experimental appservice login flow to clients. (#8440) update changelog fix a logging error in thumbnailer (#8435) changelog fixes fix version number
| * | Fix DB query on startup for negative streams. (#8447)Erik Johnston2020-10-021-1/+1
| |/ | | | | | | | | | | | | | | For negative streams we have to negate the internal stream ID before querying the DB. The effect of this bug was to query far too many rows, slowing start up time, but we would correctly filter the results afterwards so there was no ill effect.
* | Merge commit 'cc40a59b4' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-214-42/+62
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'cc40a59b4': 1.21.0 Add prometheus metrics to track federation delays (#8430) Make token serializing/deserializing async (#8427) Allow additional SSO properties to be passed to the client (#8413) changelog Add an improved "forward extremities" metric Rewrite BucketCollector Fix _exposition.py to stop stripping samples Drop support for ancient prometheus_client (#8426) Various clean ups to room stream tokens. (#8423) changelog Report state res metrics to Prometheus and log Move Measure calls into `resolve_events_with_store` Expose a `get_resource_usage` method in `Measure` Move `resolve_events_with_store` into StateResolutionHandler
| * Make token serializing/deserializing async (#8427)Erik Johnston2020-09-301-4/+4
| | | | | | The idea is that in future tokens will encode a mapping of instance to position. However, we don't want to include the full instance name in the string representation, so instead we'll have a mapping between instance name and an immutable integer ID in the DB that we can use instead. We'll then do the lookup when we serialize/deserialize the token (we could alternatively pass around an `Instance` type that includes both the name and ID, but that turns out to be a lot more invasive).
| * Add an improved "forward extremities" metricRichard van der Hoff2020-09-301-2/+25
| | | | | | | | | | Hopefully, N(extremities) * N(state_events) is a more realistic approximation to "how big a problem is this room?".
| * Rewrite BucketCollectorRichard van der Hoff2020-09-301-16/+10
| | | | | | | | | | | | | | | | | | | | | | | | This was a bit unweildy for what I wanted: in particular, I wanted to assign each measurement straight into a bucket, rather than storing an intermediate Counter which didn't do any bucketing at all. I've replaced it with something that is hopefully a bit easier to use. (I'm not entirely sure what the difference between a HistogramMetricFamily and a GaugeHistogramMetricFamily is, but given our counters can go down as well as up the latter *sounds* more accurate?)
| * Various clean ups to room stream tokens. (#8423)Erik Johnston2020-09-292-20/+23
| |
* | Merge commit '8238b55e0' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-214-7/+31
|\| | | | | | | | | | | | | | | * commit '8238b55e0': Update description of server_name config option (#8415) Discard an empty upload_name before persisting an uploaded file (#7905) Don't table scan events on worker startup (#8419) Mypy fixes for `synapse.handlers.federation` (#8422)
| * Don't table scan events on worker startup (#8419)Erik Johnston2020-09-291-1/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix table scan of events on worker startup. This happened because we assumed "new" writers had an initial stream position of 0, so the replication code tried to fetch all events written by the instance between 0 and the current position. Instead, set the initial position of new writers to the current persisted up to position, on the assumption that new writers won't have written anything before that point. * Consider old writers coming back as "new". Otherwise we'd try and fetch entries between the old stale token and the current position, even though it won't have written any rows. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
| * Mypy fixes for `synapse.handlers.federation` (#8422)Richard van der Hoff2020-09-293-6/+6
| | | | | | For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.
* | Merge commit 'f43c66d23' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-216-4/+108
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'f43c66d23': Add support for running Complement against the local checkout (#8317) Filter out appservices from mau count (#8404) Only assert valid next_link params when provided (#8417) Add metrics to track success/otherwise of replication requests (#8406) Fix handling of connection timeouts in outgoing http requests (#8400) Changelog Don't check whether a 3pid is allowed to register during password reset Add checks for postgres sequence consistency (#8402) Create a mechanism for marking tests "logcontext clean" (#8399) Add `ui_auth_sessions_ips` table to `synapse_port_db` ignore list (#8410) A pair of tiny cleanups in the federation request code. (#8401) typo
| * Filter out appservices from mau count (#8404)Will Hunt2020-09-291-1/+8
| | | | | | This is an attempt to fix #8403.
| * Add checks for postgres sequence consistency (#8402)Erik Johnston2020-09-284-2/+99
| |
| * typoMatthew Hodgson2020-09-281-1/+1
| |
* | Merge commit '31acc5c30' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-219-36/+188
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '31acc5c30': Escape the error description on the sso_error template. (#8405) Fix occasional "Re-starting finished log context" from keyring (#8398) Allow existing users to login via OpenID Connect. (#8345) Fix schema delta for servers that have not backfilled (#8396) Fix MultiWriteIdGenerator's handling of restarts. (#8374) s/URLs/variables in changelog s/accidentally/incorrectly in changelog Update changelog wording Add type annotations to SimpleHttpClient (#8372) Add new sequences to port DB script (#8387) Add EventStreamPosition type (#8388) Mark the shadow_banned column as boolean in synapse_port_db. (#8386)
| * Allow existing users to login via OpenID Connect. (#8345)Tdxdxoz2020-09-251-2/+2
| | | | | | | | | | | | | | Co-authored-by: Benjamin Koch <bbbsnowball@gmail.com> This adds configuration flags that will match a user to pre-existing users when logging in via OpenID Connect. This is useful when switching to an existing SSO system.
| * Fix schema delta for servers that have not backfilled (#8396)Erik Johnston2020-09-252-2/+8
| | | | | | | | | | Fixes #8395.
| * Fix MultiWriteIdGenerator's handling of restarts. (#8374)Erik Johnston2020-09-244-22/+160
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On startup `MultiWriteIdGenerator` fetches the maximum stream ID for each instance from the table and uses that as its initial "current position" for each writer. This is problematic as a) it involves either a scan of events table or an index (neither of which is ideal), and b) if rows are being persisted out of order elsewhere while the process restarts then using the maximum stream ID is not correct. This could theoretically lead to race conditions where e.g. events that are persisted out of order are not sent down sync streams. We fix this by creating a new table that tracks the current positions of each writer to the stream, and update it each time we finish persisting a new entry. This is a relatively small overhead when persisting events. However for the cache invalidation stream this is a much bigger relative overhead, so instead we note that for invalidation we don't actually care about reliability over restarts (as there's no caches to invalidate) and simply don't bother reading and writing to the new table in that particular case.
| * Add EventStreamPosition type (#8388)Erik Johnston2020-09-243-11/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)
* | Merge commit '2983049a7' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-2114-83/+123
|\| | | | | | | | | | | | | | | | | | | | | | | * commit '2983049a7': Factor out `_send_dummy_event_for_room` (#8370) Improve logging of state resolution (#8371) Fix bug which caused failure on join with malformed membership events (#8385) Use `async with` for ID gens (#8383) Don't push if an user account has expired (#8353) Do not check lint/test dependencies at runtime. (#8377) Add note to reverse_proxy.md about disabling Apache's mod_security2 (#8375) Changelog
| * Fix bug which caused failure on join with malformed membership events (#8385)Richard van der Hoff2020-09-231-3/+7
| |
| * Use `async with` for ID gens (#8383)Erik Johnston2020-09-2313-80/+102
| | | | | | This will allow us to hit the DB after we've finished using the generated stream ID.
| * Don't push if an user account has expired (#8353)Mathieu Velten2020-09-231-0/+14
| |
* | Merge commit '4325be1a5' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-2126-48/+205
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '4325be1a5': Fix missing null character check on guest_access room state Fixed a bug with reactivating users with the admin API (#8362) Admin API for reported events (#8217) Fix wording of deprecation notice in changelog Deprecation warning for synapse admin api being accessible under /_matrix Create function to check for long names in devices (#8364) Add a comment re #1691 Fix a bad merge from release-v1.20.0. (#8354) Admin API for querying rooms where a user is a member (#8306) Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322) Simplify super() calls to Python 3 syntax. (#8344) Allow appservice users to /login (#8320) Update test logging to be able to accept braces (#8335) Move lint dependencies to extras_require (#8330)
| * Fix missing null character check on guest_access room stateAndrew Morgan2020-09-221-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When updating room_stats_state, we try to check for null bytes slipping in to the content for state events. It turns out we had added guest_access as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a m.room.guest_access event then breaks room_stats_state updates. This PR adds the check for guest_access. A further PR will improve this function so that this hopefully does not happen again in future.
| * Fixed a bug with reactivating users with the admin API (#8362)Dirk Klimpel2020-09-221-1/+1
| | | | | | | | | | | | | | Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.
| * Admin API for reported events (#8217)Dirk Klimpel2020-09-221-0/+95
| | | | | | Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`
| * Merge tag 'v1.20.0rc5' into developPatrick Cloke2020-09-181-8/+5
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](https://github.com/matrix-org/synapse/issues/8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](https://github.com/matrix-org/synapse/issues/8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](https://github.com/matrix-org/synapse/issues/8349)) Internal Changes ---------------- - Blacklist [MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) SyTests until it is implemented. ([\#8285](https://github.com/matrix-org/synapse/issues/8285))
| * | Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322)reivilibre2020-09-181-2/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.
| * | Simplify super() calls to Python 3 syntax. (#8344)Patrick Cloke2020-09-1825-45/+43
| | | | | | | | | | | | | | | | | | | | | This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py
* | | Merge commit '43f2b67e4' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-201-8/+5
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | * commit '43f2b67e4': Intelligently select extremities used in backfill. (#8349) Add flags to /versions about whether new rooms are encrypted by default. (#8343) Fix ratelimiting for federation `/send` requests. (#8342) blacklist MSC2753 sytests until it's implemented in synapse (#8285)
| * | Intelligently select extremities used in backfill. (#8349)Erik Johnston2020-09-181-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.
* | | Merge commit '837293c31' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-2020-111/+225
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '837293c31': Remove obsolete __future__ imports (#8337) Use admin_patterns for all admin APIs. (#8331) Fix a potential bug of UnboundLocalError (#8329) Switch metaclass initialization to python 3-compatible syntax (#8326) Catch-up after Federation Outage (split, 4): catch-up loop (#8272) Use slots in attrs classes where possible (#8296) Fix typos in comments. Add the topic and avatar to the room details admin API (#8305) Improve SAML error messages (#8248) Add experimental support for sharding event persister. Again. (#8294) Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281) Use TLSv1.2 for fake servers in tests (#8208) Add /_synapse/client to the reverse proxy docs (#8227) Clean up `Notifier.on_new_room_event` code path (#8288)
| * | Remove obsolete __future__ imports (#8337)Jonathan de Jong2020-09-171-2/+0
| | |
| * | Switch metaclass initialization to python 3-compatible syntax (#8326)Jonathan de Jong2020-09-164-17/+10
| | |
| * | Catch-up after Federation Outage (split, 4): catch-up loop (#8272)reivilibre2020-09-151-1/+42
| | |
| * | Use slots in attrs classes where possible (#8296)Patrick Cloke2020-09-145-5/+5
| | | | | | | | | | | | | | | slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.
| * | Add the topic and avatar to the room details admin API (#8305)Tulir Asokan2020-09-141-1/+2
| | |
| * | Add experimental support for sharding event persister. Again. (#8294)Erik Johnston2020-09-147-29/+105
| | | | | | | | | | | | | | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
| * | Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)Erik Johnston2020-09-114-56/+61
| | |
| * | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-101-2/+3
| |\|
* | | Merge commit '453dfe210' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-202-11/+148
|\| | | | | | | | | | | | | | | | | * commit '453dfe210': blacklist MSC2753 sytests until it's implemented in synapse (#8285) Don't remember `enabled` of deleted push rules and properly return 404 for missing push rules in `.../actions` and `.../enabled` (#7796)
| * | Don't remember `enabled` of deleted push rules and properly return 404 for ↵reivilibre2020-09-092-11/+148
| | | | | | | | | | | | | | | | | | | | | missing push rules in `.../actions` and `.../enabled` (#7796) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Merge commit 'e45b83411' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-206-20/+185
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'e45b83411': Add types to async_helpers (#8260) Fix mypy error on develop (#8282) Include method in thumbnail media name (#7124) Add types to StreamToken and RoomStreamToken (#8279) Add a config option for validating 'next_link' parameters against a domain whitelist (#8275) Clean up types for PaginationConfig (#8250) Use the right constructor for log records (#8278) Fix `MultiWriterIdGenerator.current_position`. (#8257)
| * | Include method in thumbnail media name (#7124)DeepBlueV7.X2020-09-083-0/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
| * | Add types to StreamToken and RoomStreamToken (#8279)Erik Johnston2020-09-082-14/+14
| | | | | | | | | The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.
| * | Fix `MultiWriterIdGenerator.current_position`. (#8257)Erik Johnston2020-09-081-6/+37
| | | | | | | | | | | | | | | It did not correctly handle IDs finishing being persisted out of order, resulting in the `current_position` lagging until new IDs are persisted.
* | | Merge commit 'd4daff9b5' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-201-2/+3
|\ \ \ | | |/ | |/| | | | | | | * commit 'd4daff9b5': Fix /notifications and pushers misbehaving because of unread counts (#8280)
| * | Fix /notifications and pushers misbehaving because of unread counts (#8280)Brendan Abolivier2020-09-081-2/+3
| | |
* | | Merge commit 'cca03dbec' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-202-30/+28
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | * commit 'cca03dbec': fix typo s/fixes/fix/ Directly import json from the standard library. (#8259) Allow for make_awaitable's return value to be re-used. (#8261) Rename 'populate_stats_process_rooms_2' background job back to 'populate_stats_process_rooms' again (#8243)
| * | Rename 'populate_stats_process_rooms_2' background job back to ↵Andrew Morgan2020-09-082-30/+28
| | | | | | | | | | | | | | | | | | | | | 'populate_stats_process_rooms' again (#8243) Fixes https://github.com/matrix-org/synapse/issues/8238 Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)
| * | Merge remote-tracking branch 'origin/release-v1.20.0' into developRichard van der Hoff2020-09-085-35/+111
| |\|
* | | Merge commit '525efab61' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-205-35/+111
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | * commit '525efab61': 1.20.0rc1 Systemd docs: configure workers to start after main process. (#8276) Only add rows to the push actions table if the event notifies or should be marked unread (#8274) Avoid table-scanning users at startup (#8271) Fix unread count failing on NULL values (#8270) Add more logging to debug slow startup (#8264) Refuse to upgrade database on worker processes (#8266)
| * | Avoid table-scanning users at startup (#8271)Richard van der Hoff2020-09-071-11/+14
| | | | | | | | | This takes about 10 seconds in the best case; often more.
| * | Fix unread count failing on NULL values (#8270)Brendan Abolivier2020-09-071-1/+6
| | | | | | | | | | | | Fix unread counts making sync fail if the value of the `unread_count` column in `event_push_summary` is `None`.
| * | Add more logging to debug slow startup (#8264)Richard van der Hoff2020-09-074-7/+32
| | | | | | | | | | | | I'm hoping this will provide some pointers for debugging https://github.com/matrix-org/synapse/issues/7968.
| * | Refuse to upgrade database on worker processes (#8266)Richard van der Hoff2020-09-071-17/+61
| | |
* | | Merge commit '7586fdf1e' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-201-5/+22
|\ \ \ | | |/ | |/| | | | | | | | | | | | | * commit '7586fdf1e': Bump canonicaljson to version 1.4.0 (#8262) Run database updates in a transaction (#8265) Add tests for `last_successful_stream_ordering` (#8258)
| * | Run database updates in a transaction (#8265)Richard van der Hoff2020-09-071-5/+22
| | | | | | | | | Fixes: #6467
* | | Merge commit '77b4711bc' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-203-37/+20
|\| | | | | | | | | | | | | | | | | | | | * commit '77b4711bc': Add cross-signing sigs to the `keys` object (#8234) Unread counts fixes (#8254) Fix a regression from calling read_templates. (#8252)
| * | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-063-37/+20
| |\|
| | * Add cross-signing sigs to the `keys` object (#8234)Richard van der Hoff2020-09-042-34/+17
| | | | | | | | | | | | | | | All the callers want this info in the same place, so let's reduce the duplication by doing it here.
| | * Unread counts fixes (#8254)Brendan Abolivier2020-09-041-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixup `ALTER TABLE` database queries Make the new columns nullable, because doing otherwise can wedge a server with a big database, as setting a default value rewrites the table. * Switch back to using the notifications count in the push badge Clients are likely to be confused if we send a push but the badge count is the unread messages one, and not the notifications one. * Changelog
* | | Merge commit '7513006b0' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-201-1/+1
|\| | | | | | | | | | | | | | * commit '7513006b0': In light of #8255, use BIGINTs for destination_rooms (#8256)
| * | In light of #8255, use BIGINTs for destination_rooms (#8256)reivilibre2020-09-041-1/+1
| | |
* | | Merge commit '17fa4c7ca' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-2016-34/+194
|\| | | | | | | | | | | | | | | | | | | | | | | * commit '17fa4c7ca': Catch up after Federation Outage (split, 2): Track last successful stream ordering after transmission (#8247) Catch-up after Federation Outage (split, 1) (#8230) Fix type signature in simple_select_one_onecol and friends (#8241) Stop sub-classing object (#8249)
| * | Catch up after Federation Outage (split, 2): Track last successful stream ↵reivilibre2020-09-042-0/+59
| | | | | | | | | | | | | | | ordering after transmission (#8247) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | Catch-up after Federation Outage (split, 1) (#8230)reivilibre2020-09-044-5/+109
| |/ | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
| * Fix type signature in simple_select_one_onecol and friends (#8241)reivilibre2020-09-041-10/+7
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * Stop sub-classing object (#8249)Patrick Cloke2020-09-0412-19/+19
| |
* | Merge commit '9f8abdcc3' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-207-100/+26
|\| | | | | | | | | * commit '9f8abdcc3': Revert "Add experimental support for sharding event persister. (#8170)" (#8242)
| * Revert "Add experimental support for sharding event persister. (#8170)" (#8242)Brendan Abolivier2020-09-047-100/+26
| | | | | | | | | | | | | | * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit 82c1ee1c22a87b9e6e3179947014b0f11c0a1ac3. * Changelog
* | Merge commit 'be16ee59a' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-201-44/+65
|\| | | | | | | | | | | | | * commit 'be16ee59a': Add type hints to more handlers (#8244) Remove obsolete order field in `send_new_transaction` (#8245) Split fetching device keys and signatures into two transactions (#8233)
| * Split fetching device keys and signatures into two transactions (#8233)Richard van der Hoff2020-09-031-44/+65
| | | | | | I think this is simpler (and moves stuff out of the db threads)
* | Merge commit '208e1d3eb' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-205-22/+68
|\| | | | | | | | | | | | | | | | | | | * commit '208e1d3eb': Fix typing for `@cached` wrapped functions (#8240) Remove useless changelog about reverting a #8239. Revert pinning of setuptools (#8239) Fix typing for SyncHandler (#8237) wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231) Add an overload for simple_select_one_onecol_txn. (#8235)
| * Fix typing for SyncHandler (#8237)Erik Johnston2020-09-032-5/+5
| |
| * wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231)Richard van der Hoff2020-09-032-17/+39
| | | | | | | | | | We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.
| * Add an overload for simple_select_one_onecol_txn. (#8235)Patrick Cloke2020-09-021-0/+24
| |
* | Merge commit '912e02491' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-201-15/+14
|\| | | | | | | | | * commit '912e02491': Convert runInteraction to async/await (#8156)
| * Convert runInteraction to async/await (#8156)Patrick Cloke2020-09-021-15/+14
| |
* | Merge commit '112266eaf' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-205-88/+267
|\| | | | | | | | | | | * commit '112266eaf': Add StreamStore to mypy (#8232) Re-implement unread counts (again) (#8059)
| * Add StreamStore to mypy (#8232)Erik Johnston2020-09-022-18/+62
| |
| * Re-implement unread counts (again) (#8059)Brendan Abolivier2020-09-024-70/+205
| |
* | Merge commit '0d4f614fd' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-2010-46/+175
|\| | | | | | | | | | | | | | | | | * commit '0d4f614fd': Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225) Add experimental support for sharding event persister. (#8170) Add /user/{user_id}/shared_rooms/ api (#7785) Do not try to store invalid data in the stats table (#8226) Convert the main methods run by the reactor to async. (#8213)
| * Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225)Richard van der Hoff2020-09-021-11/+6
| | | | | | | | | | We can use the existing `_get_e2e_device_keys_and_signatures_txn` instead of creating our own txn function
| * Add experimental support for sharding event persister. (#8170)Erik Johnston2020-09-027-26/+100
| | | | | | | | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
| * Add /user/{user_id}/shared_rooms/ api (#7785)Will Hunt2020-09-021-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add shared_rooms api * Add changelog * Add . * Wrap response in {"rooms": } * linting * Add unstable_features key * Remove options from isort that aren't part of 5.x `-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020 * Update imports to make isort happy * Add changelog * Update tox.ini file with correct invocation * fix linting again for isort * Vendor prefix unstable API * Fix to match spec * import Codes * import Codes * Use FORBIDDEN * Update changelog.d/7785.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Implement get_shared_rooms_for_users * a comma * trailing whitespace * Handle the easy feedback * Switch to using runInteraction * Add tests * Feedback * Seperate unstable endpoint from v2 * Add upgrade node * a line * Fix style by adding a blank line at EOF. * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Tulir Asokan <tulir@maunium.net> * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update UPGRADE.rst Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix UPGRADE/CHANGELOG unstable paths unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>
| * Do not try to store invalid data in the stats table (#8226)Patrick Cloke2020-09-021-8/+26
| |
* | Merge commit 'abeab964d' into anoa/dinsic_release_1_21_xAndrew Morgan2020-10-207-112/+172
|\| | | | | | | | | | | | | | | | | | | * commit 'abeab964d': Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224) Fix errors when updating the user directory with invalid data (#8223) Explain better what GDPR-erased means (#8189) Convert additional databases to async/await part 3 (#8201) Convert appservice code to async/await. (#8207) Rename `_get_e2e_device_keys_txn` (#8222)
| * Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224)Richard van der Hoff2020-09-022-20/+40
| | | | | | | | this makes it a bit clearer what's going on.
generated by cgit-magenta 1.5.1 (git 2.48.1) at 2025-08-09 02:46:16 +0000