summary refs log tree commit diff
path: root/synapse/storage (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge commit '5a5cf6460' into dinsicAndrew Morgan2020-08-031-1/+1
|\ | | | | | | | | * commit '5a5cf6460': Fix unread counts in sync
| * Fix unread counts in syncBrendan Abolivier2020-06-171-1/+1
| | | | | | | | | | * Always return an unread_count in get_unread_event_push_actions_by_room_for_user * Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
* | Merge commit '46613aaf7' into dinsicAndrew Morgan2020-08-032-27/+127
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '46613aaf7': (27 commits) Incorporate review Lint Incorporate review bits Pre-populate the unread_count column Don't update the schema version Use attr instead of a dict Lint Test that a mark_unread action updates the right counter when using a slave store Remove debug logging Test that a mark_unread action updates the right counter Fix summary rotation Log for invalid values of notif Fix SQL Fix schema update Lint Save the count of unread messages to event_push_summary Actually act on mark_unread Appease mypy Lint Use temporary prefixes as per the MSC ...
| * Implement unread counter (MSC2625) (#7673)Brendan Abolivier2020-06-172-27/+127
| |\ | | | | | | Implementation of https://github.com/matrix-org/matrix-doc/pull/2625
| | * Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1513-81/+62
| | |\
| | * | Incorporate reviewBrendan Abolivier2020-06-151-15/+11
| | | |
| | * | LintBrendan Abolivier2020-06-121-3/+8
| | | |
| | * | Incorporate review bitsBrendan Abolivier2020-06-121-14/+13
| | | |
| | * | Pre-populate the unread_count columnBrendan Abolivier2020-06-121-0/+5
| | | |
| | * | Don't update the schema versionBrendan Abolivier2020-06-122-1/+1
| | | |
| | * | Use attr instead of a dictBrendan Abolivier2020-06-121-21/+31
| | | |
| | * | Fix summary rotationBrendan Abolivier2020-06-121-12/+35
| | | |
| | * | Log for invalid values of notifBrendan Abolivier2020-06-111-0/+6
| | | |
| | * | Fix SQLBrendan Abolivier2020-06-111-3/+3
| | | |
| | * | Fix schema updateBrendan Abolivier2020-06-111-1/+1
| | | |
| | * | LintBrendan Abolivier2020-06-111-1/+2
| | | |
| | * | Save the count of unread messages to event_push_summaryBrendan Abolivier2020-06-113-20/+53
| | | |
| | * | Use temporary prefixes as per the MSCBrendan Abolivier2020-06-101-1/+1
| | | |
| | * | Use a more efficient way of calculating countersBrendan Abolivier2020-06-101-23/+20
| | | |
| | * | Add a new unread_counter to sync responsesBrendan Abolivier2020-06-101-2/+23
| | | |
| | * | Rename dont_push into mark_unreadBrendan Abolivier2020-06-101-3/+2
| | | |
| | * | Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-10294-11621/+18475
| | |\ \
| | * | | Add experimental "dont_push" push action to suppress push for notificationsMatthew Hodgson2019-09-191-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a potential solution to https://github.com/vector-im/riot-web/issues/3374 and https://github.com/vector-im/riot-web/issues/5953 as raised by Mozilla at https://github.com/vector-im/riot-web/issues/10868. This lets you define a push rule action which increases the badge count (unread notification) count on a given room, but doesn't actually send a push for that notification via email or HTTP. We might want to define this as the default behaviour for group chats in future to solve https://github.com/vector-im/riot-web/issues/3268 at last. This is implemented as a string action rather than a tweak because: * Other pushers don't care about the tweak, given they won't ever get pushed * The DB can store the tweak more efficiently using the existing `notify` table. * It avoids breaking the default_notif/highlight_action optimisations. Clients which generate their own notifs (e.g. desktop notifs from Riot/Web would need to be aware of the new push action) to uphold it. An alternative way to do this would be to maintain a `msg_count` alongside `highlight_count` and `notification_count` in `unread_notifications` in sync responses. However, doing this by counting the rows in `events` since the `stream_position` of the user's last read receipt turns out to be painfully slow (~200ms), perhaps due to the size of the events table. So instead, we use the highly optimised existing event_push_actions (and event_push_actions_staging) table to maintain the counts - using the code paths which already exist for tracking unread notification counts efficiently. These queries are typically ~3ms or so. The biggest issues I see here are: * We're slightly repurposing the `notif` field on `event_push_actions` to track whether a given action actually sent a `push` or not. This doesn't seem unreasonable, but it's slightly naughty given that previously the field explicitly tracked whether `notify` was true for the action (and as a result, it was uselessly always set to 1 in the DB). * We're going to put more load on the `event_push_actions` table for all the random group chats which people had previously muted. In practice i don't think there are many of these though. * There isn't an MSC for this yet (although this comment could become one).
* | | | | Merge commit 'f6f7511a4' into dinsicAndrew Morgan2020-08-034-37/+183
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit 'f6f7511a4': Refactor getting replication updates from database. (#7636)
| * | | | Refactor getting replication updates from database. (#7636)Erik Johnston2020-06-164-37/+183
| | | | | | | | | | | | | | | The aim here is to make it easier to reason about when streams are limited and when they're not, by moving the logic into the database functions themselves. This should mean we can kill of `db_query_to_update_function` function.
* | | | | Merge commit '231252516' into dinsicAndrew Morgan2020-08-031-4/+5
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '231252516': Fix "argument of type 'ObservableDeferred' is not iterable" error (#7708)
| * | | | Fix "argument of type 'ObservableDeferred' is not iterable" error (#7708)Patrick Cloke2020-06-161-4/+5
| | | | |
* | | | | Merge commit 'a3f11567d' into dinsicAndrew Morgan2020-08-0310-27/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit 'a3f11567d': Replace all remaining six usage with native Python 3 equivalents (#7704)
| * | | | Replace all remaining six usage with native Python 3 equivalents (#7704)Dagfinn Ilmari Mannsåker2020-06-1610-27/+7
| | |_|/ | |/| |
* | | | Merge commit '03619324f' into dinsicAndrew Morgan2020-08-0313-81/+62
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '03619324f': Create a ListenerConfig object (#7681) Fix changelog wording 1.15.1 Wrap register_device coroutine in an ensureDeferred (#7684) Ensure the body is a string before comparing push rules. (#7701) Ensure etag is a string for GET room_keys/version response (#7691) Update m.id.phone to use 'phone' instead of 'number' (#7687) Fix "There was no active span when trying to log." error (#7698) Enable 3PID add/bind/unbind endpoints on r0 routes Discard RDATA from already seen positions. (#7648) Replace iteritems/itervalues/iterkeys with native versions. (#7692) Fix warnings about losing log context during UI auth. (#7688) Fix a typo when comparing the URI & method during UI Auth. (#7689) Remove "user_id" from GET /presence. (#7606) Increase the default SAML session expirary time to 15 minutes. (#7664) fix typo in sample_config.yaml (#7652) Take out a lock before modifying _CACHES (#7663) Add option to enable encryption by default for new rooms (#7639) Clean-up the fallback login code. (#7657)
| * | | Replace iteritems/itervalues/iterkeys with native versions. (#7692)Patrick Cloke2020-06-1512-80/+61
| | | |
| * | | Fix warnings about losing log context during UI auth. (#7688)Patrick Cloke2020-06-121-1/+1
| | |/ | |/|
* | | Merge branch 'release-v1.15.0' of github.com:matrix-org/synapse into ↵Andrew Morgan2020-06-247-43/+55
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dinsic-release-v1.15.x * 'release-v1.15.0' of github.com:matrix-org/synapse: (55 commits) 1.15.0 Fix some attributions Update CHANGES.md 1.15.0rc1 Revert "1.15.0rc1" 1.15.0rc1 Fix bug in account data replication stream. (#7656) Convert the registration handler to async/await. (#7649) Accept device information at the login fallback endpoint. (#7629) Convert user directory handler and related classes to async/await. (#7640) Add an option to disable autojoin for guest accounts (#6637) Clarifications to the admin api documentation (#7647) Update to the stable SSO prefix for UI Auth. (#7630) Fix type information on `assert_*_is_admin` methods (#7645) Remove some unused constants. (#7644) Typo fixes. Allow new users to be registered via the admin API even if the monthly active user limit has been reached (#7263) Add device management to admin API (#7481) Attempt to fix PhoneHomeStatsTestCase.test_performance_100 being flaky. (#7634) Support CS API v0.6.0 (#6585) ...
| * | Fix bug in account data replication stream. (#7656)Erik Johnston2020-06-093-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Ensure account data stream IDs are unique. The account data stream is shared between three tables, and the maximum allocated ID was tracked in a dedicated table. Updating the max ID happened outside the transaction that allocated the ID, leading to a race where if the server was restarted then the same ID could be allocated but the max ID failed to be updated, leading it to be reused. The ID generators have support for tracking across multiple tables, so we may as well use that instead of a dedicated table. * Fix bug in account data replication stream. If the same stream ID was used in both global and room account data then the getting updates for the replication stream would fail due to `heapq.merge(..)` trying to compare a `str` with a `None`. (This is because you'd have two rows like `(534, '!room')` and `(534, None)` from the room and global account data tables). Fix is just to order by stream ID, since we don't rely on the ordering beyond that. The bug where stream IDs can be reused should be fixed now, so this case shouldn't happen going forward. Fixes #7617
| * | async/await get_user_id_by_threepid (#7620)Andrew Morgan2020-06-032-23/+24
| | | | | | | | | | | | | | | Based on #7619 async's `get_user_id_by_threepid` and its call stack.
| * | Improve performance of _get_state_groups_from_groups_txn (#7567)Dagfinn Ilmari Mannsåker2020-06-011-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The query keeps showing up in my slow query log. This changes the plan under the top-level Sort node from ``` WindowAgg (cost=280335.88..292963.15 rows=561212 width=80) (actual time=138.651..160.562 rows=27112 loops=1) -> Sort (cost=280335.88..281738.91 rows=561212 width=84) (actual time=138.597..140.622 rows=27112 loops=1) Sort Key: state_groups_state.type, state_groups_state.state_key, state_groups_state.state_group Sort Method: quicksort Memory: 4581kB -> Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=21.548..47.657 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=21.526..21.535 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=21.280..21.493 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.005..0.991 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` to ``` Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=24.194..52.834 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=24.130..24.138 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=23.887..24.113 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.016..1.159 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` This cuts the execution time from ~190ms to ~130ms, i.e. a reduction of ~30%. The full plans are visualised at https://explain.depesz.com/s/WpbT and https://explain.depesz.com/s/KlEk Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
| * | Use upsert when inserting read receipts (#7607)Dagfinn Ilmari Mannsåker2020-06-011-9/+4
| | | | | | | | | | | | | | | Fixes #7469 Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
| * | Fix incorrect placeholder syntax in database prepartion code (#7575)Andrew Morgan2020-05-271-3/+2
| | | | | | | | | We were using `logger` syntax which isn't supported by `Exception`s.
* | | Add a bulk user info endpoint and deprecate the old one (#46)Andrew Morgan2020-06-191-0/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | The current `/user/<user_id>/info` API was useful in that it could be used by any user to lookup whether another user was deactivate or expired. However, it was impractical as it only allowed for a single lookup at once. Clients trying to use this API were met with speed issues as they tried to query this information for all users in a room. This PR adds an equivalent CS and Federation API that takes a list of user IDs, and returning a mapping from user ID to info dictionary. Note that the federation in this PR was a bit trickier than in the original #12 as we can no longer use a federation query, as those don't allow for JSON bodies - which we require to pass a list of user IDs. Instead we do the whole thing of adding a method to transport/client and transport/server. This PR also adds unittests. The earlier PR used Sytest, presumably for testing across federation, but as this is Synapse-specific that felt a little gross. Unit tests for the deprecated endpoint have not been added.
* | | Performance improvements to marking expired users as inactive (#47)Andrew Morgan2020-06-192-16/+52
| | | | | | | | | This is a performance-related improvement to #13, which queried and hid active *and* already inactive users, one-by-one. This PR updates the code to query only **active**, expired users, all at once, and then mark them as inactive, all at once.
* | | Merge branch 'release-v1.14.0' of github.com:matrix-org/synapse into ↵Andrew Morgan2020-06-1036-1667/+2295
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dinsic-release-v1.14.x * 'release-v1.14.0' of github.com:matrix-org/synapse: (108 commits) Fix typo in PR link Update debian changelog 1.14.0 Improve changelog wording 1.14.0rc2 Fix sample config docs error (#7581) Fix up comments Fix specifying cache factors via env vars with * in name. (#7580) Don't apply cache factor to event cache. (#7578) Ensure ReplicationStreamer is always started when replication enabled. (#7579) Remove the changes to the debian changelog Not full release yet, this is rc1 Merge event persistence move changelog entries More changelog fix Changelog fixes 1.14.0 Replace device_27_unique_idx bg update with a fg one (#7562) Fix incorrect exception handling in KeyUploadServlet.on_POST (#7563) Fix recording of federation stream token (#7564) Simplify reap_monthly_active_users (#7558) ...
| * | Replace device_27_unique_idx bg update with a fg one (#7562)Richard van der Hoff2020-05-265-62/+94
| | | | | | | | | | | | | | | | | | The bg update never managed to complete, because it kept being interrupted by transactions which want to take a lock. Just doing it in the foreground isn't that bad, and is a good deal simpler.
| * | Simplify reap_monthly_active_users (#7558)Richard van der Hoff2020-05-231-59/+41
| | | | | | | | | | | | | | | | | | we can use `make_in_list_sql_clause` rather than doing our own half-baked equivalent, which has the benefit of working just fine with empty lists. (This has quite a lot of tests, so I think it's pretty safe)
| * | Optimise some references to hs.config (#7546)Richard van der Hoff2020-05-221-8/+20
| | | | | | | | | These are surprisingly expensive, and we only really need to do them at startup.
| * | Add option to move event persistence off master (#7517)Erik Johnston2020-05-226-43/+60
| | |
| * | Add ability to wait for replication streams (#7542)Erik Johnston2020-05-222-3/+5
| | | | | | | | | | | | | | | | | | | | | The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room). Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on. People probably want to look at this commit by commit.
| * | Retry to sync out of sync device lists (#7453)Brendan Abolivier2020-05-211-12/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it. https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync. This commit uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now. It also adds a looping call to retry all failed resync every 30s. This shouldn't cause too much spam in the logs as this commit also removes the "Failed to handle device list update for..." warning logs when catching `NotRetryingDestination`. Fixes #7418
| * | Fix bug in persist events when dealing with non member types. (#7548)Erik Johnston2020-05-211-2/+2
| | | | | | | | | | | | | | | `_is_server_still_joined` will throw if it is given state updates with non-user ID state keys with local user leaves. This is actually rarely a problem since local leaves almost always get persisted by themselves. (I discovered this on a branch that was otherwise broken, so I haven't seen this in the wild)
| * | Merge pull request #7519 from matrix-org/rav/kill_py2_codeRichard van der Hoff2020-05-186-55/+17
| |\ \ | | | | | | | | Kill off some old python 2 code
| | * | remove `builtins.buffer` code from storage codeRichard van der Hoff2020-05-153-24/+3
| | | | | | | | | | | | | | | | this is no longer needed on python 3
| | * | remove to_asciiRichard van der Hoff2020-05-152-19/+11
| | | | | | | | | | | | | | | | this is a no-op on python 3.
| | * | Remove `exception_to_unicode`Richard van der Hoff2020-05-151-12/+3
| | | | | | | | | | | | | | | | this is a no-op on python 3.
| * | | Fix limit logic for AccountDataStream (#7384)Richard van der Hoff2020-05-151-19/+43
| | | | | | | | | | | | | | | | | | | | | | | | Make sure that the AccountDataStream presents complete updates, in the right order. This is much the same fix as #7337 and #7358, but applied to a different stream.
| * | | Fix a couple of small typosAndrew Morgan2020-05-151-2/+2
| | | |
| * | | Add a worker store for search insertion. (#7516)Erik Johnston2020-05-151-47/+49
| | | | | | | | | | | | | | | | | | | | This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.
| * | | Prevent 0-member/null room_version rooms from appearing in group room ↵Andrew Morgan2020-05-151-14/+78
| | | | | | | | | | | | | | | | queries (#7465)
| * | | Move event stream handling out of slave store. (#7491)Erik Johnston2020-05-155-19/+160
| | | | | | | | | | | | | | | | | | | | This allows us to have the logic on both master and workers, which is necessary to move event persistence off master. We also combine the instantiation of ID generators from DataStore and slave stores to the base worker stores. This allows us to select which process writes events independently of the master/worker splits.
| * | | Fix a small typo in the arguments of simple_update in ↵Andrew Morgan2020-05-151-1/+1
| |/ / | | | | | | | | | update_remote_profile_cache (#7511)
| * | Merge tag 'v1.13.0rc2' into developRichard van der Hoff2020-05-141-1/+2
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.13.0rc2 (2020-05-14) ============================== Bugfixes -------- - Fix a long-standing bug which could cause messages not to be sent over federation, when state events with state keys matching user IDs (such as custom user statuses) were received. ([\#7376](https://github.com/matrix-org/synapse/issues/7376)) - Restore compatibility with non-compliant clients during the user interactive authentication process, fixing a problem introduced in v1.13.0rc1. ([\#7483](https://github.com/matrix-org/synapse/issues/7483)) Internal Changes ---------------- - Fix linting errors in new version of Flake8. ([\#7470](https://github.com/matrix-org/synapse/issues/7470))
| * | | Allow censoring of events to happen on workers. (#7492)Erik Johnston2020-05-131-6/+1
| | | | | | | | | | | | This is safe as we can now write to cache invalidation stream on workers, and is required for when we move event persistence off master.
| * | | SpellingErik Johnston2020-05-132-2/+2
| | | |
| * | | Shuffle persist event data store functions. (#7440)Erik Johnston2020-05-1317-1234/+1373
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The aim here is to get to a stage where we have a `PersistEventStore` that holds all the write methods used during event persistence, so that we can take that class out of the `DataStore` mixin and instansiate it separately. This will allow us to instansiate it on processes other than master, while also ensuring it is only available on processes that are configured to write to events stream. This is a bit of an architectural change, where we end up with multiple classes per data store (rather than one per data store we have now). We end up having: 1. Storage classes that provide high level APIs that can talk to multiple data stores. 2. Data store modules that consist of classes that must point at the same database instance. 3. Classes in a data store that can be instantiated on processes depending on config.
| * | | Fix new flake8 errors (#7470)Erik Johnston2020-05-121-2/+2
| | | |
| * | | Allow configuration of Synapse's cache without using synctl or environment ↵Amber Brown2020-05-113-7/+7
| | | | | | | | | | | | | | | | variables (#6391)
| * | | Remove unused store method get_hosts_in_room (#7448)Andrew Morgan2020-05-111-10/+0
| | | |
| * | | Merge branch 'release-v1.13.0' into developAndrew Morgan2020-05-111-0/+21
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * release-v1.13.0: Don't UPGRADE database rows RST indenting Put rollback instructions in upgrade notes Fix changelog typo Oh yeah, RST Absolute URL it is then Fix upgrade notes link Provide summary of upgrade issues in changelog. Fix ) Move next version notes from changelog to upgrade notes Changelog fixes 1.13.0rc1 Documentation on setting up redis (#7446) Rework UI Auth session validation for registration (#7455) Fix errors from malformed log line (#7454) Drop support for redis.dbid (#7450)
| * | | | Add room details admin endpoint (#7317)Manuel Stahl2020-05-071-0/+31
| | | | |
| * | | | Support any process writing to cache invalidation stream. (#7436)Erik Johnston2020-05-075-42/+92
| | | | |
| * | | | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-061-2/+2
| |\ \ \ \
| * \ \ \ \ Merge pull request #7428 from matrix-org/rav/cross_signing_keys_cacheRichard van der Hoff2020-05-061-77/+21
| |\ \ \ \ \ | | | | | | | | | | | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulk
| | * | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulkRichard van der Hoff2020-05-061-54/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ... mostly because the latter has a cache.
| | * | | | | Fix batching for fetching cross-signing keysRichard van der Hoff2020-05-061-23/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's no point carefully dividing a list into batches, and then completely ignoring the batches.
| * | | | | | Merge branch 'develop' into rav/upsert_for_device_listRichard van der Hoff2020-05-063-6/+174
| |\ \ \ \ \ \
| | * | | | | | Add MultiWriterIdGenerator. (#7281)Erik Johnston2020-05-041-2/+167
| | |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used to coordinate stream IDs across multiple writers. Functions as the equivalent of both `StreamIdGenerator` and `SlavedIdTracker`.
| * | | | | | use an upsert to update device_lists_outbound_last_successRichard van der Hoff2020-05-063-18/+71
| | | | | | |
| * | | | | | Better type annotations for simple_upsert_txnRichard van der Hoff2020-05-061-30/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | most of these params don't really need to be lists.
* | | | | | | Merge branch 'release-v1.13.0' of github.com:matrix-org/synapse into ↵Andrew Morgan2020-06-1028-456/+1266
|\ \ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dinsic-release-v1.14.x * 'release-v1.13.0' of github.com:matrix-org/synapse: (257 commits) Update changelog based on feedback. Move warnings in the changelog and re-iterate changes to branches. 1.13.0 update dh-virtualenv (#7526) 1.13.0rc3 Hash passwords earlier in the registration process (#7523) 1.13.0rc2 1.13.0rc2 Stop `get_joined_users` corruption from custom statuses (#7376) Do not validate that the client dict is stable during UI Auth. (#7483) Fix new flake8 errors (#7489) Don't UPGRADE database rows RST indenting Put rollback instructions in upgrade notes Fix changelog typo Oh yeah, RST Absolute URL it is then Fix upgrade notes link Provide summary of upgrade issues in changelog. Fix ) Move next version notes from changelog to upgrade notes ...
| * | | | | | Stop `get_joined_users` corruption from custom statuses (#7376)Richard van der Hoff2020-05-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a bug where the `get_joined_users` cache could be corrupted by custom status events (or other state events with a state_key matching the user ID). The bug was introduced by #2229, but has largely gone unnoticed since then. Fixes #7099, #7373.
| * | | | | | Fix new flake8 errors (#7489)Patrick Cloke2020-05-131-2/+2
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | This is a cherry-pick of 1a1da60ad2c9172fe487cd38a164b39df60f4cb5 (#7470) to the release-v1.13.0 branch.
| * | | | | Rework UI Auth session validation for registration (#7455)Patrick Cloke2020-05-081-0/+21
| | |_|/ / | |/| | | | | | | | | | | | | Be less strict about validation of UI authentication sessions during registration to match client expecations.
| * | | | Merge branch 'release-v1.13.0' into erikj/faster_device_lists_fetchRichard van der Hoff2020-05-052-4/+7
| |\ \ \ \ | | | |/ / | | |/| |
| | * | | Wait for current_state_events_membership before populate_stats_process_rooms ↵Richard van der Hoff2020-05-011-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#7387) populate_stats_process_rooms was added in #5971 / v1.4.0; current_state_events_membership was added in #5706 / v1.3.0. Fixes #7380.
| | * | | async/await is_server_admin (#7363)Andrew Morgan2020-05-011-3/+2
| | |/ /
| * / / Speed up fetching device lists changes in sync.Erik Johnston2020-05-051-2/+2
| |/ / | | | | | | | | | | | | Currently we copy `users_who_share_room` needlessly about three times, which is expensive when the set is large (which it can easily be).
| * | Persist user interactive authentication sessions (#7302)Patrick Cloke2020-04-304-0/+318
| | | | | | | | | | | | | | | By persisting the user interactive authentication sessions to the database, this fixes situations where a user hits different works throughout their auth session and also allows sessions to persist through restarts of Synapse.
| * | Fix limit logic for EventsStream (#7358)Richard van der Hoff2020-04-291-4/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Factor out functions for injecting events into database I want to add some more flexibility to the tools for injecting events into the database, and I don't want to clutter up HomeserverTestCase with them, so let's factor them out to a new file. * Rework TestReplicationDataHandler This wasn't very easy to work with: the mock wrapping was largely superfluous, and it's useful to be able to inspect the received rows, and clear out the received list. * Fix AssertionErrors being thrown by EventsStream Part of the problem was that there was an off-by-one error in the assertion, but also the limit logic was too simple. Fix it all up and add some tests.
| * | Return total number of users and profile attributes in admin users endpoint ↵Manuel Stahl2020-04-281-29/+39
| | | | | | | | | | | | | | | (#6881) Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
| * | Fix EventsStream raising assertions when it falls behindRichard van der Hoff2020-04-241-12/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Figuring out how to correctly limit updates from this stream without dropping entries is far more complicated than just counting the number of rows being returned. We need to consider each query separately and, if any one query hits the limit, truncate the results from the others. I think this also fixes some potentially long-standing bugs where events or state changes could get missed if we hit the limit on either query.
| * | Extend room admin api with additional attributes (#7225)Dirk Klimpel2020-04-221-4/+74
| | |
| * | Fix a potentially-huge sql query (#7274)Richard van der Hoff2020-04-151-7/+16
| | | | | | | | | | | | | | | We could end up looking up tens of thousands of events, which could cause large amounts of data to be logged to the postgres log.
| * | typosMatthew Hodgson2020-04-111-1/+1
| | |
| * | bg update to clear out duplicate outbound_device_list_pokes (#7193)Richard van der Hoff2020-04-074-13/+181
| | | | | | | | | | | | We seem to have some duplicates, which could do with being cleared out.
| * | Convert delete_url_cache_media to async/await. (#7241)Patrick Cloke2020-04-071-2/+2
| | |
| * | Remove sent outbound device list pokes from the database (#7192)Richard van der Hoff2020-04-072-2/+23
| | | | | | | | | They just get in the way.
| * | Fix race in replication (#7226)Erik Johnston2020-04-071-20/+20
| | | | | | | | | | | | Fixes a race between handling `POSITION` and `RDATA` commands. We do this by simply linearizing handling of them.
| * | Remove stream before/after debug log lines (#7207)Andrew Morgan2020-04-061-2/+0
| | |
| * | Merge pull request #7190 from matrix-org/rav/one_bg_update_at_a_timeRichard van der Hoff2020-04-033-59/+76
| |\ \ | | | | | | | | Only run one background update at a time
| | * | Update docstring per review commentsRichard van der Hoff2020-04-031-1/+1
| | | |
| | * | review commentRichard van der Hoff2020-04-021-1/+1
| | | |
| | * | Only run one background update at a timeRichard van der Hoff2020-03-313-27/+68
| | | |
| | * | Make do_next_background_update return a boolRichard van der Hoff2020-03-311-7/+5
| | | | | | | | | | | | | | | | returning a None or an int that we don't use is confusing.
| | * | Make `has_completed_background_updates` asyncRichard van der Hoff2020-03-311-4/+3
| | | | | | | | | | | | | | | | (Almost) everywhere that uses it is happy with an awaitable.
| | * | Remove unused `start_background_update`Richard van der Hoff2020-03-311-21/+0
| | | | | | | | | | | | | | | | This was only used in a unit test, so let's just inline it in the test.
| * | | Fix device list update stream ids going backward (#7158)Richard van der Hoff2020-04-031-2/+8
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Occasionally we could get a federation device list update transaction which looked like: ``` [ {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}} ] ``` Having `stream_ids` which are lower than `prev_ids` looks odd. It might work (I'm not actually sure), but in any case it doesn't seem like a reasonable thing to expect other implementations to support.
| * | Fill in the 'default' field for user-defined push rules (#6639)Karlinde2020-03-311-0/+1
| | | | | | | | | Signed-off-by: Karl Linderhed <git@karlinde.se>
| * | Only setdefault for signatures if device has key_json (#7177)Andrew Morgan2020-03-311-10/+14
| | |
| * | Fix use of async/await in media code (#7184)Patrick Cloke2020-03-311-2/+2
| | |
| * | Rewrite prune_old_outbound_device_pokes for efficiency (#7159)Richard van der Hoff2020-03-301-13/+58
| | | | | | | | | | | | make sure we clear out all but one update for the user
| * | Transfer alias mappings when joining an upgraded room (#6946)Andrew Morgan2020-03-301-3/+23
| | |
| * | Ensure is_verified on /_matrix/client/r0/room_keys/keys is a boolean (#7150)Andrew Morgan2020-03-271-1/+2
| | |
| * | Only import sqlite3 when type checking (#7155)David Vo2020-03-271-2/+5
| | | | | | | | | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
| * | Move catchup of replication streams to worker. (#7024)Erik Johnston2020-03-255-199/+201
| | | | | | | | | This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.
| * | Clean up some LoggingContext stuff (#7120)Richard van der Hoff2020-03-242-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.
| * | Remove concept of a non-limited stream. (#7011)Erik Johnston2020-03-203-16/+31
| | |
| * | Change device list streams to have one row per ID (#7010)Erik Johnston2020-03-192-65/+72
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add 'device_lists_outbound_pokes' as extra table. This makes sure we check all the relevant tables to get the current max stream ID. Currently not doing so isn't problematic as the max stream ID in `device_lists_outbound_pokes` is the same as in `device_lists_stream`, however that will change. * Change device lists stream to have one row per id. This will make it possible to process the streams more incrementally, avoiding having to process large chunks at once. * Change device list replication to match new semantics. Instead of sending down batches of user ID/host tuples, send down a row per entity (user ID or host). * Newsfile * Remove handling of multiple rows per ID * Fix worker handling * Comments from review
| | * | Comments from reviewErik Johnston2020-03-181-8/+19
| | | |
| | * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2020-03-021-1/+3
| | |\ \ | | | | | | | | | | | | | | | erikj/fixup_devices_stream
| | * | | Remove handling of multiple rows per IDErik Johnston2020-02-281-34/+1
| | | | |
| | * | | Change device list replication to match new semantics.Erik Johnston2020-02-281-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | Instead of sending down batches of user ID/host tuples, send down a row per entity (user ID or host).
| | * | | Change device lists stream to have one row per id.Erik Johnston2020-02-281-18/+41
| | | | | | | | | | | | | | | | | | | | | | | | | This will make it possible to process the streams more incrementally, avoiding having to process large chunks at once.
| | * | | Add 'device_lists_outbound_pokes' as extra table.Erik Johnston2020-02-281-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes sure we check all the relevant tables to get the current max stream ID. Currently not doing so isn't problematic as the max stream ID in `device_lists_outbound_pokes` is the same as in `device_lists_stream`, however that will change.
* | | | | Move sql schema delta files to their new locationAndrew Morgan2020-05-284-0/+0
| | | | |
* | | | | Fix sytest CIAndrew Morgan2020-05-281-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Switch sytest-synapse to sytest-dinsic * Be sure to invalidate our caches properly! * Remove duplicate encryption state key definition * Remove old config option name in comment * Make dinsic the default in merge_base_branch
* | | | | Only import sqlite3 when type checkingDavid Vo2020-05-281-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
* | | | | Fix another instanceAndrew Morgan2020-05-281-5/+7
| | | | |
* | | | | Only setdefault for signatures if device has key_jsonAndrew Morgan2020-05-281-5/+7
| | | | |
* | | | | apply lintingAndrew Morgan2020-05-141-2/+0
| | | | |
* | | | | Add caches for get_profile_{displayname,avatar_url}Andrew Morgan2020-05-011-0/+3
| | | | |
* | | | | Improve get auth chain difference algorithm. (#7095)Andrew Morgan2020-03-241-1/+149
|\| | | | | | | | | | | | | | | | | | | | | | | | * commit '4a17a647a': Improve get auth chain difference algorithm. (#7095)
| * | | | Improve get auth chain difference algorithm. (#7095)Erik Johnston2020-03-181-1/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was originally implemented by pulling the full auth chain of all state sets out of the database and doing set comparison. However, that can take a lot work if the state and auth chains are large. Instead, lets try and fetch the auth chains at the same time and calculate the difference on the fly, allowing us to bail early if all the auth chains converge. Assuming that the auth chains do converge more often than not, this should improve performance. Hopefully.
* | | | | Merge commit '6a3504636' into dinsic-release-v1.12.xAndrew Morgan2020-03-242-0/+62
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '6a3504636': (29 commits) Revert "Add options to disable setting profile info for prevent changes. (#7053)" Populate the room version from state events (#7070) Fix buggy condition in account validity handler (#7074) Use innerText instead of innerHTML Add type annotations and comments to auth handler (#7063) Lint Put the file in the templates directory Update wording and config Changelog Move the default SAML2 error HTML to a dedicated file Refactor a bit Also don't fail on aliases events in this case Lint Changelog Also don't filter out events sent by ignored users when checking state visibility Fix condition Don't filter out dummy events when we're checking the visibility of state Update sample_config.yaml Update synapse/config/registration.py lint, fix tests ...
| * | | | Populate the room version from state events (#7070)Brendan Abolivier2020-03-162-0/+62
| | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7065 This is basically the same as https://github.com/matrix-org/synapse/pull/6847 except it tries to populate events from `state_events` rather than `current_state_events`, since the latter might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.
* | | | | Merge pull request #7058 from matrix-org/babolivier/saml_error_htmlAndrew Morgan2020-03-241-2/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '6640460d0': Rephrase default message Hopefully mypy is happy now Attempt at appeasing the gods of mypy Lint Changelog Update sample config SAML2: render a comprehensible error page if something goes wrong
| * | | | Hopefully mypy is happy nowBrendan Abolivier2020-03-101-2/+8
| | | | |
* | | | | Merge pull request #7055 from ↵Andrew Morgan2020-03-241-17/+17
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | matrix-org/babolivier/get_time_of_last_push_action_before * commit '14b2ebe76': Changelog Fix undefined `room_id` in `make_summary_text` Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore`
| * | | | Merge pull request #7055 from ↵Brendan Abolivier2020-03-091-17/+17
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | matrix-org/babolivier/get_time_of_last_push_action_before Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore
| | * | | | Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore`Brendan Abolivier2020-03-091-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7054 I also had a look at the rest of the functions in `EventPushActionsStore` and in the push notifications send code and it looks to me like there shouldn't be any other method with this issue in this part of the codebase.
* | | | | | Remove special auth and redaction rules for aliases events in experimental ↵Andrew Morgan2020-03-241-2/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | room ver. (#7037) * commit '06eb5cae0': Remove special auth and redaction rules for aliases events in experimental room ver. (#7037)
| * | | | | Remove special auth and redaction rules for aliases events in experimental ↵Patrick Cloke2020-03-091-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | room ver. (#7037)
* | | | | | Break down monthly active users by appservice_id (#7030)Andrew Morgan2020-03-241-1/+31
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '1d66dce83': Break down monthly active users by appservice_id (#7030)
| * | | | | Break down monthly active users by appservice_id (#7030)Neil Johnson2020-03-061-1/+31
| |/ / / / | | | | | | | | | | | | | | | | | | | | * Break down monthly active users by appservice_id and emit via prometheus. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | | | | Read the room version from database when fetching events (#6874)Andrew Morgan2020-03-241-16/+68
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '8ef8fb2c1': Read the room version from database when fetching events (#6874) Update debian changelog
| * | | | Read the room version from database when fetching events (#6874)Richard van der Hoff2020-03-041-16/+68
| | |/ / | |/| | | | | | | | | | | | | | This is a precursor to giving EventBase objects the knowledge of which room version they belong to.
* | | | Always return a deferred from `get_current_state_deltas`. (#7019)Andrew Morgan2020-03-241-1/+3
|\| | | | | | | | | | | | | | | | | | | * commit 'b29474e0a': Always return a deferred from `get_current_state_deltas`. (#7019)
| * | | Always return a deferred from `get_current_state_deltas`. (#7019)Erik Johnston2020-03-021-1/+3
| |/ / | | | | | | | | | | | | This currently causes presence notify code to log exceptions when there is no state changes to process. This doesn't actually cause any problems as we'd simply do nothing anyway.
* | | Fixed set a user as an admin with the new API (#6928)Andrew Morgan2020-03-241-6/+10
|\| | | | | | | | | | | | | | * commit '9b06d8f8a': Fixed set a user as an admin with the new API (#6928)
| * | Fixed set a user as an admin with the new API (#6928)Dirk Klimpel2020-02-281-6/+10
| | | | | | | | | Fix #6910
* | | Add some type annotations in `synapse.storage` (#6987)Andrew Morgan2020-03-246-82/+266
|\| | | | | | | | | | | | | | * commit '132b673db': Add some type annotations in `synapse.storage` (#6987)
| * | Add some type annotations in `synapse.storage` (#6987)Richard van der Hoff2020-02-276-82/+266
| | | | | | | | | | | | | | | I cracked, and added some type definitions in synapse.storage.
* | | Store room version on invite (#6983)Andrew Morgan2020-03-241-0/+20
|\| | | | | | | | | | | | | | * commit '3e99528f2': Store room version on invite (#6983)
| * | Store room version on invite (#6983)Richard van der Hoff2020-02-261-0/+20
| | | | | | | | | | | | | | | When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere...
* | | Updated warning for incorrect database collation/ctype (#6985)Andrew Morgan2020-03-241-3/+7
|\| | | | | | | | | | | | | | * commit '7728d87fd': Updated warning for incorrect database collation/ctype (#6985)
| * | Updated warning for incorrect database collation/ctype (#6985)Uday Bansal2020-02-261-3/+7
| | | | | | | | | Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com>
* | | Sanity-check database before running upgrades (#6982)Andrew Morgan2020-03-242-17/+32
|\| | | | | | | | | | | | | | * commit 'e66f099ca': Sanity-check database before running upgrades (#6982)
| * | Sanity-check database before running upgrades (#6982)Richard van der Hoff2020-02-252-17/+32
| | | | | | | | | | | | | | | | | | Some of the database deltas rely on `config.server_name` being set correctly, so we should check that it is before running the deltas. Fixes #6870.
* | | Merge worker apps into one. (#6964)Andrew Morgan2020-03-241-78/+78
|\| | | | | | | | | | | | | | * commit 'bbf8886a0': Merge worker apps into one. (#6964)
| * | Merge worker apps into one. (#6964)Erik Johnston2020-02-251-78/+78
| | |
* | | Upsert room version when we join over federation (#6968)Andrew Morgan2020-03-241-0/+17
|\| | | | | | | | | | | | | | * commit 'a301934f4': Upsert room version when we join over federation (#6968)
| * | Upsert room version when we join over federation (#6968)Richard van der Hoff2020-02-241-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns.
* | | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)Andrew Morgan2020-03-2419-55/+56
|\| | | | | | | | | | | | | | | | | | | | * commit '509e381af': Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) changelog Increase MAX_EVENTS_BEHIND for replication clients
| * | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)Patrick Cloke2020-02-2119-55/+56
| | | | | | | | | | | | Ensure good comprehension hygiene using flake8-comprehensions.
* | | don't insert into the device table for remote cross-signing keys (#6956)Andrew Morgan2020-03-241-15/+18
|\| | | | | | | | | | | | | | * commit 'a90d0dc5c': don't insert into the device table for remote cross-signing keys (#6956)
| * | don't insert into the device table for remote cross-signing keys (#6956)Hubert Chathi2020-02-201-15/+18
| | |
* | | Add some clarifications to README.md in the database schema directory. (#6615)Andrew Morgan2020-03-243-15/+21
|\| | | | | | | | | | | | | | | | | * commit '4fb5f4d0c': Add some clarifications to README.md in the database schema directory. (#6615) Minor perf fixes to `get_auth_chain_ids`.
| * | Add some clarifications to README.md in the database schema directory. (#6615)Ruben Barkow-Kuder2020-02-201-8/+16
| | | | | | | | | Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
| * | Minor perf fixes to `get_auth_chain_ids`.Erik Johnston2020-02-192-7/+5
| | |
* | | Reduce auth chains fetched during v2 state res. (#6952)Andrew Morgan2020-03-241-5/+23
|\| | | | | | | | | | | | | | | | | * commit '2b37eabca': Reduce auth chains fetched during v2 state res. (#6952) update changes.md
| * | Reduce auth chains fetched during v2 state res. (#6952)Erik Johnston2020-02-191-5/+23
| | | | | | | | | | | | | | | | | | The state res v2 algorithm only cares about the difference between auth chains, so we can pass in the known common state to the `get_auth_chain` storage function so that it can ignore those events.
* | | Revert `get_auth_chain_ids` changes (#6951)Andrew Morgan2020-03-241-28/+0
|\| | | | | | | | | | | | | | * commit '099c96b89': Revert `get_auth_chain_ids` changes (#6951)
| * | Revert `get_auth_chain_ids` changes (#6951)Erik Johnston2020-02-191-28/+0
| | |
* | | Increase DB/CPU perf of `_is_server_still_joined` check. (#6936)Andrew Morgan2020-03-242-15/+59
|\| | | | | | | | | | | | | | * commit '0d0bc3579': Increase DB/CPU perf of `_is_server_still_joined` check. (#6936)
| * | Increase DB/CPU perf of `_is_server_still_joined` check. (#6936)Erik Johnston2020-02-192-15/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Increase DB/CPU perf of `_is_server_still_joined` check. For rooms with large amount of state a single user leaving could cause us to go and load a lot of membership events and then pull out membership state in a large number of batches. * Newsfile * Update synapse/storage/persist_events.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Fix adding if too soon * Update docstring * Review comments * Woops typo Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Limit size of get_auth_chain_ids query (#6947)Andrew Morgan2020-03-241-18/+23
|\| | | | | | | | | | | | | | * commit '5a5abd55e': Limit size of get_auth_chain_ids query (#6947)
| * | Limit size of get_auth_chain_ids query (#6947)Erik Johnston2020-02-191-18/+23
| | |
* | | Increase perf of `get_auth_chain_ids` used in state res v2. (#6937)Andrew Morgan2020-03-241-0/+23
|\| | | | | | | | | | | | | | * commit '8a380d0fe': Increase perf of `get_auth_chain_ids` used in state res v2. (#6937)
| * | Increase perf of `get_auth_chain_ids` used in state res v2. (#6937)Erik Johnston2020-02-181-0/+23
| | | | | | | | | We do this by moving the recursive query to be fully in the DB.
* | | wait for current_state_events_membership before ↵Andrew Morgan2020-03-231-2/+5
|\| | | | | | | | | | | | | | | | | | | | delete_old_current_state_events (#6924) * commit '46fa66bbf': wait for current_state_events_membership before delete_old_current_state_events (#6924)
| * | wait for current_state_events_membership before ↵Richard van der Hoff2020-02-171-2/+5
| | | | | | | | | | | | delete_old_current_state_events (#6924)
* | | Remove unused `get_room_stats_state` method. (#6869)Andrew Morgan2020-03-231-25/+0
|\| | | | | | | | | | | | | | * commit 'e1d858984': Remove unused `get_room_stats_state` method. (#6869)
| * | Remove unused `get_room_stats_state` method. (#6869)Richard van der Hoff2020-02-071-25/+0
| | |
* | | Allow moving group read APIs to workers (#6866)Andrew Morgan2020-03-231-359/+361
|\| | | | | | | | | | | | | | * commit 'de2d26737': Allow moving group read APIs to workers (#6866)
| * | Allow moving group read APIs to workers (#6866)Erik Johnston2020-02-071-359/+361
| | |
* | | Reduce amount of logging at INFO level. (#6862)Andrew Morgan2020-03-232-3/+3
|\| | | | | | | | | | | | | | * commit 'ed630ea17': Reduce amount of logging at INFO level. (#6862)
| * | Reduce amount of logging at INFO level. (#6862)Erik Johnston2020-02-062-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
| * | Merge tag 'v1.10.0rc2' into developErik Johnston2020-02-061-2/+2
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850))
| | * | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-051-0/+10
| | | | | | | | | | | | add device signatures to device key query results
* | | | Reduce performance logging to DEBUG (#6833)Andrew Morgan2020-03-231-1/+1
|\| | | | | | | | | | | | | | | | | | | * commit 'a831d2e4e': Reduce performance logging to DEBUG (#6833)
| * | | Reduce performance logging to DEBUG (#6833)Michael Kaye2020-02-051-1/+1
| | | | | | | | | | | | | | | | | | | | * Reduce tnx performance logging to DEBUG * Changelog.d
* | | | Database updates to populate rooms.room_version (#6847)Andrew Morgan2020-03-232-0/+57
|\| | | | | | | | | | | | | | | | | | | * commit 'd88e0ec08': Database updates to populate rooms.room_version (#6847)
| * | | Database updates to populate rooms.room_version (#6847)Richard van der Hoff2020-02-042-0/+57
| | | | | | | | | | | | We're going to need this so that we can figure out how to handle redactions when fetching events from the database.
* | | | Fix detecting unknown devices from remote encrypted events. (#6848)Andrew Morgan2020-03-231-2/+2
|\ \ \ \ | | |/ / | |/| | | | | | | | | | * commit '6475382d8': Fix detecting unknown devices from remote encrypted events. (#6848)
| * | | Fix detecting unknown devices from remote encrypted events. (#6848)Erik Johnston2020-02-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776.
* | | | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedAndrew Morgan2020-03-231-0/+10
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | * commit '74bf3fdbb': add changelog add device signatures to device key query results
| * | | add device signatures to device key query resultsHubert Chathi2020-02-041-0/+10
| |/ /
* | | Fix deleting of stale marker for device lists (#6819)Andrew Morgan2020-03-231-7/+7
|\| | | | | | | | | | | | | | * commit '83b0ea047': Fix deleting of stale marker for device lists (#6819)
| * | Fix deleting of stale marker for device lists (#6819)Erik Johnston2020-01-311-7/+7
| | | | | | | | | | | | We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync.
* | | Merge pull request #6820 from matrix-org/rav/get_room_version_idAndrew Morgan2020-03-232-3/+26
|\| | | | | | | | | | | | | | | | | | | | * commit '160522e32': newsfile Add `get_room_version` method s/get_room_version/get_room_version_id/
| * | Add `get_room_version` methodRichard van der Hoff2020-01-311-1/+24
| | | | | | | | | | | | So that we can start factoring out some of this boilerplatey boilerplate.
| * | s/get_room_version/get_room_version_id/Richard van der Hoff2020-01-312-2/+2
| | | | | | | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object.
* | | Log when we delete room in bg update (#6816)Andrew Morgan2020-03-231-0/+2
|\| | | | | | | | | | | | | | * commit 'e0992fcc5': Log when we delete room in bg update (#6816)
| * | Log when we delete room in bg update (#6816)Erik Johnston2020-01-301-0/+2
| | |
* | | Backgroud update to clean out rooms from current state (#6802)Andrew Morgan2020-03-232-2/+125
|\| | | | | | | | | | | | | | * commit '57ad702af': Backgroud update to clean out rooms from current state (#6802)
| * | Backgroud update to clean out rooms from current state (#6802)Erik Johnston2020-01-302-2/+125
| | |
* | | When server leaves room check for stale device lists. (#6801)Andrew Morgan2020-03-232-6/+82
|\| | | | | | | | | | | | | | * commit 'a5bab2d05': When server leaves room check for stale device lists. (#6801)
| * | When server leaves room check for stale device lists. (#6801)Erik Johnston2020-01-302-6/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes.
* | | When a client asks for remote keys check if should resync. (#6797)Andrew Morgan2020-03-231-3/+29
|\| | | | | | | | | | | | | | * commit 'c80a9fe13': When a client asks for remote keys check if should resync. (#6797)
| * | When a client asks for remote keys check if should resync. (#6797)Erik Johnston2020-01-301-3/+29
| | | | | | | | | | | | | | | | | | If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache.
* | | Delete current state when server leaves a room (#6792)Andrew Morgan2020-03-232-75/+197
|\| | | | | | | | | | | | | | * commit '611215a49': Delete current state when server leaves a room (#6792)
| * | Delete current state when server leaves a room (#6792)Erik Johnston2020-01-292-75/+197
| | | | | | | | | | | | | | | | | | Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in.
* | | Detect unknown remote devices and mark cache as stale (#6776)Andrew Morgan2020-03-232-5/+49
|\| | | | | | | | | | | | | | * commit 'e17a11066': Detect unknown remote devices and mark cache as stale (#6776)
| * | Detect unknown remote devices and mark cache as stale (#6776)Erik Johnston2020-01-282-5/+49
| | | | | | | | | | | | We just mark the fact that the cache may be stale in the database for now.
* | | Warn if postgres database has non-C locale. (#6734)Andrew Morgan2020-03-233-0/+52
|\| | | | | | | | | | | | | | * commit '02b44db92': Warn if postgres database has non-C locale. (#6734)
| * | Warn if postgres database has non-C locale. (#6734)Erik Johnston2020-01-283-0/+52
| | | | | | | | | As using non-C locale can cause issues on upgrading OS.
| * | Merge branch 'master' into developErik Johnston2020-01-281-1/+7
| |\ \
* | \ \ Fix setting `mau_limit_reserved_threepids` config (#6793)Andrew Morgan2020-03-231-1/+7
|\ \ \ \ | | |/ / | |/| | | | | | | | | | * commit 'bdbeeb94e': Fix setting `mau_limit_reserved_threepids` config (#6793)
| * | | Fix setting `mau_limit_reserved_threepids` config (#6793)Erik Johnston2020-01-281-1/+7
| | | | | | | | | | | | | | | | | | | | Calling the invalidation function during initialisation of the data stores introduces a circular dependency, causing Synapse to fail to start.
* | | | Add `rooms.room_version` column (#6729)Andrew Morgan2020-03-233-18/+134
|\ \ \ \ | | |/ / | |/| | | | | | | | | | * commit '8df862e45': Add `rooms.room_version` column (#6729)
| * | | Add `rooms.room_version` column (#6729)Erik Johnston2020-01-273-18/+134
| | | | | | | | | | | | This is so that we don't have to rely on pulling it out from `current_state_events` table.
* | | | Propagate cache invalidates from workers to other workers. (#6748)Andrew Morgan2020-03-231-1/+21
|\| | | | | | | | | | | | | | | | | | | * commit 'd5275fc55': Propagate cache invalidates from workers to other workers. (#6748)
| * | | Propagate cache invalidates from workers to other workers. (#6748)Erik Johnston2020-01-271-1/+21
| | | | | | | | | | | | Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers.
* | | | Make 'event.redacts' never raise. (#6771)Andrew Morgan2020-03-232-2/+2
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'fa4d609e2': Make 'event.redacts' never raise. (#6771) Fixup changelog Fixup changelog Fixup changelog
| * | | Make 'event.redacts' never raise. (#6771)Erik Johnston2020-01-232-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | There are quite a few places that we assume that a redaction event has a corresponding `redacts` key, which is not always the case. So lets cheekily make it so that event.redacts just returns None instead.
* | | | Remove unnecessary abstractions in admin handler (#6751)Andrew Morgan2020-03-231-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'ce84dd9e2': Remove unnecessary abstractions in admin handler (#6751) Fixup warning about workers changes Add deprecation headers Fixup changelog
| * | | Remove unnecessary abstractions in admin handler (#6751)Andrew Morgan2020-01-221-1/+1
| |/ /
* | | Admin API to list, filter and sort rooms (#6720)Andrew Morgan2020-03-231-1/+124
|\| | | | | | | | | | | | | | * commit '90a28fb47': Admin API to list, filter and sort rooms (#6720)
| * | Admin API to list, filter and sort rooms (#6720)Andrew Morgan2020-01-221-1/+124
| | |
* | | Allow monthly active user limiting support for worker mode, fixes #4639. (#6742)Andrew Morgan2020-03-231-82/+83
|\| | | | | | | | | | | | | | * commit '5e52d8563': Allow monthly active user limiting support for worker mode, fixes #4639. (#6742)
| * | Allow monthly active user limiting support for worker mode, fixes #4639. (#6742)Neil Johnson2020-01-221-82/+83
| | |
* | | Allow streaming cache invalidate all to workers. (#6749)Andrew Morgan2020-03-232-9/+36
|\| | | | | | | | | | | | | | * commit '5d7a6ad22': Allow streaming cache invalidate all to workers. (#6749)
| * | Allow streaming cache invalidate all to workers. (#6749)Erik Johnston2020-01-222-9/+36
| | |
* | | Add a DeltaState to track changes to be made to current state (#6716)Andrew Morgan2020-03-232-99/+111
|\| | | | | | | | | | | | | | * commit '0e6876007': Add a DeltaState to track changes to be made to current state (#6716)
| * | Add a DeltaState to track changes to be made to current state (#6716)Erik Johnston2020-01-202-99/+111
| | |
* | | Fix syntax error in run_upgrade for schema 57 (#6728)Andrew Morgan2020-03-231-3/+4
|\| | | | | | | | | | | | | | * commit '722b4f302': Fix syntax error in run_upgrade for schema 57 (#6728)
| * | Fix syntax error in run_upgrade for schema 57 (#6728)Satsuki Yanagi2020-01-171-3/+4
| | | | | | | | | | | | | | | | | | | | | Fix #6727 Related #6655 Co-authored-by: Erik Johnston <erikj@jki.re>
* | | Merge pull request #6714 from matrix-org/babolivier/retention_select_eventAndrew Morgan2020-03-231-5/+5
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '3b72bb780': bump version to v1.9.0.dev1 Precise changelog Fixup diff Remove get_room_event_after_stream_ordering entirely Lint Rename changelog Changelog Correctly order when selecting before stream ordering Fix typo Fix instantiation of message retention purge jobs
| * | Merge pull request #6714 from matrix-org/babolivier/retention_select_eventBrendan Abolivier2020-01-171-5/+5
| |\ \ | | | | | | | | Fix instantiation of message retention purge jobs
| | * | Fixup diffBrendan Abolivier2020-01-161-6/+7
| | | |
| | * | Remove get_room_event_after_stream_ordering entirelyBrendan Abolivier2020-01-161-57/+12
| | | |
| | * | LintBrendan Abolivier2020-01-161-6/+12
| | | |
| | * | Correctly order when selecting before stream orderingBrendan Abolivier2020-01-151-2/+5
| | | |
| | * | Fix typoBrendan Abolivier2020-01-151-1/+1
| | | |
| | * | Fix instantiation of message retention purge jobsBrendan Abolivier2020-01-151-12/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When figuring out which topological token to start a purge job at, we need to do the following: 1. Figure out a timestamp before which events will be purged 2. Select the first stream ordering after that timestamp 3. Select info about the first event after that stream ordering 4. Build a topological token from that info In some situations (e.g. quiet rooms with a short max_lifetime), there might not be an event after the stream ordering at step 3, therefore we abort the purge with the error `No event found`. To mitigate that, this patch fetches the first event _before_ the stream ordering, instead of after.
* | | | Merge pull request #6724 from matrix-org/rav/log_saml_attributesAndrew Morgan2020-03-236-6/+6
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '59dc87c61': changelog Log saml assertions rather than the whole response move batch_iter to a separate module
| * | | move batch_iter to a separate moduleRichard van der Hoff2020-01-166-6/+6
| | | |
* | | | Add StateMap type alias (#6715)Andrew Morgan2020-03-233-43/+55
|\| | | | | | | | | | | | | | | | | | | * commit 'd386f2f33': Add StateMap type alias (#6715)
| * | | Add StateMap type alias (#6715)Erik Johnston2020-01-163-43/+55
| | | |
* | | | Fix purge_room admin API (#6711)Andrew Morgan2020-03-231-1/+1
|\| | | | | | | | | | | | | | | | | | | * commit '19a1aac48': Fix purge_room admin API (#6711)
| * | | Fix purge_room admin API (#6711)Erik Johnston2020-01-151-1/+1
| | | |
* | | | Add `local_current_membership` table (#6655)Andrew Morgan2020-03-234-80/+238
|\| | | | | | | | | | | | | | | | | | | * commit '28c98e51f': Add `local_current_membership` table (#6655)
| * | | Add `local_current_membership` table (#6655)Erik Johnston2020-01-154-80/+238
| |/ / | | | | | | | | | | | | | | | | | | Currently we rely on `current_state_events` to figure out what rooms a user was in and their last membership event in there. However, if the server leaves the room then the table may be cleaned up and that information is lost. So lets add a table that separately holds that information.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-02-03 18:57:04 +0000