| Commit message (Collapse) | Author | Files | Lines |
|
|
|
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
|
|
|
|
submit_event_for_as doesn't return a deferred anyway, so this is pointless.
|
|
add missing comma
|
|
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
|
|
|
|
|
|
plus a bonus next()
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
|
|
|
|
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
I've tried to grep for more of this with no success.
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
It's just a few tests, but it will at least prevent a few files from
regressing. Also, it makes it easiert to check your code against py36
while writing it.
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
|
|
|
While I was going through uses of preserve_fn for other PRs, I converted places
which only use the wrapped function once to use run_in_background, to avoid
creating the function object.
|
|
Twisted 16.0 doesn't have addTimeout, so let's backport it.
|
|
Turn any exceptions that get thrown synchronously within run_in_background into
Failures instead.
|
|
|
|
|
|
We need to be careful (under python 2, at least) that when we reraise an
exception after doing some error handling, we actually reraise the original
exception rather than anything that might have been raised (and handled) during
the error handling.
|
|
In general we want defer.gatherResults to consumeErrors, rather than having
exceptions hanging around and getting logged as CRITICAL unhandled errors.
|
|
There were a bunch of places where we fire off a process to happen in the
background, but don't have any exception handling on it - instead relying on
the unhandled error being logged when the relevent deferred gets
garbage-collected.
This is unsatisfactory for a number of reasons:
- logging on garbage collection is best-effort and may happen some time after
the error, if at all
- it can be hard to figure out where the error actually happened.
- it is logged as a scary CRITICAL error which (a) I always forget to grep for
and (b) it's not really CRITICAL if a background process we don't care about
fails.
So this is an attempt to add exception handling to everything we fire off into
the background.
|
|
|
|
|
|
|
|
* add some doc about wtf this thing does
* pin Twisted to < 18.4
* add explicit dep on six (fixes #3089)
|