| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| |
| |
| | |
* commit 'bfd79c298':
More changelog tweaks
More changelog tweaks
Remove unwanted changelog line
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Synapse 1.19.0rc1 (2020-08-13)
==============================
Removal warning
---------------
As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180).
Features
--------
- Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902))
- Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964))
- Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008))
- Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048))
- Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052))
- Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314))
Bugfixes
--------
- Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977))
- Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978))
- Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980))
- Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996))
- Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999))
- Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012))
Updates to the Docker image
---------------------------
- We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056))
Improved Documentation
----------------------
- Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899))
- Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000))
- Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992))
- Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010))
Internal Changes
----------------
- Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372))
- Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979))
- Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070))
- Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952))
- Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970))
- Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971))
- Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997))
- Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001))
- Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009))
- Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024))
- Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033))
- Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040))
- Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041))
- Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043))
- Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049))
- Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050))
- It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051))
- Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067))
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
|
| |\ \ \
| | |/
| |/|
| | |
| | | |
* commit '091ca3910':
1.19.0rc1
|
| | | | |
|
| |\ \ \
| | |/
| |/|
| | |
| | | |
* commit '53834bb9c':
Run `remove_push_actions_from_staging` in foreground (#8081)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
If we got an error persisting an event, we would try to remove the push actions
asynchronously, which would lead to a 'Re-starting finished log context'
warning.
I don't think there's any need for this to be asynchronous.
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'ff0e89465':
Drop federation transmission queues during a significant remote outage. (#7864)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Empty federation transmission queues when we are backing off.
Fixes #7828.
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
* Address feedback
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
* Reword newsfile
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'dd8f28bd3':
Fix unawaited coroutine error in tests. (#8072)
|
| | |/ |
|
| |\|
| |
| |
| |
| | |
* commit 'fbe930dad':
Convert the roommember database to async/await. (#8070)
|
| | | |
|
| |\|
| |
| |
| |
| | |
* commit '5ecc8b582':
Convert devices database to async/await. (#8069)
|
| | | |
|
| |\|
| |
| |
| |
| | |
* commit '5dd73d029':
Add type hints to handlers.message and events.builder (#8067)
|
| | | |
|
| |\|
| |
| |
| |
| | |
* commit 'd68e10f30':
Convert account data, device inbox, and censor events databases to async/await (#8063)
|
| | |
| |
| |
| | |
async/await (#8063)
|
| |\|
| |
| |
| |
| | |
* commit 'a3a59bab7':
Convert appservice, group server, profile and more databases to async (#8066)
|
| | | |
|
| |\|
| |
| |
| |
| |
| |
| |
| |
| | |
* commit '9d1e4942a':
Fix typing for notifier (#8064)
Add comment explaining cast
Handle optional dependencies for Oidc and Saml
Newsfile
Change HomeServer definition to work with typing.
|
| | | |
|
| | |\
| | |
| | | |
Change HomeServer definition to work with typing.
|
| | | |\ |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Duplicating function signatures between server.py and server.pyi is
silly. This commit changes that by changing all `build_*` methods to
`get_*` methods and changing the `_make_dependency_method` to work work
as a descriptor that caches the produced value.
There are some changes in other files that were made to fix the typing
in server.py.
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '04faa0bfa':
Convert tags and metrics databases to async/await (#8062)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'a0acdfa9e':
Converts event_federation and registration databases to async/await (#8061)
|
| | | |/
| |/| |
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit '61d8ff0d4':
Update changelog.d/8051.misc
Newsfile
Move setting of Filter into code.
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We do this to prevent foot guns. The default config uses a MemoryFilter,
but users are free to change to logging to files directly. If they do
then they have to ensure to set the `filters: [context]` on the right
handler, otherwise records get written with the wrong context.
Instead we move the logic to happen when we generate a record, which is
when we *log* rather than *handle*.
(It's possible to add filters to loggers in the config, however they
don't apply to descendant loggers and so they have to be manually set on
*every* logger used in the code base)
|
| | | | |
| | | |
| | | | |
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We do this to prevent foot guns. The default config uses a MemoryFilter,
but users are free to change to logging to files directly. If they do
then they have to ensure to set the `filters: [context]` on the right
handler, otherwise records get written with the wrong context.
Instead we move the logic to happen when we generate a record, which is
when we *log* rather than *handle*.
(It's possible to add filters to loggers in the config, however they
don't apply to descendant loggers and so they have to be manually set on
*every* logger used in the code base)
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'a1e9bb9ea':
Add typing info to Notifier (#8058)
|
| | |/ / |
|
| |\| |
| | |
| | |
| | |
| | | |
* commit 'a0f574f3c':
Reduce INFO logging (#8050)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
c.f. #8021
A lot of the code here is to change the `Completed 200 OK` logging to include the request URI so that we can drop the `Sending request...` log line.
Some notes:
1. We won't log retries, which may be confusing considering the time taken log line includes retries and sleeps.
2. The `_send_request_with_optional_trailing_slash` will always be logged *without* the forward slash, even if it succeeded only with the forward slash.
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit 'db131b6b2':
Change the default log config to reduce disk I/O and storage (#8040)
Implement login blocking based on SAML attributes (#8052)
Add an assertion on prev_events in create_new_client_event (#8041)
Typo
Lint
why mypy why
Lint
Incorporate review
Incorporate review
Fix PUT /pushrules to use the right rule IDs
Back out the database hack and replace it with a temporary config setting
Fix cache name
Fix cache invalidation calls
Lint
Changelog
Implement new experimental push rules with a database hack to enable them
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Change default log config to buffer by default.
This batches up writes to the filesystem, which is more efficient for
disk I/O. This means that it can take some time for logs to get written
to disk. Note that ERROR logs (and above) immediately flush the buffer.
This only effects new installs, as we only write the log config if
started with `--generate-config` (in the same way we do for generating
signing keys).
* Default to keeping last 4 days of logs.
This hopefully reduces the amount of logs kept for new servers. Keeping
the last 1GB of logs is likely overkill for new servers, but equally may
not be enough for busy ones.
Instead, we keep the last four days worth of logs, enough so that admins
can investigate any problems that happened over e.g. a long weekend.
|
| | |/
| |
| |
| |
| |
| |
| | |
Hopefully this mostly speaks for itself. I also did a bit of cleaning up of the
error handling.
Fixes #8047
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
I think this would have caught all the cases in
https://github.com/matrix-org/synapse/issues/7642 - and I think a 500 makes
more sense here than a 403
|
| | |\ \
| | | |
| | | | |
With an undocumented configuration setting to enable them for specific users.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | |\ \
| | | | |
| | | | |
| | | | | |
babolivier/new_push_rules
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | |\ \ \
| | | | | |
| | | | | |
| | | | | | |
babolivier/new_push_rules
|
| | | | | | | |
|
| | | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
babolivier/new_push_rules
|
| | | | | | | | |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | | |
* commit '39c3f6875':
Stop uploading -py3 docker images (#8056)
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '7f837959e':
Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users database to async (#8042)
Convert additional database stores to async/await (#8045)
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
database to async (#8042)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '1048ed2af':
Clarify that undoing a shutdown might not be possible (#8010)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit 'de6f89206':
Add a comment about SSLv23_METHOD (#8043)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '2f9fd5ab0':
Don't log OPTIONS request at INFO (#8049)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '4e874ed59':
Remove unnecessary maybeDeferred calls (#8044)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '7620912d8':
Add health check endpoint (#8048)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '4dd27e6d1':
Reduce unnecessary whitespace in JSON. (#7372)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '2ffd6783c':
Revert #7736 (#8039)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit 'fe6cfc80e':
Convert some util functions to async (#8035)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit 'd4a7829b1':
Convert synapse.api to async/await (#8031)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit 'c36228c40':
Convert run_as_background_process inner function to async. (#8032)
|
| | | | | | | | |
|
| |\| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit '66f24449d':
Improve performance of the register endpoint (#8009)
|
| | | |_|_|_|/
| |/| | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '079bc3c8e':
Fixup worker doc (again) (#8000)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit 'a7bdf98d0':
Rename database classes to make some sense (#8033)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '0a86850ba':
Stop the parent process flushing the logs on exit (#8012)
|
| | | | | | |
| | | | | |
| | | | | | |
This solves the problem that the first few lines are logged twice on matrix.org. Hopefully the comments explain it.
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '8b786db32':
bug report template: move comments into comment (#8030)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '7cac9006d':
Spruce up the check-newsfragment CI output (#8024)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This PR:
* Reduces the amount of noise in the `check-newsfragment` CI output by hiding the dependency installation output by default.
* Prints a link to the changelog/debian changelog section of the contributing guide if an error is found.
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '8ff2deda7':
Fix async/await calls for broken media providers. (#8027)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '88a3ff12f':
Convert the SimpleHttpClient to async. (#8016)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit 'e19de43eb':
Convert streams to async. (#8014)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '916cf2d43':
re-implement daemonize (#8011)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This has long been something I've wanted to do. Basically the `Daemonize` code
is both too flexible and not flexible enough, in that it offers a bunch of
features that we don't use (changing UID, closing FDs in the child, logging to
syslog) and doesn't offer a bunch that we could do with (redirecting stdout/err
to a file instead of /dev/null; having the parent not exit until the child is
running).
As a first step, I've lifted the Daemonize code and removed the bits we don't
use. This should be a non-functional change. Fixing everything else will come
later.
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '481f76c7a':
Remove signature check on v1 identity server lookups (#8001)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We've [decided](https://github.com/matrix-org/synapse/issues/5253#issuecomment-665976308) to remove the signature check for v1 lookups.
The signature check has been removed in v2 lookups. v1 lookups are currently deprecated. As mentioned in the above linked issue, this verification was causing deployments for the vector.im and matrix.org IS deployments, and this change is the simplest solution, without being unjustified.
Implementations are encouraged to use the v2 lookup API as it has [increased privacy benefits](https://github.com/matrix-org/matrix-doc/pull/2134).
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '5d92a1428':
Prevent join->join membership transitions changing member count (#7977)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc.
However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information.
This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point.
Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update).
Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '681250980':
Implement handling of HTTP HEAD requests. (#7999)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '2a89ce8cd':
Convert the crypto module to async/await. (#8003)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit 'b6c6fb795':
Allow guests to operate in encrypted rooms (#7314)
|
| | | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Michael Albert <michael.albert@awesome-technologies.de>
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '3b415e23a':
Convert replication code to async/await. (#7987)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit 'db5970ac6':
Convert ACME code to async/await. (#7989)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit 'd1008fe94':
Fix some comments and types in service notices (#7996)
|
| | | | | | | |
|
| |\| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit '394be6a0e':
Newsfile
Add ratelimiting on joins
Add docs for undoing room shutdowns (#7998)
|
| | |\ \ \ \ \
| | |_|_|_|/
| |/| | | | |
Add ratelimiting on joins
|
| | | |\ \ \ \
| | |/ / / /
| |/| | | |
| | | | | | |
erikj/add_rate_limiting_to_joins
|
| | | |_|_|/
| |/| | |
| | | | | |
These docs were tested successfully in production by a customer, so it's probably fine.
|
| | | | | | |
|
| | | |/ / |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '6d4b79002':
Update workers docs (#7990)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '0a7fb2471':
Fix invite rejection when we have no forward-extremeties (#7980)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Thanks to some slightly overzealous cleanup in the
`delete_old_current_state_events`, it's possible to end up with no
`event_forward_extremities` in a room where we have outstanding local
invites. The user would then get a "no create event in auth events" when trying
to reject the invite.
We can hack around it by using the dangling invite as the prev event.
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '606805bf0':
Fix typo in docs/workers.md (#7992)
|
| | | | | |
|
| | |\| | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'c978f6c45':
Convert federation client to async/await. (#7975)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit '4cce8ef74':
Convert appservice to async. (#7973)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'b3a97d6da':
Convert some of the data store to async. (#7976)
|
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* commit '3950ae51e':
Ensure that remove_pusher is always async (#7981)
Ensure the msg property of HttpResponseException is a string. (#7979)
Remove from the event_relations table when purging historical events. (#7978)
Add additional logging for SAML sessions. (#7971)
Add MSC reference to changelog for #7736
Re-implement unread counts (#7736)
Various improvements to the docs (#7899)
Convert storage layer to async/await. (#7963)
Add an option to disable purge in delete room admin API (#7964)
Move some log lines from default logger to sql/transaction loggers (#7952)
Use the JSON module from the std library instead of simplejson. (#7936)
Fix exit code for `check_line_terminators.sh` (#7970)
Option to allow server admins to join complex rooms (#7902)
Fix typo in metrics docs (#7966)
Add script for finding files with unix line terminators (#7965)
Convert the remaining media repo code to async / await. (#7947)
Convert a synapse.events to async/await. (#7949)
Convert groups and visibility code to async / await. (#7951)
Convert push to async/await. (#7948)
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add option ```purge``` to ```POST /_synapse/admin/v1/rooms/<room_id>/delete```
Fixes: #3761
Signed-off-by: Dirk Klimpel dirk@klimpel.org
|
| | | | |
| | | |
| | | | |
Idea from matrix-org/synapse-dinsic#49
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If there are *no* files with CRLF line endings, then the xargs exits with a
non-zero exit code (as expected), but then, since that is the last thing to
happen in the script, the script as a whole exits non-zero, making the whole
thing fail.
using `if/then/fi` instead of `&& (...)` means that the script exits with a
zero exit code.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Fixes #7901.
Signed-off-by: Niklas Tittjung <nik_t.01@web.de>
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Synapse 1.18.0rc2 (2020-07-28)
==============================
Bugfixes
--------
- Fix an `AssertionError` exception introduced in v1.18.0rc1. ([\#7876](https://github.com/matrix-org/synapse/issues/7876))
- Fix experimental support for moving typing off master when worker is restarted, which is broken in v1.18.0rc1. ([\#7967](https://github.com/matrix-org/synapse/issues/7967))
Internal Changes
----------------
- Further optimise queueing of inbound replication commands. ([\#7876](https://github.com/matrix-org/synapse/issues/7876))
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This PRs adds a script to check for unix-line terminators in the repo. It will be used to address https://github.com/matrix-org/synapse/issues/7943 by adding the check to CI.
I've changed the original script slightly as proposed in https://github.com/matrix-org/pipelines/pull/81#discussion_r460580664
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
https://github.com/matrix-org/synapse-dinsic/pull/51 added an option that would automatically bind a user's threepid to a configured identity server after they had registered. Unfortunately, when you bind threepids, ideally you would store that mapping in the database so that later on you can remove those mappings when you deactivate an account.
We found that due the fact that we did not store these mappings, threepids were not unbound upon user account deactivation.
This PR fixes the issue by creating the mappings again, meaning they will again be removed upon account deactivation.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If the last admin of a room departs, and thus the room no longer has any admins within it, we "freeze" the room. Freezing a room means that the power level required to do anything in the room (sending messages, inviting others etc) will require power level 100.
At the moment, an admin can come back and unfreeze the room manually. The plan is to eventually make unfreezing of the room automatic on admin rejoin, though that will be in a separate PR.
This *could* work in mainline, however if the admin who leaves is on a homeserver without this functionality, then the room isn't frozen. I imagine this would probably be pretty confusing to people. Part of this feature was allowing Synapse modules to send events, which has been implemented in mainline at https://github.com/matrix-org/synapse/pull/8479, and cherry-picked to the `dinsic` fork in 62c7b10. The actual freezing logic has been implemented here in the RoomAccessRules module.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This PR allows Synapse modules making use of the `ModuleApi` to create and send non-membership events into a room. This can useful to have modules send messages, or change power levels in a room etc. Note that they must send event through a user that's already in the room.
The non-membership event limitation is currently arbitrary, as it's another chunk of work and not necessary at the moment.
This commit has been cherry-picked from mainline.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug introduced in https://github.com/matrix-org/synapse-dinsic/commit/ff91a451b
We were checking whether the `nextLink` param was valid, even if it wasn't provided. In that case, `nextLink` was `None`, which would clearly not be a valid URL.
This would prevent password reset and other operations if `nextLink` was not provided and the `next_link_domain_whitelist` config option was in use.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Swap these calls around, as the check for changing `restricted` to `unrestricted` will actually change `self.restricted_room` to an unrestricted room.
Do that last, instead of first. Additionally add a comment with a warning.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
join rules on rule change (#63)
This PR switches several conditions regarding room access rules to check against the status of the room's inclusion in the public room list instead of its join rules.
The code includes a snapshot of https://github.com/matrix-org/synapse/pull/8292, which will likely change in time and need merging in again.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
admin requirements for unknown state events (#61)
This PR modifies the `RoomAccessRules` module, an implementation of `ThirdPartyEventRules`, to both:
* Modify the default power levels when creating a room to set:
- `invite` to be minimum PL50
- `state_default` to be minimum PL100
* Enforce this when creating the room.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Various cleanups of the DINUM-specific `RoomAccessRules` module, including:
* Type hints
* Docstring cleanups
* Some code cleanups
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
whitelist (#8275)
This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285
They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality.
This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004, but across all `*/submit_token` endpoint.
This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | | |
It's currently expected by the Tchap clients, a fix will be deployed to them later on.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Revert "Remove "user_id" from GET /presence. (#7606)"
|
| | | | | | |
| | | | | |
| | | | | | |
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
|
| | | | | | | |
|
| |/ / / / /
| | | | |
| | | | |
| | | | | |
This reverts commit a3fbc23c39c0366392fd51faf0b1696f1f1d21c7.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Merge Synapse release v1.18.0 into 'dinsic'
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
linting after the v1.18.0 mainline merge
|
| | |\ \ \ \ \
| | | |_|/ /
| | |/| | |
| | | | | |
| | | | | |
| | | | | | |
* commit '320ef9885':
Fix formatting of changelog and upgrade notes
Add deprecation warnings
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
|
| | |\| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* commit 'a9631b7b4':
1.18.0
Update worker docs with recent enhancements (#7969)
|
| | | | | | | |
|
| | | | |/ /
| | |/| | |
|
| | |\| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* commit '7000a215e':
1.18.0rc2
Typing worker needs to handle stream update requests (#7967)
Handle replication commands synchronously where possible (#7876)
update changelog
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
IIRC this doesn't break tests because its only hit on reconnection, or something.
Basically, when a process needs to fetch missing updates for the `typing` stream it needs to query the writer instance via HTTP (as we don't write typing notifications to the DB), the problem was that the endpoint (`streams`) was only registered on master and specifically not on the typing writer worker.
|
| | | |/ /
| | | |
| | | | |
Most of the stuff we do for replication commands can be done synchronously. There's no point spinning up background processes if we're not going to need them.
|
| | | | | |
|
| | |\| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* commit 'f88c48f3b':
1.18.0rc1
Fix error reporting when using `opentracing.trace` (#7961)
Fix typing replication not being handled on master (#7959)
Remove hacky error handling for inlineDeferreds. (#7950)
Convert tests/rest/admin/test_room.py to unix file endings (#7953)
Support oEmbed for media previews. (#7920)
Convert state resolution to async/await (#7942)
Fix up types and comments that refer to Deferreds. (#7945)
Do not convert async functions to Deferreds in the interactive_auth_handler (#7944)
Convert more of the media code to async/await (#7873)
Return an empty body for OPTIONS requests. (#7886)
Downgrade warning on client disconnect to INFO (#7928)
Convert presence handler helpers to async/await. (#7939)
Update the auth providers to be async. (#7935)
Put a cache on `/state_ids` (#7931)
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Handling of incoming typing stream updates from replication was not
hooked up on master, effecting set ups where typing was handled on a
different worker.
This is really only a problem if the master process is also handling
sync requests, which is unlikely for those that are at the stage of
moving typing off.
The other observable effect is that if a worker restarts or a
replication connect drops then the typing worker will issue a
`POSITION typing`, triggering master process to try and stream *all*
typing updates from position 0.
Fixes #7907
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Converts tests/rest/admin/test_room.py to have unix file endings after they were accidentally changed in #7613.
Keeping the same changelog as #7613 as it hasn't gone out in a release yet.
|
| | | | |
| | | |
| | | | |
Fixes previews of Twitter URLs by using their oEmbed endpoint to grab content.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
(#7944)
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Clients disconnecting before we finish processing the request happens from time
to time. We don't need to yell about it
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If we send out an event which refers to `prev_events` which other servers in
the federation are missing, then (after a round or two of backfill attempts),
they will end up asking us for `/state_ids` at a particular point in the DAG.
As per https://github.com/matrix-org/synapse/issues/7893, this is quite
expensive, and we tend to see lots of very similar requests around the same
time.
We can therefore handle this much more efficiently by using a cache, which (a)
ensures that if we see the same request from multiple servers (or even the same
server, multiple times), then they share the result, and (b) any other servers
that miss the initial excitement can also benefit from the work.
[It's interesting to note that `/state` has a cache for exactly this
reason. `/state` is now essentially unused and replaced with `/state_ids`, but
evidently when we replaced it we forgot to add a cache to the new endpoint.]
|
| | |\| |
| | | |
| | | |
| | | |
| | | | |
* commit '4876af06d':
Abort federation requests if the client disconnects early (#7930)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For inbound federation requests, if a given remote server makes too many
requests at once, we start stacking them up rather than processing them
immediatedly.
However, that means that there is a fair chance that the requesting server will
disconnect before we start processing the request. In that case, if it was a
read-only request (ie, a GET request), there is absolutely no point in
building a response (and some requests are quite expensive to handle).
Even in the case of a POST request, one of two things will happen:
* Most likely, the requesting server will retry the request and we'll get the
information anyway.
* Even if it doesn't, the requesting server has to assume that we didn't get
the memo, and act accordingly.
In short, we're better off aborting the request at this point rather than
ploughing on with what might be a quite expensive request.
|
| | |\| |
| | | |
| | | |
| | | |
| | | | |
* commit 'ff22672fd':
Reorder database docs to promote postgresql. (#7933)
|
| | | | | |
|
| | |\| |
| | | |
| | | |
| | | |
| | | | |
* commit '68cd93582':
Convert the federation agent and related code to async/await. (#7874)
|
| | | | | |
|
| | |\| |
| | | |
| | | |
| | | |
| | | | |
* commit '13d77464c':
Follow-up to admin API to re-activate accounts (#7908)
|
| | | | | |
|
| | |\| |
| | | |
| | | |
| | | |
| | | | |
* commit 'cc9bb3dc3':
Convert the message handler to async/await. (#7884)
|
| | | | | |
|
| | |\| |
| | | |
| | | |
| | | |
| | | | |
* commit 'a4cf94a3c':
Update the dates for ACME v1 EOL
|
| | | |\ \
| | | |/
| | |/| |
Update the dates for ACME v1 EOL
|
| | | |/
| | |
| | |
| | | |
As per https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430
|
| | |\|
| | |
| | |
| | |
| | | |
* commit '923c99502':
Skip serializing /sync response if client has disconnected (#7927)
|
| | | |
| | |
| | | |
... it's a load of work which may be entirely redundant.
|
| | |\|
| | |
| | |
| | |
| | | |
* commit 'b74919c72':
Add debugging to sync response generation (#7929)
|
| | | | |
|
| | |\|
| | |
| | |
| | |
| | | |
* commit '931b02684':
Remove an unused prometheus metric (#7878)
|
| | | | |
|
| | |\|
| | |
| | |
| | |
| | | |
* commit '05060e022':
Track command processing as a background process (#7879)
|
| | | |
| | |
| | |
| | | |
I'm going to be doing more stuff synchronously, and I don't want to lose the
CPU metrics down the sofa.
|
| | |\|
| | |
| | |
| | |
| | |
| | | |
* commit '15997618e':
Clean up PreserveLoggingContext (#7877)
fix an incorrect comment
|
| | | |
| | |
| | | |
This had some dead code and some just plain wrong docstrings.
|
| | | | |
|
| | |\|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* commit 'de119063f': (31 commits)
Convert room list handler to async/await. (#7912)
Element CSS and logo in email templates (#7919)
Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914)
Remove unused code from synapse.logging.utils. (#7897)
Fix a typo in the sample config. (#7890)
Fix deprecation warning: import ABC from collections.abc (#7892)
Change sample config's postgres user to synapse_user (#7889)
Fix deprecation warning due to invalid escape sequences (#7895)
Remove Ubuntu Eoan that is now EOL (#7888)
Fix the trace function for async functions. (#7872)
Add help for creating a user via docker (#7885)
Switch to Debian:Slim from Alpine for the docker image (#7839)
Stop using 'device_max_stream_id' (#7882)
Fix TypeError in synapse.notifier (#7880)
Add a default limit (of 100) to get/sync operations. (#7858)
Change "unknown room ver" logging to warning. (#7881)
Convert device handler to async/await (#7871)
Convert synapse.app to async/await. (#7868)
Convert _base, profile, and _receipts handlers to async/await (#7860)
Add admin endpoint to get members in a room. (#7842)
...
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
Use Element CSS and logo in notification emails when app name is Element.
Signed-off-by: Jason Robinson <jasonr@matrix.org>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
script (#7914)
Run `isort`, `flake8` and `black` over the `contrib/` directory and `synctl` script. The latter was already being done in CI, but now the linting script does it too.
Fixes https://github.com/matrix-org/synapse/issues/7910
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
The [postgres setup docs](https://github.com/matrix-org/synapse/blob/develop/docs/postgres.md#set-up-database) recommend setting up your database with user `synapse_user`.
However, uncommenting the postgres defaults in the sample config leave you with user `synapse`.
This PR switches the sample config to recommend `synapse_user`. Took a me a second to figure this out, so assume this will beneficial to others.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Fix deprecation warnings due to invalid escape sequences.
* Add changelog
Signed-off-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
|
| | | | |
|
