summary refs log tree commit diff
path: root/synapse/rest/client
diff options
context:
space:
mode:
authorAndrew Morgan <andrew@amorgan.xyz>2020-03-19 17:49:07 +0000
committerAndrew Morgan <andrew@amorgan.xyz>2020-03-19 17:49:07 +0000
commit82be5c38d67a31f6cb275ec27389a1e80ad7a63a (patch)
tree007c66f2be2dfc6b256bc4b06e098130de1a5af3 /synapse/rest/client
parentPrevent redacted events from appearing in message search (#6377) (diff)
parent1.7.0rc2 (diff)
downloadsynapse-82be5c38d67a31f6cb275ec27389a1e80ad7a63a.tar.xz
1.7.0rc2
* commit 'd156912c4':
  1.7.0rc2
  Back out change preventing setting null avatar URLs
  Fixup changelogs
Diffstat (limited to 'synapse/rest/client')
-rw-r--r--synapse/rest/client/v1/profile.py12
1 files changed, 6 insertions, 6 deletions
diff --git a/synapse/rest/client/v1/profile.py b/synapse/rest/client/v1/profile.py

index 3eb4823d58..165313b572 100644 --- a/synapse/rest/client/v1/profile.py +++ b/synapse/rest/client/v1/profile.py
@@ -16,6 +16,7 @@ """ This module contains REST servlets to do with profile: /profile/<paths> """ from twisted.internet import defer +from synapse.api.errors import Codes, SynapseError from synapse.http.servlet import RestServlet, parse_json_object_from_request from synapse.rest.client.v2_alpha._base import client_patterns from synapse.types import UserID @@ -122,12 +123,11 @@ class ProfileAvatarURLRestServlet(RestServlet): content = parse_json_object_from_request(request) try: - new_avatar_url = content.get("avatar_url") - except Exception: - return 400, "Unable to parse avatar_url" - - if new_avatar_url is None: - return 400, "Missing required key: avatar_url" + new_avatar_url = content["avatar_url"] + except KeyError: + raise SynapseError( + 400, "Missing key 'avatar_url'", errcode=Codes.MISSING_PARAM + ) await self.profile_handler.set_avatar_url( user, requester, new_avatar_url, is_admin