summary refs log tree commit diff
diff options
context:
space:
mode:
authorSean Quah <8349537+squahtx@users.noreply.github.com>2022-08-16 16:21:55 +0100
committerGitHub <noreply@github.com>2022-08-16 16:21:55 +0100
commitf4ab6a4a96ceb02e260a3d025ff6c1e6cfefe4ed (patch)
treef75530bf187cbf51604855daf03b6b133e56e99d
parentAdd missing links in `user_consent` section of configuration manual (#13536) (diff)
downloadsynapse-f4ab6a4a96ceb02e260a3d025ff6c1e6cfefe4ed.tar.xz
Refuse to start when `faster_joins` is enabled on a worker deployment (#13531)
Synapse does not currently support faster room joins on deployments with
workers.

Signed-off-by: Sean Quah <seanq@matrix.org>
-rw-r--r--changelog.d/13531.misc1
-rw-r--r--synapse/app/generic_worker.py7
2 files changed, 8 insertions, 0 deletions
diff --git a/changelog.d/13531.misc b/changelog.d/13531.misc
new file mode 100644
index 0000000000..986122d3d0
--- /dev/null
+++ b/changelog.d/13531.misc
@@ -0,0 +1 @@
+Faster room joins: Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported.
diff --git a/synapse/app/generic_worker.py b/synapse/app/generic_worker.py
index 42d1f6d219..30e21d9707 100644
--- a/synapse/app/generic_worker.py
+++ b/synapse/app/generic_worker.py
@@ -441,6 +441,13 @@ def start(config_options: List[str]) -> None:
         "synapse.app.user_dir",
     )
 
+    if config.experimental.faster_joins_enabled:
+        raise ConfigError(
+            "You have enabled the experimental `faster_joins` config option, but it is "
+            "not compatible with worker deployments yet. Please disable `faster_joins` "
+            "or run Synapse as a single process deployment instead."
+        )
+
     synapse.events.USE_FROZEN_DICTS = config.server.use_frozen_dicts
     synapse.util.caches.TRACK_MEMORY_USAGE = config.caches.track_memory_usage