diff options
| author | Erik Johnston <erik@matrix.org> | 2020-09-16 12:40:58 +0100 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2020-09-16 12:40:58 +0100 |
| commit | f1c9ded7385049e477c14c9045975d214055c19f (patch) | |
| tree | e15eb558420902d3d8bbace67c2c94f23cc400e7 | |
| parent | 1.19.1 (diff) | |
| parent | Newsfile (diff) | |
| download | synapse-f1c9ded7385049e477c14c9045975d214055c19f.tar.xz | |
Merge branch 'erikj/fix_origin_check' into release-v1.19.2
| -rw-r--r-- | changelog.d/8324.bugfix | 1 | ||||
| -rw-r--r-- | synapse/federation/federation_client.py | 7 |
2 files changed, 5 insertions, 3 deletions
diff --git a/changelog.d/8324.bugfix b/changelog.d/8324.bugfix new file mode 100644 index 0000000000..32788a9284 --- /dev/null +++ b/changelog.d/8324.bugfix @@ -0,0 +1 @@ +Fix fetching events from remote servers that are malformed. diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py index 38ac7ec699..a2e8d96ea2 100644 --- a/synapse/federation/federation_client.py +++ b/synapse/federation/federation_client.py @@ -54,7 +54,7 @@ from synapse.events import EventBase, builder from synapse.federation.federation_base import FederationBase, event_from_pdu_json from synapse.logging.context import make_deferred_yieldable, preserve_fn from synapse.logging.utils import log_function -from synapse.types import JsonDict +from synapse.types import JsonDict, get_domain_from_id from synapse.util import unwrapFirstError from synapse.util.caches.expiringcache import ExpiringCache from synapse.util.retryutils import NotRetryingDestination @@ -386,10 +386,11 @@ class FederationClient(FederationBase): pdu.event_id, allow_rejected=True, allow_none=True ) - if not res and pdu.origin != origin: + pdu_origin = get_domain_from_id(pdu.sender) + if not res and pdu_origin != origin: try: res = await self.get_pdu( - destinations=[pdu.origin], + destinations=[pdu_origin], event_id=pdu.event_id, room_version=room_version, outlier=outlier, |